Commit Graph

30973 Commits

Author SHA1 Message Date
ArcaneDefence
c092f08403 Adds mothpeople potion of flight wings (#50183)
* First steps

* bugfix and color match

* Changes as requested

* h

* D

* T

* M

* Lowercase
2020-04-01 04:01:00 -03:00
Rohesie
6f7f3bab9f Client var moves (#50304) 2020-04-01 14:39:49 +08:00
Rohesie
b940ce3ff9 progressbar refactor (#50316) 2020-04-01 14:38:55 +08:00
Fikou
2aae69af8a makes armor respective helmet values the same part 57 (#50166)
* makes armor respective helmet values the same part 57

* yeah ok

* forgot another one
2020-03-31 15:26:47 -04:00
Arkatos1
3bb4b326d0 Curse of the Barnyard is now a pointed spell (#50257)
* Initial commit

* Barnyard Curse is not a pointed spell, pointed spell code improvements

* Selection type consistency

* Grammar cleanup

* Cleanup and better mousepointer icon

* Line endings
2020-03-31 16:21:08 +08:00
ArcaneMusic
a24f6da1e3 Items without Export Datums calculate their value based on material datums. (#49991)
* The exportlarity.

* Some clean up on cargo logs. May need tweaks still

* Whoops.

* Several Review comments and some cleanup on pricetags

* Review comments round 2

* Almost forgot

* further updates.

* Forgot one.

* Yeah that isn't doing anything.
2020-03-31 02:55:06 -03:00
SteelSlayer
b391baeb74 Republish - Machinery processing refactor (#49307)
* initial

small thing

* improvements

1. Removes loops for picking up items. its now an item by item basis unless there is an ore box involved
2. Removed pickup_rate and ore_buffer var for the ORM, they aren't needed anymore
3. Fixed conveyors not moving items that get created on top of them (New / Initialize), by sending signals when atoms are created.

* renames the registered signal proc name so travis doesn't throw a fit

* signal improvement

* forgot to update other proc names

* ninjanomnom review changes

replace NEVER_PROCESS with START_PROCESSING_MANUALLY

default_unfasten_wrench override for ORM

50 -> 5 SECONDS

I totally didn't mispell anything

* makes a new signal: COMSIG_ATOM_CREATED

* more review changes

* duh

* even more review improvements

* switch >= to >

* reverts conveyors back to using process() for moving stuff

* various touch ups, adds documentation

* rebase to fix map conflicts with forgottenship.dmm

Co-authored-by: SteelSlayer <SteelSlayer@users.noreply.github.com>
2020-03-31 01:52:25 -03:00
Ryll Ryll
bf177cffed Shoelace fixes, adds helper for seeing if you're already interacting with a target (#50048)
* use the correct do_after target

* stomp

* sorry travis

* lace em up

* less specific

* checks if the shoes move

* NULL ME OUT

* last requests

* unhelper
2020-03-30 23:53:16 -03:00
Akrilla
078d7bebc4 stam crit (#50297) 2020-03-30 17:29:55 -03:00
Tad Hardesty
0c67ccf379 Fix runtime on cable bridge mapload initialization (#50280) 2020-03-30 22:27:46 +08:00
skoglol
cb7e5b5f73 Fixes grinders (#50276) 2020-03-29 18:21:58 -04:00
LemonInTheDark
d2726a19dc Fixes sm zap runtime to do with nonexistent turfs (#50200)
Checks to see if the turf we're zapping off exists and has a gasmix
Why It's Good For The Game

Makes things less cringe
Changelog

cl
fix: Fixed a supermatter zap runtime
/cl
2020-03-30 10:05:00 +13:00
Arkatos1
c7c2e4b531 Mouse pointer icons cleanup (#50241)
About The Pull Request

This PR reorganizes all mouse pointers icons in the codebase into a single folder under /effects, and removes 4 unused mouse pointer icons, all of which are remnants of the Clockwork Cult.

Also removes one rogue white pixel in blind_target.dmi.
Why It's Good For The Game

Better organization and less space taken by unused icons.
Changelog

cl Arkatos
code: Mouse pointer icons were reorganized to be more easily used in the future.
/cl
2020-03-30 10:00:39 +13:00
spessbandit
c3ac60abc8 Create Command Report dialog now tells you the current CentCom name. (#49831)
About The Pull Request

The admin Create Command Report verb now displays the current Central Command name in the dialog box, in case it has been previously changed.

also fixed one(1) typo
Why It's Good For The Game

because the other day I murdered everybody's immulsion by sending a "Central Command" report without realizing someone had hit Change Command Report previously

(pr title aside this is not just for manuel)
Changelog

cl bandit
admin: The Create Command Report dialog now tells you the current CentCom name.
/cl
2020-03-30 09:59:07 +13:00
ATH1909
444b17be9d Massively Buffs the Lightning Bolt Spell (#49745)
* Update aimed.dm

* Update spellbook.dm

* Update aimed.dm

* Update aimed.dm

* minimum cooldown is now 2 seconds
2020-03-29 13:15:31 -04:00
LeonSpilogale
623260a158 Fixed bug in Tea Aspera leaves (#50237)
There was a missing line (line 17) that outlined what reagents are produced by dried Tea Aspera leaves when ground.  With the code added back, dried Tea Aspera will now produce 4% vitamins and 10% Tea Leaves in relation to their potency, which is in line with the stats I could find listed on the /tg/station wiki and the reagent list for the Tea Astera.
2020-03-29 17:40:47 +08:00
Archanial
3c31dcac61 leg (#50226) 2020-03-29 16:38:13 +08:00
Tlaltecuhtli
db2bcef0bf fixes inability to get free stuff as job (#50251)
* fixes unability to get free stuff as job

* Update wardrobes.dm
2020-03-29 16:19:45 +08:00
ATH1909
b66d4016c8 it doesn't have to be this way (#50272) 2020-03-29 16:16:06 +08:00
Rohesie
96810ba7c0 incapacitating traits (#50270) 2020-03-29 16:12:08 +08:00
Ghilker
22cf0dc785 Freon fixes, tweaks and balancing (#50153)
* balancing, fixes, tweaks

* freon specific_heat increase

* fix an issue with negative temperature

* changed HyperNob canister color

* done change request and tweaked more the hardcap limit
2020-03-28 21:31:35 +01:00
ArcaneDefence
3b518482e0 Fix malf AI camera upgrade module (#50249)
Changes a see_invisible value that was being adjusted to be a 
lighting_alpha value that is adjusted when a malf AI uses the camera 
upgrades so that it no longer effectively blinds them.

The lighting_alpha value is the same value that nightvision goggles 
use, so players should be familiar with how things look with it, so 
that they will still be able to discern lighting levels in an area.
2020-03-28 11:35:13 -07:00
Gamer025
b9b188a830 Fixes "Show alerts" button/link in chat doing nothing for borgs (#50195)
* Fix "Show alerts" button/link in chat

AI has a topic proc that checks if showalerts is 1 (gets set by clicking the href) and if yes shows AI alerts. works the same for borgs but they don't have a custom topic proc so showalerts is never evaluated

* Update code/modules/mob/living/silicon/robot/robot.dm

Today I learned that . = ..() is better than ..() thanks to the coding people from the discord server

Co-Authored-By: spookydonut <github@spooksoftware.com>

Co-authored-by: spookydonut <github@spooksoftware.com>
2020-03-28 21:08:15 +08:00
Dennok
95c6d579b7 Fix /turf/open/space/bluespace spark crash (#50229) 2020-03-28 00:40:04 -07:00
Coconutwarrior97
f1e4432574 Limit summon events to one cast for 2 points (#50223)
Just re-opening Buggy123's PR, props to them and those who contributed 
there: #49365

Tweaks summon events to have one use at a cost of 2 points. Approved by 
headmins.

Summon events won't be able to cause quite as much insanity with an 
event happening every minute.
2020-03-27 23:24:32 -07:00
skoglol
850d32f6a2 Adds range check to beaker eject for grinder and biogen (#49998)
* Adds range check to beaker eject for grinder and biogen

* Drops on ground
2020-03-27 18:18:02 -04:00
Fikou
92acfdcc0e medical jobs now have the sterile mask by default (#50206)
* medical jobs now get a medical mask

* i should put it in here too
2020-03-27 17:14:26 -04:00
uomo
027b294a59 Gives the Psychologist some pills. (#50211)
* Creates pill and pill bottle types for the psych, puts them in their backpack.

* Update code/game/objects/items/storage/firstaid.dm

Co-Authored-By: trollbreeder <trollbreeder@users.noreply.github.com>

* Update code/game/objects/items/storage/firstaid.dm

Co-Authored-By: trollbreeder <trollbreeder@users.noreply.github.com>

* Update code/modules/reagents/reagent_containers/pill.dm

Co-Authored-By: trollbreeder <trollbreeder@users.noreply.github.com>

* Update pill.dm

Removes an unneeded blank line.

* Cleans up a needless comma and space.

* wording change for happiness bottle

Co-authored-by: trollbreeder <trollbreeder@users.noreply.github.com>
2020-03-27 16:35:07 -04:00
Arkatos1
7fb478c83b Mind Transfer is now a pointed spell (#50119)
* Mind Swap pointed spell

* Cast safety, cleanup

* Warning messages cleanup

* Autodoc

* Update code/game/objects/items/granters.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* Update code/modules/spells/spell_types/mind_transfer.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* Review fixes

* Blind range check fix

* Generic range check and cleanup

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-03-26 15:47:29 -03:00
Fikou
a59e4fb1b5 merges civilian and service departments (#50142)
* merges the service and civilian departments

* yee haw
2020-03-26 22:05:28 +08:00
Kyle Spier-Swenson
128859ab81 Smart Asset Cache - no more resending assets on round restart. (#49982)
The asset cache will now store json on the player's computer with info on what browser assets they have, all non-active assets (anything but .js(m) and .htm(l)) are reused in further connections. Browser assets in byond persist for an individual dream seeker instance, and are destoryed when the window is closed (so this only helps reconnects and round restarts) The data is stored in the client's asset folder to ensure its current and retrieved using javascript and sent back to the server using ajax(XHR).

The md5 of the asset files are generated on the server and stored on the client. It is used to validate the asset hasn't changed from a code update, and is not re-checked client side.

To ensure this can't be used by a malicious byond server to override javascript assets before redirecting people to /tg/ (where the attacker's javascript would then be allowed to run verbs and spoof topics) we do not mark javascript as pre-loaded when loading the client's asset cache json file on connection.
Other Changes

    I moved some things around, the asset cache file was getting thicc:
        Put new asset cache datums into code/modules/asset_cache/asset_list_items.dm
        Find the asset cache datum abstract definitions inside code/modules/asset_cache/asset_list.dm
    I fixed a bug where blocking asset sends would not block later calls to send the same asset while the send was still underway - todo: have it bind to the first send rather then initating its own.
    The small file sent to the client to verify it got all pending asset sends will no longer use random names. This should keep the client's asset folder from exploding with hundreds of random htm files, much to the joy of oranges.
    Passively loading assets no longer batches.
    Unified the two procs.
2020-03-26 22:05:43 +13:00
moo
a93bc92034 fixes nightmare (#50174)
meow :3
2020-03-25 14:06:52 -03:00
RiskySikh
32b0bda313 Adds Another Bible Sprite (#50156)
* newreligion

* resolvespritemergeconflict

* spacefix

* spacefix2

* spacefix3

* spacefix4

* fix lineendings

Co-authored-by: spookydonut <github@spooksoftware.com>
2020-03-26 01:00:40 +08:00
Fikou
062adf51b5 swat helmet now has the same armor as the swat suit (#50148) 2020-03-26 00:47:52 +08:00
Detective-Google
7ef87a250d Fixes weapon_weight being defined twice? (#50184) 2020-03-26 00:44:13 +08:00
Dennok
bacdf15745 partial copy_from() (#50162)
* partial copy_from()

* partial copy_from() in reconcile_air()

* core copy_from

* partial copy_from() in temporarily_store_air()

* Update gas_mixture.dm

* partial

* some docs
2020-03-25 13:32:01 -03:00
Rohesie
30ca02afb5 movespeed_modification unlawful list modification fix (#50135)
* copy

* Spooky suggestion
2020-03-25 17:34:35 +08:00
AnturK
2be0f092bf Fixes ghost operating gateways. (#50157) 2020-03-24 21:33:32 +13:00
Kyle Spier-Swenson
9924db0e6c Use /tg/'s Discord UserID wiki page over Discord's because Discord's guide sucks. (#50172)
https://tgstation13.org/wiki/How_to_find_your_Discord_User_ID

Somebody who is an experienced discord user will likely already know how to find this, and somebody who is not may not be conformable enabling dev mode to get it. The bot command method is good for people who are on their phone, the url method is good for people on web discord, and desktop app users are likely to already have dev mode on.
2020-03-24 08:09:44 +13:00
Kyle Spier-Swenson
ab0d88048e Adds tgs command to return the person's discord userid. (#50170) 2020-03-24 08:09:35 +13:00
Kyle Spier-Swenson
44c0866961 Adds user feedback to discord verifying (#50169)
If it doesn't say success, the user will assume it failed.
2020-03-24 08:09:24 +13:00
RiskySikh
c620cd543c Modifies Stinger receipe, taste and description for Irish Car Bomb, Green Beer, Goldschläger, Blood Mead, Mead, and Grape Soda (#50080)
* AlcoholicDescription

AlcoholDescription


Alcohol


Alcohol

* Fix

* GreenBeerFix

* GreenBeerFix2

* goldschalger fix

* goldschlagerfix2

* glassdescfix
2020-03-23 14:48:56 -03:00
Fikou
bac5fd01a5 adds bubblegum gum (#50026)
* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* adds bubblegum gum

* autodoc

* fixes fuckups

* fixes merge conflict and bad things

* nicer color

* shortens proc name

* Update code/modules/food_and_drinks/food/snacks_other.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* cringe

Co-authored-by: Changelogs <action@github.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
2020-03-23 14:04:26 -03:00
trollbreeder
af1777d7de Adds some documentation to species.dm (#50121)
* Documentation on species vars, and roughly 40-50% of procs

I can do no more of this. My mind is dead from boredom.

* thought this proc was deprecated, apparantly its not

cloning removal has permanentally scarred me

* Updates speed and armor variable docs

It wasn't made clear that armor was percentage based and speed was multiplicative in the documentation. This is now fixed.
Also removes some whitespace.

* Update code/modules/mob/living/carbon/human/species.dm

Co-Authored-By: nemvar <47324920+nemvar@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species.dm

Co-Authored-By: nemvar <47324920+nemvar@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species.dm

Co-Authored-By: nemvar <47324920+nemvar@users.noreply.github.com>

* Documentation updates with Qustinuss

Mentions fixedmutcolor in hair_color
Makes preferred food_type vars more clear that they are bitfields.
toxic_food is not toxic, it's just more disgusting than disliked food
Updates overlay var doc to mention that an empty string adds no damage overlays.

* Defines uniqueness, also lastname docs change

Updates generate name proc to have info on the unique argument
Changes override this to set to false on lastname. Overriding is done with procs, not vars or arguments

* updates proc docs to use double asterisk

if this fails travis documentation i'm gonna be angery

* i guess that makes sense

updates copy properties proc with better docs

* Part 2 of i guess this makes sense

i should stop early commiting y'know

* Update code/modules/mob/living/carbon/human/species.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

Co-authored-by: nemvar <47324920+nemvar@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
2020-03-23 08:27:36 -03:00
Rohesie
528fc99f28 lying to lying_angle and set proc (#50018)
* lying angle

* duplicate

* Documentation

* Comments
2020-03-22 21:49:52 -07:00
Tetr4
e0a623efce Relax air alarm pressure alarm thresholds (#50133) 2020-03-22 23:43:23 -03:00
Rob Bailey
2f127f8b95 More glowing stuff (#50109)
* vending machine framework

* wip

* all vending masks

* more glowing stuff

* dynamic unsetting of luminosity

* use define
2020-03-22 23:38:50 -03:00
RiskySikh
9bca49ccee Higadrite Metabolization Fix (#49951)
* GoatPlushie

Removes emagged plushie

* Revert "GoatPlushie"

This reverts commit f4395c4afdeb55c959cd1716eadc37ef2ff0c809.

* higadritemetabolizingfix

* Update code/modules/reagents/chemistry/reagents/medicine_reagents.dm

Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>

Co-authored-by: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
2020-03-22 18:03:54 -04:00
Rohesie
906d6f3d24 [READY] Fireman carry QoL changes (#49733)
* Fireman carry

* Change requests.

* doc
2020-03-22 18:00:56 -04:00
Mickyan
aee54c56c5 Adds space carp taming and a new bundle for the curator: the carp hunter (#50020)
* fish friends

* fish pals

* fish pals

* dumb

* hunting knife now is useful

* hunting knife now has a sprite

* FUCK

* inhand

* rohesie reviews

Co-authored-by: Fikou <piotrbryla@onet.pl>
2020-03-21 21:11:11 -03:00