Commit Graph

3282 Commits

Author SHA1 Message Date
Rob Bailey
65e9888fa6 [READY] Smart Cables (#44265)
Cables now autoconnect on cardinal directions. All cable placement has been completely stripped out and replaced with simple single cable per tile logic.
Low effort demo: https://www.youtube.com/watch?v=fXp8s6ORWbA
Yes I am aware that cutting it is not dropping wire, that version was bugged.
Cables no longer need a knot specifically placed to link to power objects. The sprite is automatically changed to represent this.
The only exception to this logic is that on smes units, due to the terminal being next to the output, they will not link there.
On a technical powernet side, this is the same as old cables once actually placed. They still use the existing powernet system, just the placement and connection works differently.

Old cables have been turned into "pipe cleaners" for wire art purposes. they work just like the old ones, just missing all the powernet functionality, and also you can put them on top of the floor.
Why It's Good For The Game

How obnoxious cables were to both map and work with in game has been something that has annoyed me for a really long time now.
This is both easier for new players to learn, and easier for experienced players to work with.
Along with making in game much more intuitive and easier, it makes mapping much easier as well. Mad lad wjohn was able to rip out all the mapping conversion in one day because of how much faster it is to work with.

cl actioninja and wjohn
add: Cables have been completely reworked. Simple per tile connection logic, automatically connects to things above it. Think minecraft redstone.
add: Old cables have been kept as pipe cleaner. They are non-functional in terms of power, but otherwise have the same connection logic. Also can go on top of tiles.
remove: mech cable layer has been removed because it was terrible shitcode nobody used
tweak: (sort of balance) cable stack sized has been reduced to 15.
/cl
2019-06-22 10:24:37 +12:00
Shaps
8954265573 Agender fixes (#44597)
Credits to Europaisch for help finding all the records stuff

Fixes a few issues I was not aware of with my initial PR

* Being agender is now a distinct DNA value (fixes agender spessmen
  turning female when having their DNA referenced, like during cloning
  and some rudimentary transformations)
* Neatens up preference code, more in line with previous code, fixes
  an issue with male underwear not surviving preference loading and
  defaulting to female underwear
* Allows agender spessmen to change their facial hair with mirrors
* Change medical, personnel, and security records from sex to gender
  and add "Other" option (they currently display "plural" even for
  agendered species like ethereals)
* The -san honorific now applies to plural gender instead of just
  neuter with the Chinese Cartoons admin secret (highly important)

I have never really played genetics and only tested the DNA code with
cloning and rudimentary transformations while still in a body (which
causes it to reference the old body's DNA, like with cloning). Please
let me know if there's a better way to do this and/or if this is apt
to create issues.
2019-06-19 13:59:39 -07:00
vuonojenmustaturska
8ddc9677c7 examine-code refactor (#44636)
* 1/4 done? maybe?

* more

* stuff

* incremental stuff

* stuff

* stuff & things

* mostly done but not yet

* stuffing

* stuffing 2: electric boogaloo

* Git Commit and the Kingdom of the Crystal Skull

* make it actually compile

* found more stuff

* fixes

* fix AI laws appearing out of order

* fix windows

* should be the remaining stuff

* this time for real

* i guess it should compile too

* fix sechuds
2019-06-19 22:07:57 +02:00
nemvar
6eaf40adb1 Makes the hermit more based. (#44564)
* welp

* h

* Let's hope I didn't mess map diff up.

* prisoner unbased
2019-06-18 23:24:09 -04:00
nemvar
137e2af8e2 Turns art into a component (#44525)
* welp

* h

* artcomponent

* I forgot something

* handsome squidward

* handsome squid

* n

* Ghosts should have fun too, I guess.
2019-06-18 14:23:42 +02:00
nemvar
74c8498c08 [Ready]Gives ashwalkers an antag datum (#44396)
* welp

* Savages, savages, barely even human.

* Savages, savages, barely even human

* You didn't see this

* h

* bee gone

* FFS, I mixed up my... ugh

* savage

* removed test line

* Turns ashwalkers into antags

* fuck

* hjjg

* fixes stupid

* g

* h2

* Damn...

* There we go?

* If it compiles, we can ship it

* Forgot the actually remove the thingy
2019-06-14 19:48:12 +02:00
nemvar
9a69d66feb Fix the open closet verb (#44480)
Fixes a bug and actually makes it do what it's supposed to do instead
of a hand attack.
2019-06-13 19:24:49 -07:00
Emmett Gaines
45ec62931d Finally removes the signal redirect component (#44251) 2019-06-09 17:25:50 -04:00
Rob Bailey
5743c9a748 Dragging prone mobs slows you down, fireman carrying (#44155)
About The Pull Request

Dragging prone mobs (resting, knocked down, stunned, dead, in crit, etc) that aren't buckled to anything slows you down.

You can fireman carry by aggressive grabbing then click dragging onto yourself. This causes a slight speed penalty that is lower than dragging.
Why It's Good For The Game

Prevents the classic "stun and beat the shit out of while zipping off" which is obnoxious and I don't think anybody likes besides the people who do it.
Makes it so if you feel like being a cunt you can rest while being arrested to make you a pain to take back.
Makes it harder to steal bodies and move away before anybody can properly react, but makes dragging bodies riskier at the same time
Fireman carrying adds an element of risk reward, it takes a little while of standing still to pick them up and also slows you down slightly. More useful to move someone a long distance out of a relatively safe area than a quick pull away.
Changelog

cl
add: fireman carrying. Aggressive grab then click drag onto yourself.
tweak: pulling prone mobs slows you down.
tweak: carrying another human slows you down.
tweak: pacifists can aggressive grab.
/cl
2019-06-09 23:54:02 +12:00
bgobandit
f9330d2fd1 Art produces moodlets, good or bad depending on quality. THE REMAKE (#44174)
* Art produces moodlets, good or bad depending on quality.

* makes more requested changes

* makes requested changes/placates oranges

* fuck this shit

* this is my last will and testament, when I am dead and gone I request that my relatives make the changes that I will probably still be requested to make at that point
2019-06-08 21:58:13 +02:00
Nalzul
47700b8679 Allows you to wear the caution sign + new sprite for the caution sign (#44289)
* +Sprite +Repath

* Adds 5 brute armor
2019-06-04 11:48:47 -04:00
kingofkosmos
1bf60bbe06 Adds missing </span>'s. 2019-06-02 21:29:14 +03:00
skoglol
7969654ad1 Moves machine/computer frames and structures below object layer. (#44165)
* Moves machine and computer frames below object layer.

* Moves structures below object layer.

* moves mineral doors to airlock layer, removes excess layer overrides.
2019-05-31 19:18:41 +02:00
zxaber
130e066372 Allows unanchoring and deconstructing of linen bins (#44171)
* linen bins, your time has come

* update

* update
2019-05-31 13:10:27 +02:00
vuonojenmustaturska
6a106bc877 Remove reagent ids and use typepaths where applicable (#44166)
cl Naksu
code: reagent IDs have been removed in favor using reagent typepaths where applicable
fix: mechas, borg hyposprays etc no longer display internal reagent ids to the player
/cl
2019-05-31 21:57:26 +12:00
tralezab
ba1fd3e4f7 there is no finish line. there is no escape. more fixes. 2019-05-27 12:38:04 -07:00
tralezab
a2cf51bc3c Merge branch 'master' of https://github.com/tgstation/tgstation into feels-like-i-didn't-even-try 2019-05-27 08:54:14 -07:00
tralezab
c33c7fff9d begone, badcode! 2019-05-27 08:48:03 -07:00
Emmett Gaines
66cab55f28 Replaces the rpg loot datum with a component and makes some suffixes have real effects (#44044)
* Replaces the rpg loot datum with a component

* Makes bane accept species types

And cleans up some other code
2019-05-22 08:47:42 +02:00
skoglol
5316926510 Fixes some missing adjancency checks. (#44020) 2019-05-21 11:43:35 +02:00
zxaber
a22ffe33b1 Reworks AI backup battery system slightly, and allows (un)bolting while on backup at heavy power cost (#43952)
* power underwhelming

* Update ai_core.dm

* status page update

backup power now only shows in the status page if the AI is in the core.
2019-05-18 16:32:02 +02:00
tralezab
e50ef24030 a lot of the fixes minus ship spawning
fix names
2019-05-11 23:21:55 -07:00
Farquaar
3dbc8c3c12 Adds a Bunch of New Religious Clothing Items (#43841)
* Adds the rasta beanie

* Added Bishop Mitre

* Added some more religious headgear

Clown Mitre (Hat of the Honkmother)
Kippah
White and Red Taqiyahs
Medieval Jewish Hat

* Fixes icon_state for the Hat of the Honkmother

* Added some new chaplain outfits

Bishop Robe
Monk's Frock (with hood)
Eastern Monk's Robe
White Robe

* Added Robes of the Honkmother

* Added new religion hat icons

Bishop Mitre
Clown Mitre
Kippah
Red and White Taqiyahs
Medieval Jew Hat
Rasta Beanie

* Added new religion suit icons

Bishop Robe
Monk's frock
Eastern Monk's Robe
White robe

* Added new religious suits

* Added new religious headgear

* Added in-hand sprites for new religious suits

* Added new religious clothing to the chaplaindrobe

Includes new premium and contraband objects.

* Added clown priest's robes to premium

* Added some religion follower hats

Kippah
Taqiyah (red)

* Added rastacap to the chaplain vendor

* Fixed obj directory for red taqiyah

* Fixed spelling of "dreadlocks

* Allowed clown robes to hold prank items

* Created .dm for chaplain suits

For easy organization

* Removed clown priest robes

Put them in chaplainsuits.dm

* Moved new chaplain suits

To chaplainsuits.dm

* Moved holiday priest

to chaplainsuits.dm

* Moved holiday priest to chaplainsuits.dm

* Updated suit obj defines, added monk's frock

* Updated obj defines for chaplain suits

* Updated holiday priest obj define

* Updated chaplainsuit obj defines, added white robes

* Fixed subtype define

Man, that was an embarrassing spelling mistake

* Fixed subtype define

For real this time I hope

* Added chaplainsuits.dm

* Fixed clown robes

* Updated holiday priest path

* Updated path for chaplainsuits

* Re-added prank items to clown robe storage

* Updated pathing for chaplain suits on Pubby

* Added comments

Hopefully this will help the AppVeyor check go through
2019-05-10 15:01:45 -04:00
vuonojenmustaturska
fb45b7a017 Turns trait accessors into defines, fixes some bugs (#43820)
It's free performance.
2019-05-06 19:44:05 -04:00
vuonojenmustaturska
af552d9be5 fix guncase init (#43821) 2019-05-06 16:27:53 -04:00
zxaber
2509aaea46 Removes the negative moodlet for showering with clothes on. (#43722)
* Don't need none of that negitive attitude

* better good

* Adds a message about trying to shower with clothes on while you're filthy.
2019-04-30 10:10:39 -04:00
skoglol
bea6be8fa3 Makes falsewall hide pipes and wires. (#43724) 2019-04-29 12:12:59 -04:00
Tad Hardesty
46aa7d9d6d Improve messaging when failing to fold a bodybag (#43700) 2019-04-29 10:19:31 -04:00
Dax Dupont
b13d244d76 Adds new clown mobs for admin use (#43675)
* new clown mobs and spawners

adds several new types of clown mobs, a beacon to spawn them, and a honkrender that spawns clown hulks

* added more clown varieties and fixes to previous

* fixed unneeded capitalization and changed mob values

removed unneeded capitalization and text errors and altered mob attack values to create more variation. Honkmunculus now does very little damamge but injects a small amount of meth.

* Update clown.dm

* clown changes and new clown

new clown that spawns bananas. can leave large stacks if left unattended, so it may require some reworking. nerfed several overpowered clowns and gave chlown a beetle like stride

* added cluwne to uplink, fixed redundant variables, added new clowns

cluwne can now be purchased for 5 telecrystals as a clown exclusive uplink item. Bananas were greatly improved. new weak clown added. Gave some clowns extra parents to reduce variables.

* Update code/modules/mob/living/simple_animal/hostile/retaliate/clown.dm

Co-Authored-By: Pugnacious-Gnome <48869928+Pugnacious-Gnome@users.noreply.github.com>

* IT LIVES ONCE MORE

* forgive me for this sin

* i wish git would detect case changes

* this works
2019-04-24 18:13:57 -04:00
William Wallace
a944c2a362 Ghosts can analyze gas mixes and some new objects can be analyzed (#43502)
* Ghosts can analyze gas mixes and some new objects can be analyzed

* Replace show_air_status_to with atmosanalyzer_scan
2019-04-16 21:46:36 +12:00
Unknown
c13420e75a initial 2019-04-02 00:18:23 -07:00
Tad Hardesty
3d098c890a Standardize obj/updateicon() and update_icons() to update_icon() (#43418)
* Standardize updateicon to update_icon

* Standardize obj/update_icons() to update_icon()

* Fix pneumatic cannon infinite loop
2019-04-01 18:08:19 -04:00
pireamaineach
617880080c [NOT FUCKED ANYMORE] Numerous detective related changes. (#43317)
Numerous detective related changes.
2019-03-29 13:23:38 -04:00
ShizCalev
c1f7d01334 Repath /obj/structure/chair/office/dark to /obj/structure/chair/office (#43269)
The parent was just a dummy path, no sense having it really.
2019-03-26 20:43:30 -07:00
Tad Hardesty
956acb2d8e Fix heirloom bodybags being destroyed by use (#43262)
* Fix heirloom bodybags being destroyed by use

* Destroy folded bag if it hasn't been moved back into the world
2019-03-23 16:36:40 -04:00
81Denton
1d18047940 Fixes latejoin AI core grammar/adds multitool hint (#43231) 2019-03-21 16:18:28 -04:00
4dplanner
72fc9bb043 Fixes wheelchairs [TESTMERGE ME :)] (#42894)
Changelog

cl
fix: Buckle objects can now properly specify lying angle
fix: Wheelchairs and other such vehicles let you use UIs even if your legs don't work
fix: You can now pull objects while in a wheelchair even if your legs don't work
fix: You no longer have a chance of sleeping upside down in a bed
tweak: No longer randomises lying direction a second time on fall
/cl

code: simplified can_stand code

fixes #41703
2019-03-17 23:22:01 +13:00
BuffEngineering
1a557b2d63 Fix high security door material exploit, tweaks cost (#43035)
Fixes an exploit that allowed for infinite metal/plasteel to be farmed off of
high security/vault door deconstruction. Makes completed airlock assemblies
start with no wire security and adjusts the material costs of both doors
accordingly. As the high security airlock was fortified with normal metal
unlike the vault door this is a slight buff to it, but I am fairly sure it
will not affect the game balance noticeably.
2019-03-09 13:19:12 -08:00
Tlaltecuhtli
f5d5d2a3b1 fixes some edge cases in rcd building (#42960)
New RCD interactions
2019-03-07 10:49:43 +01:00
tralezab
0a51e7e1b9 [PROBABLY READY? REVIEW WITH SCRUTINY] New event: Fugitives (#42554)
* fugitives

* lets make this a bit cleaner

* cultists and the beginnings of security detail, lots of wip

* wip security

* WALDO (and some more work on yalp, of course)

* adding antagonist teams for both hunter and fugitives, roundend report beginnings

* this whole file is shit, but hopefully a little better

* it compiles (+ space police)

* some more work

* S.E.L.F. fluff

* grammar and icon fixes

* lets finish yalp elor, give it the justice it deserves

* moves hunter spawns to ship pods + russians P1

* moves hunter spawns to ship pods + russians P2

* fugitives and hunters now recognize eachother

* hunter spawning finished(?)

* missed this

* ATH's review

* runtime fixed, added yalp's transport ability

* anturk's review

* makes hunter.dm better trust me

* oopsies

* INVOKE_ASYNC

* russian ship + finally a (bad) sprite for the capture machine

* step > pixel, thanks travis

* mooshroom review p1

* mooshroom review p2

* improper use of /improper

* waldo's radio doesn't stick, police id

* candidate picking is more flexible + minor things
2019-03-06 10:17:46 -05:00
skoglol
cbecd7a93a Another fridge access pass (#43012)
Removes access restriction on fridges and meat fridges in areas where you
shouldn't be expected to have kitchen access. Notably, everywhere that is not
the main station kitchen. I didn't think to check this in #41923.
2019-03-05 21:12:34 -08:00
ShizCalev
5dc1e548a3 Fix secure crates not returning a value for take_damage (#42969) 2019-03-02 13:57:40 -08:00
oranges
7a3dfa6b40 Merge pull request #42923 from ShizCalev/janicard-sign-fix
Fixes janicart /holosign interactions
2019-03-02 09:47:36 +13:00
oranges
1a3af2d0c1 Merge pull request #42925 from actioninja/bucketspritefix
Fixes mop bucket sprite not updating properly after filling with a bucket
2019-03-02 09:47:06 +13:00
ShizCalev
25d142e917 Fixes janitors not spawning with the proper janitor holobarriers (#42921)
* Fixes janitors not spawning with the proper janitor holobarriers

* one more
2019-03-02 09:46:22 +13:00
Coconutwarrior97
765f8e32e0 Fixes transit tube barricade spam (#42813)
* Only two transit tubes per turf can be wrenched down.

* Made a can_wrench_in_loc() proc. Placed it at start of wrench_act and afterI.use_tool.

* This aint lookin hot.

* Should be working now.

* Added proc at start of wrench_act.

* Fixed if statement and put it before to_chat.
2019-03-02 09:43:53 +13:00
WJohn
6f959e7192 Slightly tweaks syndie lavaland/listening post bases. (#42913)
When the circuit lab was added and subsequently removed from the lavaland base, it left a poorly lit spot by medbay. Also adds explosive warnings in the test chamber to hopefully dissuade people from blowing the whole base up.
2019-02-26 21:39:51 -05:00
actioninja
ca94efb18f mop bucket sprite update fix 2019-02-26 00:13:47 -08:00
ShizCalev
1a8b17bdf8 Fixes janicart /holosign interactions 2019-02-26 02:20:17 -05:00
MrDoomBringer
e011cfe62b [RED LABEL][TESTED][SINGLE][READY][2][MINGLE] Adds an Supplypod Launch Bay specifically for ERTs or Deathsquads (#42614)
* reeling it in

* Revert "reeling it in"

This reverts commit 2b795a8baf5eec89fdc1e6b6a6ef9d36276c2e62.

* adds the room

* makes the boobs more seeable

* WHAT IS CONSISTENT PROC NAME FORMATTING FUCK FUCK FUCK

* adds fluff sign and fixes map a tiny bit

* small updates

* fuck FUCK YOUR MERGE CONFLICT FUCK
2019-02-14 21:12:55 +11:00