Implements Instrument UI Interaction When Laying Down (#72926)
## About The Pull Request
Adds floor_okay = TRUE tag to the song editor dm. Basically a small QoL
to allow you to initiate your song if you were say, slipped by a 100
potency banana and wanted to continue playing your song while waiting to
get back up. The change allows you to actually interact with instrument
UI while laying down.
## Why It's Good For The Game
Took a bit of searching but I find that this QoL feature really made a
big impact to me at least. You can play your instrument on the floor
while laying down. It makes sense to me that you should be physically
able to strum a guitar or press keys when you're on the floor as you
already are able to play anyway by starting the instrument standing up
and then laying down. This just cuts out the need to have to stand up to
re-interact with the UI if you say, got slipped or lost both your legs
in a tragic accident. Also allows you to chill on a bed and play without
having to get up, I guess. This might be a minor gameplay change to some
but for those who play instruments the entire round for others to enjoy,
this is a huge QoL.
## Changelog
🆑
qol: Musicians rejoice! You can now interact with the instrument UI
while laying down.
/🆑
Co-authored-by: ophaq <44999764+ophaq@users.noreply.github.com>
* (code bounty) The tram is now unstoppably powerful. it cannot be stopped, it cannot be slowed, it cannot be reasoned with. YOU HAVE NO IDEA HOW READY YOU ARE
* fex
* fex
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
* Fixes the inputs for the linear and exponential sustain options of the song editor. (#65008)
* Fixes the inputs for the linear and exponential sustain settings of the song editor.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Fixes the song editor UI on pianos/space minimoogs. (#64545)
This fixes a bug (#64516) where the song editor UI failed to update properly on pianos/space minimoogs.
As it turns out, the updateDialog call at the end of the file had nothing set for it, resulting in it runtiming any time it was supposed to be updating.
Setting it to (usr) fixed the problem, and the UI now works properly.
* Fixes the song editor UI on pianos/space minimoogs.
Co-authored-by: sergeirocks100 <31294280+sergeirocks100@users.noreply.github.com>
* Synthesizers and headphones can now have circuits! (#62825)
About The Pull Request
A circuit and shell components have been added to Synthesizers (headphones and spacepods included, though with a reduced capacity because of their size), so they can now be used for wiremod. Just like for instant cameras, no shell design here. They are meant to be found in dorms or maybe ordered from cargo.
Why It's Good For The Game
The station outside the sci department has plenty of USB ports stuff but is lacking when it comes to circuits shell. This is another small step toward a better and more applicable wiremod.
Changelog
cl
expansion: Synthesizers and headphones can now have circuits installed.
/cl
* Synthesizers and headphones can now have circuits!
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* if you give a monkey an instrument, it will begin playing the donkey kong theme (#61726)
* if you give a monkey an instrument, it will begin playing the donkey kong theme
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* Update _song.dm (#55564)
The instrument datum would hold up the song datums preventing them from deletion, this fixes that
* Fixes GC for songs
Co-authored-by: Azarak <azarak10@gmail.com>
* Baystruments - I had two tgstation forks for some reason and had to delete one and that nuked the last PR (#51459)
Instruments and sound channels refactor.
* Baystruments - I had two tgstation forks for some reason and had to delete one and that nuked the last PR
* Fixes dme dupe
* Fixes dme dupe (#52954)
Co-authored-by: silicons <2003111+silicons@users.noreply.github.com>
Co-authored-by: AnturK <AnturK@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
