mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-09 23:27:56 +01:00
mrmanlikesbt
b08ec39e1b
## About The Pull Request
### Don't run every single test
I've had this on my mind for several months and it being brought up
recently reminded me so here we are.
Unit tests only run on `runtimestation_minimal.dmm` now with the
exception of map tests. The following unit tests are declared as map
tests but I didn't see any map dependent logic so 🤷
- `/datum/unit_test/maptest_baseturfs_unmodified_scrape`
- `/datum/unit_test/maptest_baseturfs_placed_on_top`
- `/datum/unit_test/maptest_baseturfs_placed_on_bottom`
- `/datum/unit_test/maptest_get_turf_pixel`
- `/datum/unit_test/maptest_load_map_security`
- `/datum/unit_test/maptest_modular_map_loader`
- `/datum/unit_test/maptest_turf_icons`
`/datum/unit_test/subsystem_init` isn't really a mapping unit test but I
figured somehow, someway, maps might fuck with subsystem initializations
so I just decided to include it.
### Splits up the create & destroy test
Idk, pretty simple. Create & destroy is now split up across all
integration tests and ran in parallel.
## Why It's Good For The Game
oranges promised me "500 nzd" yo
## Changelog
No player facing changes
14 lines
606 B
Plaintext
14 lines
606 B
Plaintext
/// Tests that [/datum/job/proc/get_default_roundstart_spawn_point] returns a landmark from all joinable jobs.
|
|
/datum/unit_test/maptest_job_roundstart_spawnpoints
|
|
test_flags = UNIT_TEST_MAP_TEST
|
|
|
|
/datum/unit_test/maptest_job_roundstart_spawnpoints/Run()
|
|
for(var/datum/job/job as anything in SSjob.joinable_occupations)
|
|
if(job.spawn_positions <= 0)
|
|
// Zero spawn positions means we don't need to care if they don't have a roundstart landmark
|
|
continue
|
|
if(job.get_default_roundstart_spawn_point())
|
|
continue
|
|
|
|
TEST_FAIL("Job [job.title] ([job.type]) has no default roundstart spawn landmark.")
|