mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-09 07:08:03 +01:00
mrmanlikesbt
b08ec39e1b
## About The Pull Request
### Don't run every single test
I've had this on my mind for several months and it being brought up
recently reminded me so here we are.
Unit tests only run on `runtimestation_minimal.dmm` now with the
exception of map tests. The following unit tests are declared as map
tests but I didn't see any map dependent logic so 🤷
- `/datum/unit_test/maptest_baseturfs_unmodified_scrape`
- `/datum/unit_test/maptest_baseturfs_placed_on_top`
- `/datum/unit_test/maptest_baseturfs_placed_on_bottom`
- `/datum/unit_test/maptest_get_turf_pixel`
- `/datum/unit_test/maptest_load_map_security`
- `/datum/unit_test/maptest_modular_map_loader`
- `/datum/unit_test/maptest_turf_icons`
`/datum/unit_test/subsystem_init` isn't really a mapping unit test but I
figured somehow, someway, maps might fuck with subsystem initializations
so I just decided to include it.
### Splits up the create & destroy test
Idk, pretty simple. Create & destroy is now split up across all
integration tests and ran in parallel.
## Why It's Good For The Game
oranges promised me "500 nzd" yo
## Changelog
No player facing changes
21 lines
891 B
Plaintext
21 lines
891 B
Plaintext
/// Conveys all log_mapping messages as unit test failures, as they all indicate mapping problems.
|
|
/datum/unit_test/maptest_log_mapping
|
|
test_flags = UNIT_TEST_MAP_TEST
|
|
// Happen before all other tests, to make sure we only capture normal mapping logs.
|
|
priority = TEST_PRE
|
|
|
|
/datum/unit_test/maptest_log_mapping/Run()
|
|
var/static/regex/test_areacoord_regex = regex(@"\(-?\d+,-?\d+,(-?\d+)\)")
|
|
|
|
for(var/log_entry in GLOB.unit_test_mapping_logs)
|
|
// Only fail if AREACOORD was conveyed, and it's a station or mining z-level.
|
|
// This is due to mapping errors don't have coords being impossible to diagnose as a unit test,
|
|
// and various ruins frequently intentionally doing non-standard things.
|
|
if(!test_areacoord_regex.Find(log_entry))
|
|
continue
|
|
var/z = text2num(test_areacoord_regex.group[1])
|
|
if(!is_station_level(z) && !is_mining_level(z))
|
|
continue
|
|
|
|
TEST_FAIL(log_entry)
|