mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 09:42:29 +00:00
5d8bddfcf4
## About The Pull Request this gets rid of the `get_messengers_sorted_by_name` and `get_messengers_sorted_by_job` procs, instead replacing them with two new global lists: `GLOB.pda_messengers_by_name` and `GLOB.pda_messengers_by_job` those two lists are updated in the `add_messenger` proc, which uses the binary insert macros to insert it into the properly sorted place. why? bc sorts suck for performance and all inserts/removals to this list go thru a single proc anyways, so we can just ensure it's sorted like this once, instead of re-sorting each time. thanks to @LemonInTheDark for helping me with this <details> <summary><h3>Testing Proof</h3></summary> <img width="1708" height="1349" alt="2025-08-16 (1755391989) ~ dreamseeker" src="https://github.com/user-attachments/assets/1e2dc99a-1863-4a35-8032-8ae64706fdaa" /> <img width="1708" height="1349" alt="2025-08-16 (1755392002) ~ dreamseeker" src="https://github.com/user-attachments/assets/4d9b3bd0-7f3a-410b-a073-1bf2bd69690b" /> </details> ## Why It's Good For The Game because doing a sort repeatedly whenever someone has their PDA messenger open is stupid and sucks ## Changelog no player-facing changes