mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-02-10 00:08:19 +00:00
## About The Pull Request So apparently, as the title says, placing items on tables through the lootpanel would place them in the very corner. I learnt about this because of someone telling me it _used_ to always center them. Looking into it, this seems to be because we ALWAYS set it based on the `modifiers` `ICON_X` and `ICON_Y`:0da57e9524/code/game/objects/structures/tables_racks.dm (L319-L321)While those are not set when clicking through the lootpanel, causing these formulas to default to `-16`, and thus placing them in the corner. Comparing this to crayons/spraycans, which do center, and do this because they only adjust the `pixel_x` and `pixel_y` if `ICON_X` and `ICON_Y` are actually set:0da57e9524/code/game/objects/items/crayons.dm (L500-L502)At some point in the past tables also had this check, but it seems it got accidentally removed during the move to `item_interaction(...)` from `attackby(...)`. We just reintroduce this check, meaning it once again defaults to the item being centered. ## Why It's Good For The Game Having your item be placed on the very leg of the table is kinda awkward. ## Changelog 🆑 fix: Clicking on a table in the lootpanel with an item in-hand tries to place it in the center again. /🆑