- spider webs / vines should never have been effects in the first place
- spiderlings should probably just be mobs at some point lol
---------
Co-authored-by: Zandario <zandarioh@gmail.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
stops closet from calling take_contents twice
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Please note that
maintainers freely reserve the right to remove and add tags should they
deem it appropriate. You can attempt to finagle the system all you want,
but it's best to shoot for clear communication right off the bat. -->
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
title, will be used when i tgify machines (upgradable machinery)
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Please note that
maintainers freely reserve the right to remove and add tags should they
deem it appropriate. You can attempt to finagle the system all you want,
but it's best to shoot for clear communication right off the bat. -->
🆑
code: properly implement `INTERACT_ATOM_*`
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
- separates the composition of cyborgs into modules, iconsets, chassis,
upgrades
- modules / chassis atm can provide items, so can upgrades; in the
future we will want to probably generalize the item API a bit so
components can work
- chassis now can (unimplemented) easily be made to give different stats
- reorganizes all the cyborg sprites
- adds generalized item mounts with redirection support and tears out
legacy cyborg items
- entirely rebalances modules & writes some new lawsets in for future
use
---------
Co-authored-by: silicons <silicons@silicons.dev>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
title, preferably merge
https://github.com/Citadel-Station-13/Citadel-Station-13-RP/pull/7467
before this
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Please note that
maintainers freely reserve the right to remove and add tags should they
deem it appropriate. You can attempt to finagle the system all you want,
but it's best to shoot for clear communication right off the bat. -->
🆑
tweak: safes are 20% more cooler, also you can break it open with 3
large-sized explosives
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
- all cells in the game are now small, medium, large
- super, hyper capacity cells, device, and weapon cells are all removed
- cells now have standardized variants, some of which are printable by
R&D
- energy weapons rebalanced
- **advanced energy guns and stun revolvers removed** - use the new
modular weapon system and microfission cells.
---------
Co-authored-by: silicons <silicons@silicons.dev>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
removes the adminbus_trash variable
removes the option to play audible hunger noises
removes option to TF people into eggs
Moves the feral variable from /mob/living to the xenochimera species
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
Unused variables are not helpful.
TF to egg is unused and broken.
only chimera uses the feral variable anyway, and even then it mirrors
the mob variable for use, so lets just move it to chimera
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Please note that
maintainers freely reserve the right to remove and add tags should they
deem it appropriate. You can attempt to finagle the system all you want,
but it's best to shoot for clear communication right off the bat. -->
🆑
del: Removed unused variables that held over from vorestation
del: Removed Vore belly transform to egg options
del: Removed audible hunger noises
tweak: tweaked feral to be a chimera specific variable, instead of a mob
variable thats only used by chimera
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Applies a nerf to Monarch's charge, no longer instantaneous.
Lowers Monarch's burn/energy resist, burn should work better against it
since Xenomorphs are weak to fire.
Axes **any** and all mentions of natural spawn positions, this should
never spawn naturally. It is a boss mob.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
This has been an issue for a while, but the natural spawn points for the
Monarch were the last straw. Oopsies.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Please note that
maintainers freely reserve the right to remove and add tags should they
deem it appropriate. You can attempt to finagle the system all you want,
but it's best to shoot for clear communication right off the bat. -->
🆑
balance: lowers Monarch's burn resist, makes charge not instant.
fix: Removes any reference to the Monarch spawning naturally, probable
or not.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
So I decided to tweak xenohybrids some more
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
We love features
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Added a bunch of COMSIGnals to make the later work.
add: Added new stealth ability for xenomorph hybrids
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Adds heretic themed objects, structures, mobs and more from TG/other
servers heretic code.
Most of the items will probably remain mechanically featureless. Unless
someone's insane enough to port full heretic functionality.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
MORE madness? MORE magic shit? MORE chaos? What's not to love?!
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Heretical stuff. More to come.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: Sorrowfulwinds <rockboy3970@gmail.com>
Co-authored-by: silicons <2003111+silicons@users.noreply.github.com>
Co-authored-by: silicons-bot <121360372+silicons-bot@users.noreply.github.com>
Co-authored-by: LordME <58342752+TheLordME@users.noreply.github.com>
protean blobs can now grab/disarm people again
you can now buckle to proteans again (since they can't ventcrawl)
they can now go through plastic flaps and over tables like promethean
blobs
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Refactors clothing/under to use the new rendering system for both icons
and flags and does some general rearranging and cleanup of the code
files.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
One single consistent system is good. This also fixes a lot of missing
rolldown, rolled sleeves, and maybe some species specific sprites.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
- Moves clothing/under/accessories to clothing/legacy_accessories
- Reformats under into under/casual, /costumes, /formal, /workwear
folders.
- Changes all /obj/item/clothing/under to use the new clothing render
system
- Annihilates uniform.dmi into a thousand pieces
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑 _Shadowcat_
refactor: refactors under clothing to new render system
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: silicons <2003111+silicons@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
this doesnt work yet lol
bring over the ticket printer from CHOMPers. now you too can slap a
ticket on your friends for extreme bottom activity
## Why It's Good For The Game
soul
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: add ticket printing
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: silicons <2003111+silicons@users.noreply.github.com>
Co-authored-by: Zandario <zandarioh@gmail.com>
## About The Pull Request
This was inspired by stray discussions in the discord musing the
potential of adding pallet jacks to the game. We threw our two cents in
proposing that they control like sokoban, and reception was positive!
(Wheelchair sprites are placeholder!)
Pallet jacks have sprites created by Keekenox!
Pallet jacks have fairly interesting behavior. Notably:
- They can only be pulled cardinally. Attempting to pull them diagonally
will break the pull.
- They cannot move sideways relative to where they're facing. They can
only move forward and back.
- They can only be pulled from the side that the handle is present on.
- They don't attempt to follow you if you're still adjacent to them when
moving.
- They will always face the mob pulling them.
## Why It's Good For The Game
It'll give cargo an interesting low-tech alternative to ripley mechs if
crates that require more oomph than a spaceman body on its own are added
to the game.
The quirks in their movement are likely to make for some fairly amusing
logistics, particularly when it comes to players unfamiliar with sokoban
puzzles!
## Changelog
🆑 Bhijn and Myr, plus Keekenox for sprites
add: Added pallet jacks! These have fairly peculiar movement quirks,
being fairly reminiscent of push/pull sokoban puzzles.
/🆑
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
_Somewhere on Centcom NDV Marksman, near a window_
-"Hey, Officer, here are the manifest of the last few months from crew 7
EX 39."
-"Huh. Thank you... Wow, is it me or they are getting less people ?"
-"Yes, I agree... Yet they are getting some big bas- Holly molly, is
that the Strelka ? Its getting repaired ? My grandpa loved that ship !"
-"Huhuh. We only need a smaller crew to man it..."
_Both are looking at a the crew manifest folder_
-**"Bingo."**
The Strelka is one of the oldest NT Vessel. Started out as a Luxury
Yacht for NT, to carry VIPs and celebrities. Served also as a blockade
runner during the corporate wars. Its last function was as a pathmaker
and obstacle buster for the Marksman fleet. With being one of the
oldest, its also one of its smallest, yet still can be used as a day to
day vessel, with... a lot of sacrifices.
The Vessel got four decks, like the Triumph or Endeavour, but is arround
only 80 Tiles long and 64 tiles wide. Its main focus was mainly confort
and luxury at first, with its departments being, for a lot of them, just
cabins with walls that got destroyed to make more room.
## Why It's Good For The Game
The map was made at first to test how small a citadel station can be.
_But I got carried away :D_
There are not a lot of players playing during some time of the day, and
a request for a smaller map, that makes people interact more with each
other, has been requested. This map should do it. Its also takes a
direction that is different from the Atlas, Tether, Triumph and
Endeavour, aspect wise.
The map is also a test to apply the different ideas given from the
exploration departement debates that the server saw multiple times.
Here, the exploration depatement is actually rather open. All of the
crew can easely acces the excursion shuttle hangard. The gears of EMTs
and Explorators (and pathfy) are still here, but located in Science and
Medical (The Pathfy still get is own office). The goal is to have away
team with different crew of multiple departement more easely, without
the need to change access.
Since the vessel is a NEV, the pathfinder gets also acces to the bridge,
where he can assist with charter and helm... And of course, since this
vessel have a Obstacle removal Ballista, the pathfinder (and command)
can use it.
The main drawback of the vessel would be that some science activities
are missing, mostly those that can be found in the western plain outpost
of Lythios 43. So the remaining activities are : Robotics, RnD, Circuit,
Chemistry, Xenobiology, Xenobotany, Telescience, Xenoarchelogy, And
Anomaly.
Another drawback is the lack of maintenance tunnels. There are some
maintenance area, but were on other maps they are arround 30% to 45% of
a map, on this vessel, they be arround 10%. SMES are in glass boxes that
requires Engineering acces to open.
Other than that, all departments and activities are here. It is also
able to welcome traveler and trading shuttles in its Deck 4 hangar.
**It is still a WIP, and would require testing**
---------
Co-authored-by: LordME <58342752+TheLordME@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Fixes map errors on Gaia, Triumph, Tether, and Sky Planet.
Changes the warnings for Stairs, Catwalks, and SMES's to call CRASH()
with audit_loc() to match the standard used by paint helpers and window
spawners.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
Maps being able to load is good.
Vague warnings are now changed to verbose hard crashes to make it much
easier to fix as a mapper (and ideally prevent these issues from
embedding themselves into the codebase without notice).
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
-Fixes Gaia map errors
-Fixes Tether map errors
-Fixes Sky Planet map errors
-Fixes Triumph map errors
-Changes map Warning()s to CRASH()s
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
fix: fixed gaia, triumph, tether, skyplanet map errors.
code: changed stairs, catwalks, SMES warnings to verbose CRASHs.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
## About The Pull Request
title
someone (me) fixed sofa directions and forgot that they would need to
update the layering code
## Why It's Good For The Game
fixes a bug
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
fix: fix sofa corners layering
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
"A chilly wind starts blowling in your back whil you descend from a
shuttle. It whistle on the rusted metal base you are starting on, a
mighty sky rig... Indeed, all arround you is a Ocean of clouds, it
"waves" floating lightly in air. But you also know that the views is
only one side of a coin... This is paradise, and underneath, deep under
the clouds, is an Acidic hell... Welcome, on Lythios 43a."
This PR adds a new 6 Z level exploration map, like Miaphus and other POI
planets.
This planet have random generated POI like Miaphus, but also new
activities beyond exploring.
Indeed, the planet is home of the Voidline Shuttle Racing competions,
and comes with 3 race shuttles to compete. (A fourth one, the Arrowhead,
is on Nebula)
New planet, new foes. Flying lizards, "Dragoons", roam the skies. While
green one are peacefull, the Blue, Yellow and Red ones are too be
avoided....
Speaking of that, to defy their control in the sky, youll need probably
a fighters. Good think Pinances are arround, and crew can lauch them
from NT Outpost Hyades, a EX-SDF base.
## Why It's Good For The Game
-New destination, with new POI. Offers new place to explore, in the
harder side in some places and easier in others.
-Use of a game mechanic, fighters, that isn't used much (they are
usefull to explore arround.
-New out of spawn activity : Shuttle Race.
Still a WIP.
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Makes the warden and HoS Office electrochromic windows work.
removes two of the three warrant projectors in the security officers
locker
fixes two cameras in the Hammerhead hangar
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
tweak: tweaked the security department on atlas
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Tajara Peasants are coming.
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## A New Ghost Role and Lythios Features!
It seems like the crew is finally getting some neighbors on good old
Lythios. Tajara, of course, you have to source your colonists locally
after all. Nanotrasen is even going to let them onto station grounds to
work and trade with the crew. The new ghost role Na'sahira Colonist is
an Atlas-specific ghost role in the same vein as ashlanders. Like
Ashlanders, Colonists have unique crafting recipes, which use the new
gatherables I have added. Hopefully, this will give them more products
to trade with the crew.
In addition, I have made some other balance chances and additions:
- Two new plants that can be harvested from now spawn randomly in the
Lythios snow
- Spiders now drop poison gland items which can be extracted for their
reagents.
- Butchering now produces between 0 and the set amount of the butchering
loot rather then 0 **or** the butchering loot greatly increasing the
chances of you at least getting something from butchering.
- The powder horn now holds double the gunpowder.
- Colonist recipes are in a new "Special Recipes" Tab which I believe is
a good place to add recipes from species backgrounds or ghost role in
future development.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
The Ashlanders never saw their full potential since the crew was always
limited in how they could interact with them. Travellers and traders by
contrast are extremely freeform but are still separated from the
station. Colonists will spawn directly on the Lythios map and can
interact directly with the entire crew without delay. The colonist
recipes give incentives to interact with the new Lythios map features
and the Lythios map in general. The butchering change removes the
frustration inherent with butchering an creating and getting no rewards.
The powder horn was buffed to make it more in line with similar-sized
reagent containers and to make sure black powder weapons are better
suited for longer periods of combat. The spider poison gland PR was made
when I figured spiders
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: The Lythios Colonist ghost role.
add: two new snow plants that can be harvested, new crafting recipes,
tweak: butchered creates drop 0-amount loot rather then 0 or amounts
loot
balance: powderhorn capacity doubled
fix: Welderspear recipes now in the correct recipe category.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Moves a few checks if someone's flying/hovering to use the
is_avoiding_ground check. It also removes the slowdown of a tile if you
aren't actually stepping on it. This check does include more, like if
you are only riding on something that's lifting you up enough, but
unless it flies itself, it'll trigger what you may be avoiding, and in
turn, will be affected by it (i.E falling down the chasm, there is no
delay in my test, so no Yoshiing over a single tile.)
Draft for now to see if there are more places to check for it, and as
the balance change is big enough to warrant additional thoughts.
## Why It's Good For The Game
Flying people no longer leave footprints, nor touch the ground for water
or lava. Logically, they aren't even slowed down by the tiles. This
heavily buffs flying, at least the ignoring the slowdown part, so that
may be removed for the sake of balance. The rest should be more
flavorful, or just making sense.
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
tweak: If you aren't touching the ground, don't interact with things
there.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: MarsMond <no@email>
this is a quick one
makes them less code copypaste-y and easier to modify in the future as
i'll want to do some experimentation on the system when we start
reworking explo
Tears apart the overloaded `/obj/item/mecha_parts` into a few different
paths.
`/obj/item/vehicle_chassis` for the base part that things attach on
(this is the mech construction holder)
`/obj/item/vehicle_part` for things you attach to chassis
`/obj/item/vehicle_component` for integral components
`/obj/item/vehicle_module` for equipment
This is to prepare for further work on mecha as a system, and to get
some of the massive line changes out of the way.
Also:
- tears apart a few files that were just too long to be handled and
groups everything with their mechs
- erases some code reuse
