Apply suggestions from code review

Co-authored-by: SabreML <57483089+SabreML@users.noreply.github.com>
This commit is contained in:
Qwertytoforty
2021-10-09 12:52:46 -04:00
committed by GitHub
co-authored by SabreML
parent 6def6490a0
commit bebd890081
2 changed files with 6 additions and 7 deletions
@@ -790,11 +790,11 @@
/datum/AI_Module/large/engi_upgrade
module_name = "Engineering Cyborg Emitter Upgrade"
mod_pick_name = "emitter"
description = "Downloads firmwear that activates the built in emitter in all enginering cyborgs linked to you. Cyborgs built after this upgrade will have it."
description = "Downloads firmwear that activates the built in emitter in all enginering cyborgs linked to you. Cyborgs built after this upgrade will have it pre-installed."
cost = 50 // IDK look into this
one_purchase = TRUE
upgrade = TRUE
unlock_text = "<span class='notice'>Firmwear downloaded. Bugs removed. Built in emitters operating at 73% efficency.</span>"
unlock_text = "<span class='notice'>Firmwear downloaded. Bugs removed. Built in emitters operating at 73% efficiency.</span>"
unlock_sound = 'sound/items/rped.ogg'
/datum/AI_Module/large/engi_upgrade/upgrade(mob/living/silicon/ai/AI)
@@ -174,11 +174,10 @@
R.uneq_all()
modules = list()
if(!malfhacked)
if(R.connected_ai)
for(var/I in R.connected_ai.purchased_modules)
if(istype(src, I))
malfhacked = TRUE
if(!malfhacked && R.connected_ai)
for(var/I in R.connected_ai.purchased_modules)
if(istype(src, I))
malfhacked = TRUE
// By this point these lists should only contain items. It's safe to use typeless loops here.
for(var/item in basic_modules)