Removes preference datum caching

code/controllers/subsystem/changelog.dm

@@ -54,9 +54,8 @@ SUBSYSTEM_DEF(changelog)
 /datum/controller/subsystem/changelog/proc/UpdatePlayerChangelogDate(client/C)
 	if(!ss_ready)
 		return // Only return here, we dont have to worry about a queue list because this will be called from ShowChangelog()
-	// Technically this is only for the date but we can also do the UI button at the same time
-	var/datum/preferences/P = GLOB.preferences_datums[C.ckey]
-	if(P.toggles & PREFTOGGLE_UI_DARKMODE)
+
+	if(C.prefs.toggles & PREFTOGGLE_UI_DARKMODE)
 		winset(C, "rpane.changelog", "background-color=#40628a;font-color=#ffffff;font-style=none")
 	else
 		winset(C, "rpane.changelog", "background-color=none;font-style=none")

code/modules/client/login_processing/10-load_preferences.dm

@@ -28,9 +28,4 @@
 	return query
 
 /datum/client_login_processor/load_preferences/process_result(datum/db_query/Q, client/C)
-	C.prefs = GLOB.preferences_datums[C.ckey]
-	if(!C.prefs)
-		C.prefs = new /datum/preferences(C, Q)
-		GLOB.preferences_datums[C.ckey] = C.prefs
-	else
-		C.prefs.parent = C
+	C.prefs = new /datum/preferences(C, Q)

code/modules/client/preference/preferences.dm

@@ -1,6 +1,3 @@
-GLOBAL_LIST_EMPTY(preferences_datums)
-GLOBAL_PROTECT(preferences_datums) // These feel like something that shouldnt be fucked with
-
 GLOBAL_LIST_INIT(special_role_times, list( //minimum age (in days) for accounts to play these roles
 	ROLE_PAI = 0,
 	ROLE_POSIBRAIN = 0,