* Switch a bunch of /obj/machinery from /New to /Initialize
This is an easy and uncontroversial batch.
No globs, no late init, and stuff.
* Move more machinery to Initialize
This time the ones dealing with GLOB vars,
as well as some simpler ones i missed previously.
* More tricky New -> Initialize migrations
* The last of machinery Initialize conversion
* fixups
* Newscaster armor fix
* styling
* Comment on armor handling
* Move newscaster armor definition back to datum
* farie82 review
* kill extra .=
Co-authored-by: Farie82 <farie82@users.noreply.github.com>
* farie's review part 2
Co-authored-by: Farie82 <farie82@users.noreply.github.com>
Co-authored-by: Farie82 <farie82@users.noreply.github.com>
* Converts Eye Augments to Cybernetic Eyes
* literally not used
* it helps when you properly include all the code
* flashlight eyes
* tweaks
* conflict resolution
* can't have two eyes
* order of operations matters here
* autosurgeon
* Refactors Mutations
* traits
* more work
* styling fix
* yet even more work
* oh hush
* almost there
* it continues yet further
* and that's genetics done
* and that's it folks
* last bit and golem fixup
* oof
* oops
* tweaks and fixes
* styling
* Rework of chav disability text replacement
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull request process. -->
## What Does This PR Do
Replaces individual replacetext() calls with one regex function and a list.
Adds more chav terms, updates disused terms.
Stops replacetext() changing terms in the middle of other words, now only changes whole words.
<!-- Include a small to medium description of what your PR changes. Document every changes or this may delay review or even discourage maintainers from merging your PR! -->
## Why It's Good For The Game
Little things like this add immersion and variety, so having a few extra changes at minimal performance cost helps.
Matches found in the middle of words no longer get replaced, so you don't end up looking like a tool by saying "com**mate**d" instead of "com**man**d"
Tidying up old code to include regex also makes the code easier to maintain.
<!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. -->
## Changelog
🆑
add: Added more chav words, innit.
del: Removed some old words.
tweak: Replaced many replacetext() calls with a single regex function, only changes whole words.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
* Update goon_disabilities.dm
* Stopped chavlinks being global
Moved the chavlinks list into the chav disability datum
* ACTUALLY stopped chavlinks being global
* Tidying
Im a moron and forgot to move my comment with the lst
* Incorporated farie82's suggestion
changed rep_test to replace_speech
* Tweaks to replacement list
Removed dupes, added more -ed words, redone "you" and "your"
* PR - Gender Update
Gives Gender three states instead of two. This allows clones of tri-gendered species to properly carry their genders over to new bodies (e.g. Greys, Drask, etc.).
Tristate Gender Set Proc
Tristate Gender Get Proc
Fixes where Binary State was needed.
* Update update_icons.dm
Yeah, let's _not_ have Genderless folks get inconsistently gendered body part sprites (e.g. head, groin, torso mismatch).
* Update dna2.dm
* Update dna2.dm
* Update organ_icon.dm
* Update update_icons.dm
* Update dna2_helpers.dm
* Update organ_icon.dm
Readability (spacing)
* Update dna_injector.dm
* Update dna2.dm
* Changes made per Affected's requests.
Changes made per Affected's feedback.
* Update dna2.dm
Got our heads too deep in using this just for DNA_UI_GENDERr - returning the Set and Get procs to 0, 1, 2 as per Affected's request.
While in there, noticed some housekeeping items:
- reorganized the ranges so they flow numerically now
- changed the ranges so they don't overlap (line 205 having been the worst)
- removed the "else" statement from line 222 since we're using ASSERTS. There shouldn't be a value outside the range of 0 to 2 for this.
* Basis
* Make most targeted spells use a click with radius instead of a list
* Fixes
* Selection code
* return ..()
* Auto targeting
* Forgot a comment change
* Merge issue fix
* Scan mind and Project mind now use vision to determine the naming
* Copy pasta mistake fix
* logic fix with name dupe prevention
* Refactor ala review
