* bring it back now y'all
* adds a bunch of other changes
* pretty much works at this point
* grep
* Fixes some bugs, still chasing some down
* Add observers to recursive mob check, ensuring they can see messages from their orbitted atom
* tidy some things up
* resolve
* remove unnecessary checks
* Address todos, minor cleanups
* oh dear
* initial testing
* Fix some vulnerabilities (oops)
* Fix some other bugs from testing
* ci fixes
* Add some contingencies against clicking things you shouldn't
* fix some noted bugs
* Add observe to admin jump, improve messaging
* add a few more fixes that should mostly address some runtimes
* oh this wasn't really great
* one last thing
* Fix suit inventory problem
* Remove merge artifact
* Add some missing parens
* Prevents you from observing other ghosts, and should fix the getting stuck outside of your body issue.
* we love testing
* adds to player panel
* Fix more bugs with observers getting stuck outside of their body
* cleans up player panel, verb offerings
* shit
* Update code/_onclick/hud/alert.dm
welp
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
* Fixes some targeting issues
* Fixes targeting on aobserve
* Fix some weird storage bugs
* clean up some doulbed up follow links
* Update code/modules/admin/player_panel.dm
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
* Adds some checks for ghost observe
* Remove mentor debug log
* ahhhhhhhhh that'll do it
* Cleans up some additional checks that were not quite what they should have been
* better logging, too
* mochi review
* one more thing
* Gets robot huds mostly working
* hopefully fix folks not getting observe
* Fix order of operations causing a runtime on qdeleting
* Remove some unnecessary stack traces
* Apply suggestions from code review
Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
* Fix bug with items in your inventory disappearing on changing HUD modes
* Fix some bugs with the observe verbs
* possibly fix nullspace issues
* funny review
* missed one
---------
Signed-off-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
* Globals work
* Double access works
* All other things
* Revert "All other things"
This reverts commit 6574442eb6.
* More changes that compile and work
* IT WORKS AAAAAA
* Changes even more .len to length()
* Apply suggestions from code review
* Update code/datums/mind.dm
* Update code/__HELPERS/sorts/InsertSort.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Update code/__HELPERS/sanitize_values.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
---------
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* give verb rework ; adds a hotkey for give
* moxian review
* Adds new alert sprite shown to item giver
* Converts offering item trait to a status effect to facilitate the new alert
* Update screen_alert.dmi
* Add a `/datum/proc/signal_qdel()` helper
To cut down on copy and paste. Fixed alert flash icon not having transparency.
* lewcc review
* farie review and other fixes
For some reason my alert flash sprite no longer had an empty frame at the end so it would reach the end of the animation and be a solid yellow outline instead of invisible.
Touched screen_alert.dmi to fix that.
* reverts the addition of the give hud icon, restores give verb
I realized that making a new hud icon button would require multiple hud icons for each hud theme (the red one, green one, white one, etc.). I'm not prepared to do that much work right now.
* Update code/modules/mob/living/carbon/give.dm
Co-authored-by: Farie82 <farie82@users.noreply.github.com>
Co-authored-by: Farie82 <farie82@users.noreply.github.com>
* Stuff
* Grammar reviewer review
Co-authored-by: Sean Williams <12197162+S34NW@users.noreply.github.com>
* Shuttle call HTML fix
And multiline announcements too, à la #15645.
The clean_input() was causing the message to be encoded twice, and only decoded once. Removing it still encodes the string.
* Loadout revert
Co-authored-by: Sean Williams <12197162+S34NW@users.noreply.github.com>
Create the SSghost_spawns subsystem which serves as the subsystem for polling candidates for a special role. On the outside it works the same as /proc/pollCandidates but unifies everything so that event mob candidacies are a consistent experience
Ported from TG: Object armors are no longer defined in (unique) lists but rather datums that can be cached depending on their armor values.
Add LAZYSET define to lazily initialize a list then assigning a key to a value
Add alldirs2 global which is the same as alldirs except diagonals go first
Optimize mob memory by making alerts list lazy
Optimize obj/machinery memory by making use_log and settagwhitelist lists lazy
Optimize atom memory by not creating hud_list list for all atoms
Optimize turf memory by not creating footstep_sounds list for all turfs
Clean up code where possible
