* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* IT WORKS UP UNTIL THIS POINT
* Consolidates SLOT_FLAG and SLOT_HUD into one
* Remove cover_both_ears
* SLOT_HUD to ITEM_SLOT
* Remove clothing_trait changes for the time being
* Remove accidental copy-paste
* Re-add no-slip var
* More failure to copy-paste correctly
* Leftover flag
* Combine left and right slot flags where possible
* UNGOOF MY DEFINES, PHAND IS NOT A THING
* Minor spacing changes
* Some more fixes from merge
* Seperates ITEM SLOT AMOUNT into two defines
* ON SECOND THOUGHT LETS NOT DO THAT.
* Addresses Contra's review
* Thank you GREP
* Rename ITEM_SLOT_FEET to ITEM_SLOT_SHOES
* Added a comment to the bitmasks in clothing defines
* Rename ITEM_SLOT_TIE to ITEM_SLOT_ACCESSORY
* These are for a seperate PR.
* Magboot fixes
* Requested changes
* Re-add accidental removal
* Wrong flags
* Update code/__DEFINES/clothing_defines.dm
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: Chap <erwin@lombok.demon.nl>
* Requested changes
* Merge fixes
* Fix double headset
* Fixes multiple accessories
---------
Signed-off-by: Chap <erwin@lombok.demon.nl>
Co-authored-by: Adrer <adrermail@gmail.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
* Globals work
* Double access works
* All other things
* Revert "All other things"
This reverts commit 6574442eb6.
* More changes that compile and work
* IT WORKS AAAAAA
* Changes even more .len to length()
* Apply suggestions from code review
* Update code/datums/mind.dm
* Update code/__HELPERS/sorts/InsertSort.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Update code/__HELPERS/sanitize_values.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
---------
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* CI
* undef
* hooooly crap
* yeah
* false by default
* fixes
* alright, there we go
* oops lmao
* lol, lmao even
* proper programming
* fix
* losin my mind
* oops
* yeah coloring
* WE LOVE MULTIPLE DEFINES (ive lost my sanity)
* Part 1
* Testing 1
* Revert "Testing 1"
This reverts commit fc06554b28.
* Part 1.1
* Part 2 - UI Style List
* Preferences lists
* Preferences lists - DONE
* More inputs
* MOOOOOORE
* UI style else
* Last ones
* Double name fix
* Pre-selected Search
* Return Pick Darkness
* Return Pick Darkness
* Missing users
* Some review changes
* Revert MULE lists
* I just hate MERGE CONFLICT label
* List window tweaks
* I think there it is
* why i am stopid
* Update tgui.bundle.js
* undo all of it
* flags
* back
* head/mask
* left
* right
* Cuffs
* other name changes
* ID and PDA
* idk about calling them SLOT_HUD now
* glasses, gloves, and shoes, oh my!
* the rest
* comment
* pain
* more progress
* progress continues
* more progress™️
* saving progress while I swap brances
* leg moving working for real, woo
* more saving as power goes out
* eeven more
* fix transfer
* More changes, closer to pr ready
* final stuff for night backup
* almost done™️
* almost done
* Final changes to get ready for posting
* Update code/modules/mob/living/simple_animal/hostile/megafauna/ancient_robot.dm
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
* new sprite
* Loot added (minus crusher loot)
* Apply suggestions from code review
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
* Defines, loot, and requested changes, oh my!
* Apply suggestions from code review
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
* sound, bluespace charge improvements, more text
* Update code/game/gamemodes/nuclear/pinpointer.dm
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
* WOOO CRUSHER ITEM
* don't code when dead tired kids
* Update code/modules/mob/living/simple_animal/hostile/megafauna/ancient_robot.dm
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
* Makes crusher loot work, reworks shield for mecha fauna
* Names it, lets it spawn, buffs it, should be ready.
* Adds better sprites.
* pick to rand
* Buff, prevent cheese.
* Merge conflict hook test
* double checking to see if I installed it or not, think I need to manual
* fixes the merge issue
* makes gibtonite not yeet the mechafauna as much.
* fixes hostile/hostile fuckup
* fix most beam issues
* extra qdel insurance but it should be good
* fixes chasm issues, beep on self destruct, extra bluspace charge
* Shrinks the kaboom.
* spelling + beam fix
* Apply suggestions from code review
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
* late_initialize, var names, and styling, oh my!
* attacl
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
* Initial defines
* more work
* icon
* more stuff
* UID not hard ref
* tidying
* overload go brrt
* le sound and dead cell
* delet gap
* initial chargepack stuff
* simplify
* oops
* yeet this
* placeholder sprites
* oops magic number
* the gun speaks!
* consolidation
* tweaking and tidying
* so long old gun
* icon purge
* reapplies placeholder
* 1 minute tracker, not two
* makes it use a pinpointer
* revert tiny map changes
* cease your tracking, fool
* oops
* soft refs
* charlie review
* projectile ref to firing obj, removes testing overrides
& cleans up signals
* some more UID null checks
* ICONS
* ICONS CONFLICT
* MORE ICONS
* makes it freaking work
* first pass fixes
* charlie review
* charlie review 2, variable boogaloo
* fixes holsters
* colours the overcharged shot
* and recolours tracker to be yellow to match charge
* yellow laser icon
* widen overcharge misfire %
* fixes unlinkable pinpointers
* fixes gun not speaking when tcomms setup is changed
* steel request
* no chargey
* loudening 2022
* steel part 1
* Apply suggestions from code review
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
* restores missing sprites
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
* Allows crew and operative nuclear pinpointers to point to their respective nukes
* Maybe hit a few more of them
* Removes true/false from active, fix henk question.
* SSSPEEEEEEEEEEEDprocess
* Steels requests
* Mode is 2 in some cases(thanks adv pinpointer), steels request
* REFACTORS PINPOINTERS AGAIN and henks stuff
* Fixes travis + runtimes
* Update code/game/gamemodes/nuclear/pinpointer.dm
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
* Henks requests
* Switches things up
* Apply suggestions from code review
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
* Fixes it, adds desc as per affecteds request
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
* Handlers converted, now to fix 3532 compile errors
* 3532 compile fixes later, got runtimes on startup
* Well the server loads now atleast
* Take 2
* Oops
Toastical