* Refactor /mob/unEquip.
* fix things found in testing
* more fixes from testing
* fix removal of hooded suits
* fix flayers inability to deploy swarmprod
* fix changeling blade activation
* unnecessary parens
* pass default unequip args to proc overrides
* fix belts being able to forceMove into full hands
* refactor: Movement cross/uncross implementation.
* wrong var name
* fix unit tests dropping PDAs into nowhere
* Add documentation.
* remove unused constants
* say which procs are off limits
* fix simpleanimal z change runtime
* helps not to leave merge conflicts
* kill me
* fix typecast
* fix projectile/table collision
* treadmills don't cause MC to crash anymore
* connect_loc is appropriate here
* fix windoors and teleporters
* fix bonfires and clarify docs
* fix proximity sensors
Tested with sensors in crates, sensors in modsuits
Tested new proximity component with firing projectiles at singularity
Tested new proximity component with portable flashes
Tested new proximity component with facehuggers
* lint
* fix: polarized access helper false positives
* Revert "fix: polarized access helper false positives"
This reverts commit 9814f98cf6.
* hopefully the right change for mindflayer steam
* Changes following cameras
* fix glass table collision
* appears to fix doorspam
* fix ore bags not picking up ore
* fix signatures of /Exited
* remove debug log
* remove duplicate signal registrar
* fix emptying bags into locations
* I don't trust these nested Move calls
* use connect_loc for upgraded resonator fields
* use moveToNullspace
* fix spiderweb crossing
* fix pass checking for windows from a tile off
* fix bluespace closet/transparency issues
* fix mechs not interacting with doors and probably other things
* fix debug
* fix telepete
* add some docs
* stop trying to shoehorn prox monitor into cards
* I should make sure things build
* kill override signal warning
* undef signal
* not many prox monitors survive going off like this
* small fixes to storage
* make moving wormholes respect signals
* use correct signals for pulse demon
* fix pulse heart too
* fix smoke signals
* may have fucked singulo projectile swerve
* fix singulo projectile arcing
* remove duplicate define
* just look at it
* hopefully last cleanups of incorrect signal usage
* fix squeaking
* may god have mercy on my soul
* Apply suggestions from code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* lewc review
* Apply suggestions from code review
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* burza review
* fix bad args for grenade assemblies
* Update code/__DEFINES/is_helpers.dm
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
---------
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <daan.lyklema@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* The start
* Getting a bit further
* Slight ammo casing update
* Istype helper and foam blockage
* Adds status effect
* Foam blockage and status effect fixes
* Autolathe ammo + stun
* aaaaaaaa
* Adds uplink item
* Actual slowdown
* Makes attacking a bit faster again
* Ammo increase to 12
* Sirryan review
* Adds sprites - almost working
* Lots of fixes + mineral doors
* Mineral doors don't open with foam
* I AM NOT A KING. I AM NOT A GOD. I AM LUNACY.
* THE SCOPE CREEP
* This was done in vi. No langserver. Send help.
* Progress
* Some issues fixed
* The code builds, but the maps dont
* CC builds, I doubt anything else does
* Do this now
* Safety
* The map compiles
* THE MAPPING HELL
* Airlock controllers dont work
* Fixed bombs
* AND THATS FIXED
* Phantom edit
* Restores LL I think
* The mapmerge hooks are actually retarded
* Fixes spawners
* Half working air control
* Picky
* Hyper efficient tank monitor
* Sanity
* Laying the framework
* Improved alert console
* Dont think this is actually done anywhere
* Metering
* ONE HUNDRED AND ~~EIGHTY~~ TWENTY SEVEN
* WE ARE READY FOR BOX TO BUILD
* One map done
* Well that was easy
* Another one
* I think this is done
* I should have removed this
* I would make a russian joke but <current event>
* Delta WIP
* Makes delta work
* Early review
* TM safeguard
* oops
* METAAAAAAAAAAAAAAAAAAAAAAAAA
* Fix#4213
* Trailing
* oh for piss sake
* Shutter fix
* Roundstart ATs can go away
* Review pass 1
* What could go wrong
* BOOM BOOM BOOM
* Not needed
* Fix seed vault
* Oops
* Review changes
* Get pants that match or else you gonna look silly yo
* Posters
* Fix other hud elements
* Rereviewed
* Update shotglass.dm
* Fix for new merged PRs
* Typo
* Coming across other stuff
* Update theblob.dm
* No takebacksies
* smh i forget to leave a comment
* Updated for the detgun and cards
* Should have rerun langserver again
* No longer plastic, more in scope
* Damn you bluespace
* Reverting turret logic, out of scope at this point
* Tweak that part
* Went over energy guns again, and fixed UI White's sprite sheet
* Welding masks, glasses, and JUSTICE
* Update portable_atmospherics.dm
* Cleaning up, clearing things up
* Review and suggestions
* Update valve.dm
* More tweaks
* Missing character
* Not distinct lightmasks, so they can be overlays
* Update generator.dm
* Add parameter so holodeck doesn't try to make a perfect copy
* Update unsorted.dm
* Spiders
* Better fix for spiders, fix vamps too
* Ghosts
* Update telekinesis.dm
* Cleaning up old procs
* It's set up to not copy datums... Unless they're in a list
* Donuts, duct tape, and detgun. D3VR coming to Early Access
* Update procs that interact with doors so they call update_state instead
* Forgot one spot, and actually might as well just force lock
* Cleaning up other things... Sigh, and kitty ears
* oops
* Getting used to how it works
* blinds
* Going back to the suit obscuring thing, so it doesn't update all the time
* Missed that from merging master
* I made this PR and forgot about it
* Fix runtimes in cards
* Make things a bit more unified
* Update update_icons.dm
* yarn, really?
* Update library_equipment.dm
* Update shieldgen.dm
* Every time Charlie merges something, I go back and see if I can improve things further
* what's this? more?
* Update misc_special.dm
* wow, paper
* Review
* More reviews
* To be sure, seems like being broken messed something sometimes
* Brought airlocks closer to how TG works to iron out some stuff
* Pizza and morgue
* Doesn't seem to hurt, tried with holodeck
* Revert "Doesn't seem to hurt, tried with holodeck"
This reverts commit 158529302b.
* Icon conflict
* Fix organ damage
* Don't ask how. Why. It's like that on prod too.
* Cutting down on things and updating from TG.
* More flexible. Just in case the thing you stuck it on didn't destroy.
* Hydro was one the things I touched earlier on, better rework it
* Reviews
* Cleaning up further, also bri'ish
* Undo a change I did, and switch over to a more recent implementation
* Update biogenerator.dm
* Rolling back to old airlocks, but with new duct taped note
* Functionally the same. I'd just rather not have the smoothing happen there
* Went over APCs again
* Fix welding helmet names in species files
* Update airlock.dm
* Update persistent_overlay.dm
* Oh, topic
* a new coat of paint
* no shooting teammates on spawn for 100 damage
* datumization part 1, makes DS more OP, spacing fix
* hnng still broken but better
* breaks stuff less 99%
* mostly tgui
* oops, removes left over things from testing
* seperate tgui
* undo changes to ERT file and ERT manager
* build TGUI, front end is working
* minor fix, still broken
* this hurts me
* few small changes
* please dont fail
* mind code runs, but it doesnt work
* logging good, tgui built, will finish later
* mind code hurts, tgui should deconflict
* part one of giving up on TGUI
* 3 days of debugging, 2 lines of errors fixed
* no more unneccessary spawners
* Revert "no more unneccessary spawners"
* wow it works
* tgui, deconflict please
* a little clean up
* little more cleanup
* Sirryan addressed pt1
* Oops should commit this before the next commit
* DS isnt an option in one click antag, nuke it
* oops forgot this one small bit
* wow, simple code works
* oops, forgot to address, doesnt fix headset
* ds headset was broken long ago
* removes testing implants
* addresses requests
* get addressed code, you will be good
* few code improvements
* address moxian
* Makes deathsquad naming consistent
* this comment is true again
* a little precaution to stop AFKs
* no nuke code? no problem
* bing bam boom, more addressing
* no more runtimes I think
* clarified a few things
* gloves now show again following #18190
* Update code/game/objects/items/weapons/explosives.dm
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
* okay I'm a bit stupid
* deathsquad jumpsuit desc update
* CI my beloved, have a fix
* deathsquad gets their proper icon
* Revert "deathsquad gets their proper icon"
This reverts commit a52519305b.
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
* Grammar and spelling fixes
Grammar and spelling fixes
* 'an addition', 'look yummy'
Fixes 'a new addition' to 'an addition', reverts 'looks yummy' to 'look yummy'
* Handlers converted, now to fix 3532 compile errors
* 3532 compile fixes later, got runtimes on startup
* Well the server loads now atleast
* Take 2
* Oops
Fixes more compile errors. Down to 65 now.
updates << into to_chat
Down to 60 errors, also starts to port the codex gigas and law 666 for cyborg devils.
Fixes more compile errors. Down to 41 now.
Replaces timers with spawns, and <<s with to_chats
40 compile errors.
Down to 34 compile errors.
whoops, actually down to 34 now.
Down to 25 compile errors.
Down to 15 compile errors, I'llprobably need some help at this point.
Woo! Down to 7 compile errors.
Ported over devil hud. Number of errors up to 19.
WOO! It compiles. It's completely untested, but it compiles.
Adds devils to traitor panel
Implements iron, silver and salt banes.
implements flashing lights bane
Selling your soul prevents cloning, and some other methods of revival.
Implements harvest bane
Merged and sorted icons/obj/bureaucracy.dmi
Adds toy codex gigas
Fixes compile errors, adds codex gigas sprite.
Lots of bug fixes. Contracts work, devil revival is more consistant, etc
Adds missing icons for flaming contracts, summon pitchfork, summon wealth, employment cabinet, and sintouch.
Converts DEEP LORE explanations from hell to inferno incorporated.
Banishes the compile errors.
Devils come from hell again.
replaces offer drink obligation with a much more lore appropriate devil's fiddle reference
Also fixes contract bashing brain damage chance.
Undoes some changes I accidentally did to example config files.
Fixes up a few remaining bugs.
Puts in the codex gigas and employment contract cabinets.
-- Lemon - I kinda skipped this one, I'll patch it back in later because
map conflicts are suffering incarnate
Solves the devil law problem in a REALLY hacky snowflake way.
Fixes a few methods in which a hellbound can be revived.
Devils respawn with a limited number of appropriate items, instead of COMPLETELY naked upon corpse destruction. Also adds lines to example config.
Updates devil laws to be less hacky.
Objective to sintouch x mortals now greentexts correctly.
Contracts no longer cause brain damage. I didn't realize it was lethal on this codebase. Oops.
Splits dust(visual_only) into dust() and dust_animation() procs
Fixes some defines.
Adds undef statements to improve compile times.
Fixes race changes from demonic form changes.
Fixes small runtime error. (Which somehow didn't break anything?)
Implements lots of small changes/corrections suggested by CrazyLemon64
I still need to test these changes, along with other potential issues he brought up.
Fixes harvest bane and power contracts. Also adds a few </span> tag enders.
Corrects some edge cases with revival contracts.
Fixes compile error.
Reverts unneccecary change to item/weapon/reagent_containers
Cleans up the code for readability.
Prevents cloning of hellbound individuals.
Latejoins now properly have employment contracts added to employment cabinets (provided they still exist)
Infernal contracts are no longer rendered unreadable by fire and alcohol.
All fireproof paper remains readable after being fireballed, not just infernal contracts. (Though infernal contracts are the only fireproof paper atm)
Fixes an edge case problem with cloning.
Adds is_revivable proc to mind.
Removes snowflake code involving preventing soulseller resurrection.
Indulges in the sin of sloth, and copies tg's lazy list macros
Proc calls that transform the user no longer go to a null target
Fixes devil UI, human regression will keep appearance, and adds danceoff
Devil's base forms no longer suffocate inside the devil
Fixes runtimes, gets stuff working
The arch devil can now blast down walls with their pitchfork
EXTERMINATE ALL SPIRITS
Activates devil clause in voice of god
Fawks Mcclood
Feature P A R I T Y
Fixes devil bugs from testing
- Does a death refactor to make sure that diabolical resurrection works
- Walls no longer leave girders when blasted by the devil
- Getting a new body gives you a rudimentary amount of equipment to work
with to get out of maintenance or whereever
Does all the icons in a single commit on their own because icon
conflicts suck
Starting point of extra devil rebalance/fixes
Ports devil friends
Also oops tramples all over Fethas' corpse PR that's still up I need
to take care of that one
Styling fixes
This is a merged port from /tg/station and Virgo on logging standards.
The diary has been replaced with GLOB.world_game_log, diaryofmeanpeople
is gone (because it wasn't actually used) and a whole bunch of logging
procs have been changed to optimize Splunk.
