this commit :
https://github.com/Baystation12/Baystation12/commit/ea1060ac339c4b4ef1692f446865926cf262dd68
added in machinery's attack_hand() proc, line 238
```
if(!allowed(user))
user << "\red Access Denied."
return 1
```
to almost all machinery including computers, since they call this proc via their attack_hand() procs.
allowed(user), see access.dm line 94, in turn only checks the user's hand and wear_id,
NOT the card inside the machine,
as different machines have different vars and systems handling how they can be accessed.
instead of fixing the underlying problem, eject card verbs were added like this one :
https://github.com/Baystation12/Baystation12/commit/30385c22371a4e47ac43eac2fc953f7f8854fad4
this PR reverts that nonsense machinery addition and adds the shuttle_control access check where it belongs.
Conflicts:
code/game/machinery/machinery.dm
The flist (file list) proc was being used multiple times for each client user logon, this now only occurs once when the server starts.
Hopefully this fixes the nanoui assets issue which occurs during peak usage.
Conflicts:
code/modules/nano/nanomanager.dm
a non-damaged drone has 35 health and 35 maxHealth.
in the current proc, that is shown as (( 35 +35)/(35*2))*100 = 100 % health
a drone at half its health has 17.5 health.
current proc : (( 17.5 +35)/(35*2))*100 = 75 % health
a dead drone has 0 health.
current proc : ( 0 +35)/(35*2))*100 = 50 % health
as i fixed this proc in the silicon parent proc, this can be removed.
a non-damaged cyborg has 200 health.
in the current proc, that is shown as (200+100)/2 = 150 % health
a dead borg has 0 health.
in the current proc, that is shown as (0+100)/2 = 50 % health
Conflicts:
code/modules/mob/living/silicon/silicon.dm
Also added cancellation buttons here and there.
Prevented an exploit, resulting in ability to issue same passes with different ID, even if it doesn't have those accesses.
Conflicts:
code/WorkInProgress/Chinsky/guestpass.dm
icons/obj/computer.dmi