Commit Graph

24998 Commits

Author SHA1 Message Date
S34N
667dd5d4ac 515 Compatibility (#19636)
* 515 compat

* double spaces

* Callback documentation, aa review

* spacing

* NAMEOF_STATIC

* big beta
2022-11-08 23:08:40 +00:00
AffectedArc07
ad0cbe4b1d Different day? Different map rotation rules. (#19159)
* Different day? Different rotation rules.

* Make this mergeable

* Tweaks

* Styling
2022-11-06 19:52:19 +00:00
warriorstar-orion
7867c51b52 Replace /proc/num2hex with a much faster macro. (#19600) 2022-11-06 13:11:32 +00:00
Farie82
118f5708da Ensures update_pipe_vision is called only when you switch pipenets. Fixes lag caused by ventcrawlers (#19620)
* Ensures update_pipe_vision is called only when you switch pipenets

* Comments baby
2022-11-06 12:25:55 +00:00
FloFluoro
332fc9193a Fixes description grammar in a few places (#19607)
* Fixes punctuation on clown box description

* Fixes grammar in a couple places
2022-11-06 10:43:20 +00:00
S34N
0f4157d31e Attempts to fix phantom bot path overlays (#19360)
* a

* more things

* two more cheeky spots
2022-11-06 10:26:29 +00:00
warriorstar-orion
9657be2527 Remove unticked 'ninja' module code. (#19612) 2022-11-05 17:22:00 +00:00
warriorstar-orion
274ef027dc Add required configuration for automated map merge script. (#19484)
* Update merge_driver script.

* Actually tick and compile new files.

* Improve marker description.
2022-11-05 15:58:35 +00:00
warriorstar-orion
4ace2d6c2b Implement map tests for catching common errors. (#19204)
* Implement map tests for catching common errors.

- Adds test runner:
	- to make it easier to track things across test types
	- for example to ensure a fully specified log can be emitted

- Adds map tile test type:
	- when writing a test, coders implement CheckTile, which is
	  handed a single turf
	- when the test runner runs these tests, it iterates over
	  all turfs in the specified z-level, and runs each test's
	  CheckTile on each turf in turn.

- Adds two sample map tile tests:
	- check to see if a pipe exists on the same tile as a scrubber
	  or vent
	- check to see if a tile contains two cables, each with a center
	  node

* Review #1:

- Replace nested loops over map tiles with `block`
- Remove check for valid turf in individual tests, I think it's safe to
  assume `block` will always return legit turfs
- Added proper duration tracking for old tests
- Gave log file an appropriate extension
- Actually use `Fail` for tests

* whoops

* add more tests suggested by @Vi3trice

* Add some more tests courtesy @Bm0n and @Vi3trice

* windows are okay in space as long as it's nearspace

* Add failure threshold to prevent excessive logging.

Once this threshold is reached, a test will stop being processed for
every tile.

Note that this applies to `log_world` and `text2file` equally when
logging large amounts of failures.

* Document each test.

* Remove unnecessary reboot

* Let all map tests run to completion in CI matrix.

* I know what alphabetical means
2022-11-05 15:32:17 +00:00
Vi3trice
2d4d65664a Split those out (#19280) 2022-11-05 13:46:44 +00:00
BiancaWilkson
7592bc64ce Power gloves deal stamina damage instead of weakening. (#19508)
* No more weaken + Better description

* Better attack log

* Now also throws people

* Lower cooldown on request

* Commit farie's review

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-11-05 13:45:37 +00:00
FloFluoro
923e4b933a Adds new lawset, "Pranksimov" (#19306)
* Adds new lawset, "Goofsimov"

* Goofsimov module now spawns at player's feet

* Module renamed to AsiFun

* Renamed... again!
2022-11-05 13:44:41 +00:00
Sirryan2002
df9fd05e0f fixes runtime (#19576) 2022-11-04 08:47:59 +01:00
AffectedArc07
21109f3be2 Improved antag fishing busting (#19542) 2022-11-03 18:05:43 +00:00
PacifistDalek
250dc8a818 add description and new icons for components (#19535) 2022-11-03 18:02:35 +00:00
Christasmurf
66e893ad2d Adds Suspicious Bomber Jacket (#19545)
* syndicatebomber

* armourmeup

* Update code/modules/clothing/suits/miscellaneous.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-11-03 18:01:31 +00:00
Coolrune206
e80ae1f95f Removes .357 Speed Loaders from Autolathe, replaces with .357 Ammo Boxes (#19553)
* revolvers are balanced now, right?

* decreases metal cost per bullet from 5000 to 4000

* converts bullets to a new ammo box

* shut up Marmite (makes the revolver unrecyclable)
2022-11-03 18:01:05 +00:00
warriorstar-orion
12c873d816 Fix human appearance randomness in spawners. (#19561) 2022-11-03 17:59:30 +00:00
GDN
dfbe11e345 Alien BlackBox tracking (#19582)
* Alien BlackBox tracking

* AA's suggestion

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2022-11-03 17:57:24 +00:00
Sirryan2002
852726d107 yuh (#19592) 2022-11-03 17:56:13 +00:00
warriorstar-orion
4a105f2c7e Delete more unused files. (#19588) 2022-11-03 17:41:38 +00:00
warriorstar-orion
4bb50665a8 Remove unused dead code for cargobonus event. (#19587) 2022-11-03 17:40:52 +00:00
FloFluoro
17a307c044 Fixes overlays on cmagged plant disks (#19539)
* Fixes overlays on cmagged plant disks

* Oops, this wasn't needed

* Early returns

* Returns
2022-11-03 09:42:35 -05:00
AzuleUtama
ac1517e8b3 Fixes human mobs still being able to vomit while dead (#19538)
* Jaunter no longer makes dead people vomit

* Vomit proc in carbon.dm now has a death check
2022-11-03 00:05:31 -05:00
S34N
ff0c628db6 fixes weird pipes (#19530) 2022-11-02 23:12:04 -05:00
Luc
c5bc28f41f Adds *crack, an audible emote that lets you crack your knuckles. (#19529)
* Adds knuckle cracking sfx

* Add cracks for IPCs too

* Matt code suggestions

* review 2

* Fix species limitations, add diona sfx
2022-11-02 23:00:46 -05:00
AffectedArc07
6662c48c69 Fixes PR announce test being huge (#19579) 2022-11-02 21:21:57 +01:00
Stokes52
39b5d3462d Adds new ERT laser carbine item and inhand sprites (#19512) 2022-11-02 21:10:45 +01:00
Stokes52
938f04d406 Add buttoned and unbuttoned sprites for trenchcoat (#19491) 2022-11-02 21:01:58 +01:00
LynxSolstice
1f6f48e99a Removes gibbing animation (#19492)
* Removes gibbing animation

* small fix
2022-11-02 20:47:03 +01:00
warriorstar-orion
85f4503d33 Refactor announcements. (#19459)
* Refactor announcements.

* Actually make this a unit test

* Dumb

* Remove unnecessary 'as text'

* Reviews:

- Make CSS class a recognizable word
- Flip the defaults for logging

Also:

- Style fixes (default null in fields)
- Fix emergency/crew-transfer shuttle announcement titles
2022-11-02 20:31:37 +01:00
ElorgRHG
e63526cfdd Paradise's soul removal part four and five: jumpsuits and caps resprite simple as (#19424)
* New jumpsuits

* ... and new softcaps

* New colors for jumpsuits

* New colors for onmob softcaps

* "New" softcap obj sprites

* Un-mirrors the N

* Swaps the green and lightgreen obj sprites around, oops

* Deconflict

* Tweaks obj sprites for softcaps a bit

* New softcaps for corgis
2022-11-02 20:26:39 +01:00
PacifistDalek
d5b261407e Adds Radial Menus to Cyborg Module and Sprite selection (#19234)
* 1

* expand radius

* added combat droid back, gotta test whether force_modules can let the ERT secborg in

* holy crap i think it might be ready

* Update code/modules/mob/living/silicon/robot/robot.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/silicon/robot/robot.dm

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>

* change initialise to initialize, and update the sec/combat radial icon's name to be more self-explanatory

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-11-02 20:21:22 +01:00
Vi3trice
599221a602 doh (#19566) 2022-11-02 14:22:04 +00:00
Luc
d00d53803f Require lying down for a surgery step to operate (#19570) 2022-11-01 21:33:32 +00:00
Coolrune206
447edfdf83 converts laser slugs to laser scatter shot (#19552) 2022-11-01 20:51:08 +01:00
AffectedArc07
aa327a4e32 Library update + Some 515 compat (#19556)
* Library update + 515 compat

* Lets not ship debug info, inflating the files 10x+

* CRLF -> LF
2022-11-01 20:47:12 +01:00
Nathan Winters
25f7b57fc5 Small Medbot patient analysis and injection refactor (#19353)
* Gee medbot! How come your mom lets you have 26 extra parentheses?

* Check order consistency

* Avoid searching through viruses if already treated for them

* Simplify assessment logic for custom beakers

* Simplify assessment logic for viruses

* Fix medbots not considering all of patient's viruses

* Bool readability

* Fix medbots ignoring viruses if patient has no damage

* Fix medbots not considering loaded beaker when assessing treatment for viruses

* Fix inconsistent virus check between assessment and medication logic

* Check order consistency 2.0

* Fix medbots getting confused when patient has regular drug but no beaker drugs

* Refactor patient assessment

* Condense a loaded beaker volume check

* Extract virus assessment into separate proc
2022-10-31 18:08:11 -05:00
Vi3trice
05d93f665a [TM] Port TG Jump Point Search and SSpathfinder (#18984)
* move along move along

* Update bot.dm

* Diagonals are now more expensive

* Update path.dm

* Update parrot.dm

* Update path.dm

* Tweaks

* Fix cleanbot, add path safety

* Tweaked, added a safety, removed the previous one

* Update medbot.dm

* path.len isn't very safe as a whole, floorbots also had order of operations wrong

* Update medbot.dm

* clings not even once

* Back to the drawing board

* Update path.dm

* Make mules actually clear the drawn path.

* Make bots use step_towards unconditionally instead of flipping between step_to and Move

* Making extra sure the path is cleared. Somehow path was left over.

* Check for length as get_path_to is always true

* This and that
2022-10-30 15:54:51 +00:00
FloFluoro
9e78880036 Fixes punctuation on mob descriptions (#19533) 2022-10-30 15:52:00 +00:00
Vi3trice
b12c751d48 It's getting confused with that macro (#19521) 2022-10-30 15:51:08 +00:00
Stokes52
7c303ea545 Add inhand sprites for retro laser, immolator, and their variants (#19509)
Co-authored-by: Christian Stokes <christian.stokes@liferay.com>
2022-10-30 15:50:04 +00:00
HMBGERDO
9f011740da Nerfs Cult Juggernaut. Removed reflection (#19461)
* Nerfs Cult Juggernaut. Removed reflection

* bringing back jugger armor without reflections

* comment and playstyle sting changed

* Update code/modules/mob/living/simple_animal/constructs.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2022-10-30 15:49:27 +00:00
Vi3trice
b7389e3c81 [GBP no update] PDAs only hold one pen at a time (#19516)
* You hold one pen only

* Update PDA.dm

* Update PDA.dm
2022-10-28 22:07:29 +02:00
Qwertytoforty
1902641665 makes CQC not theoretically heal losebreath (#19511)
* makes CQC not theoretically heal losebreath

* hal told me to
2022-10-28 20:27:19 +02:00
ElorgRHG
4b0a2fc085 [GBP: No update] Golem hands fix, probably (#19490)
* Golem hands fix, probably

* I think this is how that works, maybe
2022-10-28 20:24:20 +02:00
ElorgRHG
de9f949994 [GBP NO UPDATE] Restricts some jumpsuits from appearing with chameleon gear (#19472)
* Restricts some jumpsuits from appearing with chameleon gear

* This is not actually a basetype that shouldn't be seen in game
2022-10-28 20:21:21 +02:00
Henri215
473a46ff5a Tweaks to autolathe design costs (#19469)
* first wave of tweaks

* Update code/modules/power/cable.dm

Co-authored-by: Edan <29551695+Edan52@users.noreply.github.com>

* Edan52 review

* missed one

Co-authored-by: Edan <29551695+Edan52@users.noreply.github.com>
2022-10-28 20:05:46 +02:00
Vi3trice
03ce2920e1 Defining Part 4 - Code cleanup toward defines (... and the rest) (#19388)
* I wasn't done

* nits
2022-10-28 19:28:23 +02:00
Henri215
47b3d08f04 Newscasters/camera monitors/displays tweaks (#19305)
* frames and autolathe

* final adjustment

* engine monitor

* circuit board selection and newscaster tweaks

* names adjustments

* entertainment frame icon adjustment

* moving to another PR

* forgot to move those

* added the other monitors circuit boards

* Update code/game/machinery/computer/camera.dm

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* removed unnecessary flow

* display

* entertainment frame uses correct icon now

* merge conflcit part 2, do_build for newscasters

* moving var

* Sirryan suggestion and reverting piece of code removed by mistake

* Update code/game/machinery/computer/buildandrepair.dm

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* added description

* Apply suggestions from code review

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* Sirryan suggestion and removed 1

* moved to on_deconstruction

* Removing unused arguments

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
2022-10-28 19:00:03 +02:00