Commit Graph

363 Commits

Author SHA1 Message Date
Spookerton 978f4511a5 examine signature changed to include distance
- distance is INFINITE, 0, or a positive integer based on get_dist() between
the examiner and examinee's turfs when they are on the same Z. When the
examiner is dead or a ghost, distance is always 0.
- also updates /examine( implementations to use it!
- adds w_class_to_name proc for reusing "It is a X item." examine behavior.
2024-01-31 13:49:52 +00:00
MistakeNot4892 e272246877 Collapsing fireplace logic into bonfire. 2024-01-18 22:38:31 +11:00
spookerton 29be1f09d2 fix some misc hits on direct overlays access 2023-09-10 17:00:06 +01:00
MistakeNot4892 964e5b878a Generalized handle_movement() checking from shoes to /obj/item. 2023-07-23 06:47:13 +10:00
klorpa f445ffde0a Spelling Fixes (#8973)
* SpellingFixes

* OtherTypos

* OtherTypos
2023-04-08 21:39:28 -08:00
Seris02 75577bd3ca cleans up so many to_chats so they use vchat filters, unsorted chat filter for everything else (#9006)
* better filters for vchat, unsorted chat filter

* adds closing tags, fixes an error I somehow missed
2023-03-08 18:57:55 -08:00
MistakeNot4892 9a84667323 Reworks on-mob overlay icon generation. (#8920)
* Porting species equip_adjust from Neb.

* get_species() => get_species_name(), adds correct get_species() impl

* sprite_sheets is now crudely lazylisted.

* Adds returns to add_blood and add_accessories.

* apply_addblends now uses an overlay.

* Renames the various worn overlay procs to be more informative.

* Debugging/refining overlay gen.

* Adding handling for string icon paths.

* Refining/debugging offset overlay gen.

* Getting the offset system working.

* Commenting out Teshari offsets for the time being.
2023-02-15 18:22:42 -08:00
MistakeNot4892 9c5eca2449 Refactoring mines and simplying disarm. 2023-01-14 00:17:59 +11:00
spookerton 271d915dff re-sealing envelopes with stamps + style tweaks
Also adds item/proc/BlockInteraction. Carries out common or configurable
checks for whether a given interaction should be allowed to continue;
reduces boilerplate somewhat.

Also refactors stamps to make this possible. Stamps are now configured
with authority_name and authority_suffix rather than setting the stamp
name directly. This is so that envelope seals can be sealed by a `Sol
Government seal` rather than `Sol Government logo stamp seal`, or a
`clown seal` rather than a `clown's rubber stamp seal`. You get the idea.

Also partially refactors folders. Their attackby behavior was a sin.
2022-11-13 12:18:05 +00:00
MistakeNot4892 86a8fb4378 Cleans up the storage accessory attackby path and prevents double insertion of items into storage accessories. 2022-11-08 12:55:20 +11:00
spookerton bb472b4832 replace 0 for EMPTY_BITFIELD on atom_flags configs 2022-10-18 09:36:40 +01:00
Cerebulon 63bcc560c3 Removes Taurs 2022-09-28 03:17:48 +01:00
MistakeNot4892 dcbf10e28a Added grafadreka.
More work on drakes.

Added grafadreka den site.

Working on refining drake AI.

Fixing drake languages.
2022-08-14 01:26:09 +10:00
Atermonera 21bd8477c7 Merge pull request #8531 from Spookerton/spkrtn/sys/global-agenda
updates all bare globals to use /global/ semantics, and all shared members to /static/
2022-04-24 19:56:07 -08:00
spookerton beec187978 clean up odd list attribute order, add tests 2022-04-24 07:54:35 +01:00
spookerton 556331a6a3 use /global/ sugar for bare globals, no leading / 2022-04-24 07:54:34 +01:00
spookerton 1f3ffc2433 non-flagged, non-complex overlay -> ssoverlays 2022-04-24 07:51:12 +01:00
spookerton 1ccb2df2de trivial 1:1 overlays -> overlay proc changes
NB. In some cases we go from a more complex image() to a single icon_state string and I assume this works for every case but do not care to check because of the sheer scale of extra fiddly effort. Buyer beware, not my code.
2022-04-24 07:50:21 +01:00
atermonera 9d71839ac6 Removes devices 2022-04-17 19:14:43 -08:00
atermonera 7a9806d9b4 Removes weapons 2022-04-17 19:14:32 -08:00
Cerebulon 5f22d34b42 Reviews all POIs for loot/balance + adds random universal anomalies [MDB_IGNORE] (#8464)
* Reviews all PRs for loot/balance + adds random universal anomalies

* Include new file

* tgm formats for a couple of deconverted maps
2022-04-16 09:43:02 -08:00
spookerton 602cc67d2b removed CLAMP define 2022-03-31 19:21:58 +01:00
atermonera c7f1880394 Revert "What was supposed to be another straightforward major system overhaul that once again spiraled out of control (#8220)"
This reverts commit 4d8c43f106.
2022-03-29 16:01:32 -08:00
Atermonera 4d8c43f106 What was supposed to be another straightforward major system overhaul that once again spiraled out of control (#8220)
* get_tool_quality has numerical meaning

* Basic tools set tool quality

* Toolspeed is replaced by tool quality checks

* Addresses assorted results from live test

* Extra cleanup
2022-01-16 15:52:55 -08:00
MistakeNot4892 2f0a618d45 /atom New() => Initialize() [MDB IGNORE] (#8298)
* Find and replace argless atom New() to Initialize().

* Manual replacement of no-arg New() to Initialize().

* Manually replacing remaining New() overrides.

* Fixing linter issues with now-removed New() args.

* Tidying area init overrides.

* Porting Neb's atom subsystem.

* Trying to isolate init problems.

* Adjusting Init code post-test.

* Merging duplicate Initialize() procs.

* Merge resolution.
2021-11-14 00:09:14 -08:00
Atermonera 9c4eceae2b Removes suicide_act() 2021-09-19 11:43:34 -08:00
MistakeNot4892 c5e295041b Merge pull request #8252 from lbnesquik/Kot-material-costs
Expands the material values of certain items.
2021-09-03 12:19:29 +10:00
lbnesquik 0810f6d51a Converts things to different material names 2021-09-01 01:05:47 +02:00
lbnesquik 89ea1ac73f Reduces the volume of grabbing jumpsuits. 2021-08-28 01:48:54 +02:00
lbnesquik cdf395c883 Expands the material values of certain items. 2021-08-27 04:06:56 +02:00
MistakeNot4892 34127628ee Merge pull request #8240 from Cerebulon/vendthrow
Vending machine throwing tweaks
2021-08-26 11:45:05 +10:00
Cerebulon 6b73ba2fe1 Vending machine throwing tweaks 2021-08-23 18:30:39 +01:00
MistakeNot4892 4c53eda3b2 General wilderness updates; fixed frostbelle, adjusted scavenging, added some recipes and mushrooms.
Fixes for wilderness commit.
2021-08-17 18:54:37 +10:00
ShadowLarkens fd3f581656 Make item/attackby call ..(), multitool tool quality fix (#8145)
* Make item/attackby call ..(), multitool tool quality fix

* Just don't print item attack messages on attackby
2021-06-20 11:51:14 -09:00
Neerti fdabe51ee8 Linter Introduction + Cleanup (#8085)
* Adds linter defines to repo.

* Uncomments linter defines already in the code.

* Resolves unreachable code linter errors.

* Nukes decade+ old syndie specops code except for computer since that's mapped in?????

* Resolves procs has no parent linter error.

* Proc signature fixes

* Bad comments

* "In" danger

* Type safety

* Implied nested list abuse

* Top level ..() usage

* Sleepy coder typos

* Invalid kwargs calls

* Pointless returns

* Linter hacks (see full message)

Byond doesn't care and it has no effect but linter doesn't like var/proc
for holding references to procs, despite that it's valid byond code.

Also, the linter seems to have serious issues figuring out relative
proc names. This commit is a sort of take-it-or-leave-it thing. It's not
required, it just cuts down on warnings, but this code is valid DM code.

* WHATEVER THIS IS

* Trick dreamchecker linter into ignoring this file's sins in it's weird use of vars

* Fix list decoration syntax - Its a list, not list of lists

- To declare that a var is a list you can `var/list/blah = list()` syntax or the `var/blah[0]` syntax.  Both do exactly the same thing. But if you do `var/list/blah[0]` that is just like doing `var/list/list/blah = list()`

* Hopefully stops the ai holder subtype folder from going quantum and sometimes changes capitalization over time, and incidentally causing 20+ linter errors.

* Fixes unwrapped negated object in list linter error.

* Resolves colon-like list accessing linter error.

* Turns linter on in linter config.

* Fixes closet indentation properly and cleans up suit storage unit switch.

Co-authored-by: Aronai Sieyes <arokha@arokha.com>
Co-authored-by: Leshana <Leshana@users.noreply.github.com>
2021-05-25 18:17:26 -09:00
ShadowLarkens 0198ff3fbf Personal Crafting & Dependencies 2021-05-02 18:05:54 -07:00
MistakeNot4892 2b48ef76c8 Ported the Nebula emote system. 2021-03-27 10:24:14 +11:00
MistakeNot4892 373b71f98b GPS presentation/update tweaks/fixes. 2021-03-18 19:54:50 +11:00
MistakeNot4892 92c6bead11 Added recon and cargo platforms. 2021-03-13 13:24:28 +11:00
Atermonera 4fe327583c Space cleaner cleans mobs (#7802) 2021-01-03 15:19:20 -08:00
Hatterhat d695723e1b RPED QoL Tweak(s)/Unimplemented RPED Variant (#7784)
* this is incredibly scuffed

* this is a monumental W bossman

* parity with downstream

Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com>
2020-12-13 16:51:04 -08:00
Mechoid 576d0657ce Kaleidoscope 2: The Retabbening (#7697)
* Begins the Project

* Move things to where they belong, if viable.

* Merge and move those files.

* Finish filenames, fix Taj ears.

* Tweak to Ater's Requests

* The Great Mergening with 03_body.

* Per Requests

* Continue per request. Plot nefarious plans to make Saviks usable as battlemounts.

* Smarter Proc Use

* Tweaken
2020-11-19 10:04:09 -08:00
atermonera eadb08bf9f Revert "Kaleidoscope, Toolbox (#7608)"
This reverts commit a68014a9ae.
2020-09-26 11:57:34 -07:00
Mechoid a68014a9ae Kaleidoscope, Toolbox (#7608)
* Begins the Project

* Move things to where they belong, if viable.

* Merge and move those files.

* Finish filenames, fix Taj ears.

* Tweak to Ater's Requests
2020-09-21 09:10:09 -07:00
Cerebulon 0815a554c6 Tweaks to pickup/equip sounds. (#7651) 2020-09-20 03:56:41 -07:00
Rykka 0c7a7fd2b8 Massive Ambience and Sound Overhaul + Addition, Squashed Commit Edition 2020-08-21 06:53:05 -04:00
Meghan-Rossi 1d8a623972 Fix cyborgs not being able to cook
*Cyborgs can now put oven dishes in the oven with their grippers
*Cyborgs can now put things into oven dishes with their grippers
2020-08-17 04:31:18 +01:00
Greenjoe12345 ba2a49999a adds wrist PDAs 2020-06-17 00:24:54 +01:00
Atermonera 6ab622a2b5 Merge pull request #7205 from VOREStation/Arokha/playsound
Alter playsound paradigm
2020-05-28 16:05:59 -07:00
Atermonera 551fc88ce1 Merge pull request #7204 from VOREStation/Arokha/performance
Performance improvements
2020-05-28 12:47:08 -07:00