Former coder comments incorrectly called things "Rib opening surgery" when it referred to cutting&retracting a bone, which includes skull /and/ ribs.
Corrected the coder comments and also renames the steps to avoid confusion.
Instead of shoehorning the player into healing the most damaged type.
This mechanic was also poorly explained and I have people DMing me about "This surgery is bugged it won't let me heal XYZ" when it was actually just a old-code blocking you from healing the lesser damage.
With the new surgery, this is a thing of the past and can be safely removed.
- Renames 'cut ribs' to 'cut bone' as it should be, as that step is also used on the head.
- Gives people a heads up when they repair the brain from death, telling them they need to perform the spinal surgery as well.
Allows you to properly perform surgery on FBP without issues.
Having a tgui input be in can_use results in really weird stuff happening. Even before this PR, it'd give you a input menu, you'd cancel it, and it'd then go into the hemostat step when you obviously didn't want to do that.
This fixes that.
-Fixes the synth brain transplant rename prompt being a) broken, and b) having the capability to force a contaminated and unsanitized real_name var for the body, which in turn has the capability to kill regex and cause big issues.
In other words: an unnamed synth body wearing a person's ID gets their display name shown as "Unknown (as name)". The problematic part is that the brain transplant procedure here forces the new body to rename itself by the copied display name, AND also forces the real_name var into that without sanitizing. This causes the chat mention system to divide the unsanitized name into 3 names "Unknown", "(as", and "name)" and to shove these into regex to look for, and the rogue () in the names makes regex commit die and likely also break map loading and stuff.
This adds throw_alert() and /obj/screen/alert, a system that allows you
to do custom hud alerts for any variety of things from "You're too
cold!" to mecha status indicators for the pilot.
There's quite a few things that actually got replaced; the
fire/oxy/tox/co2 alerts are all now just alerts, as is nutrition. The
xenochimera feral indicator would probably be a good candidate for
conversion, but I didn't touch it in this PR. There's also a number of
new alerts, such as blindness, highness, legcuffed, buckled, handcuffed,
and probably some more I missed; read code/_onclick/hud/alert.dm and see
for yourself!
Additionally, a number of tweaks have been done to resisting code, to
make it so that there's an indicator when you're buckled or handcuffed,
and can just click the alert to start resisting. This includes a
refactor that combines the logic for lockers, holders, micros
escaping from shoes, and struggling in a gut all into one proc, called
container_resist(). This means that vore bellies actually no longer need
the resist override, but it's been left in place just in case someone
finds something else they want to use it for.
Also, the health and internals indicator got moved down one tile each.
Needed room for the alerts. If we add the oxygen tank action buttons
from /tg/ and remove the internals indicator, the health indicator can
go back where it was originally.
