Commit Graph

6481 Commits

Author SHA1 Message Date
Cameron Lennox
bbc50e3ea6 Artifact Tweaks (#17077)
* fixes a critical bug with artifact triggers

* Gets rid of gas activated anomalies

Feedback has been overwhelming negative for gas trigger anomalies, so they have been removed. (I expected this. See: My coder comments) but wanted to give it a chance since more xenoarch players were coming into the scene.

* Adds more anomaly batteries.

Adds them to the protolathe

* Some more xenoarch tweaks

- Makes scanpads and harvesters craftable
- Makes harvesters upgradable
- Fixes typo in the battery ID & desc
- Fixes harvester charge logic to NOT be garbage

* whoopsies

* clarification

* more effect->trigger fixes

this one didnt matter since both were 0 but still

* Better logic

* Obey gloves
2025-02-08 14:09:03 -05:00
Cameron Lennox
3ac6fb4edf Revert "new to init (the rest of them) part 1 (#17052)" (#17084)
This reverts commit d02c67d6de.
2025-02-07 11:09:08 -05:00
Kashargul
8c66f479f0 fix missing naming (#17082)
* fix missing naming

* .

* fix init order

* fix that

* init order

* -

* this needs  to go to init

* another readio

* fix turbolift init order
2025-02-07 10:55:28 -05:00
Kashargul
9f2969410d fix orebag signals (#17065) 2025-02-05 14:07:25 -05:00
Kashargul
3d9113eae3 removes center of mass list (#17064)
* removes center of mass list

* .

* .

* fix that icon

* .
2025-02-05 14:06:59 -05:00
Cameron Lennox
9bf650610b new to init (radios) (#17055)
* probably garbage code

it works tho

* remove debug

* radios

* true false

* true false 2

* catslugs late init
2025-02-05 14:05:53 -05:00
Cameron Lennox
d02c67d6de new to init (the rest of them) part 1 (#17052) 2025-02-05 14:05:41 -05:00
Cameron Lennox
91e6eb19b9 Augment Adjustments & Fixes (#17038)
* Fixes limb augments being borked for robotic limbs

* Fixes augment melee from embedding

* Makes a bunch of the augments actually CRAFTABLE

* typo
2025-02-05 13:57:01 -05:00
ShadowLarkens
da50eedefe Work on phasing out tgui collections.ts (#16987)
* Replace a bunch of sortBy with Array.sort()

* Fix styling

* a few less to go

* power monitor

* one less

* another one

* one less

* game prefs

* anyway this

* sort stackUI

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-02-03 04:14:14 -05:00
Cameron Lennox
db636e3306 Size Changing Apparel Adjusments & Runtime fixes (#17035)
* hyper jumpsuit & deluxe bluespace bracelet changes

* Update miscellaneous_vr.dm

* fixes a runtime

* typo

* projectile runtime fix and circuitboard del

---------

Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2025-02-02 17:09:47 +01:00
Kashargul
ae65523ffe camera monitors can be properly built with the board (#17039) 2025-02-02 17:07:09 +01:00
Kashargul
3770f05e11 better robot mining scanner (#17005)
* better robot mining scanner

* .
2025-02-01 14:24:41 -05:00
Kashargul
bbed406b2e remove old inputs (#17008) 2025-02-01 14:23:25 -05:00
Cameron Lennox
a6452d7541 Fixes bodybags and crew console (#16997)
* Fixes bodybags

Enables the bodybag label overlay as well

* Labeling stuff

* Fixes bodybags

Enables the bodybag label overlay as well

* crewfix by Kash

Fixed by Kash

* more crew fix

* This got swapped, somehow
2025-01-29 21:07:03 -05:00
Kashargul
394b2a4789 some destroy cleanup (#16958)
* some destroy cleanup

* fix inits

* deconf

* wrong PR

* rm duplicate

* fix that

* forgot that
2025-01-27 09:11:39 +10:00
Cameron Lennox
09b36a7ff6 Xenoarch Rework [Ready for Review] (#16757)
* WIP Xenoarch

* Removes the chompedits

* Makes field gen not required.

Genuinely, it was a relic and NOT fun at all to lug around this giant machinery that all it did was make it so you could actually GET the artifacts.

It added nothing to the experience and simply made it feel more clunky.

Previously, the field generator REQUIRED you to select what "generator field type" it needed, which was 'used in conjunction with analysis machines to determine correct suspension field type'...

Or, if you did what 99% of every xenoarch player did, you learned how to code dive or used the wiki ("Oh, metal composite = this field gen type").

Someone down the line realized this was a dumb idea and proceeded to axe the types.

Now, I axe the generator entirely. Still leaving this IN here in case someone DOES want to reenable it, but it just makes the whole xenoarch experience that much more worse in my opinion.

Especially when you get to deposits in awkward positions that are sandwiched between two walls, meaning you can't excavate AND use the suspension gen at the same time without choosing one of the tiles to break. Visual example below. X walls, x open space, O artifacts.
XXX
xOX
xOX
XXX

* Part 1

-Slashes a LOT of RNG from xenoarch spawns. No longer will you get 5 normal, mundane bowls in a row that all look the same. They're GUARANTEED to have coloration and various effects

- Adjusts a LOT of the RNG of xenoarch spawns.

- Remove shards (was just a glass shard...The most disappointing find you could get)

- Removes rods (See above)

- Removed Cutlery (See above)

- Increases chance for the vampiric statuette to spawn

- Makes the 'syringe' archeology find generate random 3 to 6 random chemicals that get stuffed into the syringe. (Using same blacklist as the xenoflora chem blacklist)

- Readjust spawned /material weights for items. These are ALIEN artifacts. It's boring to get your 20th 'alien wooden bat' of the day. Now it's COMPLETELY random. You might get a glass bat. Or a supermatter bat. Or a diamond bat. Who knows! (Has a blacklist that includes adminspawn materials or materials that would be  too strong/make little sense. No durasteel hull knives here!)

- Made things that just spawned "this weapon" spawn a subtype of "this weapon". Things like knives, handcuffs, 'flame' (includes matches now), tanks, and tools will also follow this logic.

- Adjust it so you can get an alien tool AND alien clothes

- Alien remains aren't just useless bones anymore, they spawn with a randomized plasma vessel and organ! Go ask medical to shove it in ya!
(TODO: Test that medical can ACTUALLY shove it in you)

- Removes the no fun 'Oops you accidentally dug too far, the artifact inside breaks!' when it comes to rocky debris because the game never tells you to dig 1 at a time.

- Expands the list of what the replenishing bowl can spawn with. Uses the xenobio plant chemical blacklist. (TODO: Add a  'blacklist' var on said chemicals, sometime)

- Makes it so ARCHAEO_REMAINS_HUMANOID can spawn a random organ.

- Makes it so the ARCHAEO_REMAINS_ROBOT spawns a lost drone pod.

- Makes it so guns are more randomized in xenoarch. They now tell you what bullet type they require
Additionally, they are now a subtype of bullet and can spawn with ANY /bullet. This makes the guns ACTUALLY really weird.
- Makes it so your xenoarch guns will always spawn with some bullets.

-Expands the alien clothes spawn to include the gluttony psy_crown.

- Makes the 'ARCHAEO_UNKNOWN' that was previous broken (and spawned nothing) spawn a rare research sample. (This is generally useless since the circuit printer exists and R&D can be speedran in 10 minutes, but whatever. If your xenoarch finds one in precursor or anomalous you'll be happy.)

- The plant fossil notes to give it to xenobotany and extract it.

- Gives the instrument spawn logic the same as everything else. Subtypes.

- Swaps the 'ARCHAEO_CULTBLADE' cultblade to a new archeology based cultblade. Has SPOOKY effects. (TODO!)

- Adds the library tome to the possible spawn pool for temple digsites (Useless unless you're an antag cult but SPOOKY

- Gets rid of 'digsite animal' as it was completely irrelevent due to bones not being able to put in the xenobio machine to give you animals. (This was a very VERY old feature. I can't even recall how many years ago)\

- Makes every xenoarch effect have its own individual tag.

- Makes it so the artifact analyzer actually gives you an idea of WHAT the artifact will do instead of saying "I dunno boss, go test it and accidentally blow medical up"

- Makes it so the artifact analyzer gives you an idea of how the artifact disperses it's effect, other than using weird super sciency-sounding terms and requiring you to code dive

- Reworks the vampire artifact spawns to make it so you're rewarded for interacting with it via spawning spooky cult-themed objects.
This makes it so there's actually a (small) incentive to experiment with it instead of just proccing it once and going "INTO THE BOX OF THINGS TO NEVER BE TOUCHED AGAIN"

- Better formatting for the anomaly analyzer. No longer will it be a MASSIVE wall of text, especially if it has multiple artifacts!

* Part 2: Guns and Weight

- Adjusts the large artifact find rates. Some things (like the supermatter shard, which could just instakill the xenoarch and the crystal which was useless)  were too high, while some (like the construct shell) were too low and would NEVER really be seen. (I've done xenoarch for years now and have only seen ONE construct shell.

Previous drop rates:
Total Wt In Pool: 1590
5 wt: 0.31%
25 wt: 1.5%
100 wt: 6.2%
150 wt: 9.4%
1000 wt (artifact): 62.8%

New wt:
	// Our total is 560 (As of the time of writing. If ANY of the weights are adjusted above, you have to recalculate. Formula: (thingy_wt/total_wt)*100 = % chance of drop)
	// Artifact: 53%
	// 50 wt: 8.9%
	// 25 wt: 4.4%
	// 5 wt: 0.89%

- Adjusts the archeology gun logic. Makes it actually functional AND makes it so you can't remove the fancy bullets out of it.
- Adjusts the archeology calibers to ones that can be obtained.
- Adds a note to the archeology gun when examined that it requires ONE bullet at a time. No speedloading these alien guns!
- Makes it so the archeology gun has the proper special HUD state depending on what bullet type is loaded.
- Fixes a few runtimes pertaining to secondary items

- ADDS A DEBUG SPAWN VERB SO I CAN TEST ALL THIS. THIS NEEDS TO BE REMOVED PRIOR TO MERGE.

- Fixes an unintentional = vs == in archeo_melee.dm. It's not completed yet and is in an EARLY wip stage but might as well fix it sooner than later.

* Added an extra failsafe last second and forgot to tab it

* angy

* Energy guns

- Makes xenoarch laser gun follow the same logic as the xenoarch projectile gun, but SOMEWHAT stricter. (Not using projectile/energy for example. Beams, ion, animate, and floramut rays only!)
- Removes the '5% explode on use' chance

* Update find_spawning.dm

- Fixes a few runtimes with material display names. Some didn't have any and would runtime.
- Adjusts and expands the list of the source_material if we don't have a specific material display name. It's supposed to be alien artifacts, so unearthing a ring made of pure meitnerium or a bowl composed of roentgenium is COMPLETELY in the realm of possibility.

* More spawn logic

- Makes material stuffs spawn properly
- Makes the robot pod spawn properly
- Makes the cursedform stop spawning (It served its purpose of confirming stuff worked)
- Makes rings have different materials (https://i.imgur.com/T9OzU4p.png)
- Makes gasmask able to spawn as either a poltergeist or a voice type.
- Makes the banned materials a list in the proc only once instead of multiple times. (Cuts down on copy paste errors and makes it easier to add to. Could honestly make it a global list but eh.)
- Makes the new_item_mat default to steel correctly.
- Allows for secondary items to have different names and desriptions.

* More Small Artifact Adjustments

- Gives the artifact blade a proper decription
- Makes the vampiric statuette no longer RNG.
- Makes the occult clothing spawn in sets instead of mix&matched
- Makes the research sample (ARCHAEO_UNKNOWN) spawn properly.
- Fixes the syringe from having too much volume and not having the sprites. It's limited to 15u now, but spawns with 5 chems now, 3u each.
- Fixes the alien clothes from having the same name as the alien tool
- Makes it so boats spawn properly.

This is ALL the small artifacts taken care of, fixed, and having additional fluff added to them.

Next, I need to adjust the large artifacts, add feature to the artifact sword, rework the vampiric statue, and see about touching up the other xenoarch code

* Shock Maul Adjustment

- Makes the shock maul's description of breaking rocks different. Plays a different sound as well

* whoops quotes

* More adjustments!

- Vampiric statuette has a hint/warning of how to activate it in it's description

- Makes shadow wrights NOT sit in nullspace 5ever after activating
- Makes shadow wrights give you some fluff text instead of just randomly KOing you.
- Makes the vampiric statuette follow the same spawn logic as the vampiric large artifact

* More sword stuff

- Adds 'ispassive' typecheck helper
- Makes the artifact blade's origin tech 6/6/6 because funny
- Makes it so the cult sword only starts processing when it's first touched.
- Makes cult sword stop processing when the user dies or stops existing.
- Adds some more features

* More relic sword stuff

More artifact blade works.
- Various blade fixes

- Makes it so it can 'consecrate' SIMULATED turf, SIMULATED walls, and  girders.

- Also adjusts 0 & 1 for grille destruction & bullet passthrough to false/true while I was in there

* Purge is lame get rid of it

* mixup

* Finishes artifact sword

Makes it so if you use it and destroy it, it gets VERY upset
Makes it so the artifact sword is a way for archeology to - slowly - exchange health and time in exchange for artifacts

* Verifies all artifact effects works, fixes some

- Makes the xenoarch anomaly harvester ACTUALLY work
- This has a BUNCH of features but I'll have to detail them out better once the PR is ready for review
- Fixes a bug where rarely, "datum/artifact_effect/extreme" would get selected and do nothing.
- Fixes a server-crashing bug.
- Makes all the artifacts compatible with the artifact harvester
- Moves 'being_used' from the artifact to /obj
- Makes gas artifacts not 100% useless.
- Makes some more adjustments to the artifact sword

* small rewrite

* lightning and culstist check fixes

* iscultist

* More small adjustments

* Organization

Organizes all the atmos affecting artifacts into one folder

* Condenses artifacts

- Condenses a LOT of the artifacts down and gets rid of duplicates.

* Updates dme for new artifacts

* switch

* Type  Changes

- Adds wrench to xenoarch supply pack
- Changes istype to ishuman, isrobot, ismob where applicable

screech

* Changes <b> to span_bold

In applicable places

* Adds Power Generator artifact

- Adds power generator artifact
- Adds some sounds from Goonstation to go along with the new artifact
- Makes it so animate_shake is a proc on /obj instead of just /closet
- Makes it so you can activate artifacts with gloves on, but you won't accidentally touch them if you have gloves on.

* More edits

* Procedural gen. Rock adjustment. Drill buffs

- Speeds up excavation drill (It made no sense it  was a downgrade in speed)
- Makes it so  when going to change the depth, it defaults to whatever it's currently set to
- Makes excavation drill able to go up to 60cm
- Makes xenoarch lockers start with excavation drill
- Changes loot pile prob2 from excavation pack to excavationdrill
- Makes it so mining vendor also sells the excavation kit
- Gives miners a basic anomaly scanner (but NOT the anomaly locator) to allow miners to do basic archeology if they stumble across a rock and want to excavate it but can't actively search and locate artifacts that archeology might be going for.
- Makes archeologist's anomaly scanner able to do continual artifact searching and generation. No more will you 'run out' of artifacts halfway through a round and have nothing to do anymore. This only occurs when all large (or small) artifacts have been completely depleted on a Z level.
- Makes it so boulders no longer randomly spawn when miners are mining, even when no artifact was there.
- Makes anomaly scanner do procedural generation to keep giving further ability to mine.
- Makes it so strange rocks can be mined with any /pickaxe, as small picks (the excavation pickset) was destroying them

* Gets rid of clearance

- Gets rid of clearance range. It was confusing and not helpful in the slightest for players.

* Gets rid of unused variables

* Removes unused vars from the tsx as well

Wanted to test to make sure it'd work first

* More bugfixes

- Fixes excavation drill text
- Fixes runtime with responsive reagent
- Makes temperature artifact show up properly to the scanner
- Fixes a typo with the atmospheric effect name
- Adds some spaces to effect.dm to make the artifact analyzer effect show up properly.
- Removes a few invisible sprite organs from spawning

* Untick

* Adds a cooldown and sanity check

- Adds a cooldown to the procedural generation of the ano scanner.
- Makes the debug ability a proc on /mob so that admins can call it to spawn artifacts.
- Adds a sanity check since it's now a proc that can be called.
2025-01-27 07:15:58 +10:00
Kashargul
c0e339b1ea ports tgui color input from bubbers (#16934)
* ports tgui color input from monkeystation

* .

* push that real quick

* .

* .

* cleanup

* fix for 516

* port bubbers pre set selection

* also this

* allow 20 saved states

* oups

* regex replace

* urg

* use the update by type

* .

* .

* highlight?

* larger?

* fix those

* keep anyone below 516 on old style
2025-01-21 18:27:45 -05:00
Kashargul
7266c4c5dc more missing tags (#16937)
* more missing tags

* only some books have...

* .

* some more

* Update admin.dm

* finish it up
2025-01-21 18:27:01 -05:00
Killian
d7c77e2342 Update shock_maul.dm (#16925) 2025-01-21 16:09:45 -05:00
SatinIsle
e5e589b4e6 Cable leash crafting (#16912)
Added a craftable variant of the leash, made from a stack of cable coils (at least cables in it).
2025-01-16 16:13:47 -05:00
Cameron Lennox
49bae6a3c1 Merge pull request #16889 from Kashargul/droppingPartTwo
properly forwards the user on dropped
2025-01-14 15:39:18 -05:00
Cameron Lennox
1b976ddc41 Merge pull request #16861 from Drulikar/fix_minimap_renderer
Nanomap Rendering Fixes & Linting
2025-01-14 15:01:08 -05:00
Kashargul
fee5b21783 Update bags.dm 2025-01-13 02:01:36 +01:00
Kashargul
f9769061b1 prevent sheet snatcher overflow 2025-01-13 01:53:19 +01:00
Kashargul
e21e3d25c9 properly forwards the user on dropped 2025-01-12 16:46:37 +01:00
Drulikar
4d0c9f9a98 Merge remote-tracking branch 'upstream/master' into fix_minimap_renderer 2025-01-11 23:45:05 -06:00
Cameron Lennox
5ce956e4f0 Merge pull request #16858 from Kashargul/dropped
some dropped sanity
2025-01-11 15:20:45 -05:00
Cameron Lennox
5c85b6744b Merge pull request #16848 from Kashargul/stop-double-logging
cleans up some logging
2025-01-11 15:20:07 -05:00
ShadowLarkens
2da235c4a7 Fluff item for Beeholddrbeesphb/Evelynn (#16859) 2025-01-08 15:23:55 +01:00
Kashargul
e6062e6210 cleanup 2025-01-07 21:54:58 +01:00
Drulikar
ff70da0895 Moar! 2025-01-07 07:01:43 -06:00
Drulikar
ac8f3d5dd0 Fixes 2025-01-07 06:52:06 -06:00
Kashargul
dedfeffe4b . 2025-01-06 21:26:40 +01:00
Kashargul
d9fc7dac70 should call parent 2025-01-06 21:25:36 +01:00
Kashargul
0436afea65 some dropped sanity 2025-01-06 21:14:40 +01:00
Kashargul
b26f91600b clean them up 2025-01-06 02:29:25 +01:00
Kashargul
59b9802628 some istype to macros (#16826) 2025-01-06 06:45:02 +10:00
Kashargul
612fadc5c6 diff up port leashes (#16813) 2025-01-06 06:44:02 +10:00
Aroliacue
c556381b57 Improved/Buildable Fighter Exosuits (#16797)
* Improved/Buildable Fighter Exosuits

* Improved/Buildable Fighter Exosuits

* oops

* href

* href 2

---------

Co-authored-by: Aroliacue <avaylaiss34@gmail.com>
2025-01-06 06:43:20 +10:00
Kashargul
55d0b57b76 creating areas registers them with the grav gen (#16833)
* creating areas registers them with the grav gen

* .
2025-01-05 11:55:21 +01:00
Kashargul
ed54afbbf0 fix an issue with multi borg module registering (#16835)
* fix an issue with multi borg module registers

* fix that

* bad feeling
2025-01-05 11:54:41 +01:00
Selis
ee8fe38a8a Enables SHOULD_CALL_PARENT for datum Destroy proc (#16828) 2025-01-05 00:28:58 +01:00
Kashargul
df9b71e402 Adds SHOULD_CALL_PARENT to examine (#16822)
* Another one I'm curious about

* those don't

* this should call parent

* beds need to be fully moved due to fantasy gateway

* fix that

* finish beds
2025-01-03 08:27:02 +01:00
Kashargul
3094e65b71 intent cleanup (#16825) 2025-01-03 08:14:28 +01:00
Kashargul
987be6070d bunch of inits without return and a few easy new to init (#16815)
* bunch of inits withou return

* Update cans.dm

* bunch of New to Init

* fix that

* .

* .

* move black hole to init and callbacks

* .

* oups, should not do that late at night

* some more without returns
2025-01-02 18:31:38 +01:00
Kashargul
e6ef8b0f2c resize limits and designer / dna update (#16807)
* resize limits and designer / dna update

* .

* genes to mobs

* .

* Update designer.dm

* Update designer.dm

* species cleanup
2025-01-01 18:23:20 +10:00
Cameron Lennox
f82d1dcffa Borg Icon Optimization and Weapon Modulation (#16705)
* Streamlines borg icon generation

Cross-port of https://github.com/TS-Rogue-Star/Rogue-Star/pull/708
Makes borgs not super super wonky with icon generation
https://i.imgur.com/qp8K2tD.gif

* Virgo Specific

* Makes borgs use flags

Instead of the copy-paste gore that was EVERYWHERE

* Makes it a list. ADDS WARNINGS.

* I don't know hexi!!!

* Sit!

* Changes them to the new paths

* Makes cyborg guns modular

* whoops i forgot a word

* Makes dogborg melee modularized

Makes it so you can have a generic 'melee' sprite and a 'dagger' sprite.

* blade

Downstream compat

* Moves it to a nicer check loop
2024-12-18 20:25:59 +10:00
Guti
bc06935aa0 Virology Fixes 6 (#16715)
* Fixes

* Fix

* BS Sneeze
2024-12-16 14:46:05 +10:00
Kashargul
0825558430 enable define sanity (#16707)
* enable define sanity

* .

* .

* fix unicode

* fix broken unicode

* more

* .

* even more

* more

* more

* .

* .

* .

* .

* .

* .

* eh not sure if we even have over 1000

* defines

* -

* .

* uranium
2024-12-16 14:44:03 +10:00
ShadowLarkens
5a47c9b8a1 Check for 516 byond:// hrefs (#16359)
* Add a lint to check for hrefs that don't start with byond://

* Regex convert href links

* Regex convert _src_ as well

* Clean up the last few

* Missed a few
2024-12-11 08:33:17 +10:00