cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-07-15 18:12:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary SessionConfiguration from WindowByondInstaller`

Browse Source
This commit is contained in:
Jordan Dominion
2023-07-04 17:56:28 -04:00
parent 4eb19e7263
commit f2d70f7aa2
3 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Tgstation.Server.Host/Components/Byond/WindowsByondInstaller.cs
-8
View File
@@ -70,11 +70,6 @@ namespace Tgstation.Server.Host.Components.Byond
/// </summary>
readonly GeneralConfiguration generalConfiguration;
/// <summary>
/// The <see cref="SessionConfiguration"/> for the <see cref="WindowsByondInstaller"/>.
/// </summary>
readonly SessionConfiguration sessionConfiguration;
/// <summary>
/// The <see cref="SemaphoreSlim"/> for the <see cref="WindowsByondInstaller"/>.
/// </summary>
@@ -90,7 +85,6 @@ namespace Tgstation.Server.Host.Components.Byond
/// </summary>
/// <param name="processExecutor">The value of <see cref="processExecutor"/>.</param>
/// <param name="generalConfigurationOptions">The <see cref="IOptions{TOptions}"/> containing the value of <see cref="generalConfiguration"/>.</param>
/// <param name="sessionConfigurationOptions">The <see cref="IOptions{TOptions}"/> containing the value of <see cref="sessionConfiguration"/>.</param>
/// <param name="ioManager">The <see cref="IIOManager"/> for the <see cref="ByondInstallerBase"/>.</param>
/// <param name="fileDownloader">The <see cref="IFileDownloader"/> for the <see cref="ByondInstallerBase"/>.</param>
/// <param name="logger">The <see cref="ILogger"/> for the <see cref="ByondInstallerBase"/>.</param>
@@ -99,13 +93,11 @@ namespace Tgstation.Server.Host.Components.Byond
IIOManager ioManager,
IFileDownloader fileDownloader,
IOptions<GeneralConfiguration> generalConfigurationOptions,
IOptions<SessionConfiguration> sessionConfigurationOptions,
ILogger<WindowsByondInstaller> logger)
: base(ioManager, fileDownloader, logger)
{
this.processExecutor = processExecutor ?? throw new ArgumentNullException(nameof(processExecutor));
generalConfiguration = generalConfigurationOptions?.Value ?? throw new ArgumentNullException(nameof(generalConfigurationOptions));
sessionConfiguration = sessionConfigurationOptions?.Value ?? throw new ArgumentNullException(nameof(sessionConfigurationOptions));
var documentsDirectory = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
if (String.IsNullOrWhiteSpace(documentsDirectory))
tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs
-1
View File
@@ -169,7 +169,6 @@ namespace Tgstation.Server.Tests.Live.Instance
Mock.Of<IIOManager>(),
fileDownloader,
generalConfigOptionsMock.Object,
sessionConfigOptionsMock.Object,
Mock.Of<ILogger<WindowsByondInstaller>>())
: new PosixByondInstaller(
Mock.Of<IPostWriteHandler>(),
tests/Tgstation.Server.Tests/TestVersions.cs
-2
View File
@@ -115,7 +115,6 @@ namespace Tgstation.Server.Tests
Mock.Of<IIOManager>(),
new CachingFileDownloader(Mock.Of<ILogger<CachingFileDownloader>>()),
mockGeneralConfigurationOptions.Object,
mockSessionConfigurationOptions.Object,
Mock.Of<ILogger<WindowsByondInstaller>>());
const string ArchiveEntryPath = "byond/bin/dd.exe";
@@ -170,7 +169,6 @@ namespace Tgstation.Server.Tests
Mock.Of<IIOManager>(),
fileDownloader,
mockGeneralConfigurationOptions.Object,
mockSessionConfigurationOptions.Object,
loggerFactory.CreateLogger<WindowsByondInstaller>())
: new PosixByondInstaller(
Mock.Of<IPostWriteHandler>(),