Revert "Fixes DoS vulnerability" (#2240)

This commit is contained in:
kevinz000
2017-08-03 05:59:30 -07:00
committed by GitHub
parent dd22c79678
commit e6b07f5e96
+1 -8
View File
@@ -2,9 +2,6 @@
For the main html chat area
*********************************/
#define BICON_X_MAX 96
#define BICON_Y_MAX 96
//Precaching a bunch of shit
GLOBAL_DATUM_INIT(iconCache, /savefile, new("data/iconCache.sav")) //Cache of icons for the browser output
@@ -191,10 +188,6 @@ GLOBAL_LIST_EMPTY(bicon_cache)
/proc/icon2base64(icon/icon, iconKey = "misc")
if (!isicon(icon))
return FALSE
//DOS exploit
if(icon.Width() > BICON_X_MAX || icon.Length() > BICON_Y_MAX)
return FALSE
//
GLOB.iconCache[iconKey] << icon
var/iconData = GLOB.iconCache.ExportText(iconKey)
var/list/partial = splittext(iconData, "{")
@@ -293,4 +286,4 @@ GLOBAL_LIST_EMPTY(bicon_cache)
return M.current.client
/datum/log //exists purely to capture to_chat() output
var/log = ""
var/log = ""