The last time the Light Sensitivity code was changed, I remarked in a
review that "This should probably be a component so that its code isn't
being run on every mob forever". Well I've gotten around to doing that
myself, except I figured out it's even better off as an Element in this
situation rather than a Component. So this is now my first time adding
Elements to the repo. It turns out they're really awesome when paired
with signals.
This PR removes the hardcoded check for the light senstivity and dark
phobia traits from the Life() path, replacing them instead with two
Elements which hook into the pre-existing signal used to handle vision
updates for human mobs. I've mainly done this to help cut down on the
overwhelmingly high cost of the Life() codepath, which is currently one
of the most expensive paths we have.
While I was at it with refactoring these two, I noticed that there
wasn't a trait selection for either of them, so I added selections for
both traits to the disabilities tab so that players can opt-in to being
light sensitive or afraid of the dark!
<img width="318" height="336" alt="image"
src="https://github.com/user-attachments/assets/a1e60e83-d899-44df-8ea3-0cd5a87c231c"
/>
**Summary**
Converts hardsuit NanoUI to TGUI and overhauls much of the associated UI
and module code.
The conversion alone is what necessitated quite a bit of cleanup of our
11-year-old hardsuit code, for which I leaned heavily upon tg's
implementation of MODsuits. Therefore, this is a PARTIAL (???) port of
both https://github.com/tgstation/tgstation/pull/59109 and
https://github.com/tgstation/tgstation/pull/77022. While a lot of
wonderful code and UI design was ported 1:1 (for which I am grateful!),
our hardsuits are still NOT MODsuits. Most of our back-end remains the
same.
Fixes https://github.com/Aurorastation/Aurora.3/issues/22071
changes:
- refactor: "Migrates Hardsuit NanoUI to TGUI."
- refactor: "Updates Hardsuit module type definitions, configuration
data, many misc other functions for the purpose of the UI refactor
(general utility and readability improvements)."
- balance: "Hardsuits now passively consume a small amount of energy
while online, even when retracted."
- balance: "Hardsuit boots can no longer be retracted without also
retracting the chest piece first."
- balance: "Mounted hardsuit storage module max space increased from 9
to 14."
- balance: "Plasma cutter (standalone and mounted) damage increased and
range decreased by 50% each."
- soundadd: "Adds several new sounds for hardsuit use (attribution
located w/ files)."
- code_imp: "Makes power_wattage_readable() a global proc and adds
power_joules_readable()."
- code_imp: "Lots of misc DMdoc updates."
- bugfix: "Synthetic Charging Stations now charge hardsuit power cells
as intended."
**Old UI**
<img width="804" height="1321" alt="Screenshot 2026-05-04 135705"
src="https://github.com/user-attachments/assets/f01957a0-7cec-4fcc-b862-c9dfde0dcc43"
/>
**New UI**
<img width="998" height="782" alt="Screenshot 2026-05-04 174658"
src="https://github.com/user-attachments/assets/ad402902-d489-435a-9c16-82150ed82618"
/>
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
| Path | Original Author | License |
| --- | --- | --- |
| icons/mob/rig_modules.dmi (mounted-plasmacutter)|
[Ghostsheet](https://github.com/ghostsheet) | CC-BY-SA |
---------
Signed-off-by: Batrachophreno <Batrochophreno@gmail.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Moves all HUD screen object icon files from various scattered locations
to icons/hud. No changes made to any icon_states in this PR, no
player-facing changes. Part of larger icon organization work and in
preparation for action button rework.
Fix for a hard del caused by overmap projectiles failing to clear their
walk cycle and timers consistently. This hard delete is relatively rare,
except in any kind of event involving ship combat....
Changes the message that appears when you respawn - given an update ot
the rules, it was slightly out of date.
---------
Signed-off-by: Fyni <itsfyni@gmail.com>
Regression from BYOND versions <=515 because find/refresh was always
enabled on browser windows even when it wasn't supposed to be.
Enable find (Ctrl+F) and refresh (F5) on browser windows.
Fixes a runtime error with Read Mind that was caused by byond having a
different order of operations for ternary operators than I normally
expect. Seriously it's kinda dumb.
Commune can now send snapshot popups of paper & photo contents to
targets, similar to how Show-Held-Item can let others see the items'
contents. This was originally planned for the initial PR and only didn't
make it in because I didn't know how to get the functionality. There's
more unique psi-sensitivity interactions in this.
There is a 45% chance for psi-deaf targets to even get the photo popup.
Photo scribbles fittingly appear scrambled to the psi-deaf.
<img width="969" height="232" alt="image"
src="https://github.com/user-attachments/assets/84105c37-6c1d-4da2-83bb-738ce6651977"
/>
On the chance psi-deaf even get the photo popup, there is a 60% chance
the photo will be in greyscale.
<img width="476" height="195" alt="image"
src="https://github.com/user-attachments/assets/030407b7-ce51-4b20-a1e2-6eb93fb21be7"
/>
Psi-sensitive targets receiving a paper popup will have it translated
based on what the sender understands. This is a fun form of translation
because it's possible for the target to _not_ understand a written
language they actually know simply because the sender doesn't.
<img width="1411" height="656" alt="image"
src="https://github.com/user-attachments/assets/9d4fe196-2593-4535-b062-bbdfa8e1e819"
/>
There is also a QoL adjacency check for writing scribbles on photos now
because it bugged me I needed to use both hands while testing.
NEW: If a psi-deaf target doesn't get it in greyscale, they may also get
photos with randomized colors
<img width="443" height="444" alt="image"
src="https://github.com/user-attachments/assets/f9a1f1c0-a6af-4d1e-95e3-260231d57643"
/>
This can seriously reframe some photos. Lots of fun with possible
misunderstandings. Both the above and below are the same photo with
Skrell blood, but the above looks like vaurca blood while the below one
doesn't look to even have blood at first glance.
<img width="444" height="447" alt="image"
src="https://github.com/user-attachments/assets/166b40f2-6ed7-49af-95e1-989ffbb69e60"
/>
---------
Signed-off-by: runecap <43975590+runecap@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
This PR adds a framework for Tool Qualities. This is done via adding a
new Tool Quality Container Component, which allows any arbitrary datum
to have tool qualities, which can be checked for by other systems as
desired. These are handled as key/value pairs in an associative list,
allowing atoms to have different quality levels as a given tool, such as
being a "level 3 crowbar" and a "level 1 hammer" at the same time.
---------
Signed-off-by: Batrachophreno <Batrochophreno@gmail.com>
Co-authored-by: Batrachophreno <Batrochophreno@gmail.com>
This PR adds a new Combat skill largely designed for non-combat
characters called Tenacity. It's fairly analagous to traits like Will to
Live from Shadowrun. Ranks in this skill make a character take a little
bit longer to "bleed out in crit", but do nothing to actually change how
hard they are to take down in combat. Effectively this means that ranks
put in this skill give you a little bit more of a buffer of time to be
picked up by a paramedic and rescued.
For actual combat characters it's very undesireable since it does
nothing to actually help win you fights, so this skill is largely more
to serve as an option for characters outside of security who don't
actually want to spend any points on direct combat capabilities. All of
the numerical modifiers from the skill are rather small, and make use of
pre-existing signal hooks that I've made previously for Brainmed to
allow component based modifiers to organ code.
<img width="1069" height="243" alt="image"
src="https://github.com/user-attachments/assets/92d6c19a-a0f2-4cc8-b490-df4538fd2b3d"
/>
# Summary
This PR fixes the carry logic and persistence register of persistent
supply packages.
## Changes
- Fixed proc path of additional pickup checks that was still pointing at
only delivery packages.
- Fixed eager location check on persistence register. Objects finalize
will do the same, but this will allow objects to be brought to the
Horizon with persistence registered.
# Summary
This PR fixes two bugs with persistent items, trash and the persistent
charge card.
## Changes
- Fixed the prevention of trash in inventories becoming persistent also
preventing any items on characters becoming persistent.
- Fixed persistent charge card location on init. If the card is not in
an command area, it will be moved into the XO office, if it is in a
command area, it will stay there.
Mechanically representing its pre-existing lore and description.
Mechanical description added on the item too.
<img width="416" height="97" alt="image"
src="https://github.com/user-attachments/assets/e70da937-30ab-42f3-bf85-5a8da5accddf"
/>
NEW:
Shaper Helmet now also removes Hive name when physically speaking.
<img width="330" height="65" alt="image"
src="https://github.com/user-attachments/assets/a56af02c-0494-4589-bf15-4d59f6d0767e"
/>
NEWER: Helmet affects visible name and messages. It ignores worn ID for
obvious reasons, but some Shapers may hide their ID while talking to
other Vaurcae.
<img width="533" height="225" alt="image"
src="https://github.com/user-attachments/assets/da85914d-52bc-4036-9616-66e479794fa3"
/>
Full Preimminent Shapers should wear robes and helmet with TTS accent to
be as anonymized as possible. Parts of your carapace that peek through
can be easily hidden as well.
NEWEST: Robes and helmet functionality have been swapped, as it makes
more sense for the robes that cover you up to remove from physical
messages.
fixes representative objectives not being sent after dual representative
offices were added. they now appear in-hand, instead of being faxed, bc
i am not adding a claim system to the offices
additionally, reformats the objectives letter and includes a
confidential notice
while I was here, I also re-did all of the Megacorp / Biesel objectives
---------
Signed-off-by: c#min7 <sadkermit01@gmail.com>
Co-authored-by: FabianK3 <21039694+FabianK3@users.noreply.github.com>
Some of the prosthetics weren't ticking down EMP damage, which was
because they had overrides of Process() that weren't correctly passing
in the SPT value needed by the tick_surge_damage(seconds_per_tick) proc.
Silence,
Violence,
Adds the Outer Eye voidsuit, and gear loadouts featuring it for antags
to use. Outer Eyes enforcers favour Xanan weapons, reflected in the
loadout. While human only for now, I hope to add variants for a few
species shortly.
Also adjusts the typo which meant the exclusionists / hoplan gear in the
uplink didn't work since it was right there. Sorry for the two in one, I
knew if I left it until after this merged I would forget.
SPRITES ARE BY THE WONDERFUL @ElorgRHG!
---------
Signed-off-by: Fyni <itsfyni@gmail.com>
# Summary
This PR adds persistent supply packages and a specialized charge card
for lore arcs.
Both can only be created using admin permissions and are not intended
for general availability.
## Changes
- Added a new package type, persistent supplies.
- Abstracted existing orion deliveries for shared code.
- Added a new persistent charge card variant.
- Added exceptions and specific logging for new card variant.
## Notes
Depends on PR #22367. Specific merge order not relevant.
Icons by @Fyniiy.
Relevant information for the current arc can be found on the forum
thread [Operation Deep
Dive](https://forums.aurorastation.org/topic/22921-all-crew-thread-operation-deep-dive/).
---------
Signed-off-by: FabianK3 <21039694+FabianK3@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: SleepyGemmy <99297919+SleepyGemmy@users.noreply.github.com>
This PR fixes a few bugs that were recently reported both by players and
by our new bug monitoring system. An AI agent (specifically Gemini 3)
was used to do some of the code diving process, while the fixes were
tested and verified myself manually. Yes I have actually verified the
fixes in this PR in testing.
The swap to Calculus methods for organ EMP was done by me, no AI. I love
Calculus to much to let a bot do it for me. In particular my fix to
organ EMP was to make it so that EMP damage is handled directly as
"number of fractional seconds the EMP will last", and that they tick
down cleanly per second. I did this because after fixing mechanical
organs not doing ANY EMP effects at all, I tested them and discovered
that the EMP effects were extremely underwhelming. They were like, "Your
screen only briefly filling with static for like 2 ticks", and "your
heart skips a single beat", which was lame and nonthreatening.
Significantly more fun is making the static last for N number of
seconds, and for the Heart to fail to pump for N number of seconds (very
life threatening!)
The new organ EMP handling vars are per-organ rather than a define, so
if we want there to be different EMP times for hearts vs eyes, that's
totally doable. Just make the heart have a larger recovery rate, or the
eyes have a smaller recovery rate.
---------
Signed-off-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: Arrow768 <1331699+Arrow768@users.noreply.github.com>
I got annoyed with the Hivebot beacon causing me a test fail 3 times in
a row, so I decided to fix it myself. I've done so by:
1. Reworked hivebots to use a weakref to their beacon. No more circular
references.
2. Removed the stupid signal registries on qdeling spam, it's no longer
necessary since there's no longer a circular reference.
3. Fixed a stacktrace in the beacon calling the same function twice.
4. Made the beacon generate its smoke cloud when KILLED rather than when
DELETED (kill calls delete on a timer), so that it can no longer spawn
stupid smoke effects during the unit tests.
5. Made the beacon clear its giant lists of references to a bunch of
turfs when deleted.
Adds loadout entries for colorable variants of the tajaran fancy uniform
and fancy uniform with skirt.
<img width="320" height="1000" alt="kWG2Cynbbm"
src="https://github.com/user-attachments/assets/49d030b9-7bd5-4598-b3df-6139f5c45911"
/>
<img width="320" height="1000" alt="0OiS9w55Mm"
src="https://github.com/user-attachments/assets/3167f319-e89e-48d5-b418-82f5abbd3965"
/>
Sprites are just recolored/grayscaled versions of the existing sprites.
Also, I had to change the default option for the loadout entry because
the accent color button only shows up if the default option has accent
colors.
Also has variants for gold buttons vs silver buttons. I'm told
apparently there's a way to have a third colorable option but I couldn't
find it and I've already spent 5+ hours today working on a character
then PRing this for that character.
I just want blue. I'm sorry (Not really).
- rscadd: "Added several new restock packs avaiable from the operations
ordering console."
- balance: "Rebalanced the prices of the restock packs."
- rscadd: "Made the restock packs come with cargo access locks."
- rscadd: "Restock packs are now actual boxes that can be opened."
- rscadd: "The commissary restock crate was moved to the operations
loading bay."
- rscadd: "The toy shelf can now also hold cap gun mags, card packs,
card boxes and music cartridges."
---------
Signed-off-by: Casper3667 <8396443+Casper3667@users.noreply.github.com>
Co-authored-by: SleepyGemmy <99297919+SleepyGemmy@users.noreply.github.com>
- qol: "Reduced the crate fee when making operation orders."
- bugfix: "Fixed the wording in some of the operation programs."
- bugfix: "Fixed the delivery app showing deliveries it shouldn't."
- bugfix: "The cargo control program now properly display status
messages."
- balance: "Supplier fee was set to 0 for all current suppliers,
eliminating the 20 credit charge per supplier."
- balance: "The operations order handling fee has been turned into a
percentage charge instead, and reduced to 5% by default instead of a
flat 20 credits."
- rscadd: "It is now possible to reject orders that have been approved
but not shipped or paid for."
## About PR
Ports 4 hairstyles (hair_bun_short3, hair_ponytail_spiky,
hair_ponytail_simple, hair_parted_short) from Shiptest. "hair_bun_loose"
is derived from "hair_ponytail_simple". Colour palette is adjusted to
the modern grayscale colours we use
Ponytails and bun hairstyle was made by thearbiber, credits to them! I
wasn't able to track the author of "hair_parted_short"
This also replaces old sprites of "Ponytail, Spiky" and "Parted, Short"
## Images
<img width="896" height="616" alt="image"
src="https://github.com/user-attachments/assets/565e8b8d-9e9d-4057-a275-654a48c4bb24"
/>
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
| Path | Original Author | License |
| --- | --- | --- |
| icons/mob/human_face/hair.dmi (hair_bun_short3, hair_ponytail_spiky,
hair_ponytail_simple, hair_parted_short) | thearbiber (Shiptest) |
CC-BY-SA 3.0 |
Does primarily three things:
- Adds a new dock to the voidtamer ship so ships like the spark can
actually dock
- Adds a new armored carp, basically a reskinned dog that voidtamers can
have
- Minor fixes in the voidtamer ship
---------
Signed-off-by: Yonnimer <31339047+Yonnimer@users.noreply.github.com>
Co-authored-by: SleepyGemmy <99297919+SleepyGemmy@users.noreply.github.com>
Reverts Aurorastation/Aurora.3#22313
Somehow made a race condition that causes the protolathe to delete
stacks if and only if the stack would have been "finished" by fully
placing the stack in the protolathe.
Removes a bunch of unused circuit boards that corresponded to machinery
that didn't exist in the game anymore. These would turn up in spawners
on offsites and in random contents crates regularly, essentially
"wasting" the spawns.
renames the basic role access list to "job_access" to make its purpose
clearer and removes the unused expanded access list since we only use
the former. it should also help prevent confusion when adding access to
roles.
server config should be updated.
Skills being based on "Hard Requirements" absolutely suck, and I wasn't
happy with the surgery code being essentially hardcoded around them. So
this PR refactors surgery to use soft requirement checks, based on
modifiers to the success rate probability. Surgeries still state what
skills (if any) they require and at what level, but rather than blocking
the surgery, it instead imposes a penalty(or bonus) on the success
chance based on how much the user's surgical skill differs from the
required level. This actually stacks with the penalties for "non ideal
tools", so if you're completely unskilled in surgery and you attempt to
make an incision with a shard of glass, you're going to have an
extremely hard time.
Individual surgeries also can define how much the success rate is
modified by "skill diff", with the more advanced "surgeon exclusive"
surgeries having extremely large potential modifiers.
I have also added a signal based check for modifiers, which the Morale
component now hooks into. This can also allow for other components,
implants, drugs, etc to modify the surgery chances in the future.
I have manually tested this PR and verified by examining debug
breakpoints in VSCode that the system correctly applies its modifiers.
Lead-up to final push on NanoUI conversion; AME was removed (w approval
from Matt), DNA modifier will not be converted to Nano at this time, a
heap of templates and associated unused sprite files also removed.
Fixes https://github.com/Aurorastation/Aurora.3/issues/22296
This appears to have been caused by an excessively long timer delay in
the destruction of the 'mimic' object created when an AM is viewable
from above through an openspace turf. Now, when transitioning up a
staircase or ladder to a higher z-level, mimics of yourself and any
objects you may have been pulling are no longer still visible for 10
seconds.
I do not know exactly why the original timer was set for so long.
I did not detect any performance issues or harddels when testing it
(knocking a bunch of random holes in the the 2nd floor of runtime and
setting a bunch of greimorians loose on the 1st floor so that their
openspace mimics would be continually created and destroyed.
