This adds a fair bit:
- Splits the Hephaestus security and ERT/military uniform, since the
security uniform's description doesn't really match that of their
private military (and there is the possibility both may meet in a single
round)
- Adds a Hephaestus-colored captain's cap and gloves, which fits with
their current uniform
- Updates the cyclops uniforms to include rolled states.
- Added a Hephaestus physician's uniform and surgical outfit, and mapped
those into the ERT ship.
### Asset Licenses
The following assets that **have not** been created by myself are
included in this PR:
| Path | Original Author | License |
| --- | --- | --- |
| icons/clothing/under/uniforms/cyclops_uniforms.dmi (heph_military) |
[Paxilmaniac](https://github.com/Paxilmaniac) (tgstation) | CC-BY-SA 3.0
|
A companion to #20795
During discussion on this PR, it has come to my attention that no one
realized these also protect your hands and feet. And why would they,
considering their sprites do not cover said areas?
This is poor for player feedback, so these have been corrected to only
protect areas actually covered on the sprite itself. This means riot
guards still protect the hands (as well as some older un-updated
sprites), but this does make them a more attractive option in some
cases.
Adds unique coverings for Dominian Unathi.
Created in conjunction with @CaptainGecko. Adding him to the
conversation in case there are any questions; lore or otherwise.
Title. Noble Row said that their passports would likely be electronic,
so I went with that. Humans can also take them, as some humans are
mentioned as having citizenship through marrying an IPC on the wiki, but
this can be removed if requested.
!!Requires synth lore team input!! @NobleRow
Sprite preview (subject to change):
---------
Co-authored-by: Gabby <59633984+feartheblackout@users.noreply.github.com>
Fixes#19603Fixes#20558
- bugfix: "Fixes plant bags - now uses storage_slot system, along with
other bag subtypes."
- bugfix: "Borgs can interact with tables again."
- refactor: "Refactors make_exact_fit to be a binary variable."
- refactor: "Refactors storage items to use make_exact_fit instead of
arbitrary max_storage_space values."
- refactor: "Refactors storage items to use defines for storage space."
- bugfix: "Fixes monkey cube boxes having superfluous overlay."
- rscadd: "Updates the progress bar toggle message."
- qol: "Objects that rotated 90 degrees in storage no longer rotate in
storage slots."
<img width="732" alt="dreamseeker_qRVkIlYN78"
src="https://github.com/user-attachments/assets/1226ed22-52c1-4965-a1b4-2290e56a2ab3"
/>
Added armor defines
Converted raw strings use to defines
Added UT test to ensure people set the armor var correctly (to a list)
No player facing changes
Turned a ton of unmanaged globals into managed globals.
Refactored some UT output.
Removed some unused things, including vars.
Added a test to ensure people don't keep adding new unmanaged vars.
This PR adds four new items for Orion Express characters. They can be
found in the Factions tab of the loadout.
Orion Softcap - found under "orion headwear selection"
Quick-E-Burger Apron
Quick-E-Burger Jumpsuit
Quick-E-Burger visor
All credit for the sprites goes to goblin.stev, I only did the funny
words that make them work ingame.
FORUM THREAD:
https://forums.aurorastation.org/topic/20580-assistant-overhaul/#comment-179129
This one will probably need a wiki change or two.
The Assistant Overhaul! A.K.A "FlamingLily commits to coding something
and forgets for six months"
Also, the "Lab Assistant" (Science's learner role) has been renamed to
"Research Intern" with alt-titles to match, in the same vein as the
medical intern. This serves the dual role of clarifying the role's
nature as a departmental learner, AND makes space for the assistant alt
title.
This PR adds four new titles to the Assistant role, complete with access
and loadouts to match.
* Wait Staff: This one's pretty self explanatory. They haul food and
drinks FROM the kitchen and bar TO customers. They do not cook, and do
not get kitchen or bar access.
* Technical Assistant: This one's job is to haul crates and parts for
engineers. They get access to engineering's lobby and main hallways (as
far as a Janitor can get), but otherwise get nothing. They CANNOT start
the engines, shields, atmosphere, or anything. They spawn with a
high-vis vest and a debugger, for token vending-machine fixing efforts.
* Lab Assistant: This one's job is to haul crates and equipment for
scientists. They get access to ACCESS_RESEARCH which is like, two doors
in the research meeting room and not even the hallway outside I think
(idk). They also get a labcoat and safety goggles. For safety.
* Medical Orderly: This one's job is to haul equipment and corpses,
clean up a messy GTR, and stay out of medical's way when an alert is
called. Maybe they can man the reception as well. They spawn with a
labcoat and sterilizine (not even cleaner, because it's funnier that
way.)
I want to insist that these are assistant alt titles, and not roles with
responsibilities. They cannot do repairs, they cannot do science, they
cannot do surgery, and they CERTAINLY can't cook.
Changelog:
- rscadd: "Added four new assistant alt titles: Wait Staff, Technical
Assistant, Lab Assistant, and Medical Orderly (These are still
ASSISTANTS, and cannot perform the relevant departmental skills. These
are also different from learner roles, such as the Interns.)"
- rscadd: "Renamed the existing "Lab Assistant" (The learner role) to
"Research Intern" to better represent the intent for the role and to
make space for the alt title."
---------
Signed-off-by: FlamingLily <80451102+FlamingLily@users.noreply.github.com>
Fixes accessories not showing up on suit items.
Confusingly, accessories used the "_un" uniform suffix - this changes
them to use the "_ac" suffix.
Also moved some files around to their proper place (hair pins and bows
aren't accessories, they're ear slot items, etc.)
Fixes#20361Fixes#20352Fixes#20354
From previous PR:
- Fixes Quick Equip (Thanks, Matt)
- Fixes Loadout Preview, will override uniforms properly now
- Turns shirts into uniform items, so you can attach accessories to them
This also fixes the issue of people spawning in shirtless if they didn't
attach properly to the pants.
Additions:
- Shifts suspenders, leather chaps, and kneepads to be pants
accessories.
(This fixes the issue of accessories staying even without pants, e.g.
assless chaps)
(In future, hip holsters are to be added to this accessory list)
Anyway, that's the long and short of it. Have fun.
---------
Signed-off-by: Wowzewow (Wezzy) <42310821+alsoandanswer@users.noreply.github.com>
Co-authored-by: Fluffy <65877598+FluffyGhoster@users.noreply.github.com>
🚨 BREAKING NEWS: Our favorite dystopian frogs just got a little
less...Chinese? Down with the Social Score Order, up with the new Social
Compatability Index hyper federalist world.
: )
Also this is a Cerriq Koh memorial pull request.
---------
Signed-off-by: Warbidon <42331812+Warbidon@users.noreply.github.com>
Co-authored-by: Ben <91219575+Ben10083@users.noreply.github.com>
Refactored mousedrag procs, added signals, some safeguards, did some
cleanups around, renamed them to make a little more sense. Mostly put in
line with TG's code.
Fast clicking and releasing with a drag, depending on the grace period
and how fast it is done, can be counted as clicks, to aid in combat
scenarios where you spamclick.
* You can now ctrl+click on any worn clothing item that has accessories
attached to quickly open the accessory removal radial menu.
* Removing accessories with the radial accessory removal menu will now
reopen that menu until either all the accessories are removed, or you
click the close button.
* Plate Carrier armor accessories will now always render below other
accessories, so you don't need to shuffle everything to layer them
correctly.
Adds several new items to the Dionae loadout:
- Three sets of clothes and two hoods for voidtamers
- A jacket, cloak, two hats, and an undersuit for the ekane
- A narrows hardhat and jacket, as well as a slightly reworked jumpsuit
(made chonk)
- New Eternal Robes, the old ones are remaining for now but may be
reworked in the second wave of items
- Also removed some redundant rokz and serz items and the ships
themselves, these may be reworkedin the future, but for now aren't in
current lore.
More loadout items will ideally be coming soon for each factions in the
coming weeks/months.
---------
Signed-off-by: Yonnimer <31339047+Yonnimer@users.noreply.github.com>
Signed-off-by: Matt Atlas <mattiathebest2000@hotmail.it>
Co-authored-by: hazelrat <83198434+hazelrat@users.noreply.github.com>
Co-authored-by: Matt Atlas <mattiathebest2000@hotmail.it>
Does what it says on the tin. Purely cosmetic for now. This is step
zero.
Basically, clothing is starting to get real bloated with a lot of
variants.
More pressingly, accessories as well, and we're probably going to get
accessories of accessories.
After seeing what's going on with arm guards, leg guards, plate carriers
and the like,
it's heading towards a really messy level of abstraction.
Hopefully this will nip it in the bud, so to speak.
I've also added the layering feature used in watches, so you can tuck in
your uniform in your pants, or your coat in your pants if you're so
inclined to.
This also means that in the near future, we'll finally have the ROLL
PANTS feature that has escaped us for so long.
For reviewers :
This PR is majority legwork of simply adding the new pants slot in. Very
similar to my previous Wrist slot PR.
The rest is just changing the existing pants/skirts over to a new
loadout slot and changing paths.
---------
Signed-off-by: Wowzewow (Wezzy) <42310821+alsoandanswer@users.noreply.github.com>
Co-authored-by: Fluffy <65877598+FluffyGhoster@users.noreply.github.com>
**This is up for review.**
- Remaps the Golden Deep ghostrole to be better.
- Includes new uniforms for menial Golden Deep synthetics, and new
Golden Deep voidsuits.
- Includes the clothes dyer, a new item that changes the colour of
recolourable clothing to whatever the user wishes. Adds it exclusively
to the Golden Deep ship, so the merchant can customise their drip as
much as if they were in the loadout, since pretty much all of the newer
GD clothing is recolourable. Works for both the regular colour and the
accent colour.
- Uses submaps for the warehouse.
- A few semi-empty spaces exist right now which will be filled once the
sprites for what's going to go there are complete, particularly in the
great hall.
- The armoury is intended to be pretty strong - it's a cargo freighter
with very valuable cargo, so you have an unusually hard fight to get
said cargo if you board. It contains a laser rifle, a combat shotgun
(with a box of EMP shells, notably, with the idea that the Hoplan should
be particularly good at restraining other synthetics), two energy
glaives, and two pistols intended for the Hoplan. There are also two
machine pistols and two energy carbines, intended for if the Hoplan wish
to arm the rest of the crew.
- Adds the ship to Valley Hale - has the OK from lore, as far as I know.
Changes the slowdown of modular armour:
- The plate accessory slowdown has been changed from 1 to 0.4
- The leg guard accessory slowdown has been changed from 0 to 0.3
- the arm guard accessory slowdown has been changed from 0 to 0.3
When wearing a full set of armour, your slowdown should be equal to 1
which is the current slowdown, taking off the leg and arm guards will
now allow you to move faster at the cost of coverage. This allows better
customisation and gives more incentive to play around with the modular
side of the modular armour system. Note that this slowdown does not
apply to light armour like the standard corporate armour and similar.
Refactored the attack proc signature.
Added signals and components for the attack proc.
Added signals and components for the attackby proc.
Adjusted some leftover attackby procs signatures.
Added grep test to ensure people don't keep adding attack/attackby procs
with the wrong signature.
This is a remap of the TCAF Corvette offship, intended to be more
intuitive than the current one.
**This is up for review.**
Notes:
1. The combustion engine isn't the only source of power in the ship,
there's also a portable generator that should be able to produce enough
to keep the ship going.
2. This adds a few clothing and overmap sprites for use in the
ghostrole, credit to Noble for them, and it also consolidates a few of
the existing TCAF assets into a single faction file. It isn't
comprehensive, but it's more organised than it was.
3. The armoury has been diversified a little. It's now composed of two
blaster rifles, one bolt slinger, one combat laser rifle, one pump
shotgun, and one burst rifle, plus the PEAC and six blaster revolvers as
sidearms. The primary intention of the combat laser rifle, pump shotgun,
and burst rifle is to provide a little AP which blasters universally
badly lack, so the ghostrole should be decently competitive against
armour. My hope is it should be roughly as strong as the Coalition
Ranger ship in combat.
4. I'm not totally happy with the hangar, but I'm not satisfied with any
of the docking port designs I've been able to think of, so I'm running
with it for now. I do believe a docking port is generally preferable.
5. Per Trio, species restrictions are tightened a bit on the Decurion to
only cover humans, Skrell, IPCs, and Vaurca Warriors. Liable to be
changed. Vaurca workers have also been excluded from every combatant
ghostrole, playable only as technicians. I'll be prodding at adding
bulwarks too, but they're not currently included due to some fickleness
with giving them appropriate uniforms.
6. The sensors are the strong variant for the shuttle and ship, with the
idea that it should be particularly good at reconnaissance. I doubt
anyone would use the shuttle to scout the sector, but the sensors are
good to throw a bone in that direction.
New Twin Suns charm representing the suns of S'rend'marr, used by those
who worhship S'rendarr and Messa
---------
Co-authored-by: Ben10083 <Ben10083@users.noreply.github.com>
Refactored the abstract meta propriety into defines.
It's now more easy to spot/see abstract types thanks to the macro that
defines them.
Added a check on initialization of atoms to avoid spawning abstract
types.
Made the spawn_atom proc check for abstractness.
Made the spawn_atom proc use tgui_list for types list shorter than 1000
elements, which enables to search in them. It's too laggy on larger
lists so above 1000 it uses the builtin input.
Made the spawn_atom use a list subtraction instead of a double list,
it's lighter on memory and processing.
Refactored hitby to be in line with TG's version.
Refactored item weight defines to a more clear naming scheme, also in
line with TG's version.
Refactored how the movement bumps are handled, ported signals to handle
them, in preparation for the movement update.
Fixed disposal hit bouncing the hitting atom on the wall.
Items do not push other items anymore if they are tiny.
Reverts accessory weight handling, ontop of being exploitable as easily
as attaching the accessories after the clothe is in the bag, it doesn't
make sense that you can store the pieces singularly but not once put
together (for the modular armor, that is), and is ultimately just an
hassle to have to disassemble and reassemble it over and over every time
you have to pull the armor in the backpack and back out
Fixes the Skrandana to be white, and spelling errors on the Weishii robe
and Worker's hat.
Also, not quite sure if it should be worker's hat or workers hat.
---------
Co-authored-by: Stev-the-third <Rose@flurf.net>
This re-adds the Anomalist alt-title for Xenoarchaeologist, alongside
some uniforms for them (They're just Xenoarch radios and uniforms which
are renamed to say "Anomalist")
The justification for this is that Xenoarchaeology and Anomaly research
are pretty distinct mechanically and lorewise. This isn't to say
necessarily that a Xenoarchaeologist is incapable of doing research on
anomalies or vise versa, and I don't want to tell people that they
can't!
However, I would like to have a way for Science characters with
specialisations in anomaly research to be able to distinguish themselves
from Xenoarchaeology, because their field wouldn't really have much to
do with doing anthropological research or fossils or archaeology,
really.
