This PR is mostly about fixing body/cryo bag layering issues.
Currently live and annoying to try and treat around:
Currently, bags are are below roller beds when first deployed. If
buckled and unbuckled, they are then above, because of the + 0.1 on
buckling.
If buckled on a roller bed, dragged, and then unbuckled, they are then
above player mobs, because of the `layer + 1` on roller bed `Move()`
proc, which also doesn't get reset. I removed this +1 on Move() because
it was older than the +0.1 and seems to serve the same purpose.
The +0.1 did not have a method of reverting to the original buckled
atom's layer, so I added a var and check to handle that.
I also changed bullet casing's layer to `BELOW_TABLE_LAYER` with the
intent of not having them on top of stasis bags and roller beds, because
it causes issues as someone trying to treat wounded after a firefight.
Changing bullet casing's layer does have a consequence of putting
bullets underneath, for example, the soil in the public garden. Putting
the soil on `BELOW_TABLE_LAYER` would fix this, but with the consequence
of having the bushes be on top, making clicking the soil difficult for
farming purposes. Adding bushes to that layer causes consequences with
side window layering (like on deck three outside the public lounge.)
For this PR I only adjusted the bullet casing layer. I'm sure it has
other unintended layering interactions. Let me know if it would be
better to leave them where they are or on some other layer.
Current changes in PR: Bullets under soil/roller beds/stasis bags.
(Example of why making bullets on top of soil is difficult) Screenshot
shows both bullets and the soil being `BELOW_TABLE_LAYER` with bushes on
top, as a reference. PR Currently has bullets underneath soil.
Adds missing Machinist access and compatability for slime scanner to
Research module robots
Co-authored-by: Ben10083 <Ben10083@users.noreply.github.com>
### Introduction
The recently to atmos added hydraulic rescue tool is a robotic tool and
has none of the common item/tool properties. This PR refactors the tool
to a non-robotic version and fixes a bug in the recently added
functionality (#20138 - Airlocks can be opened instantly by moving
during the action duration).
### What changed?
- Added `/obj/item/crowbar/hydraulic_rescue_tool` to tools.dm
- Removed robotic version under AI
(`/obj/item/crowbar/robotic/jawsoflife`)
- Updated all occurrences (Sprite label due to updating the sprite
filename)
- Fix action skip bug in airlock.dm when using the tool (See
[5cc808b](5cc808ba53))
Does what it says on the tin. Purely cosmetic for now. This is step
zero.
Basically, clothing is starting to get real bloated with a lot of
variants.
More pressingly, accessories as well, and we're probably going to get
accessories of accessories.
After seeing what's going on with arm guards, leg guards, plate carriers
and the like,
it's heading towards a really messy level of abstraction.
Hopefully this will nip it in the bud, so to speak.
I've also added the layering feature used in watches, so you can tuck in
your uniform in your pants, or your coat in your pants if you're so
inclined to.
This also means that in the near future, we'll finally have the ROLL
PANTS feature that has escaped us for so long.
For reviewers :
This PR is majority legwork of simply adding the new pants slot in. Very
similar to my previous Wrist slot PR.
The rest is just changing the existing pants/skirts over to a new
loadout slot and changing paths.
---------
Signed-off-by: Wowzewow (Wezzy) <42310821+alsoandanswer@users.noreply.github.com>
Co-authored-by: Fluffy <65877598+FluffyGhoster@users.noreply.github.com>
Added some modular computer program preset tests.
Fixed some modular computer program preset that had duplicate programs.
Refactored how the computer program presets generate the list of
programs to install.
Turned some comments into DMDocs, some cleanup around.
Tests disabled reasons are now enclosed in the group correctly.
### Introduction
With the port of SSthrowing from TG (see #19421) an additional check got
added to `/atom/movable/Move`. The check
```
if(!newloc || newloc == loc)
return
```
prevents the move method from an unnecessary movement.
The method is also used by ladders to move the player to the ladder
before climbing it - With the new additional check it was no longer
possible to grab ladders if you are on the same tile, because the move
method would run the location check and return, skipping the movement,
which is correct, but results in failing to climb the ladder after all
("You fail to reach the ladder.").
This PR fixes this small but very annoying issue.
### What changed?
To not further modify the move method an additional check has been added
to the ladder-climb code to skip the move method when the player is
already on the same tile.
Readds Dionae customization options to their hair and beard options in
the setup.
While I do sorta like the idea of just having them all be body markings,
this came with too many bugs, essentially bricking them in ghostroles
and some layering issues, this just readds most options.
---------
Signed-off-by: Yonnimer <31339047+Yonnimer@users.noreply.github.com>
Removes the confusingly unnecessary nerf to Columbo's damage (he did as
much as just punching someone) from the parent mob and increases his
health from 75 to 125 so he can withstand at least a little more
punishment.
The poor guy is quite literally never let out of his enclosure because
he's less useful than just throwing a floor tile at someone. He's also
the only "unique" thing the Head of Security has left, and people seem
warm to the idea of an actual incentive to bring him out more. With
these buffs he stands an actual chance of being able to fight and take
down someone unarmed and unarmored.
Frag grenades projectiles now apply some agony and eyeblur.
Frag grenades projectiles have damage augmented by 3 points (~10%).
Frag grenades projectiles have an augmented chance of leaving a shrapnel
(+30%).
Frag grenades projectiles have a chance to ricochet up to 2 times.
Some code cleanup and removed some procs that were no longer used
(nothing called them anymore) from the projectile refactor.
Makes Skrellian Nralakk Federation consulars spawn with a box of psionic
receivers, with the idea that they can advocate for their installation
into crew for ease of work in and with the Federation. Has the okay from
Skrell lore.
It is now fairly simple to add your own aide to any job. The code has
been made more modular, cleaner, and overall easier to work with.
Added a corporate aide role for representatives. Live out your
privileged wage slave dream.
---------
Co-authored-by: Matt Atlas <liermattia@gmail.com>
See title. Works so far in my testing, should prevent the 200 webs on a
single turf issue we've all loved dealing with. This doesn't seem to be
intended behaviour, given there's a check against it in the code
already, so I'm putting it under bugfix.
Title
Banner sets for Tajaran religions (Suns and Ma'ta'ke) added to loadout
with 2 point cost
Useful for roles like chaplain that wants representation of more members
of the pantheon/ both suns
Co-authored-by: Ben10083 <Ben10083@users.noreply.github.com>
Fixed some situations where a null was being set as target.
Repathed the dreaded target_mob variable to last_found_target, and from
mob to atom, as it was not being used only for mobs.
Added procs to set and unset the last_found_target and setup the signals
relative to clear it, and validations.
Thanks to the above, removed a viewscan that was needed to delete
references when mobs die from their attacker.
General QoL of code, DMDocs.
Reverts Aurorastation/Aurora.3#20102
The aforementioned PR essentially broke the proc, since the parent proc
doesn't set any return value; this in turn breaks the offhand item from
being deleted when you move a gun from the hand to eg. the backpack,
leaving you with the offhand item occupying the other hand despite you
not holding the gun
Since the fix is essentially a reversion, and since the parent proc
doesn't set any return value so it doesn't make sense to check it, I'm
opening a reversion directly.
**This is up for review.**
- Remaps the Golden Deep ghostrole to be better.
- Includes new uniforms for menial Golden Deep synthetics, and new
Golden Deep voidsuits.
- Includes the clothes dyer, a new item that changes the colour of
recolourable clothing to whatever the user wishes. Adds it exclusively
to the Golden Deep ship, so the merchant can customise their drip as
much as if they were in the loadout, since pretty much all of the newer
GD clothing is recolourable. Works for both the regular colour and the
accent colour.
- Uses submaps for the warehouse.
- A few semi-empty spaces exist right now which will be filled once the
sprites for what's going to go there are complete, particularly in the
great hall.
- The armoury is intended to be pretty strong - it's a cargo freighter
with very valuable cargo, so you have an unusually hard fight to get
said cargo if you board. It contains a laser rifle, a combat shotgun
(with a box of EMP shells, notably, with the idea that the Hoplan should
be particularly good at restraining other synthetics), two energy
glaives, and two pistols intended for the Hoplan. There are also two
machine pistols and two energy carbines, intended for if the Hoplan wish
to arm the rest of the crew.
- Adds the ship to Valley Hale - has the OK from lore, as far as I know.
Resolved some runtimes for mimic turfs on examine.
All examine headers respect the proc signature.
All examine that do not explicitly need not to, passthrough the arglist
to references examine target procs.
