About The Pull Request
repaths clothing/under to be more sane
Also fixed a couple of bugs relating to pathing being incorrect, and modified a couple of bad descriptions and names
Also adds a map path updating script, which also helps show the full repath.
Why It's Good For The Game
improves maintainability, makes mapping easier, stages for a clothing dmi split
Changelog
cl
refactor: repathed all under clothing, keep an eye out for errors
/cl
About The Pull Request
Some skirt sprites were offset i dont know how this happened i swear i fixed this before but apparently not. Fixed the assistant skirt necklines being way too high. Added extra details on some skirts.
Added 5 previously missing skirts including 2 lawyers skirts(like they dont have enough already), rainbow, syndicate and tacticool. Fixed the disorganized mess that was the Lawdrobe.
Why It's Good For The Game
Updated skirts good. Rainbow skirt good. Skirtleneck good.
Changelog
cl
add: The long lost rainbow jumpskirt has been found
add: Rumor has it that even the syndicate have started producing skirts for their operatives
tweak: Department skirt necklines are more in-line with their jumpsuit counterparts, sprites are no longer offset, added detail
/cl
Adds a preference for jumpsuit/jumpskirt into the game. Currently runs
a jumpskirt for all occupations on spawn except for miner, since they
have their special lavaland suit, and no skirt variant I could find.
Doesn't remove skirts from lockers/machines yet since I am not 100% as
to whether that should be done (clothes are available generically for
the sake of changing outfits/recovering clothes after a whoops with
some pyrotechnics).
- Added mime envirosuits, nothing special here.
- Added clown envirosuits, which release space lube when they
extinguish the clown.
- Removes code that theoretically limits plasmamen from being clowns
and mimes, but actually doesn't.
- I guess the roles now spawning with these suits is kind of notable.
- Reverts unlisted changes to the grey detective suit from #44776.
About The Pull Request
Adds department skirts to all related lockers/vendors
Why It's Good For The Game
Skirts good
Changelog
cl
add: added department skirts
fix: fixed secskirt dixel
/cl
* 1/4 done? maybe?
* more
* stuff
* incremental stuff
* stuff
* stuff & things
* mostly done but not yet
* stuffing
* stuffing 2: electric boogaloo
* Git Commit and the Kingdom of the Crystal Skull
* make it actually compile
* found more stuff
* fixes
* fix AI laws appearing out of order
* fix windows
* should be the remaining stuff
* this time for real
* i guess it should compile too
* fix sechuds
* Passive aggressive nerfs
Yeah no. Those values were retarded
* Update syndicate.dm
* Update armor.dm
* Update packs.dm
* Update packs.dm
* Rad protection for helmets.
* Life in the zone is hard
add forgotten job checks
w
s
w
Merge remote-tracking branch 'origin/plasmeme' into plasmeme
Merge remote-tracking branch 'origin/plasmeme' into plasmeme
Merge remote-tracking branch 'origin/plasmeme' into plasmeme
r
* fugitives
* lets make this a bit cleaner
* cultists and the beginnings of security detail, lots of wip
* wip security
* WALDO (and some more work on yalp, of course)
* adding antagonist teams for both hunter and fugitives, roundend report beginnings
* this whole file is shit, but hopefully a little better
* it compiles (+ space police)
* some more work
* S.E.L.F. fluff
* grammar and icon fixes
* lets finish yalp elor, give it the justice it deserves
* moves hunter spawns to ship pods + russians P1
* moves hunter spawns to ship pods + russians P2
* fugitives and hunters now recognize eachother
* hunter spawning finished(?)
* missed this
* ATH's review
* runtime fixed, added yalp's transport ability
* anturk's review
* makes hunter.dm better trust me
* oopsies
* INVOKE_ASYNC
* russian ship + finally a (bad) sprite for the capture machine
* step > pixel, thanks travis
* mooshroom review p1
* mooshroom review p2
* improper use of /improper
* waldo's radio doesn't stick, police id
* candidate picking is more flexible + minor things
Idea and instructions by @Razharas, many thanks.
This PR only implements the framework required to catalog as well as play the sounds. Their to_chat text, and icons (if any) are not included, are to be pushed in a separate PR.
This PR does not remove the old playsound_local system, it is kept for the sake of not necessitating a direct changeover of every single playsound in the code, which will surely cause a lot of merge conflicts. It does however, replace bike horns' and toy nukes' means of playback to this datum, purely as proof of concept.
Playsound_local may remain in the code to support playback of admin-uploaded sounds that do not have an inherent datum. Playsound will likely be renamed to something else in the next PR to reflect its new, more universal function. We will see.
New process for adding sounds:
Create a new datum/outputs subtype.
If you wish, write down some supporting text; this gives further meaning to the sound.
Add multiple sounds to the sounds list, and weight them as you wish. (New)
Add a sound icon if you wish, it defaults to a generic sound circle anyways though.
playsound(/datum/outputs/new_subtype, receiver), and it will deliver, icon, sound, and text to the receiver.
Maintaining implication is that from now on playsound should only be processing datum/outputs
This pr intends to gut to_chats that are added alongside playsounds in the code.
This pr eliminates the need to initialize sounds in a list so that you can weight them or have the game play them randomly from the list.
Sound Rings
Currently, only mobs with the audiolocation var may view them. Sound icons have an alpha that depends on the volume of the sound, louder sounds create a more opaque image
Sound rings are completely modular and may be changed to any image.
In addition to renaming playsound to reflect its new function. I intend to give blind people sound icons at the cost of their small view, but that is for another PR.
cl Basilman
refactor: refactored how sounds are stored and played
add: Added sound rings and supporting text
/cl
* Refactors NODROP flag into TRAIT_NODROP
🆑 coiax
fix: Anti-drop implants can no longer be used to drop objects that they
were not responsible for sticking to a person's hand.
fix: Backfiring with a Barnyard spellbook will now play a spooky horse sound.
refactor: Refactors the way that "NODROP" items work to a new system,
there should be no change in functionality.
/🆑
Various items in the codebase were doing weird hoop jumps in order to
preserve the nodrop flag's state when it also wanted to change it, so I
moved it to a trait system.
I may have gone overboard with the type of unique trait sources, but
those can be changed later. My long term plan is make a general "CURSED"
nodrop origin, which means you can unlock cursed items by being hit with
a bolt of door opening or something. But that's for another PR, this has
no functionality changes, apart from some slightly modified descriptions
on cursed masks.
- Removed a bunch of redundant voice changing code for all the voice
changing animal masks, used two new clothing flags for this purpose.
- Also refactored a bit the animal masks, making new cursed subtypes that play
the sound when created.
* Drop location
* Wearing freshly washed clothes makes you feel better
🆑 coiax
add: Wearing a jumpsuit that's been washed in a washing machine
will give you a positive moodlet.
/🆑
In addition, cleaned up the washing machine code so there no longer
needs to be a "has_corgi" var.
* Laundry is only clean for 5 minutes
cl ShizCalev
tweak: Added examine messages for helmets & guns with flashlights (and bayonets.)
fix: Fixed an issue where you were able to remove flashlights/bayonets that were supposed to be permanently attached to a gun.
fix: Fixed an issue where you were unable to remove flashlights & bayonets from certain weapons.
fix: Fixed a potential issue where adding a flashlight to your helmet would've caused you to lose other action buttons.
fix: Fixed a issue where guns with multiple action buttons would break all but one of those action buttons.
tweak: If you have both a bayonet and a flashlight attached to your gun, you'll now be given a prompt on which you'd like to remove when using a screwdriver on it.
/cl
Shouldn't need to have "pro-gamer tips" in adminpm's just to inform folks that you can remove a flashlight from a helmet with a screwdriver.
Also added some missing handle_atom_del / Destroy logic, as well as moving the clothing can_flashlight & flashlight vars down to helmet level (since they were the only things that utilize them anyway.)
also why the fuck was the helmet flashlight var just called F. hnnnngg
This pr adds new clown costumes that come in a variety of colors including blue, green, yellow, purple, orange and now rainbow! so now clowns can go out in the station in the latest clown style!
The clown outfit got its hardcoded squeak on hit replaced with the component.
Objects which can squeak which are thrown in disposals will squeak when they hit bends in the piping.
