* Refactors connect_loc_behalf into a component (#60678)
See title. Also refactors caltrops into a component because they use connect_loc_behalf which requires them to hold the state.
This also fixes COMPONENT_DUPE_SELECTIVE from just outright not working.
connect_loc_behalf doesn't make sense as an element because it tries to hold states. There is also no way to maintain current behaviour and not have the states that it needs.
Due to the fact that it tries to hold states, it means the code itself is a lot more buggy because it's a lot harder to successfully manage these states without runtimes or bugs.
On metastation, there is only 2519 connect_loc_behalf components at roundstart. MrStonedOne has told me that datums take up this much space:
image
If we do the (oversimplified) math, there are only ever 5 variables that'll likely be changed on most connect_loc_behalf components at runtime:
connections,
tracked,
signal_atom,
parent,
signal_procs
This means that on metastation at roundstart, we take up this amount: (24 + 16 * 5) * 2519 = 261.97600 kilobytes
This is not really significant and the benefits of moving this to a component greatly outweighs the memory cost.
(Basically the memory cost is outweighed by the maint cost of tracking down issues with the thing. It's too buggy to be viable longterm basically)
* Update glass.dm
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* Del The World: Unit testing for hard deletes (#59612)
Co-authored-by: SteelSlayer <42044220+SteelSlayer@ users.noreply.github.com>
* Del The World: Unit testing for hard deletes
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@ users.noreply.github.com>
* Drugs of the 26th century. Three new hella rad drugs, one less lame drug and more!
* Update traits.dm
* Update maint_loot_trash.dm
Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* AAAAAAAAAAA
* pollution scrubbbies
* fires cause smoke, right? Also NSS journey has scrubbies
* washing things removes the smell!
* what the fuck were you doing last night
* Update temporary_pollution_emission_component.dm
* space turfs shouldn't have pollution
* Fix air now fixes smoke
* Update pollution.dm
* Update pollution.dm
* Update bonfire.dm
* fix flashing white spheres when attacking items with light sources and light spheres on inventory/action buttons (#60756)
* fix white sphere bug
* fix overlay lighting creating lights in inventory and action button
* fix flashing white spheres when attacking items with light sources and light spheres on inventory/action buttons
Co-authored-by: Couls <coul422@gmail.com>
* Fixes changelogs parsing on linux (#60777)
* Fixes changelogs parsing on linux enviroments
Co-authored-by: Vladimir Veisman <v.veisman@flashie.space>
* stops dchat clog from clientless mobs (#60772)
bug fix, because obviously the user.client check in the emote proc was supposed to work for this, but they forgot to put it in manual_emote as well.
also moved the user.client check in the emote proc a few lines above, for sliiiightly better performance, ghosts will still get the message from visible_message, but only if nearby, so it has the same effect as where it was before.
* stops dchat clog from clientless mobs
Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com>
* Food preferences quirks are no longer broken by species change. (#60582)
Added signal procs for species change to these quirks.
* Food preferences quirks are no longer broken by species change.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Fixes the accounting machine by granting unassigned accounts to new savings accounts. (#60690)
* Fixes the accounting machine by granting unassigned accounts to new savings accounts.
Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
* railings can now be vaulted/climbed over from both sides. (#60110)
Quality of life; it spares us from having to walk all the way around or destroy them with either a wirecutter (faster) or any impromptu weapon (slower, as they currently have 300 maximum integrity, despite taking only three iron rods - one more than grilles - to make) in certain occasions, and it's already a thing on other codebases that have railing objects.
* railings can now be vaulted/climbed over from both sides.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Uncomments holymelon "check liked" code, makes it work with the edible component (#60697)
* Uncomments holymelon "check liked" code, makes it work with the edible component
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Gutlunch udders no longer double as mouths (#60665)
Co-authored-by: Your mother <mothmilk666666666666@ tfwno.gf>
* Gutlunch udders no longer double as mouths
Co-authored-by: interestingusernam3 <51925758+interestingusernam3@users.noreply.github.com>
Co-authored-by: Your mother <mothmilk666666666666@ tfwno.gf>
* Renames RemoveComponent, fixes a dumb runtime in Destroy (#60653)
* Renames RemoveComponent, as its purpose was unclear. Fixes up some dumb uses, and properly docs its status as a helper proc for transfering components
* Renames RemoveComponent, fixes a dumb runtime in Destroy
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* Removes an unused trait. Adds another to the traits global list. (#60584)
Drunk healing is handled by the quirk itself. The trait is pointless.
I forgot add the uncatchable trait to the global list for admin shenanigeans.
* Removes an unused trait. Adds another to the traits global list.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Fixes a random unit test error that can happen with the hypnosis trauma (#60607)
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Fixes a random unit test error that can happen with the hypnosis trauma
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
This is a first addition to help add a little more to the space ruins we currently have. It's my first ever attempt at making any sort of map for ss13, so it will definitely not be the same level of polish as other ruins.
That being said, as I learn to make more maps, these ruins will see a revamp.
