* refactor: Movement cross/uncross implementation.
* wrong var name
* fix unit tests dropping PDAs into nowhere
* Add documentation.
* remove unused constants
* say which procs are off limits
* fix simpleanimal z change runtime
* helps not to leave merge conflicts
* kill me
* fix typecast
* fix projectile/table collision
* treadmills don't cause MC to crash anymore
* connect_loc is appropriate here
* fix windoors and teleporters
* fix bonfires and clarify docs
* fix proximity sensors
Tested with sensors in crates, sensors in modsuits
Tested new proximity component with firing projectiles at singularity
Tested new proximity component with portable flashes
Tested new proximity component with facehuggers
* lint
* fix: polarized access helper false positives
* Revert "fix: polarized access helper false positives"
This reverts commit 9814f98cf6.
* hopefully the right change for mindflayer steam
* Changes following cameras
* fix glass table collision
* appears to fix doorspam
* fix ore bags not picking up ore
* fix signatures of /Exited
* remove debug log
* remove duplicate signal registrar
* fix emptying bags into locations
* I don't trust these nested Move calls
* use connect_loc for upgraded resonator fields
* use moveToNullspace
* fix spiderweb crossing
* fix pass checking for windows from a tile off
* fix bluespace closet/transparency issues
* fix mechs not interacting with doors and probably other things
* fix debug
* fix telepete
* add some docs
* stop trying to shoehorn prox monitor into cards
* I should make sure things build
* kill override signal warning
* undef signal
* not many prox monitors survive going off like this
* small fixes to storage
* make moving wormholes respect signals
* use correct signals for pulse demon
* fix pulse heart too
* fix smoke signals
* may have fucked singulo projectile swerve
* fix singulo projectile arcing
* remove duplicate define
* just look at it
* hopefully last cleanups of incorrect signal usage
* fix squeaking
* may god have mercy on my soul
* Apply suggestions from code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* lewc review
* Apply suggestions from code review
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* burza review
* fix bad args for grenade assemblies
* Update code/__DEFINES/is_helpers.dm
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
---------
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <daan.lyklema@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* Remove a lot of CSS and make boxed message stylish
* Paint themed boxed message and sort light chat styles
* Remove copyright from chat spans
* Uh oh
* ebent
* WHYYY
* bobobo
* adds ton of epic stuff
* messages added
* Outfit!
* Indentation! Arrhghg
* Gamemode checks, antag check stuff and outfit changes and tourist icon
* ID icon, random species, gender, hair, a few comments and logs.
* Mirroring review
* Applies suggestion
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Signed-off-by: Pedro <79126660+LetXxx@users.noreply.github.com>
* Tourist Id's now have linked accounts, code cleaning as per reviews
* Following suggestion
* Apply suggestions as per review
* Addresses the risk of two people having the same account
* Typos and final cleaning
* Checking for jobban/Not showing as tourist on manifest
* Orbit test
* compile
* ebent
* WHYYY
* bobobo
* adds ton of epic stuff
* messages added
* Outfit!
* Indentation! Arrhghg
* Gamemode checks, antag check stuff and outfit changes and tourist icon
* ID icon, random species, gender, hair, a few comments and logs.
* Mirroring review
* Tourist Id's now have linked accounts, code cleaning as per reviews
* Applies suggestion
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Signed-off-by: Pedro <79126660+LetXxx@users.noreply.github.com>
* Following suggestion
* Apply suggestions as per review
* Addresses the risk of two people having the same account
* Typos and final cleaning
* Checking for jobban/Not showing as tourist on manifest
* Orbit test
* TGUI Bundle Rebuild
* Applies suggestions
---------
Signed-off-by: Pedro <79126660+LetXxx@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
* Retrofit TG pathfinder with upstream improvements
* i know how things work
* don't use HAS_TRAIT for things that aren't traits
* unique filenames
* i'm just a goofy lil moron
* use new block syntax
* apparently values don't need clamping with new block syntax?
* silence invalid JPS dest runtime
* fix runtime passing ID instead of access list
* same taste, twice the speed
* pulls proc/handle_ricochet() to the atom level. adds var/flags_ricochet and related defines.
* space indentation sneaks its way in yet again
---------
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* LINDA -> MILLA
* Tiles now change their atmos mode properly.
* Fixed a bug that made walls generate supercold air when deconstructed/destroyed.
* Apply suggestions from code review
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>
* Begone, var!
* MILLA -> milla
* Lint.
* More lint.
* Prevent negative/NaN atmos from spreading.
* Made fires start more reliably.
* Undef what the rest should not see.
* Enums are nice.
* Match LINDA better.
* Debugging verbs.
* Debug verb fixes.
* Labelled more lavaland stuff with ATMOS_MODE_LAVALAND
* Block superconductivity on a couple more things for Lavaland.
* Updated milla.dll
* Lavaland map fixes.
* Missed a spot.
* Begone, var! (again)
* Add libmilla_ci.so for continuous integration tests.
* Install/contributing instructions for MILLA.
* Directional plasmaglass windows on shuttles shouldn't stop protecting from heat after moving.
* Banish bad naming.
* Better naming and debug stats for SSair.
* Apply suggestions from code review
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>
* Magic numbers and formatting.
* Don't screw up the temperature during reactions.
* Efficiency and readability.
* Fix hotspots.
* Removed redundant safety (MILLA will already output an error)
* Optimizations.
* oops
* TGS build script update.
* Change API of gas_mixture and how you get one from a turf.
* Get in there.
* so many vars
* MILLA binary updates.
* Lint
* Made MT cost more honest.
* Gave MILLA a read-only mode.
* More read-only vs synchronized mode work.
* Even more.
* Synchronize disposals.
* Updated a bunch of stuff to use SSair.synchronize or GM.synchronize.
* MILLA <3 Tracy
* lint
* cargo fmt
* more lint
* Test needed MILLA sync.
* Silence atmos machinery that's behaving as intended, but continue objecting to other potential failures to synchronize.
* Push new MILLA DLL
* Build MILLA
* Update PR instructions for MILLA.
* Add some fancy plasmaglass windows to the Lifebringers' ship.
* The golems remembered that they should insulate *all* their engines.
* First round of TM bugfixes.
* Build MILLA
* fix two lavaland ruin turf types
* bunch more maps
* fixes milla ci and makes the interesting turf verb better
* Solid turfs can no longer conduct heat (for now...)
* Made indoor tiles in beach and winter biodomes not lavaland air.
* Re-added random IT teleport, adjusted warning message
* Fixed a tinted window on Lavaland to be a plasglass window instead.
* Made firelocks and holofans heatproof
* Made RPD auto-wrench pipes if you have a wrench in your offhand.
* Runtime fixes.
* Made visuals update more reliably.
* Lint
* Update .github/CONTRIBUTING.md
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>
* Build MILLA
* The Syndicate have installed tiny fans on their research base.
* The syndicate have figured out how to make plastitanium windows heatproof.
* This is getting out of hand. Now there are two of them.
* Un-break the auto-wrenching that I broke before committing.
* Build MILLA
* Build MILLA
* Massive MILLA refactor, assorted bugfixes.
* Build MILLA
* Explicit typing.
* Less sleeping/blocking.
* Build MILLA
* Yes, yes, this part can sleep.
* Build MILLA
* SSair reporting improvements.
* Build MILLA
* Please do not dock twice and splat yourself.
* Build MILLA
* Pls to not make SM go nuts.
* Build MILLA
* Build MILLA
* Added stricter lower bounds on plasmafire, fixing perpetually-burning SM.
* Build MILLA
* Lint
* Temporary logging, begone.
* Build MILLA
* Prevent hotspot strobing.
* Add in radiate_to_spess behavior.
* Build MILLA
* progress
* Compiling is good.
* bugfixes
* Progress.
* Ruins update.
* This one exists.
* Fixup temporary hotspots to last longer than one tick.
* Add/fix comments.
* Cut the slash.
* Fix test.
* No sleep for you.
* Build MILLA
* Prevent nested MILLA safety from runtiming.
* Build MILLA
* Runtime fix.
* Build MILLA
* Fix canisters not updating icon when gas contents change.
* Build MILLA
* Build MILLA
* Fixed an issue that made mechs very cold on environment air.
* Build MILLA
* oops
* Build MILLA
* Walls can make loud noises again.
* Build MILLA
* Fixes a rare runtime.
* Build MILLA
* Update .github/DOWNLOADING.md
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>
* Review suggestions
* Lint
* Build MILLA
* bound_mixtures now only contains mixtures that can be written
* Build MILLA
* Apply suggestions from code review
Co-authored-by: Matt <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>
* Build MILLA
* Restore the original async behavior of pyro anomalies.
* Build MILLA
* Build MILLA
* Make the safety assertion in /datum/milla_safe safer.
* Build MILLA
---------
Signed-off-by: Charlie Nolan <funnyman3595@gmail.com>
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Co-authored-by: paradisess13[bot] <165046124+paradisess13[bot]@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: GDN <Roanrichards1@Gmail.com>
* Removes blobs from the ticker if the core is destroyed, truncates counter
* Removes the mind instead of the camera mob
---------
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
* Diverse Traders Types
* Trader Type control, announcements, species spawning
* Trader Outfits
* Posh Moth - Posh Cane
* Landmarks, Trader ID Name Change
* Trader Shuttle Adjustment - Landmarks for Item Pools
* Outfit Survival Kit changes
* Added another refill for the hand labeler due to more cargo
* Trader Shuttle locker fix
* Item Stocks, Item Stock Assignments, Box Kits, Love Bottle
* Mech access, No double mechs, Small box fix
* Removed Solgov Gunkit from General Pool
* Spacing
* Moved traders to not be event subtypes, added documentation to vars
* Boxed spacing, removed improper
* Moved postequip, used box variables
* Lore team requested change - Bolt action instead of AK
* Changed landmark
* Moved soviet ammo to minor gear, increased soviet minor gear to 8.
* Obfuscated Cybersun
* Lootpool Adjustments
* Readded Solgov Kit to general pool at low weight
* Commas!
* Spelling
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
* Comments
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
* Re-Nulled After_Equip_Job
* Removed extraneous var spaces
* Relocated space in trader introduction message
* Robomoon is now once again Cybersun
* Impropered Enforcer Kit
* No more ERT box for non-NT boxes
* Fixed turbine kit stock part amount
* Subtyped skrell/unathi suit boxes
* Replaced meson cyber eye (nodrop issue) with meson sunglasses/gar mesons
* Reduced weight on arm/esword implant rare items
* Also reduced arm laser weight
* Added a couple items to skipjack large - more 'random', filled in reduced weights
* Path typo fix
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
* Removed trailing / in path
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
* Removed Cheap Breacher suit from inventory
* Apply suggestions from code review
Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
---------
Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* Globals work
* Double access works
* All other things
* Revert "All other things"
This reverts commit 6574442eb6.
* More changes that compile and work
* IT WORKS AAAAAA
* Changes even more .len to length()
* Apply suggestions from code review
* Update code/datums/mind.dm
* Update code/__HELPERS/sorts/InsertSort.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Update code/__HELPERS/sanitize_values.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
---------
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* part 1
* these also
* fuckin nuke it
* more
* more stuff
* more crap
* wow
* holy fucking shit, it works
* thats a start
* oops
* fubing bundle
* hahah brrrrr
* I LITERALLY ADDED IT BACK, FUCK OFF GIT
* yeah more changes
* hide abstract
* blamo
* thats enough for today
* old code begone
* goodbye can_strip
* nearly there
* finally
* fuckin finally
* review
* tgui
* unbreak shit
* fix OD
* okay, that should fix the last thing
* remove hover on nodrop, fix early interacting