Commit Graph

26743 Commits

Author SHA1 Message Date
GDN 19a3f768c8 into the bin (#24289) 2024-03-07 11:04:57 +00:00
Deniz aa5d68bf38 MULEBOT AI CALL Fix (#24479)
* test

* I hate mulebot

* no need to change this apparently

* INVOKE Begone, no change noticed
2024-03-07 11:03:36 +00:00
CRUNCH 3798688096 DISHONOURABLE DEMOTION! (#24283) 2024-03-07 09:34:24 +00:00
CRUNCH d0d3d30d83 Makes the crowbars of non-construction borgs red (#24281)
* Gives non-engiborgs red crowbars

* Update code/game/objects/items/tools/crowbar.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/game/objects/items/tools/crowbar.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-07 09:33:08 +00:00
Deniz ce7c7f9885 Yet another Bot refactor. 2.0 (#23900)
* test 1

claim_job
comment spaces

start

* yay, its BROKE

* Update bot.dm

* alcohol is the only escape

* static

* it works

* spacing

* cleanbot list cleanup

* comments

* space AREA

This is what insanity looks like.

Every bot PR breaks something, without fail.

fixed replace tiles? broke hull breach
fixed hullbreach? broke cleanbots
fixed hullbreach? well also broke it

* Comment Sorting

* comments 2/2

* comments 3/?

* comments 4/?

* autodoc 1/?

* maketile doesnt drop

* maketile update

* floor - snake_case + if else

* Floor - comments

* floor - snake_case 2/?

* cleanbot turf reservation comment

* floorbot ignore list

* comments

* var/atom/A

* target check. null runtime

* tile clean comment removal

* again

* reviews. final_result removal

* comment block

* avoid bot TRUE

* comments ?/?

I lost track of how manny comment commits there are

* autodocs

* autodoc

* autodocs

* ignore_job -= target.UID() additions

* anchored

Noticed that, if a tile is in space, they will dance around it as they do not anchor. Now they do

* runtime fix

* ignore_job edits. clean after 30

* typo

* fix before replace, DUH

* ignore job clearing

* Time Dilation 106% no more

* eat tile fix, oops

* replace plating

* comment shift

* lets try again

* mode !

* process_type = null + to_chat cleanup + ignore_job bot_reset

* remove extra ignore_job

* target.loc

* TRUE

* ignore job and revert loc

* move speed and such

* comment with proc

* God I hate myself

* TRUE / FALSE

* comments :)

* else if

* pesky comment

* mods are asleep, rename the vars

* small edits

* Make ignore_job culling based on amount of bots alive. 1 job per bot

* Revert move speed changes. Bots move slower than security on cere

* Emag fixes oof

* ++

* + 1?

* ++

* comment

* dropped metal amount

* paranthesis

* no need for absolute

* Thanks VSC conflict resolver for duplicating this here

* Emag is a bool now, self remind comment removed

* Documentation

* move speed null nulled

* replace_tile lag / freeze fix + removed extra job stuff

* clarification about which list is being used in comment
2024-03-06 15:05:39 +00:00
HMBGERDO adc58d9302 *deathgasp (#24403) 2024-03-06 14:40:44 +00:00
Aylong 2e61b6c51f Refresh TGUI blank window fix (#24392)
* Refresh TGUI blank window fix

* Whoopsie

* Separate things
2024-03-06 14:37:50 +00:00
Rerik007 6805e816a4 fix bot emag in ion storm (#24424) 2024-03-06 14:36:50 +00:00
Charlie Nolan df8e93b432 Fixed lastproduce initialization for grass. (#24339) 2024-03-06 14:32:30 +00:00
Charlie Nolan d6f7046e2e Borgs without a client can be reset now (#24466) 2024-03-06 14:31:01 +00:00
GDN 00c0f22788 fixes deleted cultists still being considered cultists (#24336) 2024-03-06 14:28:18 +00:00
Adrer 980af06a6b HUD is now updated properly when mob goes invisible. (#24332)
Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
2024-03-06 14:27:31 +00:00
Qwertytoforty d7c7cacc52 Adds The Qani-Laaca Sensory Computer and mephedrone. Ready for review into merge (#23926)
* Surely this will not have any critical balance implications

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* oops

* marm fixes

* fixes signal

* how on earth did I do that

* adds twitch to nanocalcium

* respect armor, lowers throw

* IPC can use, fuck up heartless people

* no crawl slowdown / meth

* *slightly* turns down the drug effect

* renames it will deal with pr desc soon

* finishes it

* rnd version empable

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Nerfs twitches visuals, due to a reported novastation bug where the visuals would endlessly stack

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* C-C-C-Changes

* Epilepsy Warning: Drug has vibrant visual effects!

* safety

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* removes twitch name, make mix explode

* oops

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-06 13:25:38 +00:00
YoursTrulyHollow e43fb1ce34 fixes the error where chicks lose their custom name when growing into chickens (#24409)
* fixes chicks

* Update code/modules/mob/living/simple_animal/friendly/farm_animals.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/friendly/farm_animals.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-03-06 13:22:35 +00:00
Adrer 473e673908 [s] Fixes a modsuit exploit (#24420)
* Destroy pins when duplicate

* Update code/modules/mod/modules/_modules.dm

* Update code/modules/mod/modules/_modules.dm

* Replaced with Qdel

---------

Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-03 22:19:32 -05:00
Charlie Nolan 7ae3bf6747 Stop using \improper improperly. (#24410) 2024-03-03 18:04:52 +00:00
GDN d6e34816e1 Deletes some unused vars (#24381) 2024-03-03 17:50:52 +00:00
warriorstar-orion 3d09c6d293 make no_lava mapping helper visible above rock walls (#24386) 2024-03-03 17:50:36 +00:00
Charlie Nolan f7e63f0460 Remove account login from eftpos. (#24397) 2024-03-03 17:49:10 +00:00
Charlie Nolan 8677559b97 Made sleepy pens awake enough to react. (#24401) 2024-03-03 17:48:48 +00:00
Contrabang 87a318a7de Refactors screen objects to /atom/movable (#24068)
* introduce helper + remove unused proc

* we love compatibility

* Update code/_onclick/hud/action_button.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/action_button.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/alert.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/blob_overmind.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/blob_overmind.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/blob_overmind.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/martial_arts/martial.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mining/lavaland/loot/tendril_loot.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/shadow.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/shadow.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/living/living_update_status.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/screen_objects.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/screen_objects.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/screen_objects.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/objects/items/weapons/storage/internal.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/machinery/computer/camera_advanced.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/machinery/computer/camera_advanced.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/objects/items/weapons/storage/internal.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/mecha/mecha.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* deconflict

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-03-03 17:37:51 +00:00
BiancaWilkson cc433a3794 Fixes an exploit with robobrains (#24394)
* this hurts me more than it hurts you

* me when istype
2024-03-02 22:43:22 +00:00
GDN 3102e151bf makes last resort work (#24387)
* makes last resort work

* Update code/modules/antagonists/changeling/powers/become_headslug.dm

---------

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-02 15:34:24 +00:00
Arthri 8844a2ab97 Removes Toxin Damage from Drinking Blood in Virus Culture Bottles (#23968)
* Make spawned_disease use O-

* Change type to Vh Null

* Make Vh Null not update blood_volume

* Make Vh Null not feed vampires

* Move string to define

* Update code/__DEFINES/reagents_defines.dm

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

---------

Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
2024-03-01 23:34:09 +00:00
DGamerL 3792a0f6c7 FINALLY (#24353) 2024-03-01 20:17:34 +00:00
Luc 06f89243f3 Spectral blade now shows orbs, not ghosts (#24124)
* Implements

* yeah I meant to do this

* this should probably be safer

* alpha

* Add some contingencies

* Update code/modules/mining/lavaland/loot/tendril_loot.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-01 20:07:19 +00:00
warriorstar-orion 0667f20681 move all EOL comments on typepath names to dmdoc (#23928)
* move all EOL comments on typepath names to dmdoc

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

---------

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-01 20:05:49 +00:00
HMBGERDO 25996e232a Pepper Spray update (#24033)
* pepper spray update

* Update code/datums/status_effects/debuffs.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Update code/modules/reagents/chemistry/reagents/food_reagents.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Update code/modules/reagents/chemistry/reagents/food_reagents.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Update code/modules/reagents/chemistry/reagents/food_reagents.dm

* Rurik review

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-01 19:56:03 +00:00
Pierre-Louis 52efa8eac5 Add coordinate janicart pda (#23489)
* Add janicart coordinates to the Janitor PDA

* Compiled the new TGUI

* TGUI update

* TGUI update

* Space for indent is the evil

* Update code/modules/pda/cart_apps.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Update code/modules/pda/cart_apps.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Update code/modules/pda/cart_apps.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Update code/modules/vehicle/janivehicle.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Update tgui/packages/tgui/interfaces/pda/pda_janitor.js

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Update code/modules/pda/cart_apps.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Update tgui/packages/tgui/interfaces/pda/pda_janitor.js

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Update tgui/packages/tgui/interfaces/pda/pda_janitor.js

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Update code/modules/pda/cart_apps.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* TGUI update

---------

Co-authored-by: Pierre-Louis <hernandezpierrelouis@protonmail.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-01 19:46:58 +00:00
warriorstar-orion e1614b9ecb Add DMI/JSON export to local client admins. (#23947)
* Add DMI/JSON export to local client admins.

* switch to log_world, add if paren
2024-03-01 13:59:56 +00:00
warriorstar-orion 43b3bb0e44 forbid in-DMI icon state name dupes with CI (#22734)
* forbid in-DMI icon state name dupes with CI

* remove final icon dupes

* use shodancoat item_state
2024-03-01 13:12:21 +00:00
Octus 805d6acb71 Sleight of Hand, a Bartender Ability (#23234)
* the start

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* pain

* ITS STILL A WIP

* dones

* Apply suggestions from code review

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* oh god, this was just a draft, it should be part of the PR

* we dont need this anymore either

* sirrayan request

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* DGL's review

* more of DLG's review

* removes bar judo

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-01 13:10:53 +00:00
HMBGERDO 9101bb588e Headslug for everyone + Headslug once per absorb + Cling abilities offline after reviving (#23992)
* nerf nerf nerf nerf

* cooldown time

* rechargable headslug

* Update code/modules/antagonists/changeling/powers/absorb.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Update code/modules/antagonists/changeling/powers/become_headslug.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

---------

Co-authored-by: matttheficus <mickusmatthew@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-01 12:59:59 +00:00
PopeDaveThe3th 7c0ce05aae Adds names and descriptions to most bullets and ammo boxes (#24363)
* Adds names and descriptions to most bullets

* Update code/modules/projectiles/ammunition/ammo_boxes.dm

Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>

* Update ammo_boxes.dm

Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>

* desc updates

* word changes

* Update ammo_casings.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update ammo_casings.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-01 12:49:23 +00:00
GDN 5e79ae0f69 fixes xenos being nullspaced in rare situations (#24362) 2024-03-01 12:48:49 +00:00
DGamerL 900d19369b Quick and easy replacing (#24352) 2024-03-01 12:47:07 +00:00
Contrabang 47d294aa22 booyah (#24344) 2024-03-01 12:45:37 +00:00
Kyani a0a8562dd7 Makes Weeping Angel Conversion Clearer (#24279)
* Update magic_projectiles.dm

* Update magic_projectiles.dm

actually changed the description to say to kill people

* rewords the transformation message

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Removes unnecessary centering

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Removes ALL the center tags

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-03-01 12:40:24 +00:00
cybercapitalism 16127be106 Photos can be burnt with hot items (#24257)
* burnphoto() now checks for get_heat() instead of requiring lighter

* fuck

* ebba and cinnamon review

* de morgan's law strikes yet again

* switch doafter timer to use seconds constant

* git gui was a mistake and you can't change my mind

* Update code/modules/paperwork/photography.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* lewc review

* craaaawling iiiin my skiiiiin

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-01 12:39:17 +00:00
Marm 1f3e991b2a Smoke Grenade Module + Blob Buff (#24224)
* is good for you

* DESCRIPTION

* fix

* Update code/modules/mod/modules/modules_security.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-01 12:38:09 +00:00
Marm f016100149 But what if I don't want to kill people? Disabler SMG Port. (#24107)
* i joined the force to help people

* disabler i hardly know her

* Update code/modules/projectiles/ammunition/energy_lens.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* oops

* Update code/__DEFINES/lighting_defines.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Update code/modules/projectiles/guns/energy/stun.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Update code/modules/projectiles/guns/energy/stun.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Update code/modules/projectiles/guns/energy/stun.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Update code/modules/projectiles/guns/energy/stun.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/projectiles/guns/energy/stun.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-01 12:03:26 +00:00
Nathan Winters da34941fae Minor pill/patch application refactor (#23958)
* Refactor pill/patch application

* I will come back to this
2024-03-01 11:39:25 +00:00
DGamerL f5da54ba15 Easy (#24351) 2024-02-28 21:08:00 +00:00
cybercapitalism a280b87103 Fixes #24198 (#24357)
* make reinforcing grab only check if mob is restrained

* restrained was false advertising
2024-02-28 21:07:22 +00:00
Contrabang 491407cea8 Adds a helper for running unit tests locally (#24269)
* adds a helper for running unit tests locally

* warning error

* okay it should be ready

* this shouldnt be here
2024-02-27 18:29:24 -05:00
GDN b7a88c6da4 fixes #24313 (#24315) 2024-02-27 18:27:27 -05:00
DGamerL 5d79d45279 Buffs Carpfu (#24120)
* Now just test

* Testing was necessary, should work now

* Update code/modules/mob/living/carbon/human/human_defense.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Fixes bolas not working

* Nullchecks

* Moar nullchecks

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-02-27 18:25:59 -05:00
Adrer 45ab7264c5 Galoshes no longer runtime when dispensed from a vendor. (#24170)
* Galoshes no longer runtime when dispensed from a vendor.

* Replaced with guard clause.

* I am going to

* Turn into the joker.

* Removed inconsistent indentation

---------

Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
2024-02-27 18:24:07 -05:00
Qwertytoforty 6910d716dd Adds the modsuit Chameleon Module (#23411)
* Adds the modsuit Chameleon Module

* Update code/datums/uplink_items/uplink_general.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/datums/uplink_items/uplink_general.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* even clearer

* Update code/datums/uplink_items/uplink_general.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-02-27 18:17:34 -05:00
Mikhail Dzianishchyts 112a606ae2 Allow an empty string when editing records, flavors, OOC notes (#24316) 2024-02-27 18:12:09 -05:00