Commit Graph

4426 Commits

Author SHA1 Message Date
DGamerL
de1229b947 Removes various helpers that can be simplified in a single variable check (#24551)
* Removes the first weird helper

* Removes get_turf_or_move

* Slightly alters the sharp weapon proc

* Adds nullcheck to adjustBruteLossByPart

* Changes `is_dead`

* Adds `hasorgans` to the replaced list

* Update code/__HELPERS/unsorted.dm

Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>

* Contra review

---------

Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
2024-03-25 01:31:56 +00:00
chuga-git
19c0b70171 Slightly refactors storage item insertion (#24429)
* everything is on fire

* silent trait check

* how did it even become CRLF

* minor formatting

* fix icon updating and adds silent insertion to global trait list

* adds the new parameter to documentation - whoops!

* pain

* contra review

* contra review again, reduces amount of checks for user in the loops

---------

Co-authored-by: cybercapitalism <98280110+cybercapitalism@users.noreply.github.com>
2024-03-24 18:41:07 +00:00
Luc
1fe7819c1b Ports action button refactor from /tg/ (#24482)
* add the new stuff

* guh

* add the brunt of it

* action button stuff

* adds a lot of other stuff

* careful find and replace

* it loads

* so many huds

* ehh yeah this kinda works

* fixes this runtime

* hacks in some DMI stuff, we'll fix it later

* Adds better mouse pointer for dragging buttons

* gets dragging into place working again, updates DMI

* moves define

* remove extra hud defines, now it compiles

* CHECK GREP

* owww

* rename action defines

* ticks

* are we good

* let's try that again

* renames mob vars

* renames

* fixes some hud issues with huds getting the wrong variable

* fixes some alignment issues

* Adds mouse-wheel scroll support

* left -> right

* I am the entire circus

* first self-review pass

* Another review pass -- just realized I need to fix keybinds

* more testing

* update icons

* oops

* Fix spell icons not appearing properly

* fixes some outstanding issues
- Action button backgrounds now work properly
- Fixes some runtimes on dropping
- Fixes some misplaced icons

* hmm

* weh

* again?

* nah?

* maybe this?

* asdf

* should finally fix CI

* add client check

* move the ?

* add missing override causing runtimes

* shift-clicking now doesn't trigger the button

* better docs
2024-03-24 17:38:53 +00:00
Contrabang
323d23acc9 Datumizes Wizards (#24702)
* fucking wizards

* this too

* this

* i think thats it

* okay lets do this

* remove commented code

* gdn review

* welp

* fix runtime

* yes

* lewc review
2024-03-21 20:56:55 +00:00
warriorstar-orion
35ca57c262 Add constructible transit tubes. (#24045)
* Add constructible transit tubes.

* Apply suggestions from code review

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* change construction type, add icon state

* don't give any glass back, support RPD recycling

* destroy/explode into glass decals

* Update code/game/objects/structures/transit_tubes/transit_tube_construction.dm

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* tube automatic orientation is unintuitive

* support manual flip/rotate like pipes

* better logic for installation

* better support for building in space

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* second half of review suggestions

* Update code/game/objects/structures/transit_tubes/transit_tube_construction.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

---------

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-21 19:27:07 +00:00
PopGamer46
d6a48deac3 Adds virology goals! Something for the viro to do (Ready for review) (#23408)
* virus analyzer and WIP virology goals

* bug fixes but not all

* tgui update

* fixed bug

* runtime fix

* small fix

* misc

* virology goals not showing required symptoms fix

* virus analyzer code polish + animation tweak

* removes virus analyzer + tweaks

* adds the health analyzer back

* code polish

* comment edit

* oops, this time resolves merge conflicts

* bigger payout and more goals upon completion

* adds the until now unused vial lockbox

* more code tweaks

* also code tweaks

* yet another code polish

* merge conflict resolve

* virology job_objective

* merge conflict resolve

* grammar

* code polish

* another polish

* forgot these

* oops, how did i do this mapping error

* some but not all code polish and moves vials to fridge because i forgot on map queue, sorry

* finally merging some of the requested changes

* forgot this

* one reguested change left

* merges last reguested change

* failed check asks to rebuild tgui

* most of the reviews

* removes lazyremove, no idea why i used it there

* reviews

* grammar

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* more reviews

* forgot to undef

* deletes old tgui file

* Contrabang reviews

* some of DGamerL´s reviews

* oops

* DGamerL´s reviews

* Update tgui.bundle.js

* stealth virus virology goal now requires 4 symptoms instead of 5

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2024-03-21 16:23:08 +00:00
Qwertytoforty
0d27af414c Adds the Organ Extractor (#24100)
* Adds the Syndicate Organ Extractor

* ipc moment

* fix bug, prevents putting organs in dead bodies to extract

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* renames sprite

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* replace xx yy

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-20 20:10:53 +00:00
Henri215
ec90b441ad Moves weapons sprites out of items.dmi (#24634)
* Moves weapons sprites out of items.dmi

* lets revert this

* oversight from energy melee PR
2024-03-19 17:08:35 +00:00
Charlie Nolan
e0c335e998 Cigar/pipe cleanup. (#24683) 2024-03-19 10:49:06 +00:00
Marm
fdef20cc9e Adds Meson Sunglasses (#24619)
* meson sunglasses

* species sprites ew

* why

* Update code/modules/clothing/glasses/glasses.dm

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>

* eeh

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply suggestions from code review

Self commit time (With approval)

---------

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-18 17:54:24 +00:00
Contrabang
9b24572ed5 Updates OpenDream pragma file (#24516)
* hell yeah-coded

* welp im too tired to fix this one

* lets test this

* Revert "lets test this"

* okay, lets test!

* fixes

* okay we good?

* i might be stupid
2024-03-17 11:56:56 +00:00
Contrabang
2ec55dbfbb Datumizes Cult. (#24379)
* cult 1

* massive data refactor

* progress

* More crap

* IM SCARED IT COMPILES

* oops

* more fixes

* good comment

* hell yeah, team control

* lol

* blamo

* blam

* More stuff

* team refactor

* epic merge fail

* src not _src_

* more

* progress

* cult

* more stuff

* water

* goodbye __IMPLIED_TYPE__

* time to undraft

* FUCK FUCK FUCK

* okay this is better

* goodbye todos

* fix

* order of operations

* last fix? maybe

* yeah

* oops

* okay this should be ALL the fixes

* wow

* hell yeah

* wow

* fixes duplicate teams + adds more team safeties

* how the fuck did this happen

* admin objective improvements

* wah more bullshit

* guh

* fuuuuck

* fucking hell

* fixes
2024-03-16 20:36:55 +00:00
JimKil3
0c25bf4a21 Cloning Rework (#21683)
* guts the cloning pod

* guts cloning console (except the tgui)

* clonescanner, more gutting, linkage

* reagent stuff

* `cloning_data` datum

* scanner inserting/removing

* scanning logic

* auto-linkage

* `get_cloning_cost()` in its entirety

* logic for which limbs to grow

* RefreshParts() and insert_organ()

* removes misinformation

* robot parts

* more organ insertion logic

* more organ code :D

* create_clone

* beginnings of clone logic

* cloning addl. stuff

* cloning finalization

* fixes CI?

* whitespace fixes (regex edition)

* ejection logic

* Update code/game/machinery/clonepod.dm

Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>

* stuff

* stuff 2

* update_icon_state stuff

* clonepod TGUI

* organ fix yipee

* cloning console UI beginnings

* cloning console main menu

* reagents stuff

* beginning of damage tab

* damages menu skeleton

* aiuhgugh

* splits up code

* ejecting patient updates ui

* contra reviews

* temp fix for CI

* tgui finished? (clueless)

* Cloning :D
it's done

* manual & tweaks

* more feedback!

* cooldown
because you can spam the fuck out if it otherwise and it's really loud for the ghost

* oops

* tweaks

* edits EVERY MAP OH GOD

* no link stuff

* oops

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Apply suggestions from code review (pt. 2)

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/machinery/computer/cloning.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* dgamer review

* Update code/game/machinery/clonepod.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* henri stuff

* makes it compile

* builds tgui (oops)

* rebuilt bundle i guess?

* not stale i swear

* fixes

* whoops

* countdown stuff

* sirryan review pt. 1

* sirryan review pt 2

* every day i'm shuffling (or something idk)

* wasdfhdfg

* sean clonepod.dm changes

* update_icon(UPDATE_ICON_STATE)

* Update code/game/machinery/clonescanner.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* icon stuff

* map weirdness

* henri disks

* unfucks maps?

* cc maps

* eject button

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* Update code/game/machinery/clonepod.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* dgamer review 2

* ourgh

* dgamer review 3

* waaaah

* fixes access locks

* fixes
Fixes the numbers issues (and no feet hopefully?)

* re-adds feet

* more fixes yipee

* un-biomass

* fixes ghost stuff

* exploit fix

---------

Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-16 16:51:13 +00:00
Marm
b703a52294 Alters Command access to include weapons permits + Telebatons are now weapons (#24621)
* beepsy nooo

* Update code/game/objects/items/weapons/batons.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/game/objects/items/weapons/batons.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-16 16:14:43 +00:00
CRUNCH
06f4662aa5 Resprites, renames, and redescribes aloe and comfrey poultices. Also adds sounds to the aloe poultice. (#24396)
* Update items.dmi

* Makes botany healing better

* New new sprites

* Made medical.dmi

Made medical.dmi, moved icons there, deleted them from items.dmi. Made sure that affected items pointed to the correct place.

* update

* h

* Update items.dmi

* These shouldn't be here

I don't know what these are or why these are here

* Update medical.dmi
2024-03-14 18:46:45 +00:00
PopGamer46
729dc56965 Fixes the nanobank tgui input window not being able to accept pin codes above 10000 (#24576)
* make max_value actually fit pin code

* iam officially blind

* fixes the same issue with setting the money account on a agent id
2024-03-14 18:37:31 +00:00
Marm
ad74916094 woops (#24620) 2024-03-14 18:33:56 +00:00
Mikhail Dzianishchyts
7d57c53aed Don't check on adjacency until player is spawned (#24586) 2024-03-12 13:39:07 +00:00
Contrabang
073852c664 Adds more unit tests for improper cables (#24262)
* cablening + remove a duplicate proc

* okay compile im dumb

* oops

* okay im dumber than I thought

* lmao

* OKAY IT WORKS PROPERLY NOW

* lets test these maps to see if they pass

* maybe this works

* undo the testing

* unfuck map files

* unfuck shit maybe?

* PLEASE i think fucking merge hooks are fucking me

* okay goodbye merge hooks

* PLEASE
2024-03-12 13:33:26 +00:00
Henri215
1c41bbd4be Resprites brown and white fedora (#24334)
* Resprites brown and white fedora

* Update code/modules/clothing/head/misc_hats.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/clothing/head/misc_hats.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-12 11:42:13 +00:00
Contrabang
ae202e22b5 GOODBYE TECHDEBT (#24408) 2024-03-11 15:09:44 -04:00
GDN
5367656862 storage items no longer bring up the turf panel on alt-click (#24395)
* storage items no longer bring up the turf panel on alt-click

* these too
2024-03-11 15:08:02 -04:00
Christasmurf
03f66b19cc Quartermaster Drip (#24341)
* quartermasterdrip

* Update code/modules/clothing/head/job_hats.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-11 15:05:27 -04:00
Contrabang
3557748229 People are now hidden behind smoke (#24229)
* no, that is NOT solid snake

* lol

* more names

* Update code/game/objects/items/weapons/storage/boxes.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/game/objects/items/weapons/storage/belt.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-11 14:13:59 -04:00
Contrabang
e32544e599 #undef is now required for all file defines (#24091)
* CI

* undef

* hooooly crap

* yeah

* false by default

* fixes

* alright, there we go

* oops lmao

* lol, lmao even

* proper programming

* fix

* losin my mind

* oops

* yeah coloring

* WE LOVE MULTIPLE DEFINES (ive lost my sanity)
2024-03-11 14:03:30 -04:00
Marm
93d9c70530 Adds the Detective Holobarrier Projector + Chalk (#24400)
* just one more thing

* gosh that was embarassing

* Update code/game/objects/items/crayons.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Update code/game/objects/items/weapons/holosign_projector.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Update code/game/objects/items/weapons/holosign_projector.dm

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>

---------

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
2024-03-11 13:17:34 -04:00
larentoun
c5c911d252 [DOWNSTREAM] Cyrillic Support v2 (#24075)
* cyrillic fixes cbdad6f11f

* fix: remove control characters

* utf-8 support

* more fixes

* spellbook to utf8

* Update code/modules/research/server.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/research/server.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/paperwork/paper.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/paperwork/folders.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/mob_say_base.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* update formatting

* fix ai alerts

* fix spaceheater

* fix noticeboard

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-03-11 09:35:08 +00:00
Charlie Nolan
d5461d38c8 Improved storage UX of labcoats and similar. (#24404)
* Improved storage UX of labcoats and similar.

* Don't runtime when forceMove is called during initializtion.

* Update code/modules/clothing/suits/suit_storage.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Update code/modules/clothing/suits/suit_storage.dm

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* Update code/modules/clothing/suits/suit_storage.dm

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

---------

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
2024-03-10 20:20:09 +00:00
Contrabang
31c7628660 Updates get_edge_target_turf to work better with diagonals (#24154)
* my evil plan

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-10 20:08:38 +00:00
Daylight
0c942f8aef Multi-day code review required (#24468) 2024-03-10 18:20:20 +00:00
McRamon
046c841cab New plasmaman suit - Coke Suit (#24465)
* all done????

* no

* ave emperor

* aaaand last pixel adjsutment

* Update code/modules/client/preference/loadout/loadout_racial.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* box name

* Update code/game/objects/items/weapons/storage/boxes.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/client/preference/loadout/loadout_racial.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-10 18:19:55 +00:00
Charlie Nolan
36b202bd26 Standardize on exclaiming about committing suicide. (#24433)
* Standardize on exclaiming about committing suicide.

* Update code/game/objects/items/weapons/kitchen.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* I think this is the last of the unexciting suicides.

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-03-10 18:18:36 +00:00
Qwertytoforty
eb3884e689 The metroid bundle no longer has adrenals, has an emp proof emaged cybernetic heart (#24371)
* The metroid bundle no longer has adrenals, has an emp proof emaged cybernetic heart

* limit it's uses please
2024-03-10 18:03:13 +00:00
Charlie Nolan
20096f3592 [s] Make on_mob_movement work on all mob movement (#24491)
* Updated on_mob_move to be called on all mob movement.

* Call parent in mob/living/Moved
2024-03-07 17:55:06 +00:00
S34N
91660824fa Browser/TGUI Stat Panels (#24065)
* initial commit (broken)

* load the html

* fix this

* Fix various issues with browser statpanel

* Fix Alt Clicking opening up a window and Add back some object verbs to the browser stat panel

* Optimize stat panel and fix guardian verbs

* Restyles Stat Panel, Adds Subpanel Sub-Categories

* Use better layout for verbs in stat panel

* Updates statpanel verb widths to be more dynamic at higher screen resolutions.

* Adjust stat panel grid item widths and breakpoints

* refactors statpanel to use tgui API

* CI moment

* more CI

* this stupid thing

* Apply suggestions from code review

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/client/client_procs.dm

* ci fix

* emergency mc debug view

* temp revert some code change suggestions due to massive runtiming

* proper atom click topic implementation

* optimise

* mob clicking in stat panels work

* yeet spell tab thingy

* yeet simple stat panel pref

* allow insertion of html into MC tab content

* tidy up status tab

* Apply suggestions from code review

* fix this

* fix CI

* oops

* fix index runtime

* fixes MC tab showing up for mentors, fixes runtime

* safeties!

* Return of theme support

* more fixes

* fix view range pref, tidy prefs tab

* Remove old stat panel from themes

* fixes

* make sure verbs don't go missing

* fix ooc/looc breaking

* Revert "make sure verbs don't go missing"

This reverts commit 7d07ad45ed.

* fix this properly

* fix stat panel hitting rate limiters

* fix borg status tab

* Object Window Niceties

* Adds file cycling for icon2base64

* optimizes icon2html() for icon files known to be in the rsc at compile time

* CI moment

* remove dupe emergency shuttle timers

* more robust verb updates

* statpanel tweaks

* zip archived changelog to avoid search results

* optimise

* fix mentor chat wonkyness when disabled

* debug log moment

* i am very smart

* reintroduce this because it was needed

* better time listings

* less jank

* stops telling admins they arent mentors

* returns MC tab pref for admins

* Update code/controllers/subsystem/SSstatpanel.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* lewcc

* OD typemaker prep

---------

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Aylong <alexanderkitsa@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-07 10:31:36 -05:00
Qwertytoforty
d7c7cacc52 Adds The Qani-Laaca Sensory Computer and mephedrone. Ready for review into merge (#23926)
* Surely this will not have any critical balance implications

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* oops

* marm fixes

* fixes signal

* how on earth did I do that

* adds twitch to nanocalcium

* respect armor, lowers throw

* IPC can use, fuck up heartless people

* no crawl slowdown / meth

* *slightly* turns down the drug effect

* renames it will deal with pr desc soon

* finishes it

* rnd version empable

* Apply suggestions from code review

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Nerfs twitches visuals, due to a reported novastation bug where the visuals would endlessly stack

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* C-C-C-Changes

* Epilepsy Warning: Drug has vibrant visual effects!

* safety

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

* removes twitch name, make mix explode

* oops

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-06 13:25:38 +00:00
Contrabang
87a318a7de Refactors screen objects to /atom/movable (#24068)
* introduce helper + remove unused proc

* we love compatibility

* Update code/_onclick/hud/action_button.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/action_button.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/alert.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/blob_overmind.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/blob_overmind.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/blob_overmind.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/martial_arts/martial.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mining/lavaland/loot/tendril_loot.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/shadow.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species/shadow.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/modules/mob/living/living_update_status.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/screen_objects.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/screen_objects.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/_onclick/hud/screen_objects.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/objects/items/weapons/storage/internal.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/machinery/computer/camera_advanced.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/machinery/computer/camera_advanced.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/objects/items/weapons/storage/internal.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* Update code/game/mecha/mecha.dm

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>

* deconflict

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-03-03 17:37:51 +00:00
warriorstar-orion
0667f20681 move all EOL comments on typepath names to dmdoc (#23928)
* move all EOL comments on typepath names to dmdoc

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

---------

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-03-01 20:05:49 +00:00
Octus
805d6acb71 Sleight of Hand, a Bartender Ability (#23234)
* the start

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* pain

* ITS STILL A WIP

* dones

* Apply suggestions from code review

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* oh god, this was just a draft, it should be part of the PR

* we dont need this anymore either

* sirrayan request

* Update code/modules/projectiles/guns/projectile/revolver.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* DGL's review

* more of DLG's review

* removes bar judo

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
2024-03-01 13:10:53 +00:00
HMBGERDO
96e910ce6b a (#24295) 2024-03-01 12:41:57 +00:00
Marm
1f3e991b2a Smoke Grenade Module + Blob Buff (#24224)
* is good for you

* DESCRIPTION

* fix

* Update code/modules/mod/modules/modules_security.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-03-01 12:38:09 +00:00
Zack
f4447fc133 Update firstaid.dm (#24302) 2024-02-27 18:28:36 -05:00
Contrabang
0ee6ec3751 dropping dusters works right (#24330) 2024-02-27 17:26:02 -05:00
HMBGERDO
ba98eb4d16 Bots refactor (#23550)
* ugh... bots refactor

* everyone uses pathfind and eyes

* most hunt logic to proc

* Update code/modules/mob/living/simple_animal/bot/ed209bot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/ed209bot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Sirryan review

* Update code/modules/mob/living/simple_animal/bot/honkbot.dm

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>

* better var naming i guess?

* Update code/modules/mob/living/simple_animal/bot/ed209bot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/griefsky.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>

* review

* uh oh

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/bot/secbot.dm

Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>

* return FALSE

---------

Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
2024-02-21 23:01:48 +00:00
DGamerL
b11002b67b Fixes cigars being lightable by everything (#24235)
* Fixes cigars being lightable by everything

* Update code/game/objects/items/weapons/cigs.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

* Update code/game/objects/items/weapons/cigs.dm

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>

---------

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-02-21 09:04:59 +00:00
DGamerL
766704700e Refactors the atmos watertank backpack (#24177)
* Refactors the atmos watertank backpack

* Update code/game/objects/items/weapons/tanks/watertank.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/game/objects/items/weapons/tanks/watertank.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Adds spans

* Henri review

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
2024-02-19 19:07:11 +00:00
Henri215
3288816b0c claymore fix (#24221) 2024-02-19 14:48:59 +00:00
Aylong
ac5add482f [READY] TGUI Input Collection (#23891)
* List Input refresh

* Modal Alerts

* Text Input

* Number Input

* Split Button

* Renaming

* Alert converts

* Text Input Conversion (Part 1)

And TextArea Autofocus + maxLength

* Text Input Conversion (Part 2)

* AAAAAAAAAAAAAAAAAAAA

* I'm FUCKED

* @GDNgit review changes

* "&#39;" fixes

* Revert TGUI Alert from admin delete

* NumberInput Window size

* CRASH if empty list

* Update code/modules/tgui/tgui_input/list_input.dm

* TGUI Rebuild

* TGUI Rebuild

* Update code/modules/paperwork/faxmachine.dm

* _char

* compile

* Rebuild

---------

Co-authored-by: Aylong <69762909+Aylong220@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2024-02-19 11:55:01 +00:00
Marm
9d4e87eaac Nerfs Botany Maximum Yield + Plant Bags (#24122)
* we're so back not dying instantly bros

* it  came to me in a dream

* Update code/game/objects/items/weapons/storage/bags.dm

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-02-19 11:44:06 +00:00
warriorstar-orion
1f7c85511c remove 'game kit' deadcode object and icon (#24161) 2024-02-19 11:41:37 +00:00