Commit Graph

69 Commits

Author SHA1 Message Date
moxian
09e7f54a43 Convert most of /obj/machinery to use Initialize rather than New (#17845)
* Switch a bunch of /obj/machinery from /New to /Initialize

This is an easy and uncontroversial batch.
No globs, no late init, and stuff.

* Move more machinery to Initialize

This time the ones dealing with GLOB vars,
as well as some simpler ones i missed previously.

* More tricky New -> Initialize migrations

* The last of machinery Initialize conversion

* fixups

* Newscaster armor fix

* styling

* Comment on armor handling

* Move newscaster armor definition back to datum

* farie82 review

* kill extra .=

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

* farie's review part 2

Co-authored-by: Farie82 <farie82@users.noreply.github.com>

Co-authored-by: Farie82 <farie82@users.noreply.github.com>
2022-06-29 08:33:52 +02:00
S34N
705578b23b Energy detective revolver (#17771)
* Initial defines

* more work

* icon

* more stuff

* UID not hard ref

* tidying

* overload go brrt

* le sound and dead cell

* delet gap

* initial chargepack stuff

* simplify

* oops

* yeet this

* placeholder sprites

* oops magic number

* the gun speaks!

* consolidation

* tweaking and tidying

* so long old gun

* icon purge

* reapplies placeholder

* 1 minute tracker, not two

* makes it use a pinpointer

* revert tiny map changes

* cease your tracking, fool

* oops

* soft refs

* charlie review

* projectile ref to firing obj, removes testing overrides
& cleans up signals

* some more UID null checks

* ICONS

* ICONS CONFLICT

* MORE ICONS

* makes it freaking work

* first pass fixes

* charlie review

* charlie review 2, variable boogaloo

* fixes holsters

* colours the overcharged shot

* and recolours tracker to be yellow to match charge

* yellow laser icon

* widen overcharge misfire %

* fixes unlinkable pinpointers

* fixes gun not speaking when tcomms setup is changed

* steel request

* no chargey

* loudening 2022

* steel part 1

* Apply suggestions from code review

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* restores missing sprites

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-06-25 20:15:09 +01:00
Bm0n
11b3566ed7 Adapts TG's version of Metastation for Paradise (#17724)
* proof of concept

* proof of concept fix

* cargo/sec/dorms/engi

* service and sci framework

* floors

* sciwaypoint

* major departments done

* candidateV1

* haha die runtime

* and a zoning error

* feedback+minorpipenetrework

* compile now please

* abracadabra

* runtimefix

* Morgue + medmaint rework

* zooooones

* forgot to delete placeholder :)

* firealarm

* floors

* dmg turf on powernode bad

* missing pipe and rogue loot spawner

* tgs pipe layout sucks

* hallway repipe and bug fixes

* MISSING TILE

* IAA, maints, SM loop expanded, pipes reworked and bug fixes

* small flip

* reverts shuttlered2 icon change

* replaces offical posters with contraband in maints

* floating cameras are not good for health

* AI core tweaks and robo storage console added to robotics

* pipe over top of vent, airlock name changes and missing spawnpoint added

* a few very small detailing changes while I wait for review

* oh and I forgot to give EVA and the teleporter room a holopad lol

* missing pipe and tile fix

* Adds more airlock helpers + few bug fixes

* i love warning stripes

* or not

* lightswitches

* zoning error fixed

* little chem update

* and firelocks

* cam fix

* minor detailing

* another missing holopad and a date change to reflect paralore

* fixes as mentioned above

* a missing side rail

* removes a good chunck of floor decals and fixes docking port

* wall stuff cleanup

* decal removed

* and an airlock

* sec depart revamp

* shutterfix

* aa

* thanks for the feedback :). should be all resolved

* quick edit

* directional cryo consoles are based, thanks sean

* akward vent no more

* how the hell

* murders var edited open shutters, another detail pass, xenobio extended by 1 tile

* quarantine lockdown shutters

* uh oh

* it just works(bug fixes)

* we should be done here

* this shouldnt have an auto airlock namer

* now it should B)

* i actually forgot one lol

* aaaahhhhhHHHHHHHH

* turned biohazard pump off + removed one warning strip

* also some door fixes

* minor touchups around bar

* ack

* air alarm fix

* stray docking port removed

* floortile dir removed

* cryo pod support added to perma

* decals removed

* """deconflict"""

* nanomob BATTLE terminals (yes I am running out of things to add)

* uh oh thats the wrong y pixle shift

* conforms with armoury standardisations

* buffs aux armoury light

* fixes icon state on air injector

* sigh.. holopads

* put a lamp in the bomb test range because the camera light doesnt work on paracode, fixed a few other things

* switch lattice out for catwalk at turbine

* minor detailing changes

* supply console fix

* HOP/Bridge supply consoles changed to non-public type

* few cosmetic tweaks around the hallway involving extinguishers, robotics locker added(even though it's kind of pointless with us having robodrobe), sci starting glass and meta buff

* 2 cameras moved off glass, slight sci chem buff with rwalls now fully protecting it, few posters moved to look less awkward

* the great tinted window removal of 2557(they kind of suck in paracode), also engineer burn medkit switched out for a standard one(in line with box)

* pipenet fix

* experimentor console added, var edited on pump changed out for on subtype

* experimentor room buffed with plasma windows(as on box)

* layering issue with a warningstrip in robotics fixed

* tile in abandoned med removed, maints glass door in botany replaced with solid door, few space heaters removed

* leftover pipe connector in maints removed

* dozen or so cameras moved about 1 tile so that they're no longer sharing a tile with a light, missing floor tile in brig fixed, cargo table cleaned up

* ooops one more camera in the vault

* /secure suit storage units replaced with normal type

* flipped decal so it's facing the right way

* high voltage warnings moved off glass in xenobio, high voltage warnings added around the vault

* quick highvolt sign fix

* replaces grimy floors with cleanable dirt, moves 1 camera 1 tile

* stand_clear decal added under armoury shutter

* Prison laundry camera added(same as TG), prison botany camra moved a tile

* slight adjustments to NTR and BS office in regards to camera and APC placement

* gateway cam move, AI sat wire moved to look more clean

* opacity change on prison transfer plastic flap

* AI Satellite antechamber turret controler fixed

* a few var edited pumps replaced with on subtype

* opps this tile should be catwalk not an airless plating

* AI upload gets firelocks+foyer gets vents and is fully set to AI upload access only, captains officer intercoms moves around a bit, lightswitches moved a bit

* oops the instead of the ai upload was missing a firealarm

* and the private subtype intercom in the captains office

* radio freq 1447 is what TG uses for their private channels, some intercoms had this set as a leftover from our old version of meta.

* Made it so that only the cheft can access the hydro fridge, fixed the hydro shutter button, added gateway access points to the gateway shutter button, fixed access on chemsitry desk

* rogue mechbay button removed

* names on solitary cells doors and flasher buttons

* forgot to fix a sink in perma I have been meaning to fix

* same as above, just a different sink

* chemistry desk change, looks better now

* engi light moved 1 tile

* moved shock warning signs(again), switched out metal botany tables for glass ones

* last of the sign fixes i hope, layer issue with tools in eva fixed

* damn signs

* and I missed two...

* slight signage cleanup on airlocks

* HOP office was missing door naming helpers

* New perma

* Camera pos change in perma, better arrivals lattice

* sign fix bridge

* added a second set of accepted/denied stamps to cargo, turned HOPs chair

* also got rid of a light in cargo

* tech storage access fix

* atmos desk cams moved around a tiny bit

* i sure hope no one noticed this one tile in the AI sat facing the wrong way

* spread the maints mice out a bit more

* fixed light placement

* found one more light

* moved cobweb off glass near space bridge

* starboard secondary maints zone fix on door

* and A-P maints

* more stuff on windows- which I hate! cringe!!!

* lights should not be beside each other

* This placement is better

* agh more lights in med

* cryodorms buff

* removes locker from maints room beside cryo since the room is smaller now

* ooops i forgot a holopad in the new cryodorms. also changs get a holopad

* annnd a floor tile

* arcade didn't have an intercom

* fixes window placement around vault from TG version

* wiring fix near vault

* old request console from old para ver of map named

* internal vault signs fixed

* more signs moved off walls and into a x/y nudge(yes i know i am being picky)

* A legecy area(the garden) gets an intercom

* moved*

* AI core flasher moved slightly to fix clipping with ai turret controller

* wall changes to the AI sat to make it a bit more clean

* news+ai request console fix

* The "Captains intercom" from TG doesn't exist in paracode so it has been replaced with an AI private intercom

* button fix

* oops

* reverts a sign change near disposals

* would you look at that i moved another camera 1 tile hahaha

* should be the last cams

* it wasnt

* fixed up the mirror in the bar backroom

* same fix applied to captains bathroom sink+mirror

* cleaned up janitor rooms intercom pos + firealarm

* bridge fire alarm moved tile down

* riot shields now stacked north to south to be in line with weapons

* 2x showcasese were missing their set names, oops

* layering fix in prisoner court cell

* Pen an paper added to BS office, APC move in showroom

* ack bs office again

* perma window fix

* extinguisher in sci moved

* det office cam fix

* remove brig prefix

* light and button tweak near bridge

* window layer again

* small tweak to the toxins loop obersvation room

* 1x wall

* clean up grillies by SM

* wiring changes/fixed in maints and at SM

* few small floor tweaks and sink shifts

* rwall akwardness fixed

* pipe under vent moved

* redid brig wiring and piping to look more clean

* one little oopsie

* more wires+intercom

* fixed the mess TG got themselves into with chemistry floor tiles

* redos medbays wiring to run along side the pipes rather than beside them

* same wiring changes that I did to med/sec but this time to the command area

* hop airvent moved on tile, some wires shifted

* unshocked window fixed

* lessens and spreads out the maints donk pocket spawns

* Viro now uses updated doors!
2022-06-11 14:09:32 +01:00
Charlie
77d03f7ab9 Spellblade rework (#17693)
* fire lighting and shielding

* blink + lavaland loot

* file move and projectile removal

* get out of MY WALLS

* review

* sprites

* forgot this

* sprite update

* Apply suggestions from code review

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* some TM changes

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
2022-06-06 16:22:18 +01:00
Qwertytoforty
e5266bdcac fixes bugged examine on docking beacons (#17877) 2022-05-27 17:33:12 +01:00
Charlie
0f7a8707ef [Ready] Refactors stuns and status effects. (#17579)
* Fixes reviver runtime

* Confusion status effect

* Dizzy status effect

* Drowsiness status effect

* decaying -> transient

* Drunkenness status effect

* why use timer when SSfastprocessing work good

* stuns (mostly)

* weaken and immobalise

* stun/weaken times

* update_flags redundancies.

* Slowed()

* Silence + fixes transient decay

* Jittery

* sleeping

* Paralyze -> weaken

* Cult sluring

* paralyse

* Stammer

* slurring + projectile cleanups

* losebreath

* Hallucination

* forgor this

* eyeblurry

* eye blind

* Druggy

* affected didn't like my spacing

* review pass

* second review pass

* some cleanups

* documentation and signal framework

* confusion fix

* Fixes spec_stun

* rejuv fix

* removes a TODO

* conflicted myself

* fixes

* self review

* review

* removes TODOs

* adminfreeze

* TM fixes

* hallucination fix + others

* tones down alchol and runtime fixes

* confusion overlay suggestion

* more fixes

* runtime fix

* losebreath fix

* clamp => directional bounded sum

* steel review

* oops

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* reduces the dizziness cycle rate

* borg hotfix

* sanctified decursening

Co-authored-by: mochi <1496804+dearmochi@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2022-05-24 16:35:26 +01:00
AffectedArc07
d5e5d9e62b No more on station shelter capsules (#17674) 2022-05-03 04:29:14 +01:00
SteelSlayer
94306264f7 Improves logging on teleportation portals (#17637)
* teleporter logging

* affected review and improvements
2022-04-21 20:58:30 +01:00
atteria
bcf90593ed Improves belt item overlay code, Adds new belt item overlay sprites (#17568)
* belt-improvements-and-sprites

* fixes my fix of botany belt allowed contents
2022-04-12 15:57:21 +01:00
S34N
03beb422b2 Remaps CC, changes z1 layout (#17425) 2022-03-14 20:08:07 +01:00
S34N
ac6f9b4725 [IDB Ignore] Refactor icon smoothing to use 8-bit bitmasking (#16620) 2021-12-15 17:04:24 +01:00
variableundefined
522390c0b9 Merge pull request #15675 from Fox-McCloud/his-grace-ascended
Implements Better His Grace
2021-09-18 15:26:30 -05:00
variableundefined
fa3fa1dc6a Merge pull request #16579 from FlattestGuitar/armor-defines
Adds defines for damage flags
2021-09-17 22:10:20 -05:00
botka4aet
ebf20f8806 Bone items review fix 2021-09-17 11:13:32 +03:00
botka4aet
d49cfd2322 2 new tribal items 2021-09-10 11:07:54 +03:00
Fox McCloud
23164e354b conflicts 2021-09-06 04:06:47 -04:00
SabreML
6648d3131f Clothing Organisation V1 2021-08-24 18:37:48 +01:00
Mieszko Jedrzejczak
559fa37756 add defines for damage flags 2021-08-20 21:09:21 +02:00
SabreML
02fe0876f5 Fix bundle #3 (#16411)
* Explosive implant

* Package wrapper

* Venus human trap sprites

* Vine damage

* Wisp vision

* Display case

* Storage viewing

* Ghost poll nullspacing

* Inflatable barrier piercing

* Pneumatic cannon

* Cow grammar

* Centcom jaunting

* Consistency

Not actually a lazy list, as far as I can tell

* Review 1

Co-Authored-By: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* Review 2

Co-Authored-By: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

* length()

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
2021-08-05 11:04:27 +01:00
dearmochi
712721fbc6 [READY] Reworks and Refactors Hallucinations (#15360)
* Hallucination rework start

* Chaser/Attacker, Abduction

* Moderates

* Majors

* saber alter

* address SteelSlayer

* Fix admin logging and runtime

* put hallucination logging on ATKLOG_ALL
2021-07-13 14:27:14 +01:00
Qwertytoforty
1b1f49ac81 Adds the Emergency Extraction Flare (#16220)
* Adds the Emergency Extraction Flare

* removes extra message

* Apply suggestions from code review

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: dearmochi <shenesis@gmail.com>

* All I ever get, is a pain in the ash... 🎵

* Affecteds requests part 1

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

* Use populate_contents

* Update code/modules/mining/equipment/wormhole_jaunter.dm

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
Co-authored-by: dearmochi <shenesis@gmail.com>
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
2021-07-02 21:32:45 +01:00
SabreML
0b375de42c Removes the the vast majority of 'The the' from the the code (#15597)
* The the

* Some more

* Review 1

* A couple more
2021-06-20 10:20:32 -04:00
Fox McCloud
118e73966f Implements Better His Grace 2021-03-05 13:51:17 -05:00
Fox McCloud
f65c8994ce Broad TG Sound Update (#15608)
* Broad TG Sound Update

* jester update
2021-02-27 11:59:33 +00:00
Fox McCloud
6074323192 Further Updates Windows (#15427)
* Further Updates Windows

* correction
2021-02-03 10:04:52 +00:00
Fox McCloud
003a1f7cba Tank Refactor; Breathing Retool (#15371)
* Tank Refactor Breathing Retool

* missed maps and doc

* just in case
2021-01-28 20:57:37 +00:00
Fox McCloud
de795c4e31 Radiation Refactor (#15331)
* First Commit

* visible radiation and engine goggles

* correction

* t-ray fix

* further adjustments and fixups

* gieger addition and cleaning fixup

* yet more fixes

* styling fixes

* fixes

* human glowing fix

* do the merge conflict avoidance dance

* Update supermatter.dm

* supermatter rads

* mapping in

* radiation doors

* yeah yeah line endings

* clean up

* styling issues

* showers
2021-01-24 22:03:13 +00:00
AffectedArc07
8f72d7556e Annihilates the blackbox (#15132)
* Lets get this show on the road

* Now were talking

* These matter

* Oh the joys of CI testing

* And this

* Wrong version

* Tweaks

* More tweaks

* Lets document this

* This too

* Upgrades this

* Fixed some sanity issues

* This too

* Screw it, this too

* More sanity

* And these

* This too

* Documentation

* This too

* Fixes **awful** scoreboard logic

* Why do we care about only half-absorbing someone

* Revert "Why do we care about only half-absorbing someone"

This reverts commit 8de1cfdf05.

* Refactors these

* Hashing

* Moxian tweaks
2020-12-24 16:06:48 -05:00
AffectedArc07
44012814d0 Merge branch 'master' into nanoui-is-dead 2020-11-26 09:34:14 +00:00
dearmochi
41d6fd9630 Fix marker beacon duplication exploit (#14973) 2020-11-23 12:23:03 +00:00
AffectedArc07
54dd2765b4 Converts all tgui_ to ui_ 2020-11-21 12:10:58 +00:00
AffectedArc07
984ac231e0 Nano Is Dead 2020-11-21 09:46:50 +00:00
Kyep
6277978bd6 Jaunters can no longer teleport megafauna, unless emagged 2020-08-03 00:08:48 -07:00
Fox McCloud
c8a7607129 Purges a Bunch of In World Calls (#13641)
* Purges a Bunch of In World Calls

* tweaks and fixes also typeless lists

* typeless

* fixes

* tweak
2020-06-22 06:56:19 -06:00
Fox McCloud
bcc45f03b7 Cuts down on Pointless Status Effect Processing (#13582) 2020-06-09 15:31:10 -04:00
AffectedArc07
210f8badf4 Makes all global variables handled by the GLOB controller (#13152)
* Handlers converted, now to fix 3532 compile errors

* 3532 compile fixes later, got runtimes on startup

* Well the server loads now atleast

* Take 2

* Oops
2020-03-20 21:56:37 -06:00
AffectedArc07
04ba5c1cc9 File standardisation (#13131)
* Adds the check components

* Adds in trailing newlines

* Converts all CRLF to LF

* Post merge EOF

* Post merge line endings

* Final commit
2020-03-17 18:08:51 -04:00
Citinited
fddff1049b [Testmerge ready] Ports tool behaviours; refactors all tools; adds functionality for self-filling reagent containers (#11700)
* Adds support for self-filling reagent containers

* Sets tool_behaviour on the default set of tools

* Fixing merge conflicts

* Refactors welder to use tool behaviour

* The refactor: part I

* The refactor: part II

* Tool Refactor Part III: Revenge of the Maint

* Tool Refactor Part IV: A New Hope

* Tool Refactor Part V: The Oldcoder Strikes Back

* Tool Refactor Part VI: Return of the Coder

* VII

* Holy shit, it compiles?!

* Nannek I completed your TODO, you owe me ice cream

* Tool helpers; telepad is compliant

* Bugtest, Round 1: Fight

Fuck refactoring disposals

* Buggfixing, Round 2: Electric Boogaloo

* Personal crafting uses tool behaviours now

* Construction datums use new tool behaviours; better way of handling fueltank refuelling; more bugfixing

* multitool_check_buffer change; removes some useless things in tool_helpers

* proc name change

* TRUE/FALSE changes

* Bugfixing, Round 3: A Good Day To Bugfix Hard

Fixes multiple issues raised by the testmerge

* Minor style changes
2020-02-15 13:31:08 -07:00
Fox McCloud
209379d22a Nerfs Glass Armor (#12544) 2019-10-27 00:19:13 -04:00
Fox McCloud
45bb5241f0 Training Wheels Come Off (#12587) 2019-10-15 19:22:42 -04:00
Fox McCloud
affa319fab Removes Console Screens (#12512) 2019-10-08 21:07:50 -04:00
Fox McCloud
20c4cf0a08 for-if-I-stand-I-stand-by-his-will-alone 2019-10-03 19:52:03 -04:00
Fox McCloud
d29be05f74 the-figment-that-was-is-now-gone 2019-10-01 19:08:15 -04:00
Fox McCloud
a469d0fcf2 for-God-has-redeemed-us-all 2019-09-30 16:49:15 -04:00
Fox McCloud
9097dfcacf Merge remote-tracking branch 'upstream/master' into universal-damage
# Conflicts:
#	code/game/machinery/machinery.dm
#	code/game/objects/items.dm
#	code/game/objects/structures.dm
#	code/game/objects/structures/inflatable.dm
#	code/game/objects/structures/mirror.dm
#	code/modules/clothing/spacesuits/hardsuit.dm
#	code/modules/clothing/suits/wiz_robe.dm
#	code/modules/mob/living/carbon/alien/alien_defense.dm
#	code/modules/mob/living/carbon/slime/slime.dm
#	code/modules/mob/living/simple_animal/friendly/slime.dm
2019-09-28 00:16:11 -04:00
farie82
0e8ddb2afe Refactors the examine proc to return a list of strings (#12280) 2019-09-25 22:05:01 -07:00
Fox McCloud
6f637b6014 Merge remote-tracking branch 'upstream/master' into universal-damage 2019-09-17 11:24:58 -04:00
Fox McCloud
1b1bd00c06 Updates Status Effects: Fixes Blood Drunk Status Effect, Buffs Regenerative Core (#12320) 2019-09-17 07:56:50 -04:00
Fox McCloud
af92373d33 though-this-world-may-be-broken 2019-09-15 05:53:43 -04:00
variableundefined
f6fe4a1520 Merge pull request #12291 from Fox-McCloud/hierophant-update
Hierophant Update
2019-09-14 22:31:38 -04:00