Commit Graph

31579 Commits

Author SHA1 Message Date
Leshana
cd0072fbc0 Add vv_edit_var to ensure VV edits call our update procs too. 2020-04-24 12:45:34 -04:00
Atlantiscze
c4a65579a9 Fixes Intellicore grabbing AI multiple times
- If you click multiple times during the do_after timer, you may try to grab the AI multiple times, possibly breaking stuff.
- Should fix #5179
2020-04-24 09:47:32 +02:00
Leshana
a279c698e3 Make shuttle control consoles constructable.
- Adds circuit boards for shuttle consoles. (Ferry, Multi, and Overmap).
- Deconstructing a console saves the linked shuttle tag in the board for when it is re-constructed.  New boards start blank but will auto-link if you build the console on a shuttle.
- Boards know what type of shuttle they can control and will only auto-link with a shuttle if it is the appropriate type.

Note: By default the only mapped-in shuttle consoles that are deconstrutable are overmap and multi shuttle consoles.   For any others, consoles built mid-game will be deconstrutable but the mapped-in ones will not.  That way the arrival, escape, supply ferry shuttles etc won't be messed with unless the mapper specifically chooses to override and make them that way.
2020-04-23 19:10:52 -04:00
Leshana
9c872f096f Add feedback to user if successful when reconnecting ship computers to ship. 2020-04-23 19:10:34 -04:00
Leshana
acbbe7d9c5 Setup auto-configuration of shuttle consoles.
- Its now possible to put shuttle consoles on a shuttle without a specific subtype or mapediting the shuttle_tag on them.
- After shtutle initialization, SSshuttles gives each initialized shuttle the chance to scan its areas for consoles it wants to claim and configure.
2020-04-23 19:08:30 -04:00
Leshana
3093b5bbd8 Add circuitboards to make overmap ship computers constructable. 2020-04-23 19:08:20 -04:00
Leshana
f7982d0e64 Fix mothershuttles moving sub-shuttles when they're away. 2020-04-23 19:08:11 -04:00
Atlantiscze
95db1d6e8d Adds basic xenoarch & exploration equipment to research robot module
- Also removes commented-out sources of construction module which is long unused.
2020-04-23 16:52:16 +02:00
Atlantiscze
2a9547f3d9 Implements additional feedback 2020-04-23 08:02:51 +02:00
Atlantiscze
b3d866c4d5 Adds updated version of power debugging items
- Infinite powersource, Infinite grid load (powersink without boom) and APC dummy load.
- Not buildable, intended primarily for debugging or admin shenanigans. For mapped-in variants setting show_extended_information = FALSE is recommended.
2020-04-23 07:48:53 +02:00
KasparoVy
50b9175cc6 Adds Colorable Apron & Tesh Labcoat
Adds a white colourable version of the blue apron
Adds a Teshari-fitted labcoat with an existing unused sprite and enables it for colouration in the loadout
2020-04-22 19:43:20 -04:00
Atermonera
a51f92bf8a Merge pull request #7012 from atlantiscze/2020_04_18_LeakFix
Fixes HE pipes not leaking when breached
2020-04-22 14:46:58 -07:00
Atermonera
a1b8a3006d Merge pull request #7023 from Mechoid/FixAndTweakRoiling
Roiling Mold Blob Fix/Tweak
2020-04-22 12:53:41 -07:00
Atermonera
c840915fa0 Merge pull request #7015 from Shadow-Quill/AirlockMessage
Airlock Description Error
2020-04-22 12:51:02 -07:00
Atermonera
e575e9c7d5 Merge pull request #7009 from atlantiscze/2020_04_17_EPRFix
Fixes supermatter monitoring EPR indicator showing Undefined
2020-04-22 12:46:47 -07:00
Leshana
092f415375 Fix Sundry Runtime Errors XII (#7007)
* Fix Runtime in atoms_movable.dm,597: list index out of bounds

* Fix Runtime in floor_attackby.dm,118: Cannot execute 0.is crowbar().

* Fix null values being present in mob_list.

* Another fix for Runtime in update_icons.dm,254: Cannot execute null.GetUIState().

- This time lets just ensure dna is instantiated no matter who is calling dress_preview_mob().

* Fix Runtime in suit_storage_unit.dm,792: Cannot execute null.set machine().

- Also fixed other mixups of usr vs. user that I found in the same file.

* Fixes Runtime in find_spawning.dm,688: Cannot read null.origin_tech

- if this else if block is reached, new_item must not exist, so we obviously can't set origin_tech on it. Examination of the code seems to suggest the original author intended that for any "talking" items to have arcane and precursor tech; since src is now being made talking, src should get the tech.

* Fix talking artifacts downgrading arcane/precursor tech

- Bump up the values by one for talking artifact items instead of overwriting whatever the value was.
2020-04-22 12:44:35 -07:00
Atlantiscze
b718f6af07 Excludes AI shells from event probability calculations
- This seems to be quite an issue on lowpop, with high danger events (strong blobs for example) firing just because the AI has an engineering/security shell(s) available. They are still one player, however, therefore it results in very hard to handle situations when trying to go a 1v1 against strong blobs with remotely controlled engineering shell (as you can't control more than one at a time)
2020-04-22 16:15:26 +02:00
Atlantiscze
a9af839845 Fixes Phazon and Janus being unable to phase
- Fixes #6302
2020-04-22 15:52:00 +02:00
Atlantiscze
51083ed119 Tweaks SMESRATE to original value
- Didn't notice the original value differed from value used on Bay. This brings it back so capacity remains unchanged
2020-04-21 22:46:47 +02:00
Leshana
21c8c94971 Fix remaining code that directly modified use_power to call update_use_power. 2020-04-21 13:15:32 -04:00
Leshana
66b40b2c71 Call update procs instead of directly setting idle_power_usage or active_power_usage.
- Adds the update_idle_power_usage() and update_active_power_usage() procs for the respective vars.
- Switches all places modifying those vars directly to call the procs instead.
- This will let us react to the change appropriately, paving the way towards static area power.
- Adds update_power_channel proc for the sake of completeness, but no machines actually modify it so far.
2020-04-21 12:53:05 -04:00
Atlantiscze
648dcf32c3 Removes stray unused variable that triggered a compile warning 2020-04-21 15:23:31 +02:00
Atlantiscze
131270c6f8 Converts Shutoff valve monitoring into a MC program
- Existing consoles remain for now, only refactored to use a shared nano_module. Included by default on engineering consoles, downloadable by anyone with basic engineering access.
- Tidies up the UI a bit, prevents manual toggling of valves when they are in Auto mode (as it would immediately toggle back)
2020-04-21 15:15:57 +02:00
Atlantiscze
252719c5f0 Implements feedback 2020-04-21 10:03:07 +02:00
Aronai Sieyes
5a92fc4ec9 Let mechs connect to ports if they're larger mechs (#7001) 2020-04-21 00:30:49 -07:00
Mechoid
e83c013948 Roiling Mold blob projectiles fly in shorter arcs. Fix projectile targeting recursion. 2020-04-20 22:38:55 -07:00
ShadowLarkens
54a8a5823d Saycode Overhaul -- Multilingualism (#6956)
* Port ParadiseSS13/Paradise#2100 - Saycode refactor

* Removed unused old carbon slimes code

* Port ParadiseSS13/Paradise#5099 - Saycode part 2

* Ported ParadiseSS13/Paradise#7170's /datum/browser Check Known Languages

* Port ParadiseSS13/Paradise#9240 - Get rid of alt_name in favor of GetAltName()

* Port ParadiseSS13/Paradise#10330 - You can now use multiple languages in one message

* Addressed Atermonera's review.

Translators now print the full message if they find any languages within the
message that the user doesn't understand, minus languages it cannot translate.

Additionally, the combine_message proc has been significantly simplified
by eliminating an ugly tree structure with the help of a little helper
proc.

The removal of the extra span inside each piece doesn't seem to have
visually changed the messages in any other way than changing where the
wordwrap happens, strangely enough. Must be something in IE's code being
picky about invisible elements. On the bright side, it splits *later*
than it did before, thus reducing the lines a message will take up by a
tiny amount.

Also, a bunch of things now have the 'filter_say' class from
PolarisSS13/Polaris#6998. Since span classes with no definition are
totally valid and just don't do anything, this PR does **not** depend on
that PR being merged first.

* Always gotta be one
2020-04-20 01:11:53 -07:00
Atermonera
1ed5556b8f Adds empty filter classes to send messages to particular vchat filters. (#6998)
* Adds empty filter classes to send messages to particular vchat filters.
Adds combat log (playerside X hit Y) filter
Adds admin log, attack log, and debug log filters (Admin side)
Moves many unfiltered admin verb outputs to admin log filter

* unmatched tags
2020-04-20 00:28:16 -07:00
Atermonera
6a15586a74 Replaces toy waterflower with spraybottle waterflower (#6997) 2020-04-20 00:24:53 -07:00
Atlantiscze
fbf33fc5df Final tweaks
- Refactors some code to more modern standards, fixes problem with PSUs not reacting to UI input.
- Adds cable coil recoloring using multitool (Bay went the path of having dedicated cable painter device but that really feels as too much of a hassle having to carry another device for this - lets just say the paint is electrically reactive in some way).
- Adds changelog
2020-04-20 08:16:19 +02:00
Atermonera
1635de6349 Merge pull request #6999 from KasparoVy/leaves-me-breathless
Update Human HUD Generation to Fix Internals Graphical Bug
2020-04-19 14:37:44 -07:00
Atermonera
0b03209c66 Merge pull request #6996 from VOREStation/vplk-ssopenspace
[PORT] Refactor the Open Space controller into MC Subsystem
2020-04-19 14:36:22 -07:00
Atermonera
098f1b1b43 Merge pull request #6993 from VOREStation/vplk-glass-firedoors
[PORT] Make glass firedoors constructable/deconstructable.
2020-04-19 14:32:55 -07:00
Atermonera
a92650b07d Merge pull request #6991 from VOREStation/pol-jobsplit
Allow 'offmap spawn' jobs to be isolated from station employees
2020-04-19 14:23:49 -07:00
Killian
58ac25157b Security Voidsuit Overhaul Redux (#6985)
* security voidsuit overhaul redux

* svo2 - small desc update

* update inhands for secEVA suits
2020-04-19 13:20:39 -07:00
Shadow Quill
7b13b7959d Desc Error 2020-04-18 20:32:12 -05:00
Unknown
ac094e1cbd Fixes spacing issue 2020-04-18 01:19:49 -04:00
Unknown
3b2b23fc8c Caps burning human temperature
Basically makes it so that a burning human no longer infinitely increases in temperature. This is also being combined with reductions to heat damage level to make high temperatures less super lethal as they currently are on this codebase.
2020-04-18 01:18:13 -04:00
Atlantiscze
123383c7f4 Fixes HE pipes not leaking when breached 2020-04-18 06:00:23 +02:00
Atlantiscze
78925e2993 Ports over power-related enhancements and tweaks i coded for Bay a while back
- Please fasten your seatbelts, this will be a long one as it joins few older Bay PRs into one.

1. Ports https://github.com/Baystation12/Baystation12/pull/12626
- SMES units may now be damaged and destroyed. Charged SMES units fail quite violently. Damage can be fixed by welding tool.
- PSUs completely refactored, ghetto variant no longer exists.
- Cell rack PSUs now can be considered a hybrid between large battery charger and a SMES. They actually use the cells to store power (so you can hot-swap the cells to get more juice simply via the UI without deconstructing the whole machine), but in comparison to SMES have poor throughput and capacity in general (cells are simply too small). They are also somewhat limited in configuration options (lacks the precision electronics of a SMES). Better matter bin lets you put in more cells, up to 9.
- Cell rack PSU also has a mode that allows charge-balancing all inserted batteries (moves energy around so each battery has the same charge %)

2. Ports https://github.com/Baystation12/Baystation12/pull/11977
- SMES units now have full load balancing capability, getting rid of that annoying "One SMES charges at full, other SMES gets nothing" problem. If insufficient power is available on input, all inputting SMESes will now charge at same percentage. If more SMESes power a single output, they will all output equal percentage of their setting.
- This appears to have a pleasant side effect of fixing the issue where SMESes could starve APCs of energy. SMESes are ALWAYS last to input power on a powernet.
- This also appears to have fixed weird values displayed in SMES output/input load readings in the UI. By weird values i mostly mean inputs/outputs actually higher than the SMES is set to have.

3. Ports https://github.com/Baystation12/Baystation12/pull/18137
- SMES units (and subtypes, therefore effectively also PSUs from previous entry) can now have more than one terminal. This effectively allows a setup where two (or more) sources feed a single SMES, which then feeds the output. SMESes can not exceed input setting even with multiple terminals.
- Typical example of use in practice would be SMES that runs something important (for example an AI, telecomms, pick whatever you want). It could have one input from the power grid, and second input from a PACMAN generator set up nearby as a backup. Before the generator would have to be wired into main grid, therefore main grid would siphon off power from it. Now the generator can be separate and dedicated for whatever use you want.
2020-04-17 08:26:29 +02:00
Atlantiscze
56e28ec2aa Fixes supermatter monitoring EPR indicator showing Undefined
- This mirrors original sources from Bay. Nano file was apparently moved from there, but code file was not.
- As for intent of this function (i coded it originally on Bay), EPR can be considered "Amount of canisters worth of gas in the core chamber", hence the weird 23.1 constant. Unlike pressure reading, this does not change with temperature, so it can be used to accurately monitor actual amount of gas in the chamber without having to take temperature in effect.
- I know the constant is kind of shady. It could possibly be recalculated using atmos constants, but i suck at math too much to do that. If anyone who knows atmos math can find a better alternative, i will gladly toss it in instead.
2020-04-17 06:06:06 +02:00
Atermonera
08d463a797 Merge pull request #6971 from KillianKirilenko/kk-cyclers
Suit Cyclers: Faster, Smarter, Better
2020-04-16 20:14:52 -07:00
Killian
f7cf3143da ssu: don't prefix 'refitted' to the desc 2020-04-17 02:37:02 +01:00
Killian
31bd5e46b3 ssu: extended list, now sorted by departments 2020-04-15 21:09:28 +01:00
Aronai Sieyes
34ffcd2284 Allow fighters to traverse overmap ships predictably 2020-04-15 13:41:22 -04:00
KasparoVy
a9e7a4d16a Update Human HUD Generation to Fix Internals Graphical Bug
Fix an issue whereby when reconnecting to the server after disconnecting/losing connection your internals HUD element will always be off, even if you're actually still breathing from a tank.
Now it checks & shows the correct state so you don't panic after lagging out IN SPACE AAAAAHHHH
2020-04-15 02:19:09 -04:00
Leshana
f8755f2de5 Fix openspace redering of under-objects that have no main icon (only over/underlays)
In particular stops manifolds from getting the openspace "map" icon state as its main icon instead of null.
2020-04-14 09:40:19 -04:00
Leshana
5dbf08b462 Refactor the Open Space controller into MC Subsystem
- Basically just refactor doWork() into fire() with the capablity to return in the middle with MC_TICK_CHECK.
- Move some vars around to be more organized.
- Only functional change is that when a turf is queued twice in one cycle, the second queue moves it to the end of the list instead of it being in the queue twice
2020-04-14 09:38:23 -04:00
Leshana
2d37c09d12 Commit move of open_space_controller.dm to subsystems folder to track history through rename. 2020-04-14 09:37:58 -04:00
Unknown
7ffb97e2b3 Improves the Laser Sniper Sprite 2020-04-13 10:25:58 -04:00