* Makes the heretic worm use the blood walk element
It was using a custom proc for this, but we have an element just for
this.
* Update code/modules/mob/living/simple_animal/heretic_monsters.dm
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* dont need this'
* adds an extra arg the to the element to keep direction
* moves da eement
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Fixes xeno -> human head of departments showing up as their original species in security records
`get_flat_human_icon` was passing preferences which chose their
original, so i added a var to `/datum/species` to check if the species
was forcefully changed
* makes it actually work
* review
Removes the tracking arg from GPSs, which I added because I thougt it'd be a helpful thing to add. Turns out it just makes it turn every GPS off on creation.
You can click someone directly with shift+ctrl+click to offer an item only to them. This is in contrast with pressing G, which offers the item to every adjacent carbon mob.
Also fixes a runtime where the Give screen alert on a potential recipient was trying to remove itself on proximity loss after the Offering status effect had already done it.
Removes duplicate range check on Give screen alert that was causing the runtime as Offering status effect takes care of it.
Also adds a check after clicking the screen alert to take something to make sure we're not dead or incapacitated, so dead people can no longer take things.
Also adds a screentip for this functionality.
Also adds some more checks to give() to make sure we can do it before sending the message to players that we're offering something.
* Refactors phylactery to be a component
- Overall improves lich code
- Changed the SOUL_IMBUE signal to return a bitflag
- Minor style improvements (indentation and such)
* Tweak initialize + fixes a bug with being gibbed
* adds a clarification comment
* And fixes a compile error oops
* reorganizing
* clear the revive timer, just in case
* oops this should drop stuff
* missing no soul trait
* type in a variable name
* god damn devil removal
- this check was removed when devil was and i think it's kinda important to prevent stacking lichdom
* rework this a bit
* plurals
* also, wrong source
* updates the description
* Some review + undoes some changes
- Corrects some comments
- Uses defines
- Rewords the lichdom entry and spell desc
- Sets default time per res to 0 secs to avoid changing behaviors
Apparently whoever implemented the signal handler forgot to pass the signal source so it was reading the thing clicked on as whether the thing clicked on was adjacent. As datums are truthy this resulted in all clicks breaking chameleon.
About The Pull Request
Alternative to #65354
Ok so like, there was a lot of not floor types on /floor. They didn't actually want any of their parent type's functionality, except maybe reacting to breaking (which was easy to move down) and some other minor stuff.
Part of what we don't want them to have is "plateable" logic.
I should not be able to put floor tiles on the snow and be fine. It's dumb.
Instead, I've moved all non floor types down to a new type, called /misc.
It holds very little logic. Mostly allowing pipes and wires and preventing blob stuff.
It also supports lattice based construction, which is one of the major changes here. I think it makes more sense, and it fixes an assumption in shuttle code that assumed you couldn't place "a new tile" by just hitting some snow with a floor tile.
Oh and lattices don't smooth with asteroid tiles anymore, this looks nicer I think.
Moving on to commits, and minor changes
Changes clf3 to try and burn any turfs it's exposed to, instead of just floors
Moves break_tile down to the turf definition, alongside burn_tile
If you're in basic buildmode and click on anything that's not handled in a targeted way, you just build plating
FUNCTION CHANGE: you can't use cult pylons to convert misc tiles over anymore
Generalizes building floors on top of something into two helper procs on /turf/open, reducing copypasta
Adds a new turf flag, IS_SOLID, that describes if a turf is tangible or not.
Uses this alongside a carpet and open check to replace plating and floor checks in carpet code. This does mean that non iron tiles can be carpeted, but I think that's fine
Moves the /floor update_icon -> update_visuals call to /open
This change is horrificly old, dating back to 8e112f6 but that commit describes nothing about why it was done. Choosing to believe it was a newfriend mistake. Uncomfortable nuking it though, because of just how old it is. Moving down instead
Create a buildable "misc" type off open, moves /dirt onto it
Basically, we want a type we can use to make something support
construction, since that can be a messy bit of logic. Also enough
structure to set things up sanely.
I'm planning on moving most misc turfs onto it, if only because
constructing on a dirt tile with rods should be possible, and the same
applies to most things
Murders captain planet, disentangles /turf/open/floor/grass/snow/basalt
Adds a diggable component that applies the behavior of "digging"
something out from a turf.
Uses it to free the above pain typepath into something a bit more
sensible
The typepaths that aren't actually used by floor tiles are moved onto
/misc
The others are given names that better describe them, and kept in
fancy_floor
Oh and snowshoes don't work on basalt anymore, sorry
Snowed over platings now actually have broken/burned icon states, fixing black holes to nowhere
Misc turfs no longer smooth as floors, so lattices will ignore them
Placing a lattice will no longer scrape the tile it's on
Ok this is a really old one.
I believe this logic is a holdover from kor's baseturf pr
(97990c9)
It used to be that turfs didn't have a concept of "beneath" and instead
just decided what should be under them by induction. This logic of "if
it's being latticed scapeaway to space" made sense then, but has since
been somewhat distorted
We do want to scape away on lattice spawn sometimes, mostly when we're
being destroyed, but not always. We especially don't want to scape away
if someone is just placing a rod, that's dumb.
Adds a path updating script for this change
I've done my best to find all the errors this repathing will pull out, but I may have missed some. I'm sorry.
Why It's Good For The Game
Very old code made better, more consistent turfs for lavaland and icebox, better visuals, minor fix to snowed plating, demon banishment in lattice placement, fixes the icebox mining shuttle not being repairable
Changelog
cl
add: Rather then being tileable with just floor tiles, lavaland turfs, asteroid and snow (among other things) now support lattice -> floor tile construction
fix: Because of the above, you can now properly fix the icebox mining shuttle
refactor: Non floor turfs are no longer typed as floor. This may break things, please yell at me if it does
/cl
About The Pull Request
AI dogs currently have a nasty habit of getting stuck when trying to fetch items sometimes, rendering their AI behavior basically dead as they're stuck in a state where they're unable to accept any commands/inputs from their environment. This PR fixes that by adding some more robust checks to make sure a failed fetch attempt doesn't softlock the pups.
This PR also adds some growling sounds for dogs in harass mode who are guarding against someone not within biting distance.
Why It's Good For The Game
Fixes some edge cases where dog AI would stop working entirely. Makes dog AI's in attack mode more conspicuous, and less reliant on text spam to show that.
Changelog
cl Ryll/Shaps
fix: Dog AI's should no longer lock up and become unresponsive after failed fetch attempts
soundadd: Dogs in harass mode that are guarding against someone will now make growling sounds
/cl
They can be bought from the mining vendor for 2750 points.
The Kheiral cuffs act as a suit sensor booster off-station, and don't do anything on-station.
This was originally #65210, but after realizing the potential I scrapped that and jumped on this.
If you die as a miner, your only potential and realistic way of being revived is if someone makes the random decision to ask if you're alright over the comms, decides to do something when you don't respond, and then makes the trip all the way to and from your location of death.
This provides a way to reward miners who worked hard to get their points with a way to possibly get revived in the event of their death, without outright reviving them or something like that.
People will still need to retrieve your body, but at least they'll know you're even dead in the first place.
Someone made a suggestion to me that fixed a problem I've been trying to work around, and now that I've made it so people can set custom decompose times, that made this WAY EASIER.
When most foods decay, they will turn into the generic moldy food sprite you've become accustomed to, without the ants. After 30 seconds, that moldy food will get consumed by ants, leaving only the anthill.
Ants also no longer spawn on lavaland's basalt, by Fikou request.
* conveyor belt and switch changes
* maintainer recommended changes 1
* maintainer recommended changes 2
* fixed hard delete
* resolve fix and name change of variable
* who knew that SECONDS is *10, not me
Adds the component to bump mining turfs and removes the code under Bumped() that handled it.
Cuts down on copypasted code if somebody wants to add bump clicking to something else in future.
About The Pull Request
Simply converts all instances of soundkeys that use get_sfx from strings into defines.
E.g. "sparks" is now SFX_SPARKS
Why It's Good For The Game
It makes life a lot easier when you're looking for a sound effect. You just type SFX_ and you get suggestions in VSC. Plus, it looks better.
image
Changelog
Not player facing.
Replaced if(!parameter) checks with if(!isnull(parameter)). Right now you can't set destroy_objects to FALSE using the destroy argument in New() because the game will think value wasn't changed.
Fixed actively_moving being TRUE after first charge.
This PR will prevent tarantulas and other mobs that can charge from moving and destroying stuff during charge delay.
Also this PR will let us avoid problems in the future if someone decides to override destroy_objects in New()
* Machinery attack_paw gives feedback for no damage attacks
* I am growing stronger
* Makes messages consistent and read better
- Cleans up shitty code
* hmm
* Adds it to hulk object attack message
Makes the decomposition examine proc, which handles the little examine warning telling you how close to decomposing a piece of food is, not hardcoded anymore. Doing this allowed me to also...
Adds a variable to food that lets them edit the decomposition timer. By default it's set to 0, which makes food automatically get its timer based off its flags. By setting the decomposition_time variable in a /obj/item/food to anything other than 0 (using SECONDS or MINUTES), it will take that amount of time to decompose instead.
* Fit Viewport cleanup
Changes how Fit Viewport works slightly.
From what I understand, the verb was created with the goal of
eliminating the pixel hunting required to get rid of letterboxing.
This works fine for stretch to fit, but ever since the command bar got
nuked it's ended up creating a lot of blackspace for targeted zoom
modes.
I've changed how it decides on its optimal width slightly, if the client
has a non stretch to fit zoom mode, we use it, the world icon size and
the clients view size to figure out the exact width we want.
The bars on the left and right have been bugging me forever. Want them
gone.
In light of this, I'm also making changing your zoom amount attempt to
fit the viewport, if you have the pref enabled.
Oh and I'm trying something with auto fit viewport stuff.
It currently waits a second between view change and fitting. The comment
implies this is to avoid winget strangeness from Login calls. When I
blamed it, I found a commit from antruk talking about client dropping,
and this being a potential fix.
Unfortunately none wrote down what dropping means, and anturk's
forgotten.
I'm making the assumption that it's related to attempting the related
winsets before an inital login is over.
I might be wrong about this, if I am we'll know what went wrong I
suppose.
* Whoops, this needs to be invoke async
* Ensures client safety, autodocs code, adds proper cleanup
* Squashed commit of the following:
commit 71fb208502
Author: Changelogs <action@github.com>
Date: Tue Jul 6 00:09:32 2021 +0000
Automatic changelog compile [ci skip]
commit d07bfa44a4
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Mon Jul 5 13:03:46 2021 -0700
Automatic changelog generation for PR #60014 [ci skip]
commit cd147702cb
Author: Fikou <piotrbryla@onet.pl>
Date: Mon Jul 5 22:03:42 2021 +0200
fixes voice of god not giving you large text (#60014)
commit bef10b996b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Mon Jul 5 11:46:16 2021 -0700
Automatic changelog generation for PR #59988 [ci skip]
commit 7b0385468b
Author: Fikou <piotrbryla@onet.pl>
Date: Mon Jul 5 20:46:13 2021 +0200
Concussive Gauntlets Resprite by MeyHaZah (#59988)
commit 56a58fc3bc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Mon Jul 5 00:51:28 2021 -0700
Automatic changelog generation for PR #59990 [ci skip]
commit 181d64d929
Author: Fikou <piotrbryla@onet.pl>
Date: Mon Jul 5 09:51:25 2021 +0200
switchblade can now be used to butcher and slice necks, icon updates when you toggle it on (#59990)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit 2b315303d9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 20:56:32 2021 -0700
Automatic changelog generation for PR #59944 [ci skip]
commit 2a3330c132
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Sun Jul 4 22:56:28 2021 -0500
Non-changeling spawned headslugs now burst non-antag changeling variant again (#59944)
commit 3b041f8d54
Author: Fikou <piotrbryla@onet.pl>
Date: Mon Jul 5 05:54:14 2021 +0200
knight helmets no longer delete a nonexisting component (#60003)
commit 826e7b01a0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 20:53:56 2021 -0700
Automatic changelog generation for PR #59994 [ci skip]
commit 31478ebcda
Author: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Date: Sun Jul 4 20:53:53 2021 -0700
Fix cursed spring ruin acting as a polymorph teleport forwarder (#59994)
commit a5827ab8b1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 20:53:29 2021 -0700
Automatic changelog generation for PR #59999 [ci skip]
commit 4fcf927bf4
Author: Bobbahbrown <bobbahbrown@gmail.com>
Date: Mon Jul 5 00:53:26 2021 -0300
fix buckling to a vehicle not setting your initial sprite position correctly (#59999)
commit 35673b7aeb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 20:52:31 2021 -0700
Automatic changelog generation for PR #60004 [ci skip]
commit adb9b76e1c
Author: Fikou <piotrbryla@onet.pl>
Date: Mon Jul 5 05:52:28 2021 +0200
wisps no longer fall in chasms (#60004)
Co-authored-by: coiax <yellowbounder@gmail.com>
commit 69a5c827c8
Author: Changelogs <action@github.com>
Date: Mon Jul 5 00:08:58 2021 +0000
Automatic changelog compile [ci skip]
commit 7ded98f76d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 16:47:35 2021 -0700
Automatic changelog generation for PR #59993 [ci skip]
commit 9c46c01439
Author: obsol <33932119+read-0nly@users.noreply.github.com>
Date: Sun Jul 4 19:47:32 2021 -0400
Adds temperature and pressure sensors to circuits (#59993)
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
commit 6948ca330f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 16:42:32 2021 -0700
Automatic changelog generation for PR #59963 [ci skip]
commit f9a2fcfdb0
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date: Sun Jul 4 19:42:29 2021 -0400
Removes plasteel as a custom material for tanks to prevent bugs (#59963)
commit 13776b7c13
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 16:41:55 2021 -0700
Automatic changelog generation for PR #59927 [ci skip]
commit 4e891fb72e
Author: spessbro <51048066+spessbro@users.noreply.github.com>
Date: Sun Jul 4 19:41:52 2021 -0400
carnivory is visible (#59927)
commit 31942bda5b
Author: interestingusernam3 <51925758+interestingusernam3@users.noreply.github.com>
Date: Mon Jul 5 01:40:04 2021 +0200
Cleans up and DMdoc's lazarus_injector.dm. (#59937)
commit f0203b9261
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 16:39:06 2021 -0700
Automatic changelog generation for PR #59950 [ci skip]
commit 63da37d8ef
Author: TheSmallBlue <ilanmori@hotmail.com>
Date: Sun Jul 4 20:39:03 2021 -0300
Adds the "Split" circuit component (#59950)
commit 6ec208438f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 16:37:54 2021 -0700
Automatic changelog generation for PR #59983 [ci skip]
commit b7c2c9134e
Author: Fikou <piotrbryla@onet.pl>
Date: Mon Jul 5 01:37:51 2021 +0200
hiero dash now doesnt work on blocked turfs (#59983)
commit fba41ea78a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 16:37:07 2021 -0700
Automatic changelog generation for PR #59982 [ci skip]
commit f124ed1cff
Author: Fikou <piotrbryla@onet.pl>
Date: Mon Jul 5 01:37:04 2021 +0200
removes the weird light from the upgraded mining hardsuit (#59982)
commit 27e1c4d3c1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 15:28:41 2021 -0700
Automatic changelog generation for PR #59986 [ci skip]
commit 189a7160da
Author: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Date: Sun Jul 4 15:28:38 2021 -0700
sillycone touch (#59986)
commit 3d43e96634
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 15:27:17 2021 -0700
Automatic changelog generation for PR #59995 [ci skip]
commit fec650f7fe
Author: 小月猫 <alina.r.starkova@gmail.com>
Date: Sun Jul 4 18:27:15 2021 -0400
fixed the define for the shock wire (#59995)
no wonder autolathes never shocked the cargo techs whenever they hacked it
commit b647efd8fb
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date: Sun Jul 4 12:54:59 2021 -0700
Migrates the hellspawn stuff over from hackmd (#59928)
* Migrates some content over from hackmd, this should make it more visible, which I think is a good thing.
In other news, we really should reorg this document, should make subdocs like oranges wanted
* Parently we lint for this, nice
commit a6635f7efe
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 09:48:21 2021 -0700
Automatic changelog generation for PR #59985 [ci skip]
commit 35af64526a
Author: Fikou <piotrbryla@onet.pl>
Date: Sun Jul 4 18:48:18 2021 +0200
Make the light eater a mining tool (#59985)
what the title says, light eater can now pick rocks
ive had a lot of rounds as admin on kilo/tram where i have to give them this so they arent stuck in gay baby jail forever
commit e6d4748d87
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 09:47:54 2021 -0700
Automatic changelog generation for PR #59984 [ci skip]
commit cd5c44d4ed
Author: Fikou <piotrbryla@onet.pl>
Date: Sun Jul 4 18:47:51 2021 +0200
Set commission plaques to below open door layer (#59984)
it looks bad when you drop an item
commit 092c73c24e
Author: InsaneRed <47158596+InsaneRed@users.noreply.github.com>
Date: Sun Jul 4 17:29:09 2021 +0300
Update Delta Camera Dir (#59960)
commit 084d325e10
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 07:28:27 2021 -0700
Automatic changelog generation for PR #59972 [ci skip]
commit 437383413a
Author: Paxilmaniac <82386923+Paxilmaniac@users.noreply.github.com>
Date: Sun Jul 4 10:28:23 2021 -0400
Meta Atmos Piping fix (#59972)
commit bb17e725da
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 03:21:19 2021 -0700
Automatic changelog generation for PR #59968 [ci skip]
commit 5347af6dfd
Author: KIBORG04 <bossmira4@gmail.com>
Date: Sun Jul 4 13:21:16 2021 +0300
Fix reveal role from a mafia psychologist (#59968)
commit 4249a1ba6b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 02:37:32 2021 -0700
Automatic changelog generation for PR #59976 [ci skip]
commit 92c6b5f4f2
Author: Paxilmaniac <82386923+Paxilmaniac@users.noreply.github.com>
Date: Sun Jul 4 05:37:30 2021 -0400
Allows the detective's and nuke op's holsters to be placed in the suit storage slot of armor vests (#59976)
* single line change that will break everything
* now they work even better
* Trailing comma
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit 3157e7ae3d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 02:20:45 2021 -0700
Automatic changelog generation for PR #59877 [ci skip]
commit e4d8795e9c
Author: coiax <yellowbounder@gmail.com>
Date: Sun Jul 4 10:20:42 2021 +0100
Add new Wallets! station trait (#59877)
Add a new simple station trait, that replaces everyone's ID with a
wallet containing said ID, as well as their starting money, and if
they're lucky, a little bonus surprise.
In addition, adds a force variable to station traits, which will
always enable them, rather than having to edit weight and probability
of rolling a trait of that sign (postive, negative).
Co-authored-by: Rohesie <rohesie@gmail.com>
commit 8a2d5307e6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jul 4 01:50:21 2021 -0700
Automatic changelog generation for PR #59772 [ci skip]
commit a8d7b45d2a
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date: Sun Jul 4 01:50:18 2021 -0700
Ban posibrains and mmis from savannah ivanov (#59772)
Savannah Ivanov cannot have mmis or posibrains in them.
Now I know that sounds BAD... but I originally intended to do this as it removes a huge trust element and bypasses recruiting people for cooperation. I simply uuuh genuinely forgot to include this, so sorry for the DRAMA.
I was considering blocking the AI too, but AIs are actually more likely to be turned against you than fellow crewmembers
Co-authored-by: coiax <yellowbounder@gmail.com>
commit 7ef4c4c027
Author: Rohesie <rohesie@gmail.com>
Date: Sun Jul 4 02:14:44 2021 -0300
Fixes a runtime and refactors suit jetpacks a bit (#59922)
commit 7c22e67bfb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 22:06:02 2021 -0700
Automatic changelog generation for PR #59752 [ci skip]
commit b2ecb787e1
Author: Greniza <61635418+Greniza@users.noreply.github.com>
Date: Sat Jul 3 22:05:58 2021 -0700
Environment Protection Bags + Minor Weather Changes (#59752)
Co-authored-by: Matthew J. <12817816+ZephyrTFA@users.noreply.github.com>
commit ea59898bc1
Author: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
Date: Sun Jul 4 00:48:27 2021 -0400
Documents antag_datum.dm (#59967)
Co-authored-by: AnturK <AnturK@users.noreply.github.com>
commit a8839f233e
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date: Sat Jul 3 21:47:10 2021 -0700
Changes a line of the master controller to make it easier to read (#59974)
commit 12645cefc4
Author: Changelogs <action@github.com>
Date: Sun Jul 4 00:09:34 2021 +0000
Automatic changelog compile [ci skip]
commit 1e063242d0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 15:29:50 2021 -0700
Automatic changelog generation for PR #59925 [ci skip]
commit 972cd3de61
Author: Bobbahbrown <bobbahbrown@gmail.com>
Date: Sat Jul 3 19:29:46 2021 -0300
introduce advanced sucking functionality to custodians (+ bonus GAGging) (#59925)
* base sucking functionality
* functional upgrade and upgrade refactor
* minor tweak here
* finish overhaul of upgrades, add gags-ified upgrades
* add documentation (you love to see it)
* update sucking sound
* do some of the requested cleanup, fix key going into trash bag, add right click func
commit d7c855b00e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 13:59:39 2021 -0700
Automatic changelog generation for PR #59966 [ci skip]
commit 7215711974
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date: Sat Jul 3 22:59:36 2021 +0200
Fix "Is This Thing On?" sci experiment to accept any explosion(#59966)
...Even those with negative devastation and/or heavy values (like IEDs, welders, fuel tanks).
commit 24cb23fa74
Author: Rohesie <rohesie@gmail.com>
Date: Sat Jul 3 15:49:32 2021 -0300
Inexistent prefs runtime fix and a little cleanup (#59915)
commit fbfefee3cd
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 11:39:59 2021 -0700
Automatic changelog generation for PR #59938 [ci skip]
commit be92d05a4b
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date: Sat Jul 3 20:39:56 2021 +0200
Large cardboard box icon fix (#59938)
* cardboard box fix
commit 4d62d199d2
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 11:37:39 2021 -0700
Automatic changelog generation for PR #59935 [ci skip]
commit 578588e8e9
Author: MMMiracles <lolaccount1@hotmail.com>
Date: Sat Jul 3 14:37:35 2021 -0400
removed extra yellow pipe and made orange/red pipe overlap in atmos better looking (#59935)
commit a2eb5c5382
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 11:36:00 2021 -0700
Automatic changelog generation for PR #59934 [ci skip]
commit 1e5e3803ae
Author: Urumasi <Urumasi@email.cz>
Date: Sat Jul 3 20:35:57 2021 +0200
Fix turbine exploit (#59934)
commit fce141a97e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 11:33:16 2021 -0700
Automatic changelog generation for PR #59931 [ci skip]
commit 7d82dc2644
Author: Sheits <81964183+Sheits@users.noreply.github.com>
Date: Sun Jul 4 04:33:13 2021 +1000
Sprites (#59931)
commit cc791ed2be
Author: Emmett Gaines <ninjanomnom@protonmail.com>
Date: Sat Jul 3 14:31:34 2021 -0400
Makes GAGS layer limit per icon state, not per config file (#59923)
commit c9314a321e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:59:41 2021 -0700
Automatic changelog generation for PR #59962 [ci skip]
commit ebac974568
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date: Sat Jul 3 18:59:38 2021 +0100
Fixed being able to insert infinitely many components into a shell. Fixes being able to view the shell's circuit in a locked shell. (#59962)
commit b54bffe24a
Author: coiax <yellowbounder@gmail.com>
Date: Sat Jul 3 18:53:36 2021 +0100
Remove unused hivemind powers and supression (#59911)
- BZ metabolites no longer mute changeling hiveminds, because changeling
hiveminds no longer exist.
- Removed code for two unused changeling powers, Hive Channel DNA and
Hive Absorb DNA.
commit 1ee1b03df3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:53:03 2021 -0700
Automatic changelog generation for PR #59917 [ci skip]
commit 5adf4f17d2
Author: death and coding <58394696+thestubborn@users.noreply.github.com>
Date: Sat Jul 3 18:53:01 2021 +0100
Allows Bananas to be holstered (#59917)
Clowntectives can now comically whip out their trusty potassium pistol to brutally feed mimes to death. Or sneak into the detective's office and replace their actual gun with a banana.
Get it, because I call you guys the banana bros all the time?
commit f279f19e08
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:52:13 2021 -0700
Automatic changelog generation for PR #59919 [ci skip]
commit e361040c74
Author: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Date: Sat Jul 3 10:52:10 2021 -0700
Fix incorporeal movers procing containment field effects (#59919)
commit 22340a88c7
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date: Sat Jul 3 13:49:04 2021 -0400
Makes bots order from what kind of venue you are, rather than being hardcoded (#59954)
Instead of checking the type of venue to order from, they will now instead check from venue_type (Which there's currently only 2 of)
commit 7d8346eb04
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:46:46 2021 -0700
Automatic changelog generation for PR #59946 [ci skip]
commit 066e34148c
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date: Sat Jul 3 13:46:43 2021 -0400
Makes tanks display their max pressure and only return their analysed contents once (#59946)
commit cd5660a87d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:46:17 2021 -0700
Automatic changelog generation for PR #59953 [ci skip]
commit 16d89a146e
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date: Sat Jul 3 18:46:13 2021 +0100
RAM now has an option to select between types. Refactored the any type to be more friendly with circuit code. (#59953)
RAM now has an option to select between types and an output signal. Refactored the any type to be more friendly with user displays.
Code that includes changing type is no longer hard to read because of snowflake code for the "any" type.
RAM can now more easily act as a constant value component.
RAM also has an output signal because it should and the fact that it doesn't was an oversight when converting everything to use input and output signals.
commit c7d4606b68
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:44:49 2021 -0700
Automatic changelog generation for PR #59952 [ci skip]
commit d35ec05181
Author: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Date: Sat Jul 3 10:44:46 2021 -0700
Fix Cross Server Messages Containing HTML Garbage (#59952)
Gets rid of a minor annoyance that has been around since like when the feature was first added?
commit ad39071239
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:44:13 2021 -0700
Automatic changelog generation for PR #59955 [ci skip]
commit a57a04b320
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date: Sat Jul 3 18:44:09 2021 +0100
Fixed carps being untameable and fixes tameable code not properly removing itself from something (#59955)
Fixes#59897
commit 452952851d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:43:38 2021 -0700
Automatic changelog generation for PR #59942 [ci skip]
commit 11dd7a852b
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date: Sat Jul 3 18:43:35 2021 +0100
Adds crew monitor usb connections and fixes the soundemitter's frequency port (#59942)
Adds crew monitor usb connections and fixes the soundemitter's frequency port
Allows you to view health and stuff.
commit ed6d5465b5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:42:45 2021 -0700
Automatic changelog generation for PR #59958 [ci skip]
commit 3356f5d2ab
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date: Sat Jul 3 18:42:42 2021 +0100
Fixed cooldowns for speech and soundemitter circuit components. Brought speech component more in line with other components. (#59958)
Fixes to the cooldowns. Also circuits now use an input trigger/output trigger system which the speech component hadn't yet adopted because it was made before that system was introduced and left out when changing most components to use this system.
Also temporarily disables input/output signal ports for the prebuilt speech relay circuit until I can properly code in a way to load circuits.
commit 78f9f71ceb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:41:36 2021 -0700
Automatic changelog generation for PR #59959 [ci skip]
commit 5e6a90a0d5
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date: Sat Jul 3 18:41:32 2021 +0100
Limits the maximum string length of a circuit component port to 5K characters (#59959)
People could duplicate string lengths to the point where UIs break (and maybe OOMs though it'd take a while).
commit 6c502cecd5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:35:37 2021 -0700
Automatic changelog generation for PR #59941 [ci skip]
commit e29c6c7a89
Author: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Date: Sat Jul 3 10:35:33 2021 -0700
Hookup Change Command Name to Create Command Report (#59941)
Adds and defaults the contents of command_name() to the list of names in the Create Command Report tgui presets if changed from Central Command.
commit 101da02669
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:34:35 2021 -0700
Automatic changelog generation for PR #59943 [ci skip]
commit cc40cc4677
Author: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Date: Sat Jul 3 10:34:32 2021 -0700
Fix blanket cure_blind calls removing quirk and blindfold traits (#59943)
Makes it so when proc/cure_blind(source) is called with no source is does not cure blindness from the quirk, blindfolds, or other eye coverings.
commit 87f0e0d4a0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jul 3 10:31:40 2021 -0700
Automatic changelog generation for PR #59957 [ci skip]
commit 3c7c5f0dbe
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date: Sat Jul 3 10:31:37 2021 -0700
PDAs now include round time (#59957)
Part of my document on duplicating verb panel functionality so at some point in the far, far future we may be rid of it. you can read more here.
hackmd.io/tJ5H3opRQiG1GCN1sP142w
The other thing the status panel needs to do is send time dilation to the tgui chat. Having messed around with tgui chat, I am very confident i'm going to need stylemistake or mothblocks help me out with that one, it's so beyond my level it isn't even funny.
I know this is a VERY long description for a very small change but expect more of this in the future
commit 911d762562
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Jul 2 21:23:19 2021 -0700
Automatic changelog generation for PR #59638 [ci skip]
commit 4a62b6ba9c
Author: YakumoChen <king_yoshi42@yahoo.com>
Date: Sat Jul 3 04:23:16 2021 +0000
New contraband peanuts (#59638)
Adds a new variety of peanuts to Getmore
Tweaks peanuts to have a higher price, since they're currently the best thing to buy in the vendor.
commit d20a701b7c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Jul 2 21:01:17 2021 -0700
Automatic changelog generation for PR #59947 [ci skip]
commit 97e15965a1
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date: Sat Jul 3 00:01:14 2021 -0400
Fix ion carbine parts kit's name and other similar grammar issues (#59947)
commit 4b84de5573
Author: Changelogs <action@github.com>
Date: Sat Jul 3 00:09:45 2021 +0000
Automatic changelog compile [ci skip]
commit 72c047c72e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Jul 2 16:23:20 2021 -0700
Automatic changelog generation for PR #59574 [ci skip]
commit 629c06dee7
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date: Sat Jul 3 00:23:17 2021 +0100
Adds blob as a midround antag like midround traitors, where it does not require a ghost role (#59574)
Co-authored-by: Jonathan Rubenstein <jrubcop@gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
commit d4ed79af38
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date: Sat Jul 3 00:17:33 2021 +0100
Fix error on secondary attacking certain secure closets. (#59867)
* Feex
* Reviewify
commit dd8e5e559a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Jul 2 13:21:36 2021 -0700
Automatic changelog generation for PR #59939 [ci skip]
commit 3c202820ef
Author: interestingusernam3 <51925758+interestingusernam3@users.noreply.github.com>
Date: Fri Jul 2 22:21:33 2021 +0200
Makes polar bears not become easier to move after you kill and revive them (#59939)
commit 5b35c83f3e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Jul 2 08:59:41 2021 -0700
Automatic changelog generation for PR #59921 [ci skip]
commit f5be9c5cee
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date: Fri Jul 2 08:59:38 2021 -0700
Removes reference to intents from Martial Arts instructions (#59921)
In CQC, Plasma Fist, Sleeping Carp and Wrestling instructions verb:
Harm -> Punch
Disarm -> Shove
Also removed reference to intents from the changeling's tentacle grab, changing it to neutral/combat stance.
commit c5914c4784
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 21:32:22 2021 -0700
Automatic changelog generation for PR #59887 [ci skip]
commit 4ae906446f
Author: aaaa1023 <74441292+aaaa1023@users.noreply.github.com>
Date: Thu Jul 1 22:32:19 2021 -0600
Sink frames are now deconstructable (#59887)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit 6e7a2372a2
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 17:18:09 2021 -0700
Automatic changelog generation for PR #59773 [ci skip]
commit 444ae340d0
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date: Thu Jul 1 17:18:06 2021 -0700
Catwalk Flooring (#59773)
commit 8841fb0006
Author: Changelogs <action@github.com>
Date: Fri Jul 2 00:11:47 2021 +0000
Automatic changelog compile [ci skip]
commit 2c5a357035
Author: Rohesie <rohesie@gmail.com>
Date: Thu Jul 1 21:06:42 2021 -0300
Reverts Entered() passing dir instead of old loc (#59910)
commit 512fe152ab
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 16:37:38 2021 -0700
Automatic changelog generation for PR #59918 [ci skip]
commit 1faae1350b
Author: Cheshify <73589390+Cheshify@users.noreply.github.com>
Date: Thu Jul 1 19:37:35 2021 -0400
Fixes Pocket Protector/Flashlight Pen Oversight (#59918)
commit ab8ba5ce2f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 16:35:30 2021 -0700
Automatic changelog generation for PR #59920 [ci skip]
commit 0ce099fd77
Author: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Date: Thu Jul 1 16:35:26 2021 -0700
Fix rogue vending machines targeting incorporeal (#59920)
commit db71bc8455
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 13:56:53 2021 -0700
Automatic changelog generation for PR #59909 [ci skip]
commit e1d3c12dba
Author: Sparkezel <53384660+Sparkezel@users.noreply.github.com>
Date: Thu Jul 1 22:56:50 2021 +0200
Make bat hits no longer stunlock (#59909)
Wooden bats are 2nd best melee weapon in game, just next to stun batons. They cost 5 wooden planks which makes them ridiculously cheap and available to everyone, and the worst thing about them is how easily they can just stunlock people out of nowhere. I did what I believe was the best way to balance them out
commit 5600467371
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 13:31:14 2021 -0700
Automatic changelog generation for PR #59884 [ci skip]
commit 05a4afd2fd
Author: Emmett Gaines <ninjanomnom@protonmail.com>
Date: Thu Jul 1 16:31:10 2021 -0400
Adds verification for reference layers to check if target config has the desired icon_state (#59884)
commit 65de6ac785
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 13:31:01 2021 -0700
Automatic changelog generation for PR #59832 [ci skip]
commit bc09b1d15a
Author: Seris02 <49109742+Seris02@users.noreply.github.com>
Date: Fri Jul 2 04:30:58 2021 +0800
Makes it so changeling legs copy digitigrade/normal, try number 2 (#59832)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit c7c84cc47d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 11:58:36 2021 -0700
Automatic changelog generation for PR #59735 [ci skip]
commit 38278f2e17
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date: Thu Jul 1 14:58:33 2021 -0400
Change uplink implants to inherit the uplink flags of the uplink they were bought from (#59735)
Uplinks implants bought from uplinks inherit the uplink flags of the uplink they were bought from.
This fixes an undocumented bug where by purchasing an uplink implant, nuke ops would be able to get things they normally can't.
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
commit fee8d505f1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 01:23:09 2021 -0700
Automatic changelog generation for PR #59875 [ci skip]
commit b949810112
Author: Bobbahbrown <bobbahbrown@gmail.com>
Date: Thu Jul 1 05:23:03 2021 -0300
Remove ability to circumvent config VAS protection (#59875)
commit 77766aa79f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 01:13:46 2021 -0700
Automatic changelog generation for PR #59904 [ci skip]
commit 1524f80565
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date: Thu Jul 1 04:13:42 2021 -0400
Fixes OOC heart commendations not saving between rounds (#59904)
commit 8c2c0670c8
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 01:13:24 2021 -0700
Automatic changelog generation for PR #59902 [ci skip]
commit e42f7f867d
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Thu Jul 1 03:13:20 2021 -0500
Fixes spread glowshrooms runtiming on initialize (#59902)
commit e381dbd79e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Jul 1 00:50:04 2021 -0700
Automatic changelog generation for PR #59905 [ci skip]
commit 8168f8d84c
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date: Thu Jul 1 03:50:01 2021 -0400
Fixes being able to sacrifice pAI's (#59905)
commit c5c941766b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 19:41:07 2021 -0700
Automatic changelog generation for PR #59873 [ci skip]
commit 90a611a344
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date: Thu Jul 1 03:41:04 2021 +0100
Fix forensic component inheritance inserting null entries into lists and causing to_chat errors. (#59873)
Fixing the following runtime:
[17:13:04] Runtime in to_chat.dm,88: Empty or null string in to_chat proc call.
proc name: to chat (/proc/to_chat)
usr: Cowboy_penis_monster/(Zackary Mason)
usr.loc: (Telecomms Control Room (105,89,2))
src: null
call stack:
to chat(Zackary Mason (/mob/living/carbon/human), "", null, "", 0, 1, 1, 0)
the forensic scanner (/obj/item/detective_scanner): add log("", 1)
the forensic scanner (/obj/item/detective_scanner): scan(Control Room (/obj/machinery/door/airlock/command/glass), Zackary Mason (/mob/living/carbon/human))
Forensic scanner attempting to add "" to the logs, which eventually gets output to_chat.
Tracked error down to forensic component lazylists and the fun of trying to OR two lazylists together.
commit 86f12caeef
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 18:46:27 2021 -0700
Automatic changelog generation for PR #59871 [ci skip]
commit 63f84711ed
Author: 小月猫 <alina.r.starkova@gmail.com>
Date: Wed Jun 30 21:46:24 2021 -0400
Fixes some minor tramstation mapping issues (#59871)
* Added heavy firedoors on the windows between toxins and the sci hallways
* Fixed air alarm placement in science
* added missing air alarms in engineering
* kitchen freezer now has the proper area
* sec point near arrivals had no air alarm
* added missing air alarms in security
* added missing air alarms in science
* added missing air alarm in escape hallway
* removed redundant air alarm
* added APC in kitchen
commit d368e4d49d
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date: Wed Jun 30 17:51:35 2021 -0700
Changes how weather sends sound to players, reduces sound loop overtime (#59284)
* Converts looping sounds from a list of play locations to just the one
* Updates all uses of looping sounds to match the new arg
* Adds an area based sound manager that hooks into looping sounds to drive the actual audio. I'll be using this to redo how weather effects handle sound
* Some structrual stuff to make everything else smoother
Timers now properly return the time left for client based timers
Weather sends global signals when it starts/stops
Looping sounds now use their timerid var for all their sound related timers, not just the main loop
* This is the painful part
Adds an area sound manager component, it handles the logic of moving into new areas potentially creating new
sound loops. We do some extra work to prevent stacking sound loops.
Adds an ash storm listener element that adds a tailored area sound manager to clients on the lavaland z level.
It's removed on logout.
Adds the ash_storm_sounds assoc list, a reference to this is passed into area sound managers, and it's modified
in a manner that doesn't break the reference in ash_storm (This is what I hate)
* Hooks ash storm listener into cliented mobs and possessed objects
* Documents the odd ref stuff, adds an ignore start var to looping sounds, fixes some errors and lint issues
* Applies kyler's review
banging
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
* Cleans up some var names, reduces the amount of looping we do in some areas
* Makes the code compile, redoes the movement listener to be more general
* fuck
* We don't need to detach on del if we're just removing signals on detach
* Should? work
* if(direct) memes
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
commit 52398b255a
Author: Changelogs <action@github.com>
Date: Thu Jul 1 00:09:35 2021 +0000
Automatic changelog compile [ci skip]
commit 7eacef421a
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date: Wed Jun 30 16:01:26 2021 -0700
Revert "Barticles for bonfires 2021 (#59869)" (#59916)
This reverts commit 0ad74e9637.
commit c94d077ca2
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 14:32:34 2021 -0700
Automatic changelog generation for PR #59893 [ci skip]
commit 39a9331614
Author: Malgover <56408561+Malgover@users.noreply.github.com>
Date: Wed Jun 30 23:32:31 2021 +0200
New riot gear sprites (#59893)
commit 852a839a50
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 14:31:51 2021 -0700
Automatic changelog generation for PR #59869 [ci skip]
commit 0ad74e9637
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date: Wed Jun 30 14:31:48 2021 -0700
Barticles for bonfires 2021 (#59869)
* barticles
* better bode
commit 257b90dd62
Author: Rohesie <rohesie@gmail.com>
Date: Wed Jun 30 18:29:03 2021 -0300
Fixes oneway effects (#59872)
commit c3f659295f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 14:25:16 2021 -0700
Automatic changelog generation for PR #59888 [ci skip]
commit 7e2a944fc7
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date: Wed Jun 30 23:25:13 2021 +0200
Null rod radial menu update (#59888)
Co-authored-by: Fikou <piotrbryla@onet.pl>
Co-authored-by: Emmanuel S. <emmanuelssr@gmail.com>
commit be0e1c4360
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 14:16:27 2021 -0700
Automatic changelog generation for PR #59684 [ci skip]
commit 6e01f2901f
Author: bloons3 <bloons3@users.noreply.github.com>
Date: Wed Jun 30 16:16:23 2021 -0500
Enhances AI law and borg logging (#59684)
Persistent logging for sometimes disputed actions
The "impacted cyborgs" is useful for reconstructing which borgs were synced to an AI at what time, which sometimes may not be clear from logs
commit 2d597584c8
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 11:38:34 2021 -0700
Automatic changelog generation for PR #59866 [ci skip]
commit 02f0fe75fa
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date: Wed Jun 30 19:38:31 2021 +0100
Adds the sound emitter circuit component (#59866)
Adds the sound emitter circuit component. Allows the integrated circuit to play a sound of varying volume and frequency.
commit 6f3f14566a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 10:21:11 2021 -0700
Automatic changelog generation for PR #59865 [ci skip]
commit b9dbda85a5
Author: Time-Green <timkoster1@hotmail.com>
Date: Wed Jun 30 19:21:08 2021 +0200
Massively buffs debriding surgery (#59865)
Yesterday, I got lasered in the arm twice. A good three minutes later I lose all controle off my arm and have an assistant debride my arm. On a surgical table with sterilizine, this took 2 minutes and 30 seconds.
All wounds can be fixed quite easily, but the infection wound type has always been an absolute nightmare. This was the only time I recorded it, but this has happened so many times and it feels like the average lies around 4~ minutes for this surgery to complete.
It still depends on how badly infected your burn wound is, but it shouldn't take longer than 30 seconds now.
commit a0941fe7f2
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 09:47:44 2021 -0700
Automatic changelog generation for PR #59885 [ci skip]
commit fcf6bbd9ec
Author: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Date: Wed Jun 30 09:47:41 2021 -0700
Fix cyborg locker right click (#59885)
I guess silicon shared the old AltClick proc with other living, but that is not the case for secondary click.
commit a2a40e2b08
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 09:46:51 2021 -0700
Automatic changelog generation for PR #59883 [ci skip]
commit 9d80156890
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date: Wed Jun 30 09:46:46 2021 -0700
Fixes an issue with performance logging (#59883)
Redoes how logs are generated, calling profile() does not guarentee that the output logs will contain one of each entry, if the value is 0 it just doesn't return data for that entry. So we need to do some memes to make sure things are working properly
Removes a debug proc that I forgot about
commit 7ad39850ed
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 09:40:26 2021 -0700
Automatic changelog generation for PR #59882 [ci skip]
commit 71e2191f5f
Author: Bobbahbrown <bobbahbrown@gmail.com>
Date: Wed Jun 30 13:40:22 2021 -0300
Add 'other tickets by user' to adminhelp ticket panel (#59882)
added a list of other tickets that have been opened by a user, when relevant, to the adminhelp ticket panel.
commit ce7a658c10
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 09:39:04 2021 -0700
Automatic changelog generation for PR #59852 [ci skip]
commit 31e9f7444a
Author: KubeRoot <kubinator4321@gmail.com>
Date: Wed Jun 30 18:39:01 2021 +0200
Make transit tube dispenser stations buildable (#59852)
Dispenser stations had some sprite issues due to using wrong icon states and having wrong orientation for flipped versions.
This PR fixes the issues and adds them to the RPD.
I can remove them from RPD construction if you don't want them to be constructible - this was the main motivation for implementing the changes in a downstream.
commit 3a0815f191
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Jun 30 01:30:55 2021 -0700
Automatic changelog generation for PR #59879 [ci skip]
commit 0f0714691e
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date: Wed Jun 30 01:30:51 2021 -0700
fixes buying shuttle insurance while the shuttle is docked (#59879)
* ok
* ??
commit bc79093c63
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Jun 29 21:21:00 2021 -0700
Automatic changelog generation for PR #59874 [ci skip]
commit 634049e1e9
Author: Bobbahbrown <bobbahbrown@gmail.com>
Date: Wed Jun 30 01:20:57 2021 -0300
Add $reset directive to config processor for setting a config entry to default value (#59874)
added this so that the value of INTERVIEW_QUESTIONS (and subsequently any other string list) can be overridden without much issue by additional config files.
i also changed the functionality of default on config_entry as it seemed to be counterintuitive to have it be set to the initial value of the config_entry. in my opinion this should be a compile-time default, and so i've refactored the code such that default now contains the actual default, and the config_entry_value is set at intialization.
commit 3542c43c5a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Jun 29 18:05:36 2021 -0700
Automatic changelog generation for PR #59880 [ci skip]
commit 50954715d8
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date: Wed Jun 30 03:05:33 2021 +0200
Fixes relic war hammer typepath (#59880)
This PR fixes a typepath mismatch - /obj/item/nullrod/hammmer and /obj/item/nullrod/hammer, which are supposed to be one item. This mismatch caused relic war hammer not to be able to do kneejerk action, and it also meant that one duplicate nullrod item was showing in the radial menu for the null rod reskin variant selection.
commit 4549b0be9d
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date: Wed Jun 30 02:03:58 2021 +0100
Fix to_chat error with empty surgery step strings (#59876)
/datum/surgery_step/incise/success() has no vague_message arg in a certain edge case when calling display_results. This eventually leads to an empty string being sent to /mob/proc/show_message() - Unsure if this is intended or not, but I've added an equivalent string based on the other usages of display_results instead of sending an empty string.
commit c0e41885b8
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Jun 29 17:53:40 2021 -0700
Automatic changelog generation for PR #59894 [ci skip]
commit 03c1ce3932
Author: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Date: Tue Jun 29 17:53:37 2021 -0700
Fix hand teleporter and other portals looping forever (#59894)
Makes portals use Bumped() instead of COMSIG_ATOM_ENTERED for detecting atoms crossing the event horizon.
Removes unused and potential loop causing forceMove argument from do_teleport()
commit 2c7c09867f
Author: Changelogs <action@github.com>
Date: Wed Jun 30 00:09:55 2021 +0000
Automatic changelog compile [ci skip]
commit 7771a76dca
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Jun 29 13:23:17 2021 -0700
Automatic changelog generation for PR #59850 [ci skip]
commit 7e9e2df721
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date: Tue Jun 29 21:23:14 2021 +0100
Adds USB to arrest consoles. Adds list circuit components. (#59850)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit b2285bf29b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Jun 29 12:50:32 2021 -0700
Automatic changelog generation for PR #59868 [ci skip]
commit d0181eacad
Author: Fikou <piotrbryla@onet.pl>
Date: Tue Jun 29 21:50:29 2021 +0200
Fix singularity beacon (#59868)
Stops singularity objects from being added to the global singularity list,
this list is only for singularity components.
This fixes singularity beacons breaking because they expect that only
singularity components are in the global singularity list.
commit 11b8701215
Author: AnturK <AnturK@users.noreply.github.com>
Date: Tue Jun 29 21:13:12 2021 +0200
Fixes minor quirk runtime. (#59870)
commit 2a1569a7a7
Author: Time-Green <timkoster1@hotmail.com>
Date: Tue Jun 29 18:21:47 2021 +0200
Remove unnecessary species breath code (#59864)
Human code override breathe(), called the species datum which checked if the human had NO_BREATH. I just made it check for NOBREATH directly, since it is apparently a human only trait.
If someone wants to implement special breathing checks/behaviour, make custom lungs
commit ae078ffbfa
Author: spessbro <51048066+spessbro@users.noreply.github.com>
Date: Tue Jun 29 04:45:18 2021 -0400
puts the drag_pickup component on card decks (#59857)
commit 3801c24229
Author: oranges <email@oranges.net.nz>
Date: Tue Jun 29 20:44:43 2021 +1200
Update rust-g version to latest release (#59863)
* Update rust version to latest release
This should fix the fact our docker build has been failing for the past
10 days
* Make wget not be quite so noisy
commit 79680e46aa
Author: Changelogs <action@github.com>
Date: Tue Jun 29 00:11:50 2021 +0000
Automatic changelog compile [ci skip]
commit 3c91a86cc5
Author: Rohesie <rohesie@gmail.com>
Date: Mon Jun 28 19:44:53 2021 -0300
Fixes a runtime: Entered() passing the wrong args (#59854)
commit c183ddf839
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Mon Jun 28 15:39:26 2021 -0700
Automatic changelog generation for PR #59855 [ci skip]
commit c3917b8225
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date: Mon Jun 28 23:39:23 2021 +0100
Cooked steaks are once again edible. (#59855)
commit baa1b96449
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Mon Jun 28 07:03:25 2021 -0700
Automatic changelog generation for PR #59520 [ci skip]
commit 24be009e96
Author: zxaber <37497534+zxaber@users.noreply.github.com>
Date: Mon Jun 28 07:03:22 2021 -0700
Jaunting no longer allows you to end up inside a wall (#59520)
Jaunting now keeps track of the last five non-blocked tiles you moved across while in the jaunt. Upon exit, it will attempt to deposit you into the last unblocked tile. Should it run out of tiles to try, you will be returned to your starting location. As such, jaunting mobs can no longer end up inside walls or dense objects. Tables, and anything else with the climbable element, are still allowed.
Added support to /turf/proc/is_blocked_turf() to allow ignoring climbable atoms.
Added the TRAIT_CLIMBABLE trait, applied by the climbable element, to accomplish the above.
commit f7ac03beb0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Mon Jun 28 07:02:01 2021 -0700
Automatic changelog generation for PR #59848 [ci skip]
commit baf7efb692
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date: Mon Jun 28 10:01:58 2021 -0400
Slightly buffs knife wounds, slightly nerfs scalpel wounds (#59848)
Recently it came to my attention that knives are actually really bad at causing slashing wounds, while the scalpel is probably a little too good at causing them, even through armor. So, here's what this PR does:
Knives in general are more effective at causing slash wounds, especially if the target has no armor/clothing on that limb. The butcher's cleaver in particular is now equally as effective as a circular saw.
Scalpels are a bit less effective at causing slash wounds against armor/clothing, though they're still extremely good at cutting, especially against exposed flesh.
With these stats, knives will be more effective against unarmored targets, and can actually be counted on to draw blood when needed.
commit ff0031b244
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Mon Jun 28 06:56:36 2021 -0700
Automatic changelog generation for PR #59779 [ci skip]
commit 52283197a6
Author: Sheits <81964183+Sheits@users.noreply.github.com>
Date: Mon Jun 28 23:56:33 2021 +1000
Paradox bag resprite and rework (#59779)
Paradox bags can now be worn on the belt slot instead of the back, while being able to carry less (it can still fit inside bags).
Adds new sprites for the icon and belt.
commit fbdfde900c
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date: Mon Jun 28 14:11:33 2021 +0100
The to_chat proc no longer accepts null or empty strings and runtimes instead. (#59843)
* Catch null text sent to to_chat
* Brain traumas no longer send empty to_chat gain strings
* Make to_chat_immediate changes and clean up args list formatting
* Fix empty to_chat message where there is no memo for admins
* Fix additional edge case where there are no messages for the ckey.
commit 5f4c0baeea
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jun 27 19:02:23 2021 -0700
Automatic changelog generation for PR #59675 [ci skip]
commit 901d6c0651
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date: Sun Jun 27 22:02:20 2021 -0400
Cyborg Cult Sacrifice Fix (#59675)
This PR fixes cyborgs' interactions with Cult's offer rune. Before this PR, the game would attempt to sacrifice the cyborg and put its mind into a soulstone by handing it over to a method that was incapable of doing so, thus creating an empty soulstone and permanently removing the cyborg from the round as a result. Now, attempting to offer a cyborg on an offer rune provides the first activator with an option of any construct to turn the cyborg into, and turns them into that when chosen, similar to how twisted construct operates but without the wait time.
Also moves cult construct list into global vars, renames THEME_CULT into THEME_FAKE_CULT and adds a real THEME_CULT for actual cult constructs, and added another proc to handle the class switching.
commit f7d2ce1510
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jun 27 18:11:55 2021 -0700
Automatic changelog generation for PR #59839 [ci skip]
commit cb3835db08
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date: Mon Jun 28 02:11:52 2021 +0100
Fix obsessed antags not getting policy string output to chat (#59839)
commit ac8a7cdf5d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jun 27 18:11:35 2021 -0700
Automatic changelog generation for PR #59822 [ci skip]
commit f0da569a02
Author: Aronai Sieyes <arokha@arokha.com>
Date: Sun Jun 27 21:11:32 2021 -0400
Fix tgui async modals (#59822)
* Fix tgui async modal constructor order
* Fix another bug with the async modals
commit 80875b03a6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jun 27 18:10:38 2021 -0700
Automatic changelog generation for PR #59830 [ci skip]
commit 891d7bb363
Author: zxaber <37497534+zxaber@users.noreply.github.com>
Date: Sun Jun 27 18:10:35 2021 -0700
Sets RD consoles to have two ID card slots (#59830)
commit dffa8af41e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jun 27 17:14:50 2021 -0700
Automatic changelog generation for PR #59360 [ci skip]
commit d3dd525e08
Author: cacogen <25089914+cacogen@users.noreply.github.com>
Date: Mon Jun 28 12:14:48 2021 +1200
Cannabis has more believable effects (#59360)
Adds cannabis reagent and replaces space drugs with it in cannabis products
Adds space drugs to rainbow weed, which fits its theme and might satisfy the people who miss the effect
Removes lipolicide from cannabis products in favour of the reagent consuming nutrition directly
Cannabis reagent gives you messages describing symptoms of cannabis intoxication, makes you laugh, makes you hungry, has a chance to couchlock you buckled to a chair and put you to sleep lying down
Cannabis no longer references hallucinating, can't be overdosed and has no addiction
Adds Stoned status effect, which is applied by cannabis reagent
Stoned status effect slows you down, gives you bloodshot eyes, makes you clumsy, boosts your mood and gives you the drugged sound environment
Adds "stoned" icon state for Stoned status effect screen alert (sprite shamelessly stolen from the Smoke spell)
Adds BLOODSHOT_EYES trait, which is applied by Stoned status effect
Adds examine eye descriptions for bloodshot eyes and player-chosen red eyes
Adds cannabis movespeed modifier, which is applied by the Stoned status effect
Adds Stoned mood event, which is applied by Stoned status effect and gives the same mood boost as High but doesn't reference tripping
commit d986f791ed
Author: Changelogs <action@github.com>
Date: Mon Jun 28 00:09:47 2021 +0000
Automatic changelog compile [ci skip]
commit 1cdbec7a37
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jun 27 15:31:07 2021 -0700
Automatic changelog generation for PR #59750 [ci skip]
commit 7ace8da9e0
Author: Kyle Spier-Swenson <kyleshome@gmail.com>
Date: Sun Jun 27 15:31:03 2021 -0700
Adds configs to disable laggy hard deletes (#59750)
cl
server: Added configs to disable laggy hard deletes once they lag the server too much.
admin: laggy hard deletes only output once per type path.
/cl
closes#58379
commit 56ec8af075
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jun 27 11:12:53 2021 -0700
Automatic changelog generation for PR #59820 [ci skip]
commit 2303f6a892
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date: Sun Jun 27 11:12:50 2021 -0700
Remove yellow siding tiles (#59820)
They're only used at Centcom, and we have decals now to do what these tiles do.
commit 134f266f78
Author: Rohesie <rohesie@gmail.com>
Date: Sun Jun 27 13:45:24 2021 -0300
Document Moved() and forwards old_locs (#59819)
- Passes the proper arguments on Moved(), forgot to do this on another PR.
- Documents the proc better.
- Cleans up code a little.
commit 3316e2223f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jun 27 08:35:57 2021 -0700
Automatic changelog generation for PR #59801 [ci skip]
commit a915c7167e
Author: Time-Green <timkoster1@hotmail.com>
Date: Sun Jun 27 17:35:53 2021 +0200
Refactors species stomach code, makes ethereal charge inherent to their stomach (#59801)
A stomach would literally just ask the species datum how to be hungry and made a bunch of exceptions for ethereals. I mostly just moved code around so that hunger is handled by a persons stomach, thus shrinking the species.dm bloat.
This also makes it so ethereal's charge mechanic is unique to their stomache, instead of this really weird inbetween where just nothing happens and you kinda starve to death. You can stick an ethereal stomach in a human and this will replace their hunger mechanic with the charge mechanic and lets them absorb power from APCs and everything. You can also give ethereals a normal stomach and they'll use the normal hunger mechanics
commit 04e845fa77
Author: AnturK <AnturK@users.noreply.github.com>
Date: Sun Jun 27 17:33:23 2021 +0200
Fixes projectile runtime (#59824)
For example projectile moving into a chasm on last step.
commit 23790c6c5e
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date: Sun Jun 27 07:43:49 2021 -0700
Fix missing SIGNAL_HANDLER (#59826)
Adds SIGNAL_HANDLER to everywhere that didn't have it that was picked up by dm-lua, which is now ready enough to catch these.
commit 8b2c21cfa1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sun Jun 27 07:18:45 2021 -0700
Automatic changelog generation for PR #59831 [ci skip]
commit c13a7a83a9
Author: Coconutwarrior97 <40315842+Coconutwarrior97@users.noreply.github.com>
Date: Sun Jun 27 09:18:42 2021 -0500
Free golem policy (#59831)
Adds policy.json functionality for Free Golems, will make it easier for future headmins to alter the policy.json rather than PR a change.
commit 2f7c7d0bad
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Jun 26 19:26:36 2021 -0700
Automatic changelog generation for PR #59556 [ci skip]
commit 67c89fa1ab
Author: Emmett Gaines <ninjanomnom@protonmail.com>
Date: Sat Jun 26 22:26:33 2021 -0400
Greyscale Mat Datum Stationary Smooth Tanks (#59556)
Stationary gas tanks have been in a terrible place for a long time, this addresses some of the issues with a more balance focused change coming in a second mapping pr after this one.
Stationary gas tanks have been made constructable and act similarly to canisters in that they can be damaged, repaired, and over-pressurized to explode. Additionally, they can be made with any rigid material and their stats depend on that material. A glass tank is going to have far less pressure capability than one made of plasteel.
In terms of gameplay there are two main differences now: Adjacent stationary tanks will merge together both graphically and with their internal storage. Any port on any of the tanks can access this shared storage. Also stationary tanks no longer magically have many times the volume for gas as the tile it's in, instead they have a pressure cap and a normal amount of volume.
Of interest to coders this pr also adds a generic grouping datum that acts similar to how pipe networks work. It maintains a listing of all adjacent objects whose type falls within a specified filter. In this case it's us…
* initial
* actually works
* Removes defines
* Autodocs, SIGNAL_HANDLER cleanup and better documentation
Monkey knockdown used to be on Crossed until it was made an AI here: 55238
Now it instead uses COMSIG_ATOM_ENTERED, which only takes into account walking over the monkey. Something that you can't do unless you are non-dense or they are lying on the floor, in which case you aren't even knocking them down?
Now it uses COMSIG_MOVABLE_CROSS instead so it's how it used to be, actually functional and useful.
How do I play/test/operate this?
Download NT Frontier on any modular computers. It should debrief you on what experiments are available and how to publish.
If you want to do a bomb experiment, make sure it's captured by the doppler array (as usual) and then print the experiments into a disk and publish it.
If you want to do a gas experiment, make the gas and either pump it into a tank and 1) overpressurize it with a "clear" gas like N2 or 2) overpressurize tanks with the gas itself. Make sure you do the overpressurizing in the compressor machine. When tanks are destroyed/ejected leaked gas will get recorded. Print it into a disk and publish it.
For publication, the file needs to be directly present inside the computer's HDD. This means you need to copy it first with the file manager.
Fill the data (if desired, it will autofill with boiler plate if you dont) and send away!
Doing experiments unlock nodes, while doing them well unlocks boosts (which are discounts but slightly more restrictive) which are purchaseable with NT Frontier.
If you are testing this and have access to admin tools, there are various premade bombs under obj/effect/spawner/newbomb
A doc I wrote detailing the why and what part of this PR.
https://hackmd.io/JOakSYVMSh2zU2YL5ju_-Q
---
# Intro
## The Problem(s)
Ordnance, (previously toxins) seems to lack a lot of content and things to do. The gameplay loop consists of making a bomb and then sending it off for credits or using it to refine cores. Ordnance at it's inception originally relies on players experimenting and finding the perfect mix over multiple rounds, but once the recipe for a "do-everything" mix got out, the original charm of individual discoveries becomes meaningless.
Another issue with ordnance is the odd difficulty curve. As a new player, ordnance is almost impossible to decipher, but once you watch a tutorial or read a wiki and can mail a 50k into space, there pretty much isn't anything else to do. Most players will be satisfied at this point without the gameplay loop encouraging them to understand or play more. The only thing you can do afterwards is to sink your teeth in and understand why that particular mix explodes the way it does. This again has a significant difficulty curve, but if you do that, the department doesn't acknowledge or reward that in any way. There are pretty much two huge spikes, with the latter one not really existing inside the department.
TLDR:
* The content being same-y over rounds.
* Odd difficulty curve:
1. A new player is oblivious to everything.
2. Those in the middle can repeat the final goal consistently without needing to understanding why
3. There is nothing to justify spending more time in the department after reaching the midgame.
## Abstract
Scientific Papers aim to add a framework to run multiple experiments in ordnance. Adding more experiments scattered across various atmospheric aspects might allow players of various knowledge levels to still have something engaging to do. A new player should have an easier challange than to mail a 50K. While those that already can make bombs should have an easier time understanding why their bombs explode the way it does. Once they fully understand why, they can set their sights on taking advantage of another reaction to set their bomb off or hone one particular reaction down.
## Goals
* Have some intro-level challanges for new players.
* Have some semblance of late-game challanges for more experienced players.
* Explain the mechanics better for those in the middle of the road.
* Incentivize trying new things out in the department.
* Better integrate Ordnance with Experisci
## Boundaries / Dont's
* Do not incentivize people to learn ordnance by using PvP loots.
* Do not shake or change the reaction system by a huge amount.
* Disincentivize having a single god-mix that does everything.
****
# Main design pillars
## A. Framework surrounding the experiments
### A.1. New experiments
Add new experiments to the ExperiSci module. These will come in two flavours: New explosions to do, and various gas synthesis experiments. Both of these are actually supported by the map layout of ordnance right now, but there is no reason to do anything outside of making a 50k as fast as possible.
### A.2. Rewards for experiments: Cash and Techweb Boosts.
Scientific papers will add a separate experiment handling system. A single experiment will be graded into various tiers, each tier corresponding to the explosion size or amount of gas made. Doing any tier of a specific experiment will unlock the discount for that specific reactions. A single explosion **WILL NOT** do multiple experiments (or even tiers) at once.
On publication, a partner can be selected. A single partner only has a specific criteria of experiments they want. The experiments will then be graded on "how good they are done", with the criteria being more punishing as tier increases. Publication will then reward scientific cooperation with the partnered partner. Players can spend this cooperation on techweb boosts. Techweb boosts are meant to be subservient to discount from experiments and will not shave a node's price to be lower than 500 points.
**Experiments will only unlock nodes, discounts are handled through this boost system.**
This is more for maintainability than anything.
### A.3. On Tedium
*This is a note on implementation more than anything, but I think this helps explains why several things are done.*
Due to the nature of atmospheric reactions in the game (they're all linear), tedium is a very important thing to consider. An experiment should have a sweet spot to aim for, but there should not be a point where further mastery is stopped dead on it's track with a reward cap.
Scientific Papers attempts to discourage this behaviour by having the "maximum score" scale off to infinity but with the rewards being smaller and smaller. The sweet spot is always there to aim for and should be well communicated with players, but on their last submission of an experiment topic players should be encouraged to do their best. There should always be a reward for pushing the system to it's limit as long as it doesn't completely nullify the other subdepartments. This is the reason why there is a hard limit on the number of publications and why the score calculation is a bit more complex than it needed to be.
## B. Gas Synthesis (Early-Mid Game)
Scientific papers will add one new machine that requests a tank to release x amounts of y gas. This will be accomplished by adding a tank pumping machine which will either burst or explode a tank, releasing the gas inside. The gas currently requested are BZ, Nitryl, Halon and Nob.
The overarching goal of this compressor machine is to present a gas synthesis challange for the players and to get them more accustomed to how a tank explodes. The gas synthesis part can always be changed in order to reflect the current state of atmospheric reactions.
## C. Explosion Changes (Mid-Late Game)
### C.1 Cause and effect.
The main theme of the explosion changes is establishing cause and effect of explosions. Reactions that happens inside a tank that's going to explode will be recorded and forwarded to a doppler array. Some experiments will require only a single cause to be present (think of it as isolating a variable). This is currently implemented for nobliumformation and pressure based bombs. Having other reactions occuring besides noblium formation will fail the first one, while having any reactions at all will fail the second one.
Adding more explosions here will be a slight challange because as of now the game has only two reactions that can reliably make an explosion.
### C.2 Tools upgrade.
Doppler array has now been retrofitted to state the probable cause of an explosion, be it reactions or just overpressurization on gas merging. These should help intermediate players figure out what is causing an explosion.
Added a new functionality to the implosion compressor:
Basically performs the gas merging and reaction that TTV does in a machine and reports the results back as if someone uses an analyzer on them. Here to give players feedback so they can try and understand what is actually going on in a bomb.
## D. Player Interaction
There should be more room for more than 1 player to play ordnance simultaneously. Previously players are also able to split tasks, but this rarely happens because tritium synthesis needs only the gas chamber to be reconfigured. Now, different players can pick different experiments and work on them. Players can also do joint tasks on one single experiment. Gases like noblium will need tritium production and also a cooling module online.
Ordnance can also coordinate with their parent department on what they really need, be it money or research bonuses.
# Potential Changes
The best-case changes that can be implemented if the current roster of content isn't enough is more reactions that can be used in bombs. Eliminating bombs entirely goes against the spirit of the subdepartment, while adding new ones will need a lot of care and consideration.
Another possible change is to implement a "gas payload" bomb. Bombs that has a set number of unreacting gas inside that will increase the heat capacity, reduce the payload, and neccesitates more bespoke mixes.
Adding more gas synthesis experiments is discouraged. The main focus of ordnance should be bombs, with gas synthesis being a side project for ordnance. These are present to ease the introduction to bombs and provide some side content.
There should be a somewhat well-justified goal in adding new synthesis experiments: e.g. BZ is there as a "tutorial" gas, Nitryl to introduce players to cooling/heating mixes, Halon to a more efficient tritium production, and Nob as a nudge to nobformation bombs and mastery over other aspects.
# Conclusion / Summary
Add more experiments to ordnance that players can take, accomplish this by:
1. Making the players perform gas synthesis or make bombs.
2. Have them collect the data, see if it fits the criteria. Explain why if it fits and why if it doesn't.
3. Have the player publish a paper.
Reward them based on how well did they do, give players agency both on the experiment phase and also publication phase.
---
TLDR: Added new experiment to toxins, added the framework for those experiments existing. Experiments comes in gas synthesis and also bombs but with more parameters. Experiments needs to be published through papers, various choices to be made there.
Implementation notes:
Because of how paper works, ordnance experiments are handled outside of experiment_handler components. My reasoning for this is twofold:
The experiments will be completed manually on publication and if the experiment isn't unlocked yet it will still be completed.
Experiment handler datums have several procs which require an atom-level parent, and I figured this is the most sensible and cleanest way to implement this without changing the experiment handler datum too much.
Small change to /obj/machinery/proc/power_change() signal ordering to adjust the state first and then send the signal. Didn't found any other usage of this signal except mine but barge down my door if it broke something.
Rewrote the ttv merge_gases() code to be slightly more readable.
A small code improvement for thermomachine to use tofixed (my fault).
Ordnance have been updated to enable the publication of papers
Several new explosive and gas synthesis experiments have been added to ordnance
Anomaly compressor has been TGUIzed and now supports simulating the reaction of the gases inside the ttv.
New tank compressor machine for toxins. You can overpressurize tanks with exotic gases and complete experiments.
Several techweb nodes are locked and require toxin experiments to complete.
Toxins can purchase boosts for various techweb nodes.
You no longer need to anchor doppler arrays for it to work.
Doppler array and implosion compressor now supports deconstruction, implosion compressor construction added.
Doppler now emits a red light to denote it's direction and it being on. Doppler not malf.
Implosion compressor renamed to anomaly refinery.
Created a new program tab "Science" for the downloader app. Removed Robotics.
Reworked the code for bombspawner (used in the cuban pete arcade game)
* Makes deadchat control inputs bypass automute.
It's slightly annoying when you get muted because you spent a minute trying to get the supermatter to move down.
Essentially SSmapping had a list for each theme of ruin (space, lava,
ice, ice underground). These were all filled with an if statement
checking the ruin templates type. Now, i've given ruins a ruin_type var, which is then used to dynamically add to a single list of ruins, which separates lists of ruins by ruin type.
Good for downstreams who may have more ruin types
Changelog
cl
refactor: Dehardcoded SSmapping ruin types.
/cl
I found out how emissives work and my first thought was "damn ants should glow that would look sick"
So now they do.
Also, having less than 5u ants in your body will make you not scream, so 0.0001u ants will no longer have that tiny chance of making someone scream for their life.
If an ant pile has a max damage value less than 1, then they won't be able to bite through your shoes. This is the same threshold as the second tier ant icon.
Makes the giant ant a hostile mob with the neutral faction, meaning they will attack anything not in the neutral faction.
imageadd: Resprites the Warden's Jackets and Jumpsuit, the HoS Jumpsuit, the Formal Jackets, the Bulletproof and Regular Security Helmets and the Security Jumpsuit!
* Fixes infi pushing off something in space
Right now you can just push "into" a dense object forever, and depending
on your move rate, just kinda glide
We can fix that by checking if we're trying to push "off" something
we're moving towards
* Makes pushing off something shift it instantly
Currently if you kick off something in space it waits the delay of the
move to start drifting. Looks dumb, let's not
* Updates backup movement to properly account for directional windows. GOD I HATE DIRECTIONAL DENSITY SHOOOOOT MEEEEEEEEEEEEEEEEEEE
* Uses range instead of orange so standing on the same tile as a directional counts properly, rather then suddenly entering a drift state. I hate it here
* Ensures all args are named, updates implementations of the proc with the new arg
lobstrosities didnt have ranged = TRUE, so they never ran OpenFire, never charging at people
also fixes their charges having less delay than they should, being pretty much instant, now brings it up to what it originally was
Zephyr
Ryll Ryll
Wallem
capsaicinz
Seth Scherer
cacogen
Watermelon914
Tim
dragomagol
RandomGamer123
Ghom
TheSilverNuke
MrMelbert
Fikou
John Willard
TemporalOroboros
LemonInTheDark
Gandalf
MacBlaze1
DTraitor
ma44
vincentiusvin
AnturK
Imaginos16
Mothblocks
alphanerdd
rellyrelly
ErdinyoBarboza
GoblinBackwards