Commit Graph

75 Commits

Author SHA1 Message Date
KasparoVy
ef5376ede2 conflict resolution 2017-02-05 17:13:34 -05:00
Fox McCloud
0874ea7295 Merge pull request #6152 from uraniummeltdown/windowflash
Window Flashing
2017-01-31 01:30:39 -05:00
KasparoVy
d73413b046 Uses the Disabilities system more correctly
Allows eyes to track eye-dependent disabilities when removed from the mob.
Farwas and Wolpins are now incurably colourblind (non-genetics based), so going lesser-form and back won't wipe your colourblindness.

Eyes being straight-up deleted (as per how set_species() handles setting up the organs required for the species we're changing to) no longer wipes colourblindness.

Now with more helper procs, less unnecessary commenting, random changes and other cleanliness-related tweaks.
2017-01-26 04:10:55 -05:00
KasparoVy
c16f734a6d Changes Colourblindness from a Preference to a Disability
For Vulpkanin and Tajara, it gives them their species-specific
colourblindness but their excellent darksight, too. Otherwise it gives
noir vision.

You can choose this disability at character creation. It is off by
default. You can turn it off via genetics and mutadone.

Fixes Cling Transform&Lesser/Greater form & Darksight bugs

Transforming to an identity will now, with 100% reliability, give you
the exact appearance as that ability bar the body_accessory and the
secondary hair/facial hair colours. Same thing with going from lesser
form to an identity that was not the one you lesser formed with.

Fixes the darksight bug from the last commit, happened 'cause typo.
Woops.

Eye Transplantation Applies Eye-dependent Genes

Transplanting colourblind Vulpkanin/Tajara eyes into a Human gives the Human
the dark_view and unique colourblindness of said Vulpkanin eyes.

Removing colourblind eyes will take the disability with it, meaning the
person will have colour vision/low darksight.
2017-01-25 23:10:22 -05:00
KasparoVy
28f9496713 Adds Colourblindness for Vulpkanin&Tajara, Refactors Darksight, tidying up, etc.
Adds colourblindness for Vulpkanin and Tajara that can be turned on by a
preference in character creation. By default, Vulpkanin and Tajara still
see in full colour, however their darksight is reduced to Human levels
unless they choose the 'unaugmented' eyes option.

Refactors darksight so it's tied to the eye organ. Refactors noir
glasses.

You can now visually distinguish mechanical/mechassisted organs from
their organic counterparts due to their names and icons.

Resolves issue w/ Colour-vision after Cloning/Lesser-to-greater Formswapping.

Cloned Vulpkanin and Tajara get unaugmented vision (colourblind and
darksight) by default since the cloners can't administer the
eye-augmentation surgery. Same goes for swapping from lesser to greater
form as a Changeling.

The monkey-forms of Vulpkanin and Tajara now have almost the same organs as
their greater forms, meaning they get the same colourblindness but
excellent darksight.
2017-01-25 23:06:30 -05:00
KasparoVy
5b9a5aeb6e Reduced redundancy.
Setting .disabilities and .mutations was made redundany by the use of
SetSEState and domutcheck.
2017-01-18 19:39:49 -05:00
KasparoVy
4a420ef768 Fat characters are now fat. 2017-01-18 18:44:36 -05:00
Krausus
6f96d0bae2 Character slot fixes
Fixes "Randomized Character Slot" not working at all and the slot load
list running 20x as many SQL queries as it should
2017-01-16 13:15:37 -05:00
uraniummeltdown
770408636f attempt to add pref option 2017-01-12 21:20:16 +04:00
Crazylemon64
66f2d40afa Giant Spiders no longer clog up the Alien role channel 2017-01-09 13:38:34 -08:00
Kyep
d94effd1f1 Formatting improvements
- Improves formatting in the "check player playtime" panel, removing the
awkward "bulletpoint -" at the front, making the "?" link work, and
displaying "none" rather than "0h" for people with no playtime.
- Improves formatting when viewing the EXP report for a player, by not
showing the jobs unlocked/locked list when job locking is off (its
pointless in this case: they all count as unlocked)
- Fixes a (currently invisible) typo on preferences screen
2017-01-04 02:41:50 -08:00
Crazy Lemon
7e0183f23f Merge pull request #5224 from Kyep/jobs_unlock_system
Playtime Tracking
2017-01-03 18:06:28 -08:00
Fox McCloud
aab6715082 Merge pull request #5962 from KasparoVy/fixes-monochromatic-bugs
Refines Cloning, Fixes a Couple Genetics-related Bugs.
2016-12-23 07:19:06 -05:00
KasparoVy
b22c97293a Refines Cloning, Fixes a Couple Genetics-related Bugs.
Characters will now be correctly assigned their species' genetic quirks at spawn.
Cloning will now correctly assign a characters species' genetic quirks.
Changing a character's species (via C.M.A. or whatever might call the set_species proc) will now correctly assign their species' genetic quirks.
2016-12-07 20:24:06 -05:00
Kyep
945225b6e8 Runtime & bug fixes
- Fixes a runtime in preferences.dm created by the Patreon PRs,
triggered when an ERT, SIT, or any other clientless mob uses
"var/datum/preferences/A = new()".
- Fixes a bug where, if a SIT is spawned with the 'choose manually'
option, one fewer person than intended is pulled in.
- Fixes syndicate headset not being included in the SIT member's notes.
- Deletes commented code.
2016-12-03 06:24:47 -08:00
Kyep
46d1fbaee1 Fixes new merge conflict from patreon PR 2016-12-02 22:53:08 -08:00
Fox McCloud
cf57887f88 Merge pull request #5914 from KasparoVy/fixes-the-pictures
Tails/body accessories now render properly in ID card photos, 'HD' Char. Preview Icon
2016-12-01 10:18:25 -05:00
Kyep
7b20d7561e Merge remote-tracking branch 'ParadiseSS13/master' into jobs_unlock_system 2016-11-28 22:19:27 -08:00
KasparoVy
b3c7e97b02 Merge branch 'sharperpreviewimages' into fixes-the-pictures. 2016-11-25 16:08:01 -05:00
Tigercat2000
198bbbffa2 Add donator loadout category and item defines 2016-11-21 13:52:12 -08:00
Tigercat2000
e997207d1f Patreon Modifications
- Adds a `donators` table for our patreon supporters.
   - Intended to be half-automated, half-manual, in order to correlate
     patreon accounts to ckeys. Uses the `active` field so that supporters
     don't have to have their ckey associated every time they stop and
     restart their donations.
 - Current actions:
   - Donators at tier 1 or greater get a palm tree next to their name in OOC
     (toggleable)
   - Donators at tier 1 or greater get +5 loadout points.
     - Known issue: Loadout points will not update if the table is
       modified during a round where the user has already logged in, due
       to preference datum caching. There's not really any good way to fix
       this, unfortunately.
2016-11-11 08:29:15 -08:00
Fox McCloud
45ba4d157a Merge pull request #5416 from KasparoVy/tail_markings_mark2
Marking Refactor, Adds tail markings + Alt heads + Secondary (F)Hair themes, Darkens Vulp/Taj + Unathi horns/frills, Sprite adjustments and more...
2016-10-23 19:29:54 -04:00
Isaac Erwin
0cc8a94d5d Fine 2016-10-04 17:49:42 -04:00
Kyep
7e613798b0 Fixes merge conflict in admin_verbs.dm 2016-10-01 13:26:24 -07:00
KasparoVy
3e653a6279 Conflict resolution. 2016-09-26 12:17:35 -04:00
Krausus
d146de1dd7 UID mass replace: src=\ref[datum] 2016-09-05 23:12:08 -04:00
KasparoVy
4ef6f71622 Less Blurry Character Preferences images. Ported from VG
https://github.com/d3athrow/vgstation13/pull/11149
2016-09-03 22:05:12 -04:00
KasparoVy
c684a1b8fe Tidies up some (facial) hair handling and randomization.
Makes the code a lot more consistent to all the other locations it's
implemented as well.

Works the exact same as it did before but with a few less lines of code.

Also sorts out an issue with two facial hair objects having the same name. Woops.
2016-09-02 20:48:34 -04:00
KasparoVy
1c407a36a1 Sorts out some runtimes, adds randomization for a bunch more stuff in character preferences, adds species validation to undergarments, adds absolute pathing to sprite_accessories and repaths alot of stuff.
Also corrects some oversights.
2016-08-27 09:22:01 -04:00
KasparoVy
e0bad95adc Adds Some Markings and a Vulp F.Hair Style, Fixes Preferences Marking Randomization, Fixes Species-change thru CMA Bug, Fixes Vulp Kita F.Hair Style Colouring, Fixes Fatness and Deformation.
Previously, your markings would only randomize if you clicked the randomize button and were of a species that had body markings. Fixes that and tidies up the proc calls for marking randomization a bit.

Furthermore, a bug existed where if you changed a mob's species via CMA, the mob's cosmetic attributes (hair, hair colour, skin colour, skin tone, marking styles and colours, head accessory style and colour) will not have changed correctly. Delaying appearance update fixed that.

Finally, a mob's body will now correctly render as fat if they become fat and skinny if they become skinny and show deformities immediately.
Further explaining this fix: It required an override to be implemented in update_body that re-cached the mob's bodyparts in order to reflect changes to the limbs (i.e. fatness/slimness).
As for deformation, I just needed to modify the existing update_body() proc call.
2016-08-23 09:06:03 -04:00
KasparoVy
9bc614a28e Conflict resolution and adds sanitization to marking SQL handling. 2016-08-21 00:01:12 -04:00
Krausus
98989aa19c SQL sanitization fixes
- Completely removes sql_sanitize_text
- Fixes inconsistent encoding of flavor and records texts
- Adds some extra sanity checking to sanitizeSQL
2016-08-19 19:58:32 -04:00
KasparoVy
44bf253594 Some CMA Improvements, an Alt Head Marking Handling Tweak, some Marking Colouration Fixes and patching the last of the gorey spots.
Changing your body accessory or alt head will now update the list
entries since the amount of available markings will change depending on
which body accessory/alt head you have.
can_change_alt_head() will now check the head organ's species instead of
the body's species.
can_change_markings() has been updated as per the style of a recent PR
(forgot the number).

Resolves an oversight where the Unathi Tiger Head marking was intended
to be available regardless of what alt head you had but wasn't in
reality.

Resolves an oversight where while the body Tiger markings were darkened, the head/face Tiger markings were forgotten.

Patches the last couple gorey spots I missed.
2016-08-19 08:10:37 -04:00
KasparoVy
ab3f71b359 Conflict resolution again 2016-08-19 01:08:08 -04:00
KasparoVy
492be645c1 Reverts unnecessary eye-colour setting fix in preferences.
Resolved by https://github.com/ParadiseSS13/Paradise/pull/5495
2016-08-18 22:20:29 -04:00
Crazylemon64
6aedd26beb Fixes a bunch of organ-related bugs 2016-08-18 19:08:29 -07:00
KasparoVy
29a90bff9f Conflict resolution. 2016-08-18 03:28:03 -04:00
Fox McCloud
c21299ddda Merge pull request #5447 from Crazylemon64/serialization_eyes_fix
Improves Serialization
2016-08-17 20:10:24 -04:00
KasparoVy
e0bfbd0af6 Keeping up to date. 2016-08-17 02:56:34 -04:00
Crazylemon64
3ca5a1f3f7 Removes eye color vars on the human, stores it on the eyes
Also adds a proc nifty for SDQL fans, which grants greater control over
spawning atoms.

Also fixes deserialization to make hair show up again
2016-08-13 23:05:32 -07:00
Fox-McCloud
3dcc4bdecd Removes Mutiny 2016-08-12 22:44:11 -04:00
KasparoVy
a5722fdfc4 Overhaul, adds color2R/G/B helper procs, adds marking/head accessory/body accessory (colours included) randomization in char prefs.
Color2R/G/B helper procs and PR overhaul suggested/co-authored by Krausus.
2016-08-12 22:37:40 -04:00
Fox-McCloud
41a74fb865 Malf AI Rework 2016-08-11 05:16:06 -04:00
KasparoVy
3610cfd4ea Markings refactor, body/marking/head accessory/hair sprite darkening, adds tail markings, more hair styles...
Tajara ears are on their head now, fixes a crash bug with tail wagging
with body accessories that are split-rendered, adds secondary
hair/facial hair themes, fixes issues with human/skrell arm/lower body
sprites etc.
2016-08-09 22:01:45 -04:00
Kyep
e64215ddb1 Update 7
- Fix: Drones now get assigned_role = Drone.
- Tweak: AI is no longer considered a head job for playtime system
configuration purposes.
- Tweak: Job gating (when enabled - its off by default) is based on Crew
playtime now. This is for all jobs, including heads and AI. Gating based
on department playtime is still possible, but based on a separate config
option that's also turned off by default.
2016-08-08 23:04:26 -07:00
Fox McCloud
607642d4ef Revert "Refactors Markings, Adds Tail (some body and head) markings, Adds Alt heads, Secondary (F)Hair Themes, Darkens Vulp/Taj + Unathi horns/frills, Sprite adjustments and more..." 2016-08-08 23:26:51 -04:00
Kyep
ab3bb8e4b7 Update 5
- Made use_exp_restrictions_heads_hours text2num'ed in configuration.dm,
rather than on use
- Converted all exp_types to #defines, instead of magic strings
- Moved exp_jobsmap to jobs.dm
- Replaced has_exp_for_job with job.available_in_playtime, which returns
- Changed <BR> -s to <LI>s, for proper HTML lists
- Made update_exp less indented, easier to read
- Fixed potential runtime in admin/topic.dm when calling exp window on a
non-existent mob
- Made job preferences screen tell you how long until you unlock each
locked job, in hours or minutes as appliccable
- Changed SQL storage format because mediumtext does not support default
''
- Converted exptimer() into a roundstart hook proc

Missed body tag

Typo fix
2016-08-05 01:30:57 -07:00
KasparoVy
769a100580 Parallax revert. remote-tracking branch 'upstream/master' into tail-markings 2016-07-28 19:00:53 -04:00
Tigercat2000
288af9f92c Revert "Merge pull request #4739 from monster860/vg-parallax"
This reverts commit 451c934379, reversing
changes made to 64f26d999f.

Conflicts:
	SQL/paradise_schema.sql
	SQL/paradise_schema_prefixed.sql
2016-07-28 15:48:27 -07:00
KasparoVy
39d3d64207 Staying up to date. 2016-07-28 17:02:07 -04:00