## About The Pull Request
Removes the IC tab in its entirety
- Some mobs (Blob Minion & Lightgeist) had manually removed the "pull"
verb, this replaces it with taking away their pull force.
- Lightgeist had their "Me" verb manually removed, this is replaced by
giving them Emotemute trait (the same that mime's bane gives)
- Floor Changer: You can now RMB the arrow buttons to look in a
direction w/o moving. Added a tip to help with this.
- Exit Hivemind: Already an action button and was removed without
further edits
### Removed entirely
Rest
Resist
Look Up/Down
Move Upwards/Down
Activate Held Object
Open Language Menu
Memories
View Skills
### Moved to command bar (secret verb ooh) because I am biased
Sleep
Navigate
### Martial Arts
Martial Arts had a button to see your current skills & the ability to
cycle between artstyles. This was replaced with 1 action button that
does both of these.
<img width="317" height="148" alt="image"
src="https://github.com/user-attachments/assets/afed910f-b6b6-441d-86cb-dade0e253044"
/>
Name auto-updates as you swap artstyle to whatever help verb the current
style uses. Mention of RMB in the name is only there if you have more
than 1 martial art, but the desc will remain just so players can see it
even if they only have one, for future reference.
## Why It's Good For The Game
Brings greater visibility to Martial Art stuff, and especially since the
stat panel is being made optional we should not be hiding ANYTHING in
there.
This also helps me with my project listed in
https://hackmd.io/443_dE5lRWeEAp9bjGcKYw?view
And also fixes some sorta-removed features due to removing verbs not
matching people's actual powers due to new features like "Custom Me" and
"Ctrl Clicking".
## Changelog
🆑 SirNightKnight (sprites), JohnFulpWillard
del: Deleted the "IC" tab of the stat panel.
fix: Lightgeists can't emote or pull as intended.
fix: Blob minions can't pull again.
qol: Martial Art users now have an action button for their
artstyle-related businesses, rather than it being in the stat panel.
qol: You can now right-click the move up/down UI buttons to look in the
direction without moving.
/🆑
## About The Pull Request
On production, I sign up for rounds (and I know I pushed the button
because the auto-deadmin message comes up) but it doesn't inject me in
the game and fails without a warning. I have no idea why it's doing this
but I shifted some stuff around and added a few logs to hopefully stop
this strange consistent failure for me to start a shift.
I just cleaned up a lot of the code and turned the ready defines into
strings instead of a boolean (so I could log it more efficiently with
little overhead, as well as standardize it to a define without people
doing wacky shit everywhere). I don't think this will fix the issue but
it will definitely make some things more clear as to why I'm not joining
rounds without warning despite clicking ready.
## Why It's Good For The Game
Cleans the code up while trying to resolve a really puzzling bug I've
been having.
## Changelog
🆑
server: The ready/not ready states of new players are logged when a
shift starts.
/🆑
## About The Pull Request
Records the number of latejoins per 5 minutes of round time.
Example data would look something like
```
0-5 minutes = 1
5-10 minutes = 2
10-15 minutes = 0
```
## About The Pull Request
Adds `GLOB.unrecommended_builds`, for byond build which are broken for
the end user in some way, but not in a way that warrants outright
blacklisting players from connecting with them
Looks like this (Ignore the number I changed it for testing purposes)
<img width="493" height="267" alt="image"
src="https://github.com/user-attachments/assets/d31636e8-a106-4d13-a8fa-aee6a50c6d27"
/>
Uses this system for the new byond build, 1670+, which breaks text
rendering
Also adds 1670+ to the list of builds to warn on compile
## Why It's Good For The Game
1670 broke the compilation step, probably permanently
Whether we will fix this or flip a pragma or w/e remains to be seen, but
until then we can tell people to compile an earlier version
1670 also broke the user experience, causing map text to show up as
really big. This will be fixed in an upcoming version
<https://www.byond.com/forum/post/2983385>
## Changelog
🆑 Melbert
qol: If you are on Byond 516.1670+, you will get an alert on login that
your build is less than functional
/🆑
## About The Pull Request
As the code currently is, if any missing limb is selected, command is
locked. This PR adjusts the logic so that command is locked only if both
arms are missing.
## Why It's Good For The Game
Disabled captains and other heads of staff offer more character creation
and roleplay opportunities. This change removes such logic discrepancies
such as a paraplegic captain being fine bug a legless captain being
disallowed. Crew with one hand are still very capable and do not need to
be blocked from command roles.
## Proof Of Testing
Code compiles with 0 errors, 0 warnings. Tested locally and working as
expected.
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
balance: Heads of staff are free to be missing as many roundstart limbs
as they want, as long as they have at least one hand.
/🆑
## About The Pull Request
Quirks only send their on_gain text when given midround, such as by an
admin
## Why It's Good For The Game
Spams the hell out of you for no reason - in very few contexts are these
messages important (randomized allergies come to mind), but there are
other avenues to figure out (such as dogtags)
## Changelog
🆑 Melbert
qol: Quirks spam you less on roundstart or latejoin
/🆑
## About The Pull Request
Quirks only send their on_gain text when given midround, such as by an
admin
## Why It's Good For The Game
Spams the hell out of you for no reason - in very few contexts are these
messages important (randomized allergies come to mind), but there are
other avenues to figure out (such as dogtags)
## Changelog
🆑 Melbert
qol: Quirks spam you less on roundstart or latejoin
/🆑
Implements https://hackmd.io/@tgstation/SkeUS7lSp , rewriting Dynamic
from the ground-up
- Dynamic configuration is now vastly streamlined, making it far far far
easier to understand and edit
- Threat is gone entirely; round chaos is now determined by dynamic
tiers
- There's 5 dynamic tiers, 0 to 4.
- 0 is a pure greenshift.
- Tiers are just picked via weight - "16% chance of getting a high chaos
round".
- Tiers have min pop ranges. "Tier 4 (high chaos) requires 25 pop to be
selected".
- Tier determines how much of every ruleset is picked. "Tier 4 (High
Chaos) will pick 3-4 roundstart[1], 1-2 light, 1-2 heavy, and 2-3
latejoins".
- The number of rulesets picked depends on how many people are in the
server - this is also configurable[2]. As an example, a tier that
demands "1-3" rulesets will not spawn 3 rulesets if population <= 40 and
will not spawn 2 rulesets if population <= 25.
- Tiers also determine time before light, heavy, and latejoin rulesets
are picked, as well as the cooldown range between spawns. More chaotic
tiers may send midrounds sooner or wait less time between sending them.
- On the ruleset side of things, "requirements", "scaling", and
"enemies" is gone.
- You can configure a ruleset's min pop and weight flat, or per tier.
- For example a ruleset like Obsession is weighted higher for tiers 1-2
and lower for tiers 3-4.
- Rather than scaling up, roundstart rulesets can just be selected
multiple times.
- Rulesets also have `min_antag_cap` and `max_antag_cap`.
`min_antag_cap` determines how many candidates are needed for it to run,
and `max_antag_cap` determines how many candidates are selected.
- Rulesets attempt to run every 2.5 minutes. [3]
- Light rulesets will ALWAYS be picked before heavy rulesets. [4]
- Light injection chance is no longer 100%, heavy injection chance
formula has been simplified.
- Chance simply scales based on number of dead players / total number
off players, with a flag 50% chance if no antags exist. [5]
[1] This does not guarantee you will actually GET 3-4 roundstart
rulesets. If a roundstart ruleset is picked, and it ends up being unable
to execute (such as "not enough candidates", that slot is effectively a
wash.) This might be revisited.
[2] Currently, this is a hard limit - below X pop, you WILL get a
quarter or a half of the rulesets. This might be revisited to just be
weighted - you are just MORE LIKELY to get a quarter or a half.
[3] Little worried about accidentally frontloading everything so we'll
see about this
[4] This may be revisited but in most contexts it seems sensible.
[5] This may also be revisited, I'm not 100% sure what the best / most
simple way to tackle midround chances is.
Other implementation details
- The process of making rulesets has been streamlined as well. Many
rulesets only amount to a definition and `assign_role`.
- Dynamic.json -> Dynamic.toml
- Dynamic event hijacked was ripped out entirely.
- Most midround antag random events are now dynamic rulesets. Fugitives,
Morphs, Slaughter Demons, etc.
- The 1 weight slaughter demon event is gone. RIP in peace.
- There is now a hidden midround event that simply adds +1 latejoin, +1
light, or +1 heavy ruleset.
- `mind.special_role` is dead. Minds have a lazylist of special roles
now but it's essentially only used for traitor panel.
- Revs refactored almost entirely. Revs can now exist without a dynamic
ruleset.
- Cult refactored a tiny bit.
- Antag datums cleaned up.
- Pre round setup is less centralized on Dynamic.
- Admins have a whole panel for interfacing with dynamic. It's pretty
slapdash I'm sure someone could make a nicer looking one.
- Maybe some other things.
See readme for more info.
Will you see a massive change in how rounds play out? My hunch says
rounds will spawn less rulesets on average, but it's ultimately to how
it's configured
🆑 Melbert
refactor: Dynamic rewritten entirely, report any strange rounds
config: Dynamic config reworked, it's now a TOML file
refactor: Refactored antag roles somewhat, report any oddities
refactor: Refactored Revolution entirely, report any oddities
del: Deleted most midround events that spawn antags - they use dynamic
rulesets now
add: Dynamic rulesets can now be false alarms
add: Adds a random event that gives dynamic the ability to run another
ruleset later
admin: Adds a panel for messing around with dynamic
admin: Adds a panel for chance for every dynamic ruleset to be selected
admin: You can spawn revs without using dynamic now
fix: Nuke team leaders get their fun title back
/🆑
(cherry picked from commit 4c277dc572)
## About The Pull Request
Implements https://hackmd.io/@tgstation/SkeUS7lSp , rewriting Dynamic
from the ground-up
- Dynamic configuration is now vastly streamlined, making it far far far
easier to understand and edit
- Threat is gone entirely; round chaos is now determined by dynamic
tiers
- There's 5 dynamic tiers, 0 to 4.
- 0 is a pure greenshift.
- Tiers are just picked via weight - "16% chance of getting a high chaos
round".
- Tiers have min pop ranges. "Tier 4 (high chaos) requires 25 pop to be
selected".
- Tier determines how much of every ruleset is picked. "Tier 4 (High
Chaos) will pick 3-4 roundstart[1], 1-2 light, 1-2 heavy, and 2-3
latejoins".
- The number of rulesets picked depends on how many people are in the
server - this is also configurable[2]. As an example, a tier that
demands "1-3" rulesets will not spawn 3 rulesets if population <= 40 and
will not spawn 2 rulesets if population <= 25.
- Tiers also determine time before light, heavy, and latejoin rulesets
are picked, as well as the cooldown range between spawns. More chaotic
tiers may send midrounds sooner or wait less time between sending them.
- On the ruleset side of things, "requirements", "scaling", and
"enemies" is gone.
- You can configure a ruleset's min pop and weight flat, or per tier.
- For example a ruleset like Obsession is weighted higher for tiers 1-2
and lower for tiers 3-4.
- Rather than scaling up, roundstart rulesets can just be selected
multiple times.
- Rulesets also have `min_antag_cap` and `max_antag_cap`.
`min_antag_cap` determines how many candidates are needed for it to run,
and `max_antag_cap` determines how many candidates are selected.
- Rulesets attempt to run every 2.5 minutes. [3]
- Light rulesets will ALWAYS be picked before heavy rulesets. [4]
- Light injection chance is no longer 100%, heavy injection chance
formula has been simplified.
- Chance simply scales based on number of dead players / total number
off players, with a flag 50% chance if no antags exist. [5]
[1] This does not guarantee you will actually GET 3-4 roundstart
rulesets. If a roundstart ruleset is picked, and it ends up being unable
to execute (such as "not enough candidates", that slot is effectively a
wash.) This might be revisited.
[2] Currently, this is a hard limit - below X pop, you WILL get a
quarter or a half of the rulesets. This might be revisited to just be
weighted - you are just MORE LIKELY to get a quarter or a half.
[3] Little worried about accidentally frontloading everything so we'll
see about this
[4] This may be revisited but in most contexts it seems sensible.
[5] This may also be revisited, I'm not 100% sure what the best / most
simple way to tackle midround chances is.
Other implementation details
- The process of making rulesets has been streamlined as well. Many
rulesets only amount to a definition and `assign_role`.
- Dynamic.json -> Dynamic.toml
- Dynamic event hijacked was ripped out entirely.
- Most midround antag random events are now dynamic rulesets. Fugitives,
Morphs, Slaughter Demons, etc.
- The 1 weight slaughter demon event is gone. RIP in peace.
- There is now a hidden midround event that simply adds +1 latejoin, +1
light, or +1 heavy ruleset.
- `mind.special_role` is dead. Minds have a lazylist of special roles
now but it's essentially only used for traitor panel.
- Revs refactored almost entirely. Revs can now exist without a dynamic
ruleset.
- Cult refactored a tiny bit.
- Antag datums cleaned up.
- Pre round setup is less centralized on Dynamic.
- Admins have a whole panel for interfacing with dynamic. It's pretty
slapdash I'm sure someone could make a nicer looking one.
- Maybe some other things.
## Why It's Good For The Game
See readme for more info.
Will you see a massive change in how rounds play out? My hunch says
rounds will spawn less rulesets on average, but it's ultimately to how
it's configured
## Changelog
🆑 Melbert
refactor: Dynamic rewritten entirely, report any strange rounds
config: Dynamic config reworked, it's now a TOML file
refactor: Refactored antag roles somewhat, report any oddities
refactor: Refactored Revolution entirely, report any oddities
del: Deleted most midround events that spawn antags - they use dynamic
rulesets now
add: Dynamic rulesets can now be false alarms
add: Adds a random event that gives dynamic the ability to run another
ruleset later
admin: Adds a panel for messing around with dynamic
admin: Adds a panel for chance for every dynamic ruleset to be selected
admin: You can spawn revs without using dynamic now
fix: Nuke team leaders get their fun title back
/🆑
This is part of my ongoing project to remove the Stat panel which you
can read/contribute to here: https://hackmd.io/443_dE5lRWeEAp9bjGcKYw
Replaces the pAI button at the bottom of Ghost's HUD with a new button
for Ghost settings
Default look
With fun verbs (admin only, the 2 buttons at the top right), No body,
and lag switches on (disables T-Ray and Zooming)
The ghost icon next to "re-enter body" is the DNR button, which requires
double click.
Extra view is now easier to understand, 0 is "default", anything more is
extra vision you get. Goes to 3 for regular users, 7 for BYOND members.
Removes the "Ghost" tab from the stat panel entirely, this replaces it.
The Ghost tab of the stat panel is filled with barely functional stuff,
like "Jump to Mob" which allows you to jump to "oranges ear" which
teleports you to nullspace, or the 4 different jump to verbs for
different things which is irrelevant from the Orbit menu and the many
improvements it got over the years, and even the Notifications panel,
which seems pretty useful, but because it's delegated to a small button
filled with the rest of these it gets entirely drowned out.
This puts all the important things in front of the user at the click of
a button, meant to be easy to navigate and giving important information
first.
🆑
add: Added a 'Ghost settings' button, taking the spot of the pAI
candidate button and replacing the "Ghost" tab of the Stat panel. This
button contains buttons pertinent to your time as an Observer.
/🆑
## About The Pull Request
This is part of my ongoing project to remove the Stat panel which you
can read/contribute to here: https://hackmd.io/443_dE5lRWeEAp9bjGcKYw
Replaces the pAI button at the bottom of Ghost's HUD with a new button
for Ghost settings
Default look
With fun verbs (admin only, the 2 buttons at the top right), No body,
and lag switches on (disables T-Ray and Zooming)
The ghost icon next to "re-enter body" is the DNR button, which requires
double click.
Extra view is now easier to understand, 0 is "default", anything more is
extra vision you get. Goes to 3 for regular users, 7 for BYOND members.
Removes the "Ghost" tab from the stat panel entirely, this replaces it.
## Why It's Good For The Game
The Ghost tab of the stat panel is filled with barely functional stuff,
like "Jump to Mob" which allows you to jump to "oranges ear" which
teleports you to nullspace, or the 4 different jump to verbs for
different things which is irrelevant from the Orbit menu and the many
improvements it got over the years, and even the Notifications panel,
which seems pretty useful, but because it's delegated to a small button
filled with the rest of these it gets entirely drowned out.
This puts all the important things in front of the user at the click of
a button, meant to be easy to navigate and giving important information
first.
## Changelog
🆑
add: Added a 'Ghost settings' button, taking the spot of the pAI
candidate button and replacing the "Ghost" tab of the Stat panel. This
button contains buttons pertinent to your time as an Observer.
/🆑
Quirks can now define if they're "species appropriate," where the base
proc's behavior is simply "does this species already have the quirk's
main trait"
I am unsure if that on its own imposes any new restrictions, currently.
Additionally, blood deficiency cannot be picked on any species without
blood or that doesn't breathe.
I'm sure there's more that might make sense, I'm open to suggestions
Alternative to #90238
Currently, reduces the possibility of taking something like blood
deficiency on a race which suffers no downside from it in order to get
free positive quirks.
Future-ly, potentially allows quirks exclusive to only a select few
species as offered by #90238🆑
fix: Species without blood can no longer be blood deficient
/🆑
commit cb550ab79badae3ffd493dcee24d96f7ad146ed6
Merge: 732416f01d8 2fac5d45a6
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Mon Apr 14 14:40:04 2025 -0400
Merge branch 'master' into upstream-25-04a
commit 2fac5d45a6
Author: Arturlang <24881678+Arturlang@users.noreply.github.com>
Date: Mon Apr 14 01:11:47 2025 +0100
bring back heretic mute ghoul maxhp to 135 HP (#3464)
## About The Pull Request
bring back heretic mute ghoul maxhp to 135 HP, these are the changes
made in
https://github.com/Bubberstation/Bubberstation/pull/2972
## Why It's Good For The Game
otherwise flesh heretic is really sad
## Proof Of Testing
numbers change, no need
## Changelog
no cl
---------
Co-authored-by: Roxy <75404941+TealSeer@users.noreply.github.com>
commit e9c4522c27
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 14 01:59:19 2025 +0200
Automatic changelog for PR #3453 [ci skip]
commit 2d595eba4f
Author: shellspeed1 <46614774+shellspeed1@users.noreply.github.com>
Date: Sun Apr 13 16:58:54 2025 -0700
Fixes bitrunning sim having cybersun comms and also makes sure persistence borgs have correct key (#3453)
## About The Pull Request
What it says on the tin
## Why It's Good For The Game
Its best to not let bitrunners ghost spawns talk on comms
## Proof Of Testing
I just did my last cpa today, I'll test this later. Besides its 3 lines
with just an item swaped.
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: Bitrunning sims no longer have comms access
fix: Borgs given the persistence access upgrade no longer default to
interdyne and get cybersun comms instead
/🆑
Co-authored-by: Roxy <75404941+TealSeer@users.noreply.github.com>
commit 394e8d64d4
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 23:24:50 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 49141446bf
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 14 00:18:15 2025 +0200
Automatic changelog for PR #3497 [ci skip]
commit 0332c060a8
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 13 18:17:52 2025 -0400
Xenoarch Machine QOL (#3497)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
A little treat for xenoarch
- The xenoarch bag can now hold broken items and useless relics in
addition to strange rocks
- You can use the bag on both the researcher and the recoverer to dump
the contents in
- The digger and the researcher make a sound now
## Why It's Good For The Game
A bag that holds only one type of item is annoying, you get a lot of the
other two items too
## Proof Of Testing
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
qol: the xenoarch bag can now hold broken items and useless relics
qol: you can use the bag on the researcher and the recoverer to dump
items in
sound: the digger and researcher now make a sound when they complete a
cycle
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
commit 2b8c074406
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 19:47:30 2025 +0200
Automatic changelog for PR #3498 [ci skip]
commit e613940ada
Author: nevimer <77420409+nevimer@users.noreply.github.com>
Date: Sun Apr 13 13:47:04 2025 -0400
restores RCD vending, moves RCD's to lockers (#3498)
## About The Pull Request
moves RCD's from engineers backpacks to their lockers roundstart - to
accommodate the stowaway change aswell as keep a tab on infinite station
resources.
## Why It's Good For The Game
Above point
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
balance: reenabled the RCD vendors and moved RCD's from spawning in
backpacks to lockers.
/🆑
commit 732416f01d8ccc6e082cbdbeb60b30c461d8e965
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 13 03:03:20 2025 -0400
these use GMM prices and thus fluctuate
commit 99f097d67faf17569711d670d5891103d96932b1
Merge: 790b64602cd 945479a622
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 13 02:12:01 2025 -0400
Merge branch 'master' into upstream-25-04a
commit 945479a622
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 13 00:59:23 2025 -0400
Fix hot spring runtime related to duplicate elements (#90555)
If something is mapped to spawn in on a hot spring tile, the tile will
add the immerse element in `/turf/open/water/Entered` before
`Initialize` runs, and when it does there's no check if the element has
already been added, unlike other spots where the immerse element is
added. This fixes that by adding a check on the call in `Initialize`.
commit 3472fddc11
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Sun Apr 13 04:16:19 2025 +0000
Automatic TGS DMAPI Update (#2743)
This pull request updates the TGS DMAPI to the latest version. Please
note any changes that may be breaking or unimplemented in your codebase
by checking what changes are in the definitions file:
code/__DEFINES/tgs.dm before merging.
Full changelog can be found
[here](https://raw.githubusercontent.com/tgstation/tgstation-server/gh-pages/changelog.yml).
- Added compatibility with SpacemanDMM's `redefined_proc` lint. (#2058
Cyberboss)
#tgs-dmapi-release
Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com>
commit e5630753ae
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:53:13 2025 +0200
Automatic changelog for PR #3481 [ci skip]
commit ac3fea9660
Author: chestlet <98193039+chestlet@users.noreply.github.com>
Date: Sat Apr 12 20:52:34 2025 -0700
Nova Port: RB-MK2 GUI Rework (#5136) (#3481)
## About The Pull Request
A significant [rework of the RB-MK2
GUI](https://github.com/NovaSector/NovaSector/pull/5136) that I did over
on Nova. The one you guys have now is painful to use in comparison so
let's get it up to snuff.
## Why It's Good For The Game
More information makes the RB-MK2 easier to use and teach in character.
With how the GUI is currently, it gives no intuitive explanation for
what it's doing. You can't tell what's going on with it.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
https://github.com/user-attachments/assets/7a178ac2-df8e-40d3-a6f3-b6aa617b69fd
</details>
## Changelog
🆑 Chestlet
admin: Improved RB-MK2 logging so admins have a full trace of exactly
what happened with it.
fix: Corrected 'tritium usage' math in the RB-MK2.
code: We've noticed that the Radioscopical Bluespace Reactor Mark Two
blueprints provided to our stations came with antiquated firmware. This
issue has been rectified. (Significant rework of the RB-MK2 GUI)
/🆑
commit 071fcd84a8
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:48:58 2025 +0200
Automatic changelog for PR #3495 [ci skip]
commit 0a5f60a36c
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 23:48:24 2025 -0400
Xenoarch machines cleanup (#3495)
## About The Pull Request
Clean up the code for xenoarch machines some because it made me sad.
- Changes `attackby`'s to `item_interaction`
- Keep a list of xenoarch items in contents instead of storing them in
**an instance of `/obj/item` (yes the abstract concept of an item)**
- Add context tips for all item interactions and removes that info from
examine text
- Switched a list to `static`
- Add assoc list of `broken_item` types to reward pools instead of
having a nightmare ladder of `istype` checks
## Why It's Good For The Game
Fixes#3442
## Proof Of Testing
Scout's honor
## Changelog
🆑
qol: xenoarch machines have context tooltips now
fix: fixed xenoarch diggers not working
/🆑
commit 16f02c756b
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:34:54 2025 +0200
Automatic changelog for PR #3441 [ci skip]
commit ede9fc1646
Author: Bombermansam <Bombermansam@yahoo.com>
Date: Sat Apr 12 23:34:09 2025 -0400
[Modular] Adds crowbars to standard borg models that do not have them (#3441)
## About The Pull Request
Adds crowbars to standard borg models that do not have them.
## Why It's Good For The Game
This is a QOL addition, it should not affect balance.
Half the borg models in the game do not have crowbars and can get stuck
behind doors if the power fails which is no fun for anyone. This fixes
it.
## Proof Of Testing
It compiles and was tested locally.
<details>
<summary> Screenshots </summary>
</details>
## Changelog
🆑
add: Adds Crowbars to Service, Medical, Clown, Sec and Peacekeeper borgs
/🆑
commit 8e4d6f7052
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:32:18 2025 +0200
Automatic changelog for PR #3491 [ci skip]
commit 0cdf875cec
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 03:32:09 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c6f88a026e
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 23:31:16 2025 -0400
Fix HEV armor not fully initializing (#3491)
## About The Pull Request
`ADD_TRAIT`/`REMOVE_TRAIT` don't take lists you need to use a proc for
that
## Why It's Good For The Game
Fixes#3484
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: fixed HEV suit not turning on properly
/🆑
commit f93466e6ab
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:18:39 2025 +0200
Automatic changelog for PR #3486 [ci skip]
commit 952a110077
Author: ariaworld <143797359+ariaworld@users.noreply.github.com>
Date: Sun Apr 13 05:18:04 2025 +0200
[FIX?] - Brings robotic brain surgery in line with organic brain sugery/lobotomy after the recent update (#3486)
## About The Pull Request
As title!
## Why It's Good For The Game
I originally opened this as an issue because I wasn't sure if this was
intended, it's why I labeled it as [FIX?]
Currently organic brain surgery heals the previous tiers of traumas as
well which makes sure there's no leftover traumas left and also removes
the RNG re-roll, applying a status effect instead. This PR brings the
robotic surgery/lobotomy in line with the organic one in a few ways:
1. Robotic blessed lobotomy now requires holy water as well (just like
organic)
2. Fix posibrain surgery now cures TRAUMA_RESILIENCE_SURGERY traumas as
well
3. Reticulate splines surgery now cures TRAUMA_RESILIENCE_SURGERY and
TRAUMA_RESILIENCE_LOBOTOMY traumas as well
4. Replaced RNG prob(75) roll with the 15-minute status effect that was
added to organic brain surgery.
This should balance/fix the robotic brain surgery to the recent change
that was done to the organic brain surgery. Only issue is the fact how
the original surgery was coded: there was no RNG roll for fix posibrain
surgery, while the normal organic surgery did.
Please feel free to close this PR if this was an intended feature/there
are issues with potential balance arguments.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
(It compiles, very simple code just handles surgery steps)
</details>
## Changelog
🆑 Goku
balance: Robotic blessed lobotomy now also requires holy water (just
like the organic surgery)
balance: Robotic blessed lobotomy requires liquid solder instead of
Palladium Synthate Catalyst
fix: Fix posibrain surgery now also cures surgery-tier brain traumas
balance: Reticulate splines surgery now also cures lower tier brain
traumas (surgery and lobotomy)
balance: Replaced advanced robotic brain surgery RNG roll with the
15-minute vulnerability status effect that was added to organic brain
surgery
/🆑
---------
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
commit 790b64602cd2e59b8397c4fe2451d2c14bddb546
Merge: 7d39bddbcb2 5e1b40cf89
Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 20:13:11 2025 -0700
Merge branch 'master' into upstream-25-04a
commit 5e1b40cf89
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:08:22 2025 +0200
Automatic changelog for PR #3492 [ci skip]
commit 5e94554873
Author: ariaworld <143797359+ariaworld@users.noreply.github.com>
Date: Sun Apr 13 05:07:55 2025 +0200
[FIX] Fixes Wooden shelves turning into metal racks when broken. (#3492)
## About The Pull Request
Title!
## Why It's Good For The Game
Bugfix, my immersion was ruined
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
:cl:Goku
fix: Fix wooden shelves turning into metal rack parts when broken.
/🆑
commit 7fed3cb7e4
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:07:00 2025 +0200
Automatic changelog for PR #3493 [ci skip]
commit 2d38b200a0
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 20:06:37 2025 -0700
Allow hypospray in medical pouch (#3493)
## About The Pull Request
Adds hypospray and cable to the allowed list of items in the medical
pouch
## Why It's Good For The Game
Commonly held items, other reagent containers are accepted but hypo is
missing.
## Changelog
🆑 LT3
qol: The medical pouch can now hold hyposprays and cable coil
/🆑
commit 7d39bddbcb2e775207a4a3e72a3940f9fbf3b0f1
Merge: fde55e27444 bb642474217
Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 17:25:22 2025 -0700
Merge branch 'upstream-25-04a' of https://github.com/Bubberstation/Bubberstation into upstream-25-04a
commit fde55e2744421b10f115724f70f3db8339b13df0
Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 17:25:20 2025 -0700
screenshots
commit cfa0c20656
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 01:39:06 2025 +0200
Automatic changelog for PR #3478 [ci skip]
commit 0397536620
Author: CatoChristopherMrow <johnmaddentickeledmyrear@gmail.com>
Date: Sat Apr 12 19:38:42 2025 -0400
Makes tackle gloves reskinnable (#3478)
## About The Pull Request
Makes tackle gloves reskinnable to their blue, red, and black variants.
## Why It's Good For The Game
Stops basic sec gear forcing you to either wear clashing colors or not
get the benefit of standard equipment. Viva la matching colors.
## Proof Of Testing
Works on my machine
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑 UvvU
add: Tackle gloves are now reskinnable.
/🆑
---------
Co-authored-by: Ian Yanik <Iwantpornspam@gmail.com>
commit 42b725836a
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 12 23:24:45 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit bb642474217244fd233372d9c68cb4bab5f871f7
Merge: 72beef087ea c872e81588
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 16:10:29 2025 -0700
Merge branch 'master' into upstream-25-04a
commit 72beef087ea8a1b291e286b09a0eb5a6713ba255
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 15:26:15 2025 -0400
this now returns an icon path not an icon object
commit 4e85c985ee77a37b44dcef393b815a04421463b7
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 15:08:12 2025 -0400
broken dmi
commit c872e81588
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 12 07:45:40 2025 +0200
Automatic changelog for PR #3490 [ci skip]
commit 27801b991c
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 01:45:17 2025 -0400
Fix admin chat buttons to cancel/refund storyteller events not working (#3490)
## About The Pull Request
The chat messages that get sent when a storyteller event is about to run
try to call `Topic` on the scheduled event datum but there isn't
actually a `Topic` proc defined for them
## Why It's Good For The Game
It's mean to trick admins with fake buttons
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
admin: the cancel and refund buttons in storyteller event notifications
will actually do something now
/🆑
commit bb14605128db2b1b5390d60b28665ed0ceae154a
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 01:06:39 2025 -0400
im tired
commit 1245d5145e4f41d63dbe983355ef4619b6441655
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 00:40:09 2025 -0400
what if the world was made of pudding
commit 7011b910d3bfaa0dba4a3d118721ad1d42a7625c
Merge: b8c00cbd266 e9ede320c9
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 00:31:56 2025 -0400
Merge branch 'master' into upstream-25-04a
commit b8c00cbd2660017d578f07ce20c3732dcfcdb60f
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 00:31:01 2025 -0400
silence linters
commit 3a3ea510ed12812fba0d97f545bf87749c16831a
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 00:00:12 2025 -0400
the economy is in shambles
commit 0a3e17e897b270dc19a63038b8e99e15ff9242ce
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 23:43:06 2025 -0400
missing icons
commit fefc1348f722cf26bb407e6f7a5ba98184867fba
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 23:24:46 2025 -0400
no override for this
commit 952f2a7502d972093e1f86bd9fa20bf3ea9788bf
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 23:16:07 2025 -0400
shotgun icon states
commit 8e256d21c2bdfd2136f60705a3b5f7600ca6c9e7
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 23:02:28 2025 -0400
no icon
commit 60164e1a4c038661d41bbb25a1e0e536147455a2
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 22:39:35 2025 -0400
fucking capital letters?
commit 1e395535db671e61ce6514c35928a900d61a3570
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 22:28:06 2025 -0400
GRRRRRR
commit 68e35b0068388eb94d1c9ec5b865787b1cdc300a
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 21:19:15 2025 -0400
wrong
commit 9f8c9499f2890fad3c479d42c12888b1e0c55a3a
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 20:59:17 2025 -0400
just put your icons anywhere who gives a shit
commit f6bc1091867a3b234f2634e8cb120eae5b0053d9
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 19:58:40 2025 -0400
buh
commit edc876bff750ddce0593e917f5a68de02383c55e
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 19:49:32 2025 -0400
added our GAGS configs to deploy
commit e9ede320c9
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 23:23:21 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c726e4ee2d231d48334d43b8ce42d8b4e70b52b0
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 18:50:04 2025 -0400
fixed recipe foodtypes
commit 9e23291b14371e4703a38ae1711b1fe5b75cbf37
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 18:24:53 2025 -0400
Fix changelogs
commit bb8477826614c6e81285c5586de07ee26686c6b1
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 17:59:23 2025 -0400
number of args changed for inject
commit f00ed38c1d
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 11:03:02 2025 +0200
Automatic changelog for PR #3456 [ci skip]
commit 29b3c8daba
Author: aKromatopzia <94389683+aKromatopzia@users.noreply.github.com>
Date: Fri Apr 11 17:02:38 2025 +0800
Smolraptor Updates (#3456)
## About The Pull Request
Adds blue and red sec smolraptors, makes janitor an alt of service
## Proof Of Testing
it works
## Changelog
🆑
add: sec smolraptors
image: fixes some errors in smolraptors
/🆑
commit 7c0978a47f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 08:21:22 2025 +0200
Automatic changelog for PR #3463 [ci skip]
commit 04fd2b0a8a
Author: ArrisFairburne <arrisfairburne@gmail.com>
Date: Fri Apr 11 02:20:59 2025 -0400
Synth brain PDAs now have departmental PDA apps pre-installed (#3463)
## About The Pull Request
Synth brains now start with your department's apps pre-installed. For
example, Scientist synths now start with NT Science Hub. They also now
have double the storage space compared to the basic PDA.
## Why It's Good For The Game
Convenience.
Also, synth PDAs have sort of existed in a weird limbo where (at least,
from my point of view having talked to some others) most synth players
just don't actually use one of the defining features of their race
because normal PDAs are largely better and more convenient, hopefully
this change emphasizes their abilities.
The doubled brain storage space is just so that synth brain PDAs can
comfortably house whatever programs come with being a dept. head.
Balance wise, I doubt it will affect anything (what could you even do
with the extra storage space, short of the dept. head apps? basic crew
apps fit comfortably on the basic PDA limit, synths can't be emagged for
expensive syndie apps, and synths can't store files on their brain via
disks).
## Proof Of Testing
(image taken after I spawned as RD; this is the synth brain PDA)
## Changelog
🆑
qol: Synthetic crew now spawn in with PDA apps relevant to their work
station.
bal: Synthetic crew brain PDAs now have 128 max capacity points (was
previously 64)
/🆑
commit eaa6352aff
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 08:20:28 2025 +0200
Automatic changelog for PR #3471 [ci skip]
commit 02f3cfdb00
Author: ariaworld <143797359+ariaworld@users.noreply.github.com>
Date: Fri Apr 11 08:20:05 2025 +0200
[MAPPING]: Change Kilo Station dorms area type from Locker to Dorms. (#3471)
## About The Pull Request
Makes sure Kilo Station's dorms area actually is a Dorms area.
## Why It's Good For The Game
Other stations' dorms are inside actual Dorms areas, effectively
granting protection from events like sudden brain trauma/heart attack,
but Kilo Station didn't have this, they were classified as lockers
instead.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
:cl:Goku
map: Kilo Station's Dormitories area type is now classified as
dormitories, not as a Locker room.
/🆑
commit 5266275bc4
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 07:03:33 2025 +0200
Automatic changelog for PR #3485 [ci skip]
commit 0a38cf2824
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 01:03:07 2025 -0400
Fix examine menu character preview being tiny (#3485)
## About The Pull Request
Upstream fixed the tiny character preview but it requires a little tweak
on implementations
## Why It's Good For The Game
I can't see the blorbo
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: fixed character preview in the examine window being tiny
/🆑
commit 3fc7296b82
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 06:23:15 2025 +0200
Automatic changelog for PR #3483 [ci skip]
commit 1d52e91fd0
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 00:22:51 2025 -0400
Fix double box on vote results chat message (#3483)
## About The Pull Request
There's a redundant override in `vote.dm` to enclose the vote results in
a purple examine box, this is the default way votes are displayed now so
it's making vote results appear as a box within a box
## Why It's Good For The Game
Looks wrong
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
Before:
After:
</details>
## Changelog
🆑
fix: fixed vote results in chat having an extra box around them
/🆑
commit ab74044fc6
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 06:20:31 2025 +0200
Automatic changelog for PR #3363 [ci skip]
commit cb06f207d3
Author: Kepteyn <94123167+Kepteyn@users.noreply.github.com>
Date: Fri Apr 11 05:20:07 2025 +0100
Just a couple more hotel rooms (#3363)
## About The Pull Request
This adds four (and a half) new infinidorm hotel rooms -- A bar themed
one, for when you want bar RP that's less public; a nightclub themed
one; an space themed one for the spaceophilliacs who want to bang in
space (or an airlock), and finally an oasis themed one, with a day and a
night version.
It also fixes the lights in the Library room, given we're no longer
downstreaming from Skyrat, and it adds a template dmm that should make
it easier for people to add new rooms should they wish - the plaque on
the floor represents the spawn point.
## Why It's Good For The Game
This adds even more variety to the infinidorm room options for people to
roleplay in as a ghost. Or to _roleplay_ in. The bar one in particular
provides an option for people who want to do a bar RP with some friends
without getting pesky interruptions from their fellow human beings who
feel the need to start a gunfight in the bar.
## Proof Of Testing
All the new hotel rooms and the library have been tested in game, and
are working quite nicely! The template map does not show up as an option
in-game, as it exists to help mappers.
## Screenshots
<details>
<summary>Foxbar</summary>
</details>
<details>
<summary>Nightclub</summary>
</details>
<details>
<summary>EVA</summary>
_The floor is, infact, fake space, and is surrounded by a fake-space
wall. You will survive nude in space here. Spacesuits still provided._
</details>
<details>
<summary>Oasis</summary>
_Only one is shown for brevity's sake, as the only difference between
day and night versions is the strength of the external lighting_
</details>
<details>
<summary>Template</summary>
_The template room. The bluespace border must be indestructible solid in
some form, while the dark grey flooring represents the wall's location
on the defautl Hilbert room. The door is located where the default door
is on it, and the plaque on the ground shows where the player will
spawn_
</details>
## Changelog
🆑
add: Added infinidorms: Fox Bar; The Nightclub; EVA; and Oasis (day and
night versions)
add: Added a mapping template for creating new infinidorms at
modular_skyrat\modules\hotel_rooms
fix: modified the lights of the Library infinidorm so it's not so damn
dark.
/🆑
commit 700856e3c5
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 23:25:40 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 02353b9ec2
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 01:05:38 2025 +0200
Automatic changelog for PR #3475 [ci skip]
commit f1722bb1c6
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Thu Apr 10 16:05:12 2025 -0700
Disable lean reset on direction change (#3475)
## About The Pull Request
Edits TG's lean component to perform the same as the pixel shift
component
## Why It's Good For The Game
Consistent shifting movement
## Changelog
🆑 LT3
qol: Leaning no longer resets with directional change
/🆑
commit 4a5c80e1813ecaf7d26ddeabf2593d2b44c86dcb
Merge: b908b32d387 ada9345244
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Thu Apr 10 10:46:20 2025 -0700
Merge branch 'master' of https://github.com/Bubberstation/Bubberstation into upstream-25-04a
commit ada9345244
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 19:16:21 2025 +0200
Automatic changelog for PR #2896 [ci skip]
commit 472893ae5e
Author: Manatee <74586965+MajManatee@users.noreply.github.com>
Date: Thu Apr 10 12:15:56 2025 -0500
Tarkon Tweaks and Xeno Changes (#2896)
## About The Pull Request
Update as of 01/26
So that was a lie
Anyways I completely remade tarkon, which is what I ORIGNIALLY wanted to
do, but used a lot of the pre-existing tarkon assets to do so, to
maintain the same feel.
Some NEW NEW features (as the project grew in scope) include:
Med/RND/Engineering are now separate "Islands" like charlie (tarkon was
always meant to be like that anyhow
Each one has a few xenos, and a new "Emergency power generator"
Scanning this with the new (not a ripoff) Hack-C tool will call in a
repair drone (Original content) to repair it, and it needs to be
defended from the xenos it alerts.
Sucsesfully completing a defence will reward sickass weapons and gear
you wouldn't normally ever get to see, making further areas easier, and
a key for the final area.
Once all 3 keys are obtained, and the areas are re-secured, you can go
to the boss area and clear out the AI sat / command zone.
A bitrunning server to allow them to make their own bitden (it's the
first prototype, and the rest must be researched so it's not
shift-start)
more floor safes with various things like some ore thumpers and two
bluespace beakers
Crates! Someone misfiled a crate of goodies and it got sent here! These
orders should be delivered to their owners! I'm sure they would
appreciate it! Probably...
A Recycler (Amazing)
A produce order console! Now you can actually cook whatever you want!
And it gives you a reason to sell stuff for money!
more stuff, lots more stuff. things keep getting added the longer it
takes for this to be looked at.
Also adds three new variants of xenobio, and two new variants of the
cargo bay. One cult (we miss you cult), one carp, and a monkey themed
xenobio.
## Why It's Good For The Game
Part 1 of my attempt to make tarkon feel better to play. The overall
gameplay was very "Meta" and didn't really give you any reason to clear
out xenos or the threats. Who knows what might come next.
Tarkon was pretty stale. A bit of new stuff might be nice. plus a reason
to use their shuttle is good.
Furthermore, tarkon WILL run on solar, so if you REALLY don't want to,
you don't HAVE to go and clear everything out.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
I did test it, and run the wave defense, it DOES work.
</details>
## Changelog
🆑
add: BUNCH of new tarkon things!
map: Tarkon QOL changes
/🆑
---------
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
Co-authored-by: Arturlang <24881678+Arturlang@users.noreply.github.com>
commit b908b32d387ffe9a2b40d2d25a03cd04c2e62868
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Thu Apr 10 08:35:37 2025 -0700
Compiletimes done
commit a9601004a82714a72f62e9b5db07d2adde27c0c3
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Thu Apr 10 08:35:26 2025 -0700
We are so comically stupid
commit 0f8d37991f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 00:05:02 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 31897a95e9
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 01:54:47 2025 +0200
Automatic changelog for PR #3468 [ci skip]
commit 385b734424
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 01:54:32 2025 +0200
Automatic changelog for PR #3470 [ci skip]
commit 0903ee683e
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Wed Apr 9 19:54:20 2025 -0400
Fix shuttles no longer making sounds or (un)bolting doors (#3468)
## About The Pull Request
The code for these things got lost in an upstream because shuttle code
got split into multiple files
## Why It's Good For The Game
Fixes#3251
## Proof Of Testing
I tested it and the shuttle went bwwwwrrmmmmm pshewww and the door bolts
went chk
## Changelog
🆑
fix: fixed shuttles missing landing/take off engine sounds
fix: fixed shuttles not bolting/unbolting their doors when moving
/🆑
commit e5b57bc08c
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Wed Apr 9 16:54:09 2025 -0700
Fix meow emote for cat tongues (#3470)
## About The Pull Request
Fixes the meow emote to use the correct emote if you have a cat tongue
## Why It's Good For The Game
MEOW.
## Changelog
🆑 LT3
fix: Mobs with cat tongue get their alternate meow sound back
/🆑
commit 204ea57363
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 9 23:23:16 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit ce5944e0733f4c5985e2e48878a02c0c35463d0a
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 08:19:09 2025 -0700
6 compiletime errors left
commit d1905c44f5
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 9 14:03:13 2025 +0200
Automatic changelog for PR #3461 [ci skip]
commit 6c3bc53604
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Wed Apr 9 08:02:51 2025 -0400
Deathmatch now stores and reapplies your respawn timer prior to being spawned (#3461)
## About The Pull Request
Title
## Why It's Good For The Game
item number TWO on the list
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
code: deathmatch doesn't reset your respawn timer
/🆑
commit f890cb36b9265f011a187b4f332812590838292c
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:45:20 2025 -0700
some color stuff
commit fb849a2a8ebc2166915cfbec1e850510678b2f22
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:38:18 2025 -0700
Fixes
commit 381d77fa68707cc5315b698474df026c2103166c
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:20:20 2025 -0700
We love guncode and refactors!!!!
commit f30bb6ca01319218795e4004219938aa3d976eb3
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:00:40 2025 -0700
I love cherry picking!!!
commit 6677a4c7bbe3c7536276178c841290a489d0a4a9
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:00:27 2025 -0700
so apparently some dumbass on nova reused the turret flag bitfield and it only now runtimes
commit 7acc721baadbdea3d3795a45b9837cfeb4fd4fd0
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 00:58:48 2025 -0700
Martials and arcade rework updates
commit bf9f393204fe7d40d5e57e76db870eb1a32aed25
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 00:47:58 2025 -0700
This might break taur icons, remember to test once we compile
commit 3bc256cb16ca2e85b78830345bba0a487f49fc17
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 00:41:03 2025 -0700
Several varchanges from tg
commit 76f5dc1b5f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 8 23:23:40 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 538049c4cd4960d2c81c43f2e387896049fb02c7
Author: Waterpig <wtryoutube@seznam.cz>
Date: Tue Apr 8 20:00:59 2025 +0200
reagent applicators fixes
commit df43e50d68419d2f24bd62eef0432bda8394cc7d
Author: Waterpig <wtryoutube@seznam.cz>
Date: Tue Apr 8 19:56:27 2025 +0200
Some missed merge fixes
commit 0f0838bb35
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 8 09:27:36 2025 +0200
Automatic changelog for PR #3399 [ci skip]
commit 234a410586
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 8 09:27:29 2025 +0200
Automatic changelog for PR #3397 [ci skip]
commit 722b51eb07
Author: Iamgoofball <iamgoofball@gmail.com>
Date: Tue Apr 8 02:27:12 2025 -0500
[MODULAR] Removes the 60 round Sol drum from being printable in Security (#3399)
## About The Pull Request
Removes the 60 round Sol drum from being printable in Security
## Why It's Good For The Game
After discussing magazine size standardization, this came up and to be
100% honest, the crew does not need LMG ammo capacity on any of their
guns. Even though it's illegal contraband to use(yes, Illegal Tech is
still fuckin' Illegal lol), it's still a lot of ammo capacity that we
don't really want the crew to have.
## Proof Of Testing
Just deleting a research design.
## Changelog
🆑
del: Removes the 60 round Sol drum from being printable in Security
/🆑
---------
Co-authored-by: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
commit 3e7223b959
Author: Iamgoofball <iamgoofball@gmail.com>
Date: Tue Apr 8 02:27:06 2025 -0500
[MODULAR] Puts the Sol/Carwo/Romulus/Szot/Trappiste gun magazine sizes in line with /tg/ standards (tiny for everything but rifles which are normal) (#3397)
## About The Pull Request
Puts the Sol/Carwo/Romulus/Szot/Trappiste gun magazine sizes in line
with /tg/ standards (tiny for everything but rifles which are normal)
## Why It's Good For The Game
Size inconsistencies between items results in confused players; it's
good to keep this sort of thing synced up so that we're not having
players ask why one pistol magazine fits in a box while another pistol
magazine doesn't fit in a box when the air tank that's bigger than both
of them does fit in the box.
If I find other guns with weird weight classes I'll fix those too.
## Proof Of Testing
Single-line changes, weight classes is a proven working system already.
## Changelog
🆑
qol: Puts the Sol/Carwo/Romulus/Szot/Trappiste gun magazine weight
classes in line with /tg/ standards for magazine weight classes (tiny
for everything but rifles or larger which are normal)
/🆑
commit 7b420bb680
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 22:16:23 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit f30b0d5df0
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 8 00:12:44 2025 +0200
Automatic changelog for PR #3452 [ci skip]
commit aa4901b571
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Mon Apr 7 15:11:59 2025 -0700
Map vote is called automatically on blob/nukies/etc. round end (#3452)
## About The Pull Request
Triggers the automatic map vote when the round is about to end due to a
station threat, if it hasn't happened.
## Why It's Good For The Game
Saves it delaying the next round if no admin catches it in time, causing
a delay as the vote and another restart needs to occur.
## Changelog
🆑 LT3
admin: Map vote is automatically triggered near the conclusion of
station ending threats
fix: Only a single announcement is sent when the shuttle is called,
fixing the overlapping sounds
/🆑
commit a6845577bd
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 21:55:15 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit bf8c0ef85f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 23:49:40 2025 +0200
Automatic changelog for PR #3459 [ci skip]
commit 28e4e2cd42
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Mon Apr 7 17:49:12 2025 -0400
Refactor changelog handling to separate files (#3459)
## About The Pull Request
This rewrites how our actions handle changelogs, and rewrites a bunch of
the changelog TGUI (in a separate file cause I don't feel like
massacring the upstream one). The gist of it is that our actions will
now create autochangelog files with bubber in the name, our changelog
compile will only compile those autochangelogs (not upstream ones if
they happen to be in there), and the compile will be done into separate
bubber changelog files in `html/changelogs/bubber_archive`. In game, the
UI will pull both archive files (upstream and ours) and combine them in
the changelog list, putting the codebase logo next to each change to
distinguish which one it's from.
~~NOTE: I'm opening this as a draft because I'm going to try and reset
our tg changelogs and then reapply all our historical changelogs into
the new bubber archive files, I'm just putting this up now so the code
can be reviewed and shit~~ done
## Why It's Good For The Game
For players this makes it easier to distinguish where a change came
from, and for developers this means we don't need to worry about
breaking the changelog when we do an upstream pull, we can completely
ignore it and just pull everything, and our tg archive files will be 1:1
with upstream with no shit from us added in.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑 TealSeer, LT3
refactor: refactored how changelogs are generated and displayed
/🆑
---------
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
commit 7de99181db
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Mon Apr 7 17:44:07 2025 -0400
Rename Autochangelog (#3462)
the refactor is about to merge this isnt gonna be included otherwise
commit 0ed680f2aa
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 23:36:02 2025 +0200
Automatic changelog for PR #3457 [ci skip]
commit 0f13b89457
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Mon Apr 7 17:35:25 2025 -0400
30 minute grace period to respawn (world time, not round time) (#3457)
## About The Pull Request
from when the server starts to 30 minutes after, respawning is free of
charge
## Why It's Good For The Game
item #1 on the list
## Proof Of Testing
it works dude trust me
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
code: respawn enabled until 30 min (world time)
/🆑
commit 99cb23f3c5
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 18:30:45 2025 +0200
Automatic changelog for PR #3434 [ci skip]
commit 697d89abf3
Author: pixelkitty286 <78038207+pixelkitty286@users.noreply.github.com>
Date: Mon Apr 7 11:30:19 2025 -0500
Cleans up and reorganizes some of the borg code (#3434)
## About The Pull Request
This PR reorganizes and cleans up some of the borg code and separates
sprite defines and borg defines once more but this time correctly.
Also fixes some small bugs with foot steps with chameleon module.
Moved some borg model specific trait procs into their own file.
## Why It's Good For The Game
Makes it more organized so we don't have one HUGE file containing all
the sprite defines and borg model code
## Proof Of Testing
It's all back end. Compile test was last done late march.
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: chameleon model foot steps
code: moved many of the borg defines to their correct _defines file and
folder
/🆑
commit 74985f40fc
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 10:28:15 2025 +0200
Automatic changelog for PR #3447 [ci skip]
commit d58cf909af
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Mon Apr 7 01:27:49 2025 -0700
Change podperson eye color (Again (Thanks Upstream)) (#3447)
commit cb3052e6ea
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 02:04:52 2025 +0200
Automatic changelog for PR #3448 [ci skip]
commit c29d36ada5
Author: sippykot <sippythekot@outlook.com>
Date: Mon Apr 7 02:04:27 2025 +0200
Fish Ass: ports over large shark tails from CHOMP (#3448)
## About The Pull Request
see title
if you want to see who made the sprites, follow the accreditation chain:
https://github.com/CHOMPStation2/CHOMPStation2/pull/9926
it doesn't fully use all the sprites, because our system here is so much
clunkier to use - if someone wants they can probably bash out several
more tail variants by copying and rearranging the existing sprites
## Why It's Good For The Game
people wanted them, gushed over them in #suggestions, and then no one
did anything, so...
also, 🦈
## Proof Of Testing
yeah i compiled it, they finally showed up in game, thanks #coder-longue
## Changelog
🆑
add: 4 new tail options
image: new tail sprites
/🆑
---------
Co-authored-by: Roxy <75404941+TealSeer@users.noreply.github.com>
commit fa6845f9e6
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 23:22:10 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 55fd8dd1f7
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 01:01:20 2025 +0200
Automatic changelog for PR #3426 [ci skip]
commit 16f6d07548
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Sun Apr 6 19:00:55 2025 -0400
Shadekin NV and movespeed rebalance (#3426)
## About The Pull Request
title + nerf movespeed in the light
## Why It's Good For The Game
still can't see shit (nv trait is 4.5, bumping it up to 15)
## Proof Of Testing
it werks
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
balance: shadekin nv buffed from 4.5/100 to 15/100
balance: shadekin move a bit slower in the light
/🆑
commit d2f96730ba
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 22:16:10 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c7def946b6
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 17:39:00 2025 +0200
Automatic changelog for PR #3450 [ci skip]
commit f833f3edc4
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 6 11:38:26 2025 -0400
Fix persistence medbots speaking on syndicate frequency (#3450)
## About The Pull Request
Make them speak on cybersun frequency
## Why It's Good For The Game
Fixes#3446
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: fixed persistence medbots speaking on wrong radio frequency
/🆑
commit 17b620b48e
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 10:19:15 2025 +0200
Automatic changelog for PR #3438 [ci skip]
commit bfb9c9e2b5
Author: pixelkitty286 <78038207+pixelkitty286@users.noreply.github.com>
Date: Sun Apr 6 03:18:52 2025 -0500
Nerfs super syndicat and makes it no longer a freedom implant. (#3438)
## About The Pull Request
- This PR makes the new syndicat ears item have a 1 minute cool down
when used and the normal ears have the same thing.
- This also ports a fix that was done on monkey station:
https://github.com/Monkestation/Monkestation2.0/pull/6017
## Why It's Good For The Game
- After watching a round on here and getting complaints about this from
SPLURT I understand now why 20 seconds is too short for such a item like
this if your gonna be a cat your gonna be a cat for a long while.
- Also to quote monkey station:
"It will make the cat not able to bypass any security non-lethal means,
which in turns mean security won't be forced to lethal them everytime
they see it."
## Proof Of Testing
Should work only changed the time values.
Edit: Compiled and tested locally
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
balance: Super cat ear cool downs are longer and removed the freedom
implant function.
/🆑
commit 4ed70fa4c7
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 10:18:17 2025 +0200
Automatic changelog for PR #3451 [ci skip]
commit 65331b085f
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 6 04:17:45 2025 -0400
Fix invisible sprites on security HUD nightvision goggles (#3451)
## About The Pull Request
Upstream changed NV goggles to have different icon states for on and off
and we dont have that so I reverted it to the tg sprite
## Why It's Good For The Game
Fixes#3383
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: fixed sechud nv goggles being invisible when off
/🆑
commit 8aad924f76
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 10:16:18 2025 +0200
Automatic changelog for PR #3443 [ci skip]
commit 3bd5803844
Author: Swift <jackwars4@gmail.com>
Date: Sun Apr 6 03:15:53 2025 -0500
Removes tackle buff for having cat ears (#3443)
## About The Pull Request
Title, manual revert of #1513
## Why It's Good For The Game
Tackle chance could be brought to 100% and people have reportedly been
exploiting this fact.
## Proof Of Testing
I think it will complie
## Changelog
:cl:Swiftfeather
balance: Cat ears no longer provide a tackle bonus
/🆑
commit 89594c8547
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 00:56:59 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit b4af64b182
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 02:25:40 2025 +0200
Automatic changelog for PR #3370 [ci skip]
commit 0e684db68a
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 5 17:24:44 2025 -0700
Update various sound prefs for 516 compatibility (#3370)
## About The Pull Request
Updates our various sound prefs to be functional post upstream/516.
## Why It's Good For The Game
We can control sound as expected again.
## To-Do
- [x] Conditional preference sounds
- [x] Jukebox sound toggle
- [x] Jukebox volume override
## Changelog
🆑 LT3
fix: Sound prefs that went missing post-516 are restored
add: Jukebox volume slider in game preferences
/🆑
---------
Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com>
commit 60e73702c6
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 07:14:09 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 9a36823173
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 09:02:26 2025 +0200
Automatic changelog for PR #3425 [ci skip]
commit 1ab85fd206
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Sat Apr 5 03:02:02 2025 -0400
Spices up vulpkanin [bounty] (#3425)
## About The Pull Request
Changes vulpkanin in several ways:
- Peanutbutter gives a mood buff
- Chocolate deals toxin damage while inside you
- innate hardened soles
- innate night vision
- hunger will drain twice as fast
- higher sensitivity to flashes
## Why It's Good For The Game
vulpkanin are literally human but fluffy, they don't even have lore in
the species selector (lol) also I'm being paid
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
add: several vulpkanin species buffs/debuffs
/🆑
---------
Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
commit 4da0397b16
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 08:54:22 2025 +0200
Automatic changelog for PR #3396 [ci skip]
commit 1ed1187fca
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Fri Apr 4 23:53:57 2025 -0700
Slug Scream! (#3396)
## About The Pull Request
Adds a new scream, "Slug". Sound file ripped from Splurt
## Why It's Good For The Game
Expression is the best thing that this video game medium can offer.
## Proof Of Testing
https://github.com/user-attachments/assets/147be9dc-98c2-4ee4-bc76-762331710143
## Changelog
🆑
sound: Slug Scream sound added to *scream choices
/🆑
commit 66e28121d4
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 08:53:15 2025 +0200
Automatic changelog for PR #3431 [ci skip]
commit 88a238b93c
Author: Bombermansam <Bombermansam@yahoo.com>
Date: Sat Apr 5 02:52:48 2025 -0400
Allows players to be sad like raptors (#3431)
## About The Pull Request
Adds a Sad Kweh emote from the two unused raptor sound files.
## Why It's Good For The Game
You can now sad birdly.
## Proof Of Testing
It compiles and was tested locally.
https://github.com/user-attachments/assets/bc5f31fb-ad12-4026-be94-d28d2db542df
## Changelog
🆑
add: *skweh emote to be sad
/🆑
commit 4a93b42977
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 08:51:43 2025 +0200
Automatic changelog for PR #3432 [ci skip]
commit f51c4d7942
Author: Bombermansam <Bombermansam@yahoo.com>
Date: Sat Apr 5 02:51:18 2025 -0400
Silicons can now Yip (#3432)
## About The Pull Request
Silicons can now emit a singular yip so they can express their inner
kobold but not too much.
## Why It's Good For The Game
Silicons can yipyip but not yip. This fixes it.
## Proof Of Testing
It compiles and was tested locally.
</details>
## Changelog
🆑
fix: Silicons can now yip.
/🆑
commit 14ec8a0440
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 08:43:03 2025 +0200
Automatic changelog for PR #3437 [ci skip]
commit e05fe31faa
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Sat Apr 5 02:42:41 2025 -0400
Adds more flavor to shadekin empathy (#3437)
## About The Pull Request
BASED ON SANITY SHADEKIN EMPATHY WILL:
-Take more or less time to send
-At lowest levels of sanity the message starts to break down some
-Be a different color in chat
## Why It's Good For The Game
Shadekin empathy is communication through FEELINGS so it being
better/worse based on how you're FEELING makes sense (to me)
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
balance: shadekin empathy is better/worse based on mood
/🆑
---------
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
commit 457754c461
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 06:38:05 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c3fe3d31ba
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Fri Apr 4 23:16:53 2025 -0700
You can cuff people to the tram rails #90293 (#3445)
## About The Pull Request
https://github.com/tgstation/tgstation/pull/90293
Handcuffed people can be buckled to the tram rails.
If the tram hits them then they will die badly.
If they're not shockproof and are buckled to a powered rail, it will zap
them repeatedly for a little bit of damage (but not a lot because you
probably want them to die from something else).
Unbuckling someone from a powered rail is also pretty dangerous.
While doing this I fucked around a bit with how the "is the tram deadly"
calculation worked because I didn't like how a deadly tram cuts your
head off but does literally no other damage. Now it pulverises and
beheads you.
## Why It's Good For The Game
---------
Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com>
commit 3c1c05052f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 4 23:23:13 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 0287fe4d0b
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 4 21:54:53 2025 +0200
Automatic changelog for PR #3440 [ci skip]
commit 6d081fe0da
Author: Bombermansam <Bombermansam@yahoo.com>
Date: Fri Apr 4 15:54:30 2025 -0400
[Modularized] Nugget Boxes and Foodpacks can now be placed into paper sacks. (#3440)
## About The Pull Request
Nugget Boxes and Foodpacks can now be placed into paper sacks.
## Why It's Good For The Game
You can now live out your minimum wage dreams as a fast food worker a
Chick'fil'a. To quote someone that wanted this "I can now fastfoodmax as
a chef".
Food packs can also be placed into paper sacks because it makes sense.
## Proof Of Testing
It compiles and was tested locally.
I would like to praise [lessthnthree](https://github.com/lessthnthree)
for their remarkable patience in teaching me how to properly modularize
code. Really, thank you so much!
</details>
## Changelog
🆑
add: Makes Nugget Boxes and Food packs small
/🆑
---------
Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
commit 0824cb07ba
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 20:19:08 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 9d8a54be49
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 22:14:42 2025 +0200
Automatic changelog for PR #3433 [ci skip]
commit 45477353d2
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 22:14:33 2025 +0200
Automatic changelog for PR #3403 [ci skip]
commit b6b6fbfba4
Author: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
Date: Thu Apr 3 14:14:17 2025 -0600
Job Spawn borgs prioritize linking to the malf AI (#3433)
## About The Pull Request
So there's this little quirk where late join cyborgs will auto link to
whatever AI has the least cyborgs. This changes that.
This adds a priority: Malf AI > AI cores
Also this deletes an unused file I noticed.
## Why It's Good For The Game
Every cyborg that spawns in the game during an active malf round should
always connect to the malf AI if it's available.
## Proof Of Testing
It works
## Changelog
🆑
balance: Cyborgs now auto link in a priority system. Malf > AI cores >
Suit AIs / Cards
/🆑
commit 1f3aedc6c1
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Thu Apr 3 13:14:07 2025 -0700
Fix brain trauma surgery (#3403)
## About The Pull Request
Fixes the highest level of trauma surgery leaving leftover traumas.
Applies a status effect instead of the random roll of a new trauma.
## Why It's Good For The Game
Having to do lobotomy surgery over and over until you hit the 25% RNG to
make it successfully go away isn't a good gameplay experience. Better to
just apply a status effect for a while instead.
## Changelog
🆑 LT3
fix: Lobotomy/blessed lobotomy should correctly remove all surgery based
traumas
balance: Lobotomy/blessed lobotomy now provides a predictable status
effect instead of a trauma RNG roll
/🆑
commit 95d97cf4a2
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 18:50:51 2025 +0200
Automatic changelog for PR #3429 [ci skip]
commit 3c30dfbaff
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Thu Apr 3 09:50:24 2025 -0700
Shadekin Ear Gradient (#3429)
## About The Pull Request
Adds a new ear type: Shadekin Gradient
## Why It's Good For The Game
Makes Healer happy
## Proof Of Testing
## Changelog
🆑
add: Added new ear type: Shadekin Gradient
/🆑
---------
Co-authored-by: Jinshee <manastra2536@gmail.com>
commit 3dd8af584e
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 06:33:08 2025 +0200
Automatic changelog for PR #3415 [ci skip]
commit c83b14b15d
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Wed Apr 2 21:32:45 2025 -0700
Porting New Bug Customization + IPC Screens (#3415)
commit d9d40def4c
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 02:35:34 2025 +0200
Automatic changelog for PR #3387 [ci skip]
commit a154dd9d97
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Wed Apr 2 17:35:10 2025 -0700
Fixes Waggingtail Sprite for Shadekin tails + Ringtail (#3387)
## About The Pull Request
All of the shadekin tails, ringtail included, had incorrectly assigned
dmi files for their wagging state, causing them to go invisible. This,
simply, fixes that.
## Why It's Good For The Game
I love fixing sprites!
## Proof Of Testing
https://github.com/user-attachments/assets/186f7dc6-4b78-4e9e-968e-fcbdae40bf2f
## Changelog
🆑
fix: fixed wagging state for all shadekin tails and ring tail (long)
/🆑
commit ba3fa0684c
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 21:56:26 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 70143cdadb
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 23:52:41 2025 +0200
Automatic changelog for PR #3419 [ci skip]
commit ad62db6f9b
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Wed Apr 2 14:52:18 2025 -0700
Adds pipe carp (#3419)
## About The Pull Request
A Ferocious, highly aggressive fish that thrives in the depths of shoddy
engineering work. Drawn to poorly sealed pipes, mismatched connectors,
and hastily patched atmospherics, these creatures feast on structural
incompetence with alarming efficiency.
## Changelog
🆑 LT3
add: Added new carp variant: carpmospheric technician
/🆑
commit dab0ff6a09
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 11:40:26 2025 +0200
Automatic changelog for PR #3423 [ci skip]
commit 27027d5ceb
Author: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
Date: Wed Apr 2 03:40:00 2025 -0600
take two: Reverts the disaboot apirl fools (#3423)
## About The Pull Request
Apirl fools code cleanup. Was a funny meme, but I don't think they
should happen next year.
## Changelog
🆑
del: Disaboots have been removed from apirl fools.
/🆑
commit 1c08269f2a
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 03:08:41 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c43c9d01ed
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Tue Apr 1 19:38:12 2025 -0700
[TM ONLY] let me send long ass subtler messages to my heart's content (TGUI payload chunking) (#3406)
## About The Pull Request
(https://github.com/tgstation/tgstation/pull/90295)
## Changelog
🆑 Y0SH1M4S73R
code: Any tgui message that would be too big to send to the server is
now split into chunks and sent in sequence. This fixes several issues,
such as...
fix: It is once again possible to save large amounts of text on paper at
once.
/🆑
---------
Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net>
Co-authored-by: Y0SH1M4S73R <y0sh1m4s73r@gmail.com>
Co-authored-by: Lucy <lucy@absolucy.moe>
commit c96d028562
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 04:35:29 2025 +0200
Automatic changelog for PR #3420 [ci skip]
commit e22c174b35
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 04:35:09 2025 +0200
Automatic changelog for PR #3407 [ci skip]
commit 43a4b964b1
Author: plsleavemealon <106043510+plsleavemealon@users.noreply.github.com>
Date: Tue Apr 1 21:35:04 2025 -0500
Ethereal Powercell Bugfix (#3420)
## About The Pull Request
Fixes ethereal powercells from 20kj back to 220kj which is what they
used to be.
## Why It's Good For The Game
It is what it used to be, and with the present vanilla values you have
to recharge yourself once every ~5 minutes or so or suffer a huge mood
debuff. And if you are entombed, you will suffer death after ~10 minutes
if you do not recharge.
## Proof Of Testing
## Changelog
🆑
fix: fixed ethereals powercell back to bubbers values
/🆑
commit 3068303ae3
Author: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
Date: Tue Apr 1 20:34:46 2025 -0600
Reverts "Adds crew monitors to Advanced biotech and lathes" (#3407)
## About The Pull Request
This removes the handheld crew monitor from the medical lathe.
## Why It's Good For The Game
Alright, I just want to start out with all sources of the handheld crew
monitor after this PR
- Paramedics spawn with them
- Blueshield (command only)
- The medical vendor premium section.
- Borg upgrades
Overall while there's been a lot of QOL to the crew monitor which I
enjoy, it's all gradually made it so deaths are very noticable and often
times with someone in medical 1 second later running towards an active
fight to drag corpses away.
- I think overall we have a sort of medical omnipresence issue,
especially with an easy research destroying a level of scarcity with the
hand held crew monitor.
Anyone can print it if they have the materials and access to the lathe
versus only a few existing outside of the paramedic starting with them.
This PR of course is not going to fully tackle it. It's not going to
stop a paramedic constantly staring at sensors or the medical console
beeping when someone's in crit. But this aims to get less eyes on
sensors, mostly the ability for everyone in medical to have a little
screen to pull out and see the live feed without actively moving to a
console.
Overall I think we have this issue (a lot of it being administrative)
where every single death must be immedietly found and the person revived
in 10 minutes. This won't fully tackle that, but if the solution is we
must bloat a ton of antag abilities and items to combat sensors then I
think we have too many eyes on sensors.
## Proof Of Testing
## Changelog
🆑
del: Removes the handheld crew monitor from the medical lathes.
/🆑
commit c9cca3fbef
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 1 23:24:18 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit de81adcb6d
Author: Waterpig <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 2 00:55:25 2025 +0200
Makes the roundend mapvote not rerun after it gets called the first time (#3418)
## About The Pull Request
See name
## Why It's Good For The Game
Fixes#3395
## Proof Of Testing
It worked I did test it
## Changelog
Nothing player facing, basically allows us to cancel the vote once it
initializes
commit b36c477460
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Tue Apr 1 18:35:54 2025 -0400
Fix every fucking piece of maint loot being skub (#3412)
## About The Pull Request
the override should append to the global maint loot list not replace it
## Why It's Good For The Game
I'm anti-skub
## Proof Of Testing
I did this PR from my phone in bed because there's no power
## About The Pull Request
Quirks can now define if they're "species appropriate," where the base
proc's behavior is simply "does this species already have the quirk's
main trait"
I am unsure if that on its own imposes any new restrictions, currently.
Additionally, blood deficiency cannot be picked on any species without
blood or that doesn't breathe.
I'm sure there's more that might make sense, I'm open to suggestions
Alternative to #90238
## Why It's Good For The Game
Currently, reduces the possibility of taking something like blood
deficiency on a race which suffers no downside from it in order to get
free positive quirks.
Future-ly, potentially allows quirks exclusive to only a select few
species as offered by #90238
## Changelog
🆑
fix: Species without blood can no longer be blood deficient
/🆑
## About The Pull Request
Fixes#90273
we relied on the post request sending the form data over the url,
apparently this was the default behavior in ie11 but edge changed the
form data to be sent in the http body, because browser standards i guess
this is bad for us though because it breaks voting since the form data
does not appear in the topic anymore. this PR changes the form
submission method to get, which correctly submits form data again.
proof of testing on localhost:
(the long line on the bottom of the log is me suibmitting my result to
the form, also note how the "Vote successful." message shows up in the
chat)
## Changelog
🆑
fix: Players on 516 can submit votes for IRV again.
/🆑
## About The Pull Request
- Selecting Wallet in the loadout, will equip the wallet when you load
into the game. It will auto-fill the wallet with small items from your
roundstart kit like quirk items or other loadout items.
- Selecting Lipstick in the loadout will automatically apply it to your
character. You still get the lipstick item at game start.
- Deletes all the preset lipstick colors, now you can just pick what
color you want. You can also pick what layer the lipstick starts at
(high, middle, low).
## Why It's Good For The Game
- Makes it work like the station trait (except the money part)
- Convenience
- Extra customization
## Changelog
🆑 Melbert
qol: Wallet loadout item comes pre-equipped
qol: Lipstick loadout item comes pre-applied
qol: You can choose your lipstick color from any color now. You can also
choose what layer it defaults to.
/🆑
Ports the helpers from
https://github.com/BeeStation/BeeStation-Hornet/pull/12240
This should fix some more of the 516 issues that I've seen while giving
a quick check through the code
The remaining browse should work now.
Also fixing another sass warning while being on it.
## About The Pull Request
## Why It's Good For The Game
## Changelog
🆑
fix: tgui say 516 will no longer change channels when the button is used
to drag it
fix: tgui say 516 will no longer leak radio messages into the wrong
channel
fix: runechat flickering when faded up messages fade out
/🆑
Converts `/datum/player_details` into `/datum/persistent_client`.
Persistent Clients persist across connections. The only time a mob's
persistent client will change is if the ckey it's bound to logs into a
different mob, or the mob is deleted (duh).
Also adds PossessByPlayer() so that transfering mob control is cleaner
and makes more immediate sense if you don't know byond-fu.
Clients are an abstract representation of a connection that can be
dropped at almost any moment so putting things that should be stable to
access at any time onto an undying object is ideal. This allows for
future expansions like abstracting away client.screen and managing
everything cleanly.
## About The Pull Request
Fixes#89458
Adds a config for auto-deadminning admins who ready up before the round
starts, or click join game after.
The deadminning happens as soon as the button is pressed, not when a job
is selected or the round starts. I figure it's better to do it straight
away since both have opportunities for metainfo to be posted in admin
chat. Before there's admins messing with dynamic config / plotting
events etc. and during the round there's basically everything that gets
posted to admin logs.
I've had to add a typecheck to the auto_deadmin proc, since the lobby
menu technically happens on the centcom Z-level, and there's a pref for
ignoring deadminning on centcom Z, so it checks to see if the admin is a
new player mob.
Changed the old config from auto_deadmin_player to auto_deadmin_always
to make it less deceptive.
Was suggested a pref could be added to do this. I can do that if people
want it maybe, but it's not in this PR at the time of posting it.
Is now a pref
<img src="https://i.ibb.co/211sBMYd/Deadmin-Prefs1.png">
<img src="https://i.ibb.co/r20Srbw4/Deadmin-Prefs2.png">
I dunno if the latejoin proccall is in the right spot in the click
sequence thing I can move it if people want.
## Why It's Good For The Game
Admins spawning themselves on station is very important for both
shenanigans and troubleshooting. It's annoying to have to click readmin
every time and I'm too lazy to figure out how to perms escalate my way
into disabling that config every round (Though I have tried).
This PR is marginally more likely to convince Timber to turn that off
than cussing him out in adminbus.
## Changelog
🆑
admin: Added a new config to force admins to deadmin when readying up or
latejoining the round.
/🆑
Ports the helpers from
https://github.com/BeeStation/BeeStation-Hornet/pull/12240
This should fix some more of the 516 issues that I've seen while giving
a quick check through the code
The remaining browse should work now.
Also fixing another sass warning while being on it.
## About The Pull Request
## Why It's Good For The Game
## Changelog
🆑
fix: tgui say 516 will no longer change channels when the button is used
to drag it
fix: tgui say 516 will no longer leak radio messages into the wrong
channel
fix: runechat flickering when faded up messages fade out
/🆑
## About The Pull Request
Converts `/datum/player_details` into `/datum/persistent_client`.
Persistent Clients persist across connections. The only time a mob's
persistent client will change is if the ckey it's bound to logs into a
different mob, or the mob is deleted (duh).
Also adds PossessByPlayer() so that transfering mob control is cleaner
and makes more immediate sense if you don't know byond-fu.
## Why It's Good For The Game
Clients are an abstract representation of a connection that can be
dropped at almost any moment so putting things that should be stable to
access at any time onto an undying object is ideal. This allows for
future expansions like abstracting away client.screen and managing
everything cleanly.
## About The Pull Request
Fixes#89458
Adds a config for auto-deadminning admins who ready up before the round
starts, or click join game after.
The deadminning happens as soon as the button is pressed, not when a job
is selected or the round starts. I figure it's better to do it straight
away since both have opportunities for metainfo to be posted in admin
chat. Before there's admins messing with dynamic config / plotting
events etc. and during the round there's basically everything that gets
posted to admin logs.
I've had to add a typecheck to the auto_deadmin proc, since the lobby
menu technically happens on the centcom Z-level, and there's a pref for
ignoring deadminning on centcom Z, so it checks to see if the admin is a
new player mob.
Changed the old config from auto_deadmin_player to auto_deadmin_always
to make it less deceptive.
Was suggested a pref could be added to do this. I can do that if people
want it maybe, but it's not in this PR at the time of posting it.
Is now a pref
<img src="https://i.ibb.co/211sBMYd/Deadmin-Prefs1.png">
<img src="https://i.ibb.co/r20Srbw4/Deadmin-Prefs2.png">
I dunno if the latejoin proccall is in the right spot in the click
sequence thing I can move it if people want.
## Why It's Good For The Game
Admins spawning themselves on station is very important for both
shenanigans and troubleshooting. It's annoying to have to click readmin
every time and I'm too lazy to figure out how to perms escalate my way
into disabling that config every round (Though I have tried).
This PR is marginally more likely to convince Timber to turn that off
than cussing him out in adminbus.
## Changelog
🆑
admin: Added a new config to force admins to deadmin when readying up or
latejoining the round.
/🆑
## About The Pull Request
Was just scrolling through the Paradise github since they seem to have
more work done for 516 to see if there's anything I can port over, found
this and thought why not.
Ports parts of https://github.com/ParadiseSS13/Paradise/pull/25105
Specifically, updaing all hrefs to use the internal ``byond://``, and
adding it to grep.
## Why It's Good For The Game
More work towards 516.
## Changelog
Nothing player-facing.
## About The Pull Request
Turns out that if you don't test if you fix works, it probably won't!
I've actually managed to test this one, and even though it gave me a
handshake error when joining the other server, at least the fade in
worked! The fadeout is set up in the same way, so it should be fine
## Why It's Good For The Game
ACTUALLY fixes#29496
## Changelog
🆑
fix: ACTUALLY fixes server hop fade in
/🆑
## About The Pull Request
Removes all fragments of veteran code from the game.
## Why It's Good For The Game
It should help maintainers when doing upstream syncs as it removes some
non-modular code. Also we have no use for the veteran system.
## Proof Of Testing
It compiled and ran.
## Changelog
Nothing player facing.
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
## About The Pull Request
Add `?` operator to `alt_job_titles` accesses
## Why It's Good For The Game
Fixes#2209
## Proof Of Testing
Spawned in as a guest with my proper equipment and title.
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
Nothing relevant to players
3591 individual conflicts
Update build.js
Update install_node.sh
Update byond.js
oh my fucking god
hat
slow
huh
holy shit
we all fall down
2 more I missed
2900 individual conflicts
2700 Individual conflicts
replaces yarn file with tg version, bumping us down to 2200-ish
Down to 2000 individual conflicts
140 down
mmm
aaaaaaaaaaaaaaaaaaa
not yt
575
soon
900 individual conflicts
600 individual conflicts, 121 file conflicts
im not okay
160 across 19 files
29 in 4 files
0 conflicts, compiletime fix time
some minor incap stuff
missed ticks
weird dupe definition stuff
missed ticks 2
incap fixes
undefs and pie fix
Radio update and some extra minor stuff
returns a single override
no more dupe definitions, 175 compiletime errors
Unticked file fix
sound and emote stuff
honk and more radio stuff
## About The Pull Request
Turns out that if you don't test if you fix works, it probably won't!
I've actually managed to test this one, and even though it gave me a
handshake error when joining the other server, at least the fade in
worked! The fadeout is set up in the same way, so it should be fine
## Why It's Good For The Game
ACTUALLY fixes#29496
## Changelog
🆑
fix: ACTUALLY fixes server hop fade in
/🆑
## About The Pull Request
<details>
- renamed ai folder to announcer
-- announcer --
- moved vox_fem to announcer
- moved approachingTG to announcer
- separated the ambience folder into ambience and instrumental
-- ambience --
- created holy folder moved all related sounds there
- created engineering folder and moved all related sounds there
- created security folder and moved ambidet there
- created general folder and moved ambigen there
- created icemoon folder and moved all icebox-related ambience there
- created medical folder and moved all medbay-related ambi there
- created ruin folder and moves all ruins ambi there
- created beach folder and moved seag and shore there
- created lavaland folder and moved related ambi there
- created aurora_caelus folder and placed its ambi there
- created misc folder and moved the rest of the files that don't have a
specific category into it
-- instrumental --
- moved traitor folder here
- created lobby_music folder and placed our songs there (title0 not used
anywhere? - server-side modification?)
-- items --
- moved secdeath to hailer
- moved surgery to handling
-- effects --
- moved chemistry into effects
- moved hallucinations into effects
- moved health into effects
- moved magic into effects
-- vehicles --
- moved mecha into vehicles
created mobs folder
-- mobs --
- moved creatures folder into mobs
- moved voice into mobs
renamed creatures to non-humanoids
renamed voice to humanoids
-- non-humanoids--
created cyborg folder
created hiss folder
moved harmalarm.ogg to cyborg
-- humanoids --
-- misc --
moved ghostwhisper to misc
moved insane_low_laugh to misc
I give up trying to document this.
</details>
- [X] ambience
- [x] announcer
- [x] effects
- [X] instrumental
- [x] items
- [x] machines
- [x] misc
- [X] mobs
- [X] runtime
- [X] vehicles
- [ ] attributions
## Why It's Good For The Game
This folder is so disorganized that it's vomit inducing, will make it
easier to find and add new sounds, providng a minor structure to the
sound folder.
## Changelog
🆑 grungussuss
refactor: the sound folder in the source code has been reorganized,
please report any oddities with sounds playing or not playing
server: lobby music has been repathed to sound/music/lobby_music
/🆑
## About The Previous Pull Request
#85308 reverted by #85929
~~Causes the round to not start when a player isn't eligible for any
jobs at a specific priority level due to runtimes trying to `pick()`
from an empty list aborting the entire job assignment stack.~~
(Fixed???? by
https://github.com/tgstation/tgstation/pull/85947/commits/e0e9f2f430079d4ab7097abe12e75f934131a638)
Maybe we should test merge this for a mo just to make sure no more
cheeky runtimes pop up before merging.
## About The Pull Request
This PR does a couple of minor things:
Makes the job debug logging a bit easier to follow.
Minorly brings some SSjob code up to code standards, converting proc
names to snake_case and doing some otherm is cleanup.
Refactored some stuff into different procs, updated some comments.
And some major things:
Changes the job assignment logic.
Old behaviour
> Assign dynamic priority roles
> Force one Head of Staff (if possible)
> Assign all AIs
> Assign overflow roles (bugged in 2 ways)
> Shuffle the available jobs list once, at the start of the random job
assignment loop
> Pick and assign random jobs for random players from High prefs down,
with a priority on Head of Staff roles
> Handle everyone that couldn't be assigned a random job
New behaviour
> Assign dynamic priority roles
> Assign all Head of Staff roles to players with High prefs
> If no Head of Staff was made in the above way, force one Head of Staff
(if possible)
> Assign all AIs
> Assign overflow roles (fixed)
> Prioritise and fill unfilled head roles at each job priority pref
level, from High prefs down.
> Build a list of all jobs that each unassigned player could be eligible
for at the above pref level.
> Pick a job from that list at random and assign it to the player.
> Handle everyone that couldn't be assigned a random job.
In reality there should be little impact on overall job assignment, the
code changes read more as semantics. For example, the priority check for
filling Head slots will have the same candidate pool in both old and new
versions, but in the new version we're more clearly saying that Heads
are important and we want to prioritise filling them for the sake of
round progression even though the outcome in new and old is the same.
A key change will lead to an increase in assistants - Overflow fixes.
Currently the code block to do early assignments to the Overflow role
doesn't work - or works but not as you'd expect. The idea was is that
because enabling the Overflow role in the prefs menu is an On/Off toggle
that sets the job to High priority when enabled and prevents any other
High priority pref, players that have the Overflow role enabled will
**always** get it. It's their highest priority job with infinite slots.
So we do a pass right at the start to give everyone with the Overflow
role enabled that role and save us wasting time later on in random job
code giving them that same role but with more work.
The problem is the code for this only assigns the Overflow role to
people with it set to Low priority in their prefs, resulting in log
readouts like:
```
[2024-07-27 09:49:43.469] DEBUG-JOB: DO, Running Overflow Check 1
[2024-07-27 09:49:43.469] DEBUG-JOB: Running FOC, Job: /datum/job/assistant, Level: Low Priority
[2024-07-27 09:49:43.472] DEBUG-JOB: FOC player job enabled at wrong level, Player: Radioprague, TheirLevel: Medium Priority, ReqLevel: Low Priority
[2024-07-27 09:49:43.472] DEBUG-JOB: FOC player job enabled at wrong level, Player: Caluan, TheirLevel: High Priority, ReqLevel: Low Priority
[2024-07-27 09:49:43.473] DEBUG-JOB: FOC player job enabled at wrong level, Player: Caractaser, TheirLevel: High Priority, ReqLevel: Low Priority
[2024-07-27 09:49:43.473] DEBUG-JOB: FOC player job enabled at wrong level, Player: Apsua, TheirLevel: High Priority, ReqLevel: Low Priority
[2024-07-27 09:49:43.475] DEBUG-JOB: FOC player job enabled at wrong level, Player: Bebrus2, TheirLevel: Medium Priority, ReqLevel: Low Priority
[2024-07-27 09:49:43.475] DEBUG-JOB: AC1, Candidates: 0
```
Where nobody gets pre-assigned the overflow role because their prefs are
all set to the High priority from being toggled... Except wait a second,
some people have it at Medium priority when it should just be a No
Role/High Priority Role toggle?
And herein we meet a problem. My hypothesis is that traits and stuff
that change the overflow have allowed players to set the "ordinary"
overflow role of Assistant to Medium and/or Low priority.
This still shows as enabled in the prefs menu, but leads to an outcome
where a player with assistant enabled is assigned Cook instead.
```
[2024-07-27 09:49:47.775] DEBUG-JOB: DO, Running Overflow Check 1
[2024-07-27 09:49:47.775] DEBUG-JOB: Running FOC, Job: /datum/job/assistant, Level: Low Priority
...
[2024-07-27 09:49:43.475] DEBUG-JOB: FOC player job enabled at wrong level, Player: Bebrus2, TheirLevel: Medium Priority, ReqLevel: Low Priority
...
[2024-07-27 09:49:47.987] DEBUG-JOB: Running AR, Player: Bebrus2, Job: /datum/job/cook, LateJoin: 0
```
So players with the Overflow job pref set to Low (an unexpected state,
should be disabled or High) would be guaranteed to get that role if none
of the higher priority Head of Staff/AI/Dynamic roles took over via the
bugged "force overflow for people with the pref enabled" proc.
Players with the Overflow job pref set to High would be guaranteed to
get that role if none of the higher priority Head of Staff/AI/Dynamic
roles took over via the random job assignment code giving them their
Highest priority role thanks to the infinite job slots of the Overflow.
And players with the Overflow job pref set to Medium (an unexpected
state, should be disabled or High) would get Assistant if the shuffle
step of the available jobs list put Assisstant before any of the other
jobs they had prefs enabled for at Medium that weren't already filled,
otherwise they'd get another random job.
This code is now changed to ignore the priority the player has set when
looking for people to fill the overflow role. As long as it **is**
enabled, the player will get it unless they're forced into a dynamic
ruleset role (AI when malf rolls) or a Head of Staff role due to their
other prefs (they have RD set to med or low, and no other player has a
Head of Staff at high so they get randomly picked and miss the overflow
role).
This will increase the number of assistants in shifts where their pref
state has Assisstant in the bugged Medium priority, but doesn't change
it for bugged Low and not-bugged High/On priority.
On the other side of the coin, we have how the random jobs are picked.
They're kinda not random, and I noticed this reading the logs then
reading the code.
The list of available jobs to pick from is randomly shuffled - but only
**once**. All players pull from a list of jobs in the same order. So you
end up with a log block like this:
```
[2024-07-27 09:49:47.985] DEBUG-JOB: DO pass, Player: Pierow, Level:3, Job:Botanist
[2024-07-27 09:49:47.985] DEBUG-JOB: Running AR, Player: Pierow, Job: /datum/job/botanist, LateJoin: 0
[2024-07-27 09:49:47.985] DEBUG-JOB: Player: Pierow is now Rank: Botanist, JCP:0, JPL:2
[2024-07-27 09:49:47.986] DEBUG-JOB: DO pass, Player: Daddos, Level:3, Job:Botanist
[2024-07-27 09:49:47.986] DEBUG-JOB: Running AR, Player: Daddos, Job: /datum/job/botanist, LateJoin: 0
[2024-07-27 09:49:47.986] DEBUG-JOB: Player: Daddos is now Rank: Botanist, JCP:1, JPL:2
[2024-07-27 09:49:47.986] DEBUG-JOB: FOC job filled and not overflow, Player: Bebrus2, Job: /datum/job/botanist, Current: 2, Limit: 2
[2024-07-27 09:49:47.987] DEBUG-JOB: FOC player job not enabled, Player: Bebrus2
[2024-07-27 09:49:47.987] DEBUG-JOB: DO pass, Player: Bebrus2, Level:3, Job:Cook
[2024-07-27 09:49:47.987] DEBUG-JOB: Running AR, Player: Bebrus2, Job: /datum/job/cook, LateJoin: 0
[2024-07-27 09:49:47.988] DEBUG-JOB: Player: Bebrus2 is now Rank: Cook, JCP:0, JPL:1
[2024-07-27 09:49:47.988] DEBUG-JOB: FOC player job not enabled, Player: Redwizz
[2024-07-27 09:49:47.988] DEBUG-JOB: FOC job filled and not overflow, Player: Redwizz, Job: /datum/job/cook, Current: 1, Limit: 1
```
The list is shuffled into an order of something like `list("Scientist",
"Botanist", "Cook", "Sec Officer", ...)` then iterated over for each
player. So every random job selection goes:
> "Does Player1 have Scientist enabled and at the right priority? No?
Okay, Botanist? Yes? You get botanist."
> "Does Player2 have Scientist enabled and at the right priority? No?
Okay, Botanist? Yes? You get botanist."
> "Does Player3 have Scientist enabled and at the right priority? No?
Okay, Botanist has no slots left so we'll remove it from the list. Okay,
Cook? Yes? You get cook."
> "Does Player4 have Scientist enabled and at the right priority? No?
Okay, Cook has no slots left so we'll remove it from the list. Okay, Sec
Officer? ..."
This can lead to stacked individual departments if it gets randomly
rolled to the start of the list in the shuffle, and completely empty
departments if they end up at the end.
On high pop shifts this is probably less of an issue. Player prefs add
noise to this and as departments at the front fill up, those at the back
pick up some of the lower pref players.
But have you ever had a shift where there's just like... No fucking sec
even though there's tons of players? The logging (before I made changes
in this PR) was a bit ass, but my hypothesis there is that sec officer
was shuffled right at the end of the random job list, so every other
department was filled up before sec officers were picked.
To mitigate this, I made the list shuffle every single time the game
picks a random available job for the player. This should lead to a more
balanced selection of available jobs by avoiding situations where the
code is biased towards packing some departments by accident.
## Why It's Good For The Game
Overflow fixes mean people who go to their prefs and see the Overflow
Role is On will all have the same experience - They will be the Overflow
role.
More random random job selection should prevent individual departments
having a jobs be stacked when it would have otherwise been possible for
a more balanced selection but the code unintentially biased random
departments to be overstaffed and understaffed each shift.
## Changelog
🆑
fix: Having the Overflow Role set to On will properly ensure you get
that role at a High priority as intended by the game code.
fix: Job selection is now a little bit more random. Fixes an
unintentional bias in random job assignment that could lead to
feast-or-famine for roles where everyone is assigned one job and nobody
is assigned another job.
/🆑
shayoki
