## About The Pull Request
Extends the part of the crafting unit test that ensures consistency
between the total mats of the components of a recipe (or rather, the
result of said recipe) and a generic instance of the same type as its
result, previously only implemented on food recipes.
## Why It's Good For The Game
This ensures a degree of consistency with the material composition of
various objects in the game. I couldn't do it in the original PR as that
one was too big already and it took months to get it merged, and have
the relative bugs fixed.
Currently a WIP as I slowly deal with the unit test reports.
## Changelog
🆑
refactor: Follow-up to the crafting/material refactor from months ago.
All objects crafted with stacks now inherit their mat composition (not
necessarily the effects and color) by default, while previously only a
few things like chair, sinks and toilets did. Report any object looking
or behaving weirdly as a result.
fix: The material composition of ammo boxes is no longer a 1/10 of what
it's supposed to be. It was a shitty hack to make it harder to recycle
empty ammo boxes. Instead, they lose materials as they're emptied now.
/🆑
## About The Pull Request
This 1st has to be PR'd so the integration tests can point out all
wallmounts that could not find a support structure to mount on. I then
will do many map edits to align them onto the closest atom
Yes we no longer use wall mount but atom mounted component. All objects
that are mounted on windows/tables & fences now also fall off when
destroyed
It'll probably be a WHILE before I can fix all wall mounts. Long day.
Expect me to misalign many stuff to fix failing CI so make sure to
provide suggestions when possible
Improved wallmount code overall
- Fixes#93793
## Changelog
🆑
fix: fixes all incorrectly maploded wall mounts that aren't actually
hanging on any support structure
fix: objects mounted on tables, windows & fences also fall off now when
destoryed
qol: lights can be mounted on windows
qol: cameras can be mounted on windows
qol: buttons can be mounted on tables
refactor: improved how wall mounts interact with objects as a whole
report bugs on github
/🆑
## About The Pull Request
changes tiled_dirt to just tiled_turf and expands its use slightly to be
the "i have a 2x2 tile sprite"
<img width="864" height="691" alt="image"
src="https://github.com/user-attachments/assets/78a7ba96-fffe-42e1-9eef-35b96b22481b"
/>
https://github.com/user-attachments/assets/7a273302-a331-48b2-a06f-d65bddf13bfd
## Why It's Good For The Game
its silly for things that arent visually tiled to use the tiled water
sprite
## Changelog
🆑
fix: stuff like carpet and wood tiles dont use the 2x2 tiled sprite
fix: similarly, floors that dont use the tiled sprite now can have
permafrost sprites (as they are not tiled)
/🆑
## About The Pull Request
When a camera update is triggered, it is instead added to a queue on a
background subsystem
An AI entering a camera chunk which is queued to update will force the
update immediately (bypassing the queue)
While the root problem of this is, ultimately, not addressed...
<img width="554" height="58"
alt="467828777-eff3f0e5-49d6-4997-b4d7-05eff6432155"
src="https://github.com/user-attachments/assets/c2d6a5f5-d958-463e-959f-116bd0dab475"
/>
...the change will ultimately prevent update spam from consuming all of
the server's resources - instead allocating updates to the backburner in
times of high server stress (or on multi-z maps)
## Changelog
🆑 Melbert
refactor: Refactored the way camera updates are handled to hopefully
reduce some lag. Report any oddities
/🆑
## About The Pull Request
There was a few things going on here
- The prox monitor for elevators didn't need to be the advanced subtype,
and that was actually breaking it because for some reason with a range
of 1 `field_turfs` only includes the center turf and there are no
`edge_turfs`, meaning the check to not overlap music if you're already
in range wouldn't work and music would start every step except the
middle
- The looping_sound subtype for elevator music had `sound_channel`
already set but the `New` code for looping_sound also has a
sound_channel arg and didn't check if one has actually been passed
before setting it, so sound_channel was being overwritten with null and
thus the music would not stop when you exited the elevator zone
## Why It's Good For The Game
Fixes#92623Fixes#88261https://github.com/user-attachments/assets/e5a2f736-bf68-430a-a3bc-070482e9b68e
## Changelog
🆑
fix: fixed elevator music starting every time you took a step
fix: fixed elevator music not stopping when you left the elevator
/🆑
## About The Pull Request
- Fixes#93603. posters now apply the wall mount component
- Fixes tram wall frame doing a lot of extra checks & not applying the
wall mount component
## Changelog
🆑
fix: posters applied on walls fall off when the wall is destroyed
fix: player mounted tram wall frame controller falls off when the wall
is destroyed
/🆑
## About The Pull Request
- Fixes#93392
- Replaces all custom callbacks with call to `deconstruct()`. The
callbacks weren't necessary as it did the same thing as `deconstruct()`
but in an round about way
- Removed duplicate `Initialize()` procs and the params `building` &
`ndir` from all wall mounts. Makes everything cleaner
## Changelog
🆑
fix: wall mounts placed by player now falls off when the wall they are
mounted on is destroyed
code: cleaned up wall mount code
/🆑
## About The Pull Request
Using a multitool on a pod door assembly controller now displays a list
of doors to choose from instead of typing an ID from `0->100`. You can
only control doors that you have either crafted/linked with an assembly
controller It can also auto generate a unique ID for you to assemble new
doors
https://github.com/user-attachments/assets/0918f1e3-1f22-4cde-b20e-0eb8bb6ba953
## Why It's Good For The Game
Having to no longer remember the ID of doors you created cause the game
now displays that list for you is very convenient. Also generating new
unique IDs without player intervention (which results in errors if you
can't remember the door IDs you typed before) is faster as well.
Not to mention currently if you have created 100 doors you run out of
unique ID's. Now that's no longer the case
## Changelog
🆑
qol: Multitooling a pod door controller now picks from a list of doors
available for that player(crafted, set via controller) only and can auto
generate new IDs for you
/🆑
## About The Pull Request
This fixes several bitfield operations that were missing parenthesis
encapsulation. I noticed this problem in:
- #92601
And decided to use regex to search for similar patterns which I came
across in:
- Move loops bypassing the `MOVELOOP_STATUS_RUNNING` status
- Elastic arms mutation bypassing `ABSTRACT` object flags for picking up
objects
- Species radiation bypassing `HEAD_HAIR` hairstyle flags for balding
- Damaged APC board status bypassing `EMAGGED` and `BROKEN` status for
screentips
- Shuttle cleanup code bypassing `MOVE_CONTENTS` for moving old turfs
- Tram crossing signals bypassing `NORTH` and `EAST` direction checks
## Why It's Good For The Game
Code behaves as intended.
## About The Pull Request
+5 damage to airlock crushing
Now uses apply damage (which means it can wound and is affected by
physiology)
Has a wound bonus so it has the potential to cause wounds. In testing it
seems super uncommon unless you're frail though.
## Why It's Good For The Game
15 damage for being smashed in a door? Insane
## Changelog
🆑 Melbert
balance: Airlock crushing now does 20 damage, up from 15. Also may
uncommonly cause wounds. Also is properly affected by damage reduction
or modifiers.
/🆑
(cherry picked from commit f84df6300b)
# Conflicts:
# code/game/machinery/doors/door.dm
## About The Pull Request
+5 damage to airlock crushing
Now uses apply damage (which means it can wound and is affected by
physiology)
Has a wound bonus so it has the potential to cause wounds. In testing it
seems super uncommon unless you're frail though.
## Why It's Good For The Game
15 damage for being smashed in a door? Insane
## Changelog
🆑 Melbert
balance: Airlock crushing now does 20 damage, up from 15. Also may
uncommonly cause wounds. Also is properly affected by damage reduction
or modifiers.
/🆑
## About The Pull Request
**1. Makes the machine creation process from both efficient.**
The machine frame no longer creates & deletes the machines old component
parts before moving in the new parts. It instead now passes its parts
directly to the circuit boards `apply_default_parts()` meaning the old
parts are never created and the new ones get applied directly. This also
mean it does not have to again call `RefreshParts()` as the machines
`Initialize()` proc will do that for us by default so the performance is
just faster now.
Flatpack box also benefits from this and it will need it as stated below
- Fixes#86514. As the circuit board is passed to the machine's
`Initialize()` proc during reconstruction so it sets it's
`all_products_free` from the board both during mapload & when player
constructed from either machine frame & flatpack
**2. Flatpack enhancements**
- The flatpack box now passes its stored circuit board into the machine
meaning any changes made like with a screw driver or such are preserved
in the newly created machine rather than the board getting deleted & the
machine creating the default board
- Flatpacker now accept custom component parts that replaces its stored
circuit board default parts. This implements
https://github.com/tgstation/tgstation/pull/91670#issuecomment-2977259973
meaning instead of the vendor created from the flatpacker starting out
empty it now accepts the refill canister and will package both of them
together. Then during deployment that stored canister is stored back in
the vendor meaning instead of starting out empty you get to carry over
all your previous stock
Depends on https://github.com/tgstation/tgstation/pull/91512 because of
named arg conflict. Keep this drafted till that gets merged
## Changelog
🆑
qol: flatpacker now accepts custom component parts(like vendor refill
canister) along with the circuit board so you can carry over your
previous stock during deployment rather than starting out empty
fix: flatpack boxes now passes its stored circuit board into the machine
thus preserving its properties instead of creating a default board in
the machine
fix: vending machines reconstructed on station from circuits loaded off
station(having free products) will continue to sell free products
code: machine construction via flatpacker/machine frame is faster
performance wise
/🆑
## About The Pull Request
**1. Makes the machine creation process from both efficient.**
The machine frame no longer creates & deletes the machines old component
parts before moving in the new parts. It instead now passes its parts
directly to the circuit boards `apply_default_parts()` meaning the old
parts are never created and the new ones get applied directly. This also
mean it does not have to again call `RefreshParts()` as the machines
`Initialize()` proc will do that for us by default so the performance is
just faster now.
Flatpack box also benefits from this and it will need it as stated below
- Fixes#86514. As the circuit board is passed to the machine's
`Initialize()` proc during reconstruction so it sets it's
`all_products_free` from the board both during mapload & when player
constructed from either machine frame & flatpack
**2. Flatpack enhancements**
- The flatpack box now passes its stored circuit board into the machine
meaning any changes made like with a screw driver or such are preserved
in the newly created machine rather than the board getting deleted & the
machine creating the default board
- Flatpacker now accept custom component parts that replaces its stored
circuit board default parts. This implements
https://github.com/tgstation/tgstation/pull/91670#issuecomment-2977259973
meaning instead of the vendor created from the flatpacker starting out
empty it now accepts the refill canister and will package both of them
together. Then during deployment that stored canister is stored back in
the vendor meaning instead of starting out empty you get to carry over
all your previous stock
Depends on https://github.com/tgstation/tgstation/pull/91512 because of
named arg conflict. Keep this drafted till that gets merged
## Changelog
🆑
qol: flatpacker now accepts custom component parts(like vendor refill
canister) along with the circuit board so you can carry over your
previous stock during deployment rather than starting out empty
fix: flatpack boxes now passes its stored circuit board into the machine
thus preserving its properties instead of creating a default board in
the machine
fix: vending machines reconstructed on station from circuits loaded off
station(having free products) will continue to sell free products
code: machine construction via flatpacker/machine frame is faster
performance wise
/🆑
## About The Pull Request
they are not attackable or clickable
fixes https://github.com/tgstation/tgstation/issues/90155
## Why It's Good For The Game
less likely to break things
## Changelog
🆑
fix: portable grav gen effects can't be moved by tram
code: portable grav gen effects are actually a subtype of effect now
/🆑
## About The Pull Request
they are not attackable or clickable
fixes https://github.com/tgstation/tgstation/issues/90155
## Why It's Good For The Game
less likely to break things
## Changelog
🆑
fix: portable grav gen effects can't be moved by tram
code: portable grav gen effects are actually a subtype of effect now
/🆑
## About The Pull Request
- Fixes airlock's run_animation from having a duplicate open in the
switch case instead of an open/closed.
- Completes the implementation of [Variable Door
Delay](https://github.com/tgstation/tgstation/pull/84631) on airlocks.
(The procs were made but never called in the airlock code.
- Implements a set_airlock_state that sets the airlock state as well as
managing operating status and animations instead of calling it
individually.
## Why It's Good For The Game
Fixes, less code duplication, airlocks use the new animation procs.
## Changelog
🆑 LT3
fix: Fixed incorrect opening case in variable door delay
code: Airlocks can have variable animation delay same as doors
/🆑
(cherry picked from commit c4877abb6f)
## About The Pull Request
- Fixes airlock's run_animation from having a duplicate open in the
switch case instead of an open/closed.
- Completes the implementation of [Variable Door
Delay](https://github.com/tgstation/tgstation/pull/84631) on airlocks.
(The procs were made but never called in the airlock code.
- Implements a set_airlock_state that sets the airlock state as well as
managing operating status and animations instead of calling it
individually.
## Why It's Good For The Game
Fixes, less code duplication, airlocks use the new animation procs.
## Changelog
🆑 LT3
fix: Fixed incorrect opening case in variable door delay
code: Airlocks can have variable animation delay same as doors
/🆑
## About The Pull Request
Flatpacks pass an arg into ``on_construction`` which makes vendors wipe
their inventory to prevent duping by repeatedly flatpacking a vendor to
refill its inventory.
Closes#91615
## Changelog
🆑
fix: Flatpacked vendors start empty to prevent duping
/🆑
## About The Pull Request
Alleviates #91603
As in it does not fix it because i have not been able to reproduce it.
It now checks for invalid values and defaults to `amount`(which is 1)
during `Initialize()` and not null so we don't have to pass the number
`1` when creating a single sheet.
A stack trace is thrown for <= 0 sheet amounts so we can debug & fix
stuff
## Changelog
🆑
code: stacks error on invalid amounts, removed manual passing of number
`1` when creating a single stack in many cases
/🆑
## About The Pull Request
Flatpacks pass an arg into ``on_construction`` which makes vendors wipe
their inventory to prevent duping by repeatedly flatpacking a vendor to
refill its inventory.
Closes#91615
## Changelog
🆑
fix: Flatpacked vendors start empty to prevent duping
/🆑
## About The Pull Request
Alleviates #91603
As in it does not fix it because i have not been able to reproduce it.
It now checks for invalid values and defaults to `amount`(which is 1)
during `Initialize()` and not null so we don't have to pass the number
`1` when creating a single sheet.
A stack trace is thrown for <= 0 sheet amounts so we can debug & fix
stuff
## Changelog
🆑
code: stacks error on invalid amounts, removed manual passing of number
`1` when creating a single stack in many cases
/🆑
Revival of https://github.com/tgstation/tgstation/pull/86482, which is
even more doable now that we have rustg iconforge generation.
What this PR does:
- Sets up every single GAGS icon in the game to have their own preview
icon autogenerated during compile. This is configurable to not run
during live. The icons are created in `icons/map_icons/..`
- This also has the side effect of providing accurate GAGS icons for
things like the loadout menu. No more having to create your own
previews.
<details><summary>Mappers rejoice!</summary>
</details>
<details><summary>Uses iconforge so it does not take up much time during
init</summary>
</details>
---
this still applies:
Note for Spriters:
After you've assigned the correct values to vars, you must run the game
through init on your local machine and commit the changes to the map
icon dmi files. Unit tests should catch all cases of forgetting to
assign the correct vars, or not running through init.
Note for Server Operators:
In order to not generate these icons on live I've added a new config
entry which should be disabled on live called GENERATE_ASSETS_IN_INIT in
the config.txt
No more error icons in SDMM and loadout.
🆑
refactor: preview icons for greyscale items are now automatically
generated, meaning you can see GAGS as they actually appear ingame while
mapping or viewing the loadout menu.
/🆑
---------
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
## About The Pull Request
Revival of https://github.com/tgstation/tgstation/pull/86482, which is
even more doable now that we have rustg iconforge generation.
What this PR does:
- Sets up every single GAGS icon in the game to have their own preview
icon autogenerated during compile. This is configurable to not run
during live. The icons are created in `icons/map_icons/..`
- This also has the side effect of providing accurate GAGS icons for
things like the loadout menu. No more having to create your own
previews.
<details><summary>Mappers rejoice!</summary>
</details>
<details><summary>Uses iconforge so it does not take up much time during
init</summary>
</details>
---
### Copied from https://github.com/tgstation/tgstation/pull/86482 as
this still applies:
Note for Spriters:
After you've assigned the correct values to vars, you must run the game
through init on your local machine and commit the changes to the map
icon dmi files. Unit tests should catch all cases of forgetting to
assign the correct vars, or not running through init.
Note for Server Operators:
In order to not generate these icons on live I've added a new config
entry which should be disabled on live called GENERATE_ASSETS_IN_INIT in
the config.txt
## Why It's Good For The Game
No more error icons in SDMM and loadout.
## Changelog
🆑
refactor: preview icons for greyscale items are now automatically
generated, meaning you can see GAGS as they actually appear ingame while
mapping or viewing the loadout menu.
/🆑
---------
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Melee attack chain now has a list passed along with it,
`attack_modifiers`, which you can stick force modifiers to change the
resulting attack
This is basically a soft implementation of damage packets until a more
definitive pr, but one that only applies to item attack chain, and not
unarmed attacks.
This change was done to facilitate a baton refactor - batons no longer
hack together their own attack chain, and are now integrated straight
into the real attack chain. This refactor itself was done because batons
don't send any attack signals, which has been annoying in the past (for
swing combat).
🆑 Melbert
refactor: Batons have been refactored again. Baton stuns now properly
count as an attack, when before it was a nothing. Report any oddities,
particularly in regards to harmbatonning vs normal batonning.
refactor: The method of adjusting item damage mid-attack has been
refactored - some affected items include the Nullblade and knives.
Report any strange happenings with damage numbers.
refactor: A few objects have been moved to the new interaction chain -
records consoles, mawed crucible, alien weeds and space vines, hedges,
restaurant portals, and some mobs - to name a few.
fix: Spears only deal bonus damage against secure lockers, not all
closet types (including crates)
/🆑
## About The Pull Request
Melee attack chain now has a list passed along with it,
`attack_modifiers`, which you can stick force modifiers to change the
resulting attack
This is basically a soft implementation of damage packets until a more
definitive pr, but one that only applies to item attack chain, and not
unarmed attacks.
This change was done to facilitate a baton refactor - batons no longer
hack together their own attack chain, and are now integrated straight
into the real attack chain. This refactor itself was done because batons
don't send any attack signals, which has been annoying in the past (for
swing combat).
## Changelog
🆑 Melbert
refactor: Batons have been refactored again. Baton stuns now properly
count as an attack, when before it was a nothing. Report any oddities,
particularly in regards to harmbatonning vs normal batonning.
refactor: The method of adjusting item damage mid-attack has been
refactored - some affected items include the Nullblade and knives.
Report any strange happenings with damage numbers.
refactor: A few objects have been moved to the new interaction chain -
records consoles, mawed crucible, alien weeds and space vines, hedges,
restaurant portals, and some mobs - to name a few.
fix: Spears only deal bonus damage against secure lockers, not all
closet types (including crates)
/🆑
People can now pet held mothroaches and pugs if they want to, or use
items on them, hopefully without causing many issues. After all, it only
took about a couple dozen lines of code to make...
...Oh, did the 527 files changed or the 850~ lines added/removed perhaps
catch your eye? Made you wonder if I accidentally pushed the wrong
branch? or skewed something up big time? Well, nuh uh. I just happen to
be fed up with the melee attack chain still using stringized params
instead of an array/list. It was frankly revolting to see how I'd have
had to otherwise call `list2params` for what I'm trying to accomplish
here, and make this PR another tessera to the immense stupidity of our
attack chain procs calling `params2list` over and over and over instead
of just using that one call instance from `ClickOn` as an argument. It's
2025, honey, wake up!
I also tried to replace some of those single letter vars/args but there
are just way too many of them.
Improving old code. And I want to be able to pet mobroaches while
holding them too.
🆑
qol: You can now interact with held mobs in more ways beside wearing
them.
/🆑
## About The Pull Request
This won't actually do anything on live, since those are all set to
UTC±0 currently
Pins logging and IC uses of time2text to UTC±0 instead of using the
system timezone (byond default)
Timezones not being set to utc0 caused issues before (and is again)
All timezones are now passed explicitly to make it more likely it's
cargo culted properly at least
Deletes worldtime2text cus it was gameTimestamp default args
## Why It's Good For The Game
Server timezone changes probably shouldn't affect logging, round times,
file hashes, IC time, when you caught fish, etc
## Changelog
🆑
refactor: Logging and IC timestamps will now always use UTC±0 and not be
affected by server system timezone changes
fix: Station and round times will not longer be incorrect if the system
timezone is not UTC±0
/🆑
---------
Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
## About The Pull Request
People can now pet held mothroaches and pugs if they want to, or use
items on them, hopefully without causing many issues. After all, it only
took about a couple dozen lines of code to make...
...Oh, did the 527 files changed or the 850~ lines added/removed perhaps
catch your eye? Made you wonder if I accidentally pushed the wrong
branch? or skewed something up big time? Well, nuh uh. I just happen to
be fed up with the melee attack chain still using stringized params
instead of an array/list. It was frankly revolting to see how I'd have
had to otherwise call `list2params` for what I'm trying to accomplish
here, and make this PR another tessera to the immense stupidity of our
attack chain procs calling `params2list` over and over and over instead
of just using that one call instance from `ClickOn` as an argument. It's
2025, honey, wake up!
I also tried to replace some of those single letter vars/args but there
are just way too many of them.
## Why It's Good For The Game
Improving old code. And I want to be able to pet mobroaches while
holding them too.
## Changelog
🆑
qol: You can now interact with held mobs in more ways beside wearing
them.
/🆑
commit cb550ab79badae3ffd493dcee24d96f7ad146ed6
Merge: 732416f01d8 2fac5d45a6
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Mon Apr 14 14:40:04 2025 -0400
Merge branch 'master' into upstream-25-04a
commit 2fac5d45a6
Author: Arturlang <24881678+Arturlang@users.noreply.github.com>
Date: Mon Apr 14 01:11:47 2025 +0100
bring back heretic mute ghoul maxhp to 135 HP (#3464)
## About The Pull Request
bring back heretic mute ghoul maxhp to 135 HP, these are the changes
made in
https://github.com/Bubberstation/Bubberstation/pull/2972
## Why It's Good For The Game
otherwise flesh heretic is really sad
## Proof Of Testing
numbers change, no need
## Changelog
no cl
---------
Co-authored-by: Roxy <75404941+TealSeer@users.noreply.github.com>
commit e9c4522c27
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 14 01:59:19 2025 +0200
Automatic changelog for PR #3453 [ci skip]
commit 2d595eba4f
Author: shellspeed1 <46614774+shellspeed1@users.noreply.github.com>
Date: Sun Apr 13 16:58:54 2025 -0700
Fixes bitrunning sim having cybersun comms and also makes sure persistence borgs have correct key (#3453)
## About The Pull Request
What it says on the tin
## Why It's Good For The Game
Its best to not let bitrunners ghost spawns talk on comms
## Proof Of Testing
I just did my last cpa today, I'll test this later. Besides its 3 lines
with just an item swaped.
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: Bitrunning sims no longer have comms access
fix: Borgs given the persistence access upgrade no longer default to
interdyne and get cybersun comms instead
/🆑
Co-authored-by: Roxy <75404941+TealSeer@users.noreply.github.com>
commit 394e8d64d4
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 23:24:50 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 49141446bf
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 14 00:18:15 2025 +0200
Automatic changelog for PR #3497 [ci skip]
commit 0332c060a8
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 13 18:17:52 2025 -0400
Xenoarch Machine QOL (#3497)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
A little treat for xenoarch
- The xenoarch bag can now hold broken items and useless relics in
addition to strange rocks
- You can use the bag on both the researcher and the recoverer to dump
the contents in
- The digger and the researcher make a sound now
## Why It's Good For The Game
A bag that holds only one type of item is annoying, you get a lot of the
other two items too
## Proof Of Testing
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
qol: the xenoarch bag can now hold broken items and useless relics
qol: you can use the bag on the researcher and the recoverer to dump
items in
sound: the digger and researcher now make a sound when they complete a
cycle
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
commit 2b8c074406
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 19:47:30 2025 +0200
Automatic changelog for PR #3498 [ci skip]
commit e613940ada
Author: nevimer <77420409+nevimer@users.noreply.github.com>
Date: Sun Apr 13 13:47:04 2025 -0400
restores RCD vending, moves RCD's to lockers (#3498)
## About The Pull Request
moves RCD's from engineers backpacks to their lockers roundstart - to
accommodate the stowaway change aswell as keep a tab on infinite station
resources.
## Why It's Good For The Game
Above point
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
balance: reenabled the RCD vendors and moved RCD's from spawning in
backpacks to lockers.
/🆑
commit 732416f01d8ccc6e082cbdbeb60b30c461d8e965
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 13 03:03:20 2025 -0400
these use GMM prices and thus fluctuate
commit 99f097d67faf17569711d670d5891103d96932b1
Merge: 790b64602cd 945479a622
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 13 02:12:01 2025 -0400
Merge branch 'master' into upstream-25-04a
commit 945479a622
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 13 00:59:23 2025 -0400
Fix hot spring runtime related to duplicate elements (#90555)
If something is mapped to spawn in on a hot spring tile, the tile will
add the immerse element in `/turf/open/water/Entered` before
`Initialize` runs, and when it does there's no check if the element has
already been added, unlike other spots where the immerse element is
added. This fixes that by adding a check on the call in `Initialize`.
commit 3472fddc11
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Sun Apr 13 04:16:19 2025 +0000
Automatic TGS DMAPI Update (#2743)
This pull request updates the TGS DMAPI to the latest version. Please
note any changes that may be breaking or unimplemented in your codebase
by checking what changes are in the definitions file:
code/__DEFINES/tgs.dm before merging.
Full changelog can be found
[here](https://raw.githubusercontent.com/tgstation/tgstation-server/gh-pages/changelog.yml).
- Added compatibility with SpacemanDMM's `redefined_proc` lint. (#2058
Cyberboss)
#tgs-dmapi-release
Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com>
commit e5630753ae
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:53:13 2025 +0200
Automatic changelog for PR #3481 [ci skip]
commit ac3fea9660
Author: chestlet <98193039+chestlet@users.noreply.github.com>
Date: Sat Apr 12 20:52:34 2025 -0700
Nova Port: RB-MK2 GUI Rework (#5136) (#3481)
## About The Pull Request
A significant [rework of the RB-MK2
GUI](https://github.com/NovaSector/NovaSector/pull/5136) that I did over
on Nova. The one you guys have now is painful to use in comparison so
let's get it up to snuff.
## Why It's Good For The Game
More information makes the RB-MK2 easier to use and teach in character.
With how the GUI is currently, it gives no intuitive explanation for
what it's doing. You can't tell what's going on with it.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
https://github.com/user-attachments/assets/7a178ac2-df8e-40d3-a6f3-b6aa617b69fd
</details>
## Changelog
🆑 Chestlet
admin: Improved RB-MK2 logging so admins have a full trace of exactly
what happened with it.
fix: Corrected 'tritium usage' math in the RB-MK2.
code: We've noticed that the Radioscopical Bluespace Reactor Mark Two
blueprints provided to our stations came with antiquated firmware. This
issue has been rectified. (Significant rework of the RB-MK2 GUI)
/🆑
commit 071fcd84a8
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:48:58 2025 +0200
Automatic changelog for PR #3495 [ci skip]
commit 0a5f60a36c
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 23:48:24 2025 -0400
Xenoarch machines cleanup (#3495)
## About The Pull Request
Clean up the code for xenoarch machines some because it made me sad.
- Changes `attackby`'s to `item_interaction`
- Keep a list of xenoarch items in contents instead of storing them in
**an instance of `/obj/item` (yes the abstract concept of an item)**
- Add context tips for all item interactions and removes that info from
examine text
- Switched a list to `static`
- Add assoc list of `broken_item` types to reward pools instead of
having a nightmare ladder of `istype` checks
## Why It's Good For The Game
Fixes#3442
## Proof Of Testing
Scout's honor
## Changelog
🆑
qol: xenoarch machines have context tooltips now
fix: fixed xenoarch diggers not working
/🆑
commit 16f02c756b
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:34:54 2025 +0200
Automatic changelog for PR #3441 [ci skip]
commit ede9fc1646
Author: Bombermansam <Bombermansam@yahoo.com>
Date: Sat Apr 12 23:34:09 2025 -0400
[Modular] Adds crowbars to standard borg models that do not have them (#3441)
## About The Pull Request
Adds crowbars to standard borg models that do not have them.
## Why It's Good For The Game
This is a QOL addition, it should not affect balance.
Half the borg models in the game do not have crowbars and can get stuck
behind doors if the power fails which is no fun for anyone. This fixes
it.
## Proof Of Testing
It compiles and was tested locally.
<details>
<summary> Screenshots </summary>
</details>
## Changelog
🆑
add: Adds Crowbars to Service, Medical, Clown, Sec and Peacekeeper borgs
/🆑
commit 8e4d6f7052
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:32:18 2025 +0200
Automatic changelog for PR #3491 [ci skip]
commit 0cdf875cec
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 03:32:09 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c6f88a026e
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 23:31:16 2025 -0400
Fix HEV armor not fully initializing (#3491)
## About The Pull Request
`ADD_TRAIT`/`REMOVE_TRAIT` don't take lists you need to use a proc for
that
## Why It's Good For The Game
Fixes#3484
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: fixed HEV suit not turning on properly
/🆑
commit f93466e6ab
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:18:39 2025 +0200
Automatic changelog for PR #3486 [ci skip]
commit 952a110077
Author: ariaworld <143797359+ariaworld@users.noreply.github.com>
Date: Sun Apr 13 05:18:04 2025 +0200
[FIX?] - Brings robotic brain surgery in line with organic brain sugery/lobotomy after the recent update (#3486)
## About The Pull Request
As title!
## Why It's Good For The Game
I originally opened this as an issue because I wasn't sure if this was
intended, it's why I labeled it as [FIX?]
Currently organic brain surgery heals the previous tiers of traumas as
well which makes sure there's no leftover traumas left and also removes
the RNG re-roll, applying a status effect instead. This PR brings the
robotic surgery/lobotomy in line with the organic one in a few ways:
1. Robotic blessed lobotomy now requires holy water as well (just like
organic)
2. Fix posibrain surgery now cures TRAUMA_RESILIENCE_SURGERY traumas as
well
3. Reticulate splines surgery now cures TRAUMA_RESILIENCE_SURGERY and
TRAUMA_RESILIENCE_LOBOTOMY traumas as well
4. Replaced RNG prob(75) roll with the 15-minute status effect that was
added to organic brain surgery.
This should balance/fix the robotic brain surgery to the recent change
that was done to the organic brain surgery. Only issue is the fact how
the original surgery was coded: there was no RNG roll for fix posibrain
surgery, while the normal organic surgery did.
Please feel free to close this PR if this was an intended feature/there
are issues with potential balance arguments.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
(It compiles, very simple code just handles surgery steps)
</details>
## Changelog
🆑 Goku
balance: Robotic blessed lobotomy now also requires holy water (just
like the organic surgery)
balance: Robotic blessed lobotomy requires liquid solder instead of
Palladium Synthate Catalyst
fix: Fix posibrain surgery now also cures surgery-tier brain traumas
balance: Reticulate splines surgery now also cures lower tier brain
traumas (surgery and lobotomy)
balance: Replaced advanced robotic brain surgery RNG roll with the
15-minute vulnerability status effect that was added to organic brain
surgery
/🆑
---------
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
commit 790b64602cd2e59b8397c4fe2451d2c14bddb546
Merge: 7d39bddbcb2 5e1b40cf89
Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 20:13:11 2025 -0700
Merge branch 'master' into upstream-25-04a
commit 5e1b40cf89
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:08:22 2025 +0200
Automatic changelog for PR #3492 [ci skip]
commit 5e94554873
Author: ariaworld <143797359+ariaworld@users.noreply.github.com>
Date: Sun Apr 13 05:07:55 2025 +0200
[FIX] Fixes Wooden shelves turning into metal racks when broken. (#3492)
## About The Pull Request
Title!
## Why It's Good For The Game
Bugfix, my immersion was ruined
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
:cl:Goku
fix: Fix wooden shelves turning into metal rack parts when broken.
/🆑
commit 7fed3cb7e4
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 05:07:00 2025 +0200
Automatic changelog for PR #3493 [ci skip]
commit 2d38b200a0
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 20:06:37 2025 -0700
Allow hypospray in medical pouch (#3493)
## About The Pull Request
Adds hypospray and cable to the allowed list of items in the medical
pouch
## Why It's Good For The Game
Commonly held items, other reagent containers are accepted but hypo is
missing.
## Changelog
🆑 LT3
qol: The medical pouch can now hold hyposprays and cable coil
/🆑
commit 7d39bddbcb2e775207a4a3e72a3940f9fbf3b0f1
Merge: fde55e27444 bb642474217
Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 17:25:22 2025 -0700
Merge branch 'upstream-25-04a' of https://github.com/Bubberstation/Bubberstation into upstream-25-04a
commit fde55e2744421b10f115724f70f3db8339b13df0
Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 17:25:20 2025 -0700
screenshots
commit cfa0c20656
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 13 01:39:06 2025 +0200
Automatic changelog for PR #3478 [ci skip]
commit 0397536620
Author: CatoChristopherMrow <johnmaddentickeledmyrear@gmail.com>
Date: Sat Apr 12 19:38:42 2025 -0400
Makes tackle gloves reskinnable (#3478)
## About The Pull Request
Makes tackle gloves reskinnable to their blue, red, and black variants.
## Why It's Good For The Game
Stops basic sec gear forcing you to either wear clashing colors or not
get the benefit of standard equipment. Viva la matching colors.
## Proof Of Testing
Works on my machine
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑 UvvU
add: Tackle gloves are now reskinnable.
/🆑
---------
Co-authored-by: Ian Yanik <Iwantpornspam@gmail.com>
commit 42b725836a
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 12 23:24:45 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit bb642474217244fd233372d9c68cb4bab5f871f7
Merge: 72beef087ea c872e81588
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 12 16:10:29 2025 -0700
Merge branch 'master' into upstream-25-04a
commit 72beef087ea8a1b291e286b09a0eb5a6713ba255
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 15:26:15 2025 -0400
this now returns an icon path not an icon object
commit 4e85c985ee77a37b44dcef393b815a04421463b7
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 15:08:12 2025 -0400
broken dmi
commit c872e81588
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 12 07:45:40 2025 +0200
Automatic changelog for PR #3490 [ci skip]
commit 27801b991c
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 01:45:17 2025 -0400
Fix admin chat buttons to cancel/refund storyteller events not working (#3490)
## About The Pull Request
The chat messages that get sent when a storyteller event is about to run
try to call `Topic` on the scheduled event datum but there isn't
actually a `Topic` proc defined for them
## Why It's Good For The Game
It's mean to trick admins with fake buttons
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
admin: the cancel and refund buttons in storyteller event notifications
will actually do something now
/🆑
commit bb14605128db2b1b5390d60b28665ed0ceae154a
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 01:06:39 2025 -0400
im tired
commit 1245d5145e4f41d63dbe983355ef4619b6441655
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 00:40:09 2025 -0400
what if the world was made of pudding
commit 7011b910d3bfaa0dba4a3d118721ad1d42a7625c
Merge: b8c00cbd266 e9ede320c9
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 00:31:56 2025 -0400
Merge branch 'master' into upstream-25-04a
commit b8c00cbd2660017d578f07ce20c3732dcfcdb60f
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 00:31:01 2025 -0400
silence linters
commit 3a3ea510ed12812fba0d97f545bf87749c16831a
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sat Apr 12 00:00:12 2025 -0400
the economy is in shambles
commit 0a3e17e897b270dc19a63038b8e99e15ff9242ce
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 23:43:06 2025 -0400
missing icons
commit fefc1348f722cf26bb407e6f7a5ba98184867fba
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 23:24:46 2025 -0400
no override for this
commit 952f2a7502d972093e1f86bd9fa20bf3ea9788bf
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 23:16:07 2025 -0400
shotgun icon states
commit 8e256d21c2bdfd2136f60705a3b5f7600ca6c9e7
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 23:02:28 2025 -0400
no icon
commit 60164e1a4c038661d41bbb25a1e0e536147455a2
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 22:39:35 2025 -0400
fucking capital letters?
commit 1e395535db671e61ce6514c35928a900d61a3570
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 22:28:06 2025 -0400
GRRRRRR
commit 68e35b0068388eb94d1c9ec5b865787b1cdc300a
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 21:19:15 2025 -0400
wrong
commit 9f8c9499f2890fad3c479d42c12888b1e0c55a3a
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 20:59:17 2025 -0400
just put your icons anywhere who gives a shit
commit f6bc1091867a3b234f2634e8cb120eae5b0053d9
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 19:58:40 2025 -0400
buh
commit edc876bff750ddce0593e917f5a68de02383c55e
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 19:49:32 2025 -0400
added our GAGS configs to deploy
commit e9ede320c9
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 23:23:21 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c726e4ee2d231d48334d43b8ce42d8b4e70b52b0
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 18:50:04 2025 -0400
fixed recipe foodtypes
commit 9e23291b14371e4703a38ae1711b1fe5b75cbf37
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 18:24:53 2025 -0400
Fix changelogs
commit bb8477826614c6e81285c5586de07ee26686c6b1
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 17:59:23 2025 -0400
number of args changed for inject
commit f00ed38c1d
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 11:03:02 2025 +0200
Automatic changelog for PR #3456 [ci skip]
commit 29b3c8daba
Author: aKromatopzia <94389683+aKromatopzia@users.noreply.github.com>
Date: Fri Apr 11 17:02:38 2025 +0800
Smolraptor Updates (#3456)
## About The Pull Request
Adds blue and red sec smolraptors, makes janitor an alt of service
## Proof Of Testing
it works
## Changelog
🆑
add: sec smolraptors
image: fixes some errors in smolraptors
/🆑
commit 7c0978a47f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 08:21:22 2025 +0200
Automatic changelog for PR #3463 [ci skip]
commit 04fd2b0a8a
Author: ArrisFairburne <arrisfairburne@gmail.com>
Date: Fri Apr 11 02:20:59 2025 -0400
Synth brain PDAs now have departmental PDA apps pre-installed (#3463)
## About The Pull Request
Synth brains now start with your department's apps pre-installed. For
example, Scientist synths now start with NT Science Hub. They also now
have double the storage space compared to the basic PDA.
## Why It's Good For The Game
Convenience.
Also, synth PDAs have sort of existed in a weird limbo where (at least,
from my point of view having talked to some others) most synth players
just don't actually use one of the defining features of their race
because normal PDAs are largely better and more convenient, hopefully
this change emphasizes their abilities.
The doubled brain storage space is just so that synth brain PDAs can
comfortably house whatever programs come with being a dept. head.
Balance wise, I doubt it will affect anything (what could you even do
with the extra storage space, short of the dept. head apps? basic crew
apps fit comfortably on the basic PDA limit, synths can't be emagged for
expensive syndie apps, and synths can't store files on their brain via
disks).
## Proof Of Testing
(image taken after I spawned as RD; this is the synth brain PDA)
## Changelog
🆑
qol: Synthetic crew now spawn in with PDA apps relevant to their work
station.
bal: Synthetic crew brain PDAs now have 128 max capacity points (was
previously 64)
/🆑
commit eaa6352aff
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 08:20:28 2025 +0200
Automatic changelog for PR #3471 [ci skip]
commit 02f3cfdb00
Author: ariaworld <143797359+ariaworld@users.noreply.github.com>
Date: Fri Apr 11 08:20:05 2025 +0200
[MAPPING]: Change Kilo Station dorms area type from Locker to Dorms. (#3471)
## About The Pull Request
Makes sure Kilo Station's dorms area actually is a Dorms area.
## Why It's Good For The Game
Other stations' dorms are inside actual Dorms areas, effectively
granting protection from events like sudden brain trauma/heart attack,
but Kilo Station didn't have this, they were classified as lockers
instead.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
:cl:Goku
map: Kilo Station's Dormitories area type is now classified as
dormitories, not as a Locker room.
/🆑
commit 5266275bc4
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 07:03:33 2025 +0200
Automatic changelog for PR #3485 [ci skip]
commit 0a38cf2824
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 01:03:07 2025 -0400
Fix examine menu character preview being tiny (#3485)
## About The Pull Request
Upstream fixed the tiny character preview but it requires a little tweak
on implementations
## Why It's Good For The Game
I can't see the blorbo
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: fixed character preview in the examine window being tiny
/🆑
commit 3fc7296b82
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 06:23:15 2025 +0200
Automatic changelog for PR #3483 [ci skip]
commit 1d52e91fd0
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Fri Apr 11 00:22:51 2025 -0400
Fix double box on vote results chat message (#3483)
## About The Pull Request
There's a redundant override in `vote.dm` to enclose the vote results in
a purple examine box, this is the default way votes are displayed now so
it's making vote results appear as a box within a box
## Why It's Good For The Game
Looks wrong
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
Before:
After:
</details>
## Changelog
🆑
fix: fixed vote results in chat having an extra box around them
/🆑
commit ab74044fc6
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 06:20:31 2025 +0200
Automatic changelog for PR #3363 [ci skip]
commit cb06f207d3
Author: Kepteyn <94123167+Kepteyn@users.noreply.github.com>
Date: Fri Apr 11 05:20:07 2025 +0100
Just a couple more hotel rooms (#3363)
## About The Pull Request
This adds four (and a half) new infinidorm hotel rooms -- A bar themed
one, for when you want bar RP that's less public; a nightclub themed
one; an space themed one for the spaceophilliacs who want to bang in
space (or an airlock), and finally an oasis themed one, with a day and a
night version.
It also fixes the lights in the Library room, given we're no longer
downstreaming from Skyrat, and it adds a template dmm that should make
it easier for people to add new rooms should they wish - the plaque on
the floor represents the spawn point.
## Why It's Good For The Game
This adds even more variety to the infinidorm room options for people to
roleplay in as a ghost. Or to _roleplay_ in. The bar one in particular
provides an option for people who want to do a bar RP with some friends
without getting pesky interruptions from their fellow human beings who
feel the need to start a gunfight in the bar.
## Proof Of Testing
All the new hotel rooms and the library have been tested in game, and
are working quite nicely! The template map does not show up as an option
in-game, as it exists to help mappers.
## Screenshots
<details>
<summary>Foxbar</summary>
</details>
<details>
<summary>Nightclub</summary>
</details>
<details>
<summary>EVA</summary>
_The floor is, infact, fake space, and is surrounded by a fake-space
wall. You will survive nude in space here. Spacesuits still provided._
</details>
<details>
<summary>Oasis</summary>
_Only one is shown for brevity's sake, as the only difference between
day and night versions is the strength of the external lighting_
</details>
<details>
<summary>Template</summary>
_The template room. The bluespace border must be indestructible solid in
some form, while the dark grey flooring represents the wall's location
on the defautl Hilbert room. The door is located where the default door
is on it, and the plaque on the ground shows where the player will
spawn_
</details>
## Changelog
🆑
add: Added infinidorms: Fox Bar; The Nightclub; EVA; and Oasis (day and
night versions)
add: Added a mapping template for creating new infinidorms at
modular_skyrat\modules\hotel_rooms
fix: modified the lights of the Library infinidorm so it's not so damn
dark.
/🆑
commit 700856e3c5
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 23:25:40 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 02353b9ec2
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 11 01:05:38 2025 +0200
Automatic changelog for PR #3475 [ci skip]
commit f1722bb1c6
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Thu Apr 10 16:05:12 2025 -0700
Disable lean reset on direction change (#3475)
## About The Pull Request
Edits TG's lean component to perform the same as the pixel shift
component
## Why It's Good For The Game
Consistent shifting movement
## Changelog
🆑 LT3
qol: Leaning no longer resets with directional change
/🆑
commit 4a5c80e1813ecaf7d26ddeabf2593d2b44c86dcb
Merge: b908b32d387 ada9345244
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Thu Apr 10 10:46:20 2025 -0700
Merge branch 'master' of https://github.com/Bubberstation/Bubberstation into upstream-25-04a
commit ada9345244
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 19:16:21 2025 +0200
Automatic changelog for PR #2896 [ci skip]
commit 472893ae5e
Author: Manatee <74586965+MajManatee@users.noreply.github.com>
Date: Thu Apr 10 12:15:56 2025 -0500
Tarkon Tweaks and Xeno Changes (#2896)
## About The Pull Request
Update as of 01/26
So that was a lie
Anyways I completely remade tarkon, which is what I ORIGNIALLY wanted to
do, but used a lot of the pre-existing tarkon assets to do so, to
maintain the same feel.
Some NEW NEW features (as the project grew in scope) include:
Med/RND/Engineering are now separate "Islands" like charlie (tarkon was
always meant to be like that anyhow
Each one has a few xenos, and a new "Emergency power generator"
Scanning this with the new (not a ripoff) Hack-C tool will call in a
repair drone (Original content) to repair it, and it needs to be
defended from the xenos it alerts.
Sucsesfully completing a defence will reward sickass weapons and gear
you wouldn't normally ever get to see, making further areas easier, and
a key for the final area.
Once all 3 keys are obtained, and the areas are re-secured, you can go
to the boss area and clear out the AI sat / command zone.
A bitrunning server to allow them to make their own bitden (it's the
first prototype, and the rest must be researched so it's not
shift-start)
more floor safes with various things like some ore thumpers and two
bluespace beakers
Crates! Someone misfiled a crate of goodies and it got sent here! These
orders should be delivered to their owners! I'm sure they would
appreciate it! Probably...
A Recycler (Amazing)
A produce order console! Now you can actually cook whatever you want!
And it gives you a reason to sell stuff for money!
more stuff, lots more stuff. things keep getting added the longer it
takes for this to be looked at.
Also adds three new variants of xenobio, and two new variants of the
cargo bay. One cult (we miss you cult), one carp, and a monkey themed
xenobio.
## Why It's Good For The Game
Part 1 of my attempt to make tarkon feel better to play. The overall
gameplay was very "Meta" and didn't really give you any reason to clear
out xenos or the threats. Who knows what might come next.
Tarkon was pretty stale. A bit of new stuff might be nice. plus a reason
to use their shuttle is good.
Furthermore, tarkon WILL run on solar, so if you REALLY don't want to,
you don't HAVE to go and clear everything out.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
I did test it, and run the wave defense, it DOES work.
</details>
## Changelog
🆑
add: BUNCH of new tarkon things!
map: Tarkon QOL changes
/🆑
---------
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
Co-authored-by: Arturlang <24881678+Arturlang@users.noreply.github.com>
commit b908b32d387ffe9a2b40d2d25a03cd04c2e62868
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Thu Apr 10 08:35:37 2025 -0700
Compiletimes done
commit a9601004a82714a72f62e9b5db07d2adde27c0c3
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Thu Apr 10 08:35:26 2025 -0700
We are so comically stupid
commit 0f8d37991f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 00:05:02 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 31897a95e9
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 01:54:47 2025 +0200
Automatic changelog for PR #3468 [ci skip]
commit 385b734424
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 10 01:54:32 2025 +0200
Automatic changelog for PR #3470 [ci skip]
commit 0903ee683e
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Wed Apr 9 19:54:20 2025 -0400
Fix shuttles no longer making sounds or (un)bolting doors (#3468)
## About The Pull Request
The code for these things got lost in an upstream because shuttle code
got split into multiple files
## Why It's Good For The Game
Fixes#3251
## Proof Of Testing
I tested it and the shuttle went bwwwwrrmmmmm pshewww and the door bolts
went chk
## Changelog
🆑
fix: fixed shuttles missing landing/take off engine sounds
fix: fixed shuttles not bolting/unbolting their doors when moving
/🆑
commit e5b57bc08c
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Wed Apr 9 16:54:09 2025 -0700
Fix meow emote for cat tongues (#3470)
## About The Pull Request
Fixes the meow emote to use the correct emote if you have a cat tongue
## Why It's Good For The Game
MEOW.
## Changelog
🆑 LT3
fix: Mobs with cat tongue get their alternate meow sound back
/🆑
commit 204ea57363
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 9 23:23:16 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit ce5944e0733f4c5985e2e48878a02c0c35463d0a
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 08:19:09 2025 -0700
6 compiletime errors left
commit d1905c44f5
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 9 14:03:13 2025 +0200
Automatic changelog for PR #3461 [ci skip]
commit 6c3bc53604
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Wed Apr 9 08:02:51 2025 -0400
Deathmatch now stores and reapplies your respawn timer prior to being spawned (#3461)
## About The Pull Request
Title
## Why It's Good For The Game
item number TWO on the list
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
code: deathmatch doesn't reset your respawn timer
/🆑
commit f890cb36b9265f011a187b4f332812590838292c
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:45:20 2025 -0700
some color stuff
commit fb849a2a8ebc2166915cfbec1e850510678b2f22
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:38:18 2025 -0700
Fixes
commit 381d77fa68707cc5315b698474df026c2103166c
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:20:20 2025 -0700
We love guncode and refactors!!!!
commit f30bb6ca01319218795e4004219938aa3d976eb3
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:00:40 2025 -0700
I love cherry picking!!!
commit 6677a4c7bbe3c7536276178c841290a489d0a4a9
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 01:00:27 2025 -0700
so apparently some dumbass on nova reused the turret flag bitfield and it only now runtimes
commit 7acc721baadbdea3d3795a45b9837cfeb4fd4fd0
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 00:58:48 2025 -0700
Martials and arcade rework updates
commit bf9f393204fe7d40d5e57e76db870eb1a32aed25
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 00:47:58 2025 -0700
This might break taur icons, remember to test once we compile
commit 3bc256cb16ca2e85b78830345bba0a487f49fc17
Author: Majkl-J <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 9 00:41:03 2025 -0700
Several varchanges from tg
commit 76f5dc1b5f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 8 23:23:40 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 538049c4cd4960d2c81c43f2e387896049fb02c7
Author: Waterpig <wtryoutube@seznam.cz>
Date: Tue Apr 8 20:00:59 2025 +0200
reagent applicators fixes
commit df43e50d68419d2f24bd62eef0432bda8394cc7d
Author: Waterpig <wtryoutube@seznam.cz>
Date: Tue Apr 8 19:56:27 2025 +0200
Some missed merge fixes
commit 0f0838bb35
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 8 09:27:36 2025 +0200
Automatic changelog for PR #3399 [ci skip]
commit 234a410586
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 8 09:27:29 2025 +0200
Automatic changelog for PR #3397 [ci skip]
commit 722b51eb07
Author: Iamgoofball <iamgoofball@gmail.com>
Date: Tue Apr 8 02:27:12 2025 -0500
[MODULAR] Removes the 60 round Sol drum from being printable in Security (#3399)
## About The Pull Request
Removes the 60 round Sol drum from being printable in Security
## Why It's Good For The Game
After discussing magazine size standardization, this came up and to be
100% honest, the crew does not need LMG ammo capacity on any of their
guns. Even though it's illegal contraband to use(yes, Illegal Tech is
still fuckin' Illegal lol), it's still a lot of ammo capacity that we
don't really want the crew to have.
## Proof Of Testing
Just deleting a research design.
## Changelog
🆑
del: Removes the 60 round Sol drum from being printable in Security
/🆑
---------
Co-authored-by: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
commit 3e7223b959
Author: Iamgoofball <iamgoofball@gmail.com>
Date: Tue Apr 8 02:27:06 2025 -0500
[MODULAR] Puts the Sol/Carwo/Romulus/Szot/Trappiste gun magazine sizes in line with /tg/ standards (tiny for everything but rifles which are normal) (#3397)
## About The Pull Request
Puts the Sol/Carwo/Romulus/Szot/Trappiste gun magazine sizes in line
with /tg/ standards (tiny for everything but rifles which are normal)
## Why It's Good For The Game
Size inconsistencies between items results in confused players; it's
good to keep this sort of thing synced up so that we're not having
players ask why one pistol magazine fits in a box while another pistol
magazine doesn't fit in a box when the air tank that's bigger than both
of them does fit in the box.
If I find other guns with weird weight classes I'll fix those too.
## Proof Of Testing
Single-line changes, weight classes is a proven working system already.
## Changelog
🆑
qol: Puts the Sol/Carwo/Romulus/Szot/Trappiste gun magazine weight
classes in line with /tg/ standards for magazine weight classes (tiny
for everything but rifles or larger which are normal)
/🆑
commit 7b420bb680
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 22:16:23 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit f30b0d5df0
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 8 00:12:44 2025 +0200
Automatic changelog for PR #3452 [ci skip]
commit aa4901b571
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Mon Apr 7 15:11:59 2025 -0700
Map vote is called automatically on blob/nukies/etc. round end (#3452)
## About The Pull Request
Triggers the automatic map vote when the round is about to end due to a
station threat, if it hasn't happened.
## Why It's Good For The Game
Saves it delaying the next round if no admin catches it in time, causing
a delay as the vote and another restart needs to occur.
## Changelog
🆑 LT3
admin: Map vote is automatically triggered near the conclusion of
station ending threats
fix: Only a single announcement is sent when the shuttle is called,
fixing the overlapping sounds
/🆑
commit a6845577bd
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 21:55:15 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit bf8c0ef85f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 23:49:40 2025 +0200
Automatic changelog for PR #3459 [ci skip]
commit 28e4e2cd42
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Mon Apr 7 17:49:12 2025 -0400
Refactor changelog handling to separate files (#3459)
## About The Pull Request
This rewrites how our actions handle changelogs, and rewrites a bunch of
the changelog TGUI (in a separate file cause I don't feel like
massacring the upstream one). The gist of it is that our actions will
now create autochangelog files with bubber in the name, our changelog
compile will only compile those autochangelogs (not upstream ones if
they happen to be in there), and the compile will be done into separate
bubber changelog files in `html/changelogs/bubber_archive`. In game, the
UI will pull both archive files (upstream and ours) and combine them in
the changelog list, putting the codebase logo next to each change to
distinguish which one it's from.
~~NOTE: I'm opening this as a draft because I'm going to try and reset
our tg changelogs and then reapply all our historical changelogs into
the new bubber archive files, I'm just putting this up now so the code
can be reviewed and shit~~ done
## Why It's Good For The Game
For players this makes it easier to distinguish where a change came
from, and for developers this means we don't need to worry about
breaking the changelog when we do an upstream pull, we can completely
ignore it and just pull everything, and our tg archive files will be 1:1
with upstream with no shit from us added in.
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑 TealSeer, LT3
refactor: refactored how changelogs are generated and displayed
/🆑
---------
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
commit 7de99181db
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Mon Apr 7 17:44:07 2025 -0400
Rename Autochangelog (#3462)
the refactor is about to merge this isnt gonna be included otherwise
commit 0ed680f2aa
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 23:36:02 2025 +0200
Automatic changelog for PR #3457 [ci skip]
commit 0f13b89457
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Mon Apr 7 17:35:25 2025 -0400
30 minute grace period to respawn (world time, not round time) (#3457)
## About The Pull Request
from when the server starts to 30 minutes after, respawning is free of
charge
## Why It's Good For The Game
item #1 on the list
## Proof Of Testing
it works dude trust me
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
code: respawn enabled until 30 min (world time)
/🆑
commit 99cb23f3c5
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 18:30:45 2025 +0200
Automatic changelog for PR #3434 [ci skip]
commit 697d89abf3
Author: pixelkitty286 <78038207+pixelkitty286@users.noreply.github.com>
Date: Mon Apr 7 11:30:19 2025 -0500
Cleans up and reorganizes some of the borg code (#3434)
## About The Pull Request
This PR reorganizes and cleans up some of the borg code and separates
sprite defines and borg defines once more but this time correctly.
Also fixes some small bugs with foot steps with chameleon module.
Moved some borg model specific trait procs into their own file.
## Why It's Good For The Game
Makes it more organized so we don't have one HUGE file containing all
the sprite defines and borg model code
## Proof Of Testing
It's all back end. Compile test was last done late march.
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: chameleon model foot steps
code: moved many of the borg defines to their correct _defines file and
folder
/🆑
commit 74985f40fc
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 10:28:15 2025 +0200
Automatic changelog for PR #3447 [ci skip]
commit d58cf909af
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Mon Apr 7 01:27:49 2025 -0700
Change podperson eye color (Again (Thanks Upstream)) (#3447)
commit cb3052e6ea
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 02:04:52 2025 +0200
Automatic changelog for PR #3448 [ci skip]
commit c29d36ada5
Author: sippykot <sippythekot@outlook.com>
Date: Mon Apr 7 02:04:27 2025 +0200
Fish Ass: ports over large shark tails from CHOMP (#3448)
## About The Pull Request
see title
if you want to see who made the sprites, follow the accreditation chain:
https://github.com/CHOMPStation2/CHOMPStation2/pull/9926
it doesn't fully use all the sprites, because our system here is so much
clunkier to use - if someone wants they can probably bash out several
more tail variants by copying and rearranging the existing sprites
## Why It's Good For The Game
people wanted them, gushed over them in #suggestions, and then no one
did anything, so...
also, 🦈
## Proof Of Testing
yeah i compiled it, they finally showed up in game, thanks #coder-longue
## Changelog
🆑
add: 4 new tail options
image: new tail sprites
/🆑
---------
Co-authored-by: Roxy <75404941+TealSeer@users.noreply.github.com>
commit fa6845f9e6
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 23:22:10 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 55fd8dd1f7
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Mon Apr 7 01:01:20 2025 +0200
Automatic changelog for PR #3426 [ci skip]
commit 16f6d07548
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Sun Apr 6 19:00:55 2025 -0400
Shadekin NV and movespeed rebalance (#3426)
## About The Pull Request
title + nerf movespeed in the light
## Why It's Good For The Game
still can't see shit (nv trait is 4.5, bumping it up to 15)
## Proof Of Testing
it werks
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
balance: shadekin nv buffed from 4.5/100 to 15/100
balance: shadekin move a bit slower in the light
/🆑
commit d2f96730ba
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 22:16:10 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c7def946b6
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 17:39:00 2025 +0200
Automatic changelog for PR #3450 [ci skip]
commit f833f3edc4
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 6 11:38:26 2025 -0400
Fix persistence medbots speaking on syndicate frequency (#3450)
## About The Pull Request
Make them speak on cybersun frequency
## Why It's Good For The Game
Fixes#3446
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: fixed persistence medbots speaking on wrong radio frequency
/🆑
commit 17b620b48e
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 10:19:15 2025 +0200
Automatic changelog for PR #3438 [ci skip]
commit bfb9c9e2b5
Author: pixelkitty286 <78038207+pixelkitty286@users.noreply.github.com>
Date: Sun Apr 6 03:18:52 2025 -0500
Nerfs super syndicat and makes it no longer a freedom implant. (#3438)
## About The Pull Request
- This PR makes the new syndicat ears item have a 1 minute cool down
when used and the normal ears have the same thing.
- This also ports a fix that was done on monkey station:
https://github.com/Monkestation/Monkestation2.0/pull/6017
## Why It's Good For The Game
- After watching a round on here and getting complaints about this from
SPLURT I understand now why 20 seconds is too short for such a item like
this if your gonna be a cat your gonna be a cat for a long while.
- Also to quote monkey station:
"It will make the cat not able to bypass any security non-lethal means,
which in turns mean security won't be forced to lethal them everytime
they see it."
## Proof Of Testing
Should work only changed the time values.
Edit: Compiled and tested locally
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
balance: Super cat ear cool downs are longer and removed the freedom
implant function.
/🆑
commit 4ed70fa4c7
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 10:18:17 2025 +0200
Automatic changelog for PR #3451 [ci skip]
commit 65331b085f
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun Apr 6 04:17:45 2025 -0400
Fix invisible sprites on security HUD nightvision goggles (#3451)
## About The Pull Request
Upstream changed NV goggles to have different icon states for on and off
and we dont have that so I reverted it to the tg sprite
## Why It's Good For The Game
Fixes#3383
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: fixed sechud nv goggles being invisible when off
/🆑
commit 8aad924f76
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 10:16:18 2025 +0200
Automatic changelog for PR #3443 [ci skip]
commit 3bd5803844
Author: Swift <jackwars4@gmail.com>
Date: Sun Apr 6 03:15:53 2025 -0500
Removes tackle buff for having cat ears (#3443)
## About The Pull Request
Title, manual revert of #1513
## Why It's Good For The Game
Tackle chance could be brought to 100% and people have reportedly been
exploiting this fact.
## Proof Of Testing
I think it will complie
## Changelog
:cl:Swiftfeather
balance: Cat ears no longer provide a tackle bonus
/🆑
commit 89594c8547
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 00:56:59 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit b4af64b182
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sun Apr 6 02:25:40 2025 +0200
Automatic changelog for PR #3370 [ci skip]
commit 0e684db68a
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Sat Apr 5 17:24:44 2025 -0700
Update various sound prefs for 516 compatibility (#3370)
## About The Pull Request
Updates our various sound prefs to be functional post upstream/516.
## Why It's Good For The Game
We can control sound as expected again.
## To-Do
- [x] Conditional preference sounds
- [x] Jukebox sound toggle
- [x] Jukebox volume override
## Changelog
🆑 LT3
fix: Sound prefs that went missing post-516 are restored
add: Jukebox volume slider in game preferences
/🆑
---------
Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com>
commit 60e73702c6
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 07:14:09 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 9a36823173
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 09:02:26 2025 +0200
Automatic changelog for PR #3425 [ci skip]
commit 1ab85fd206
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Sat Apr 5 03:02:02 2025 -0400
Spices up vulpkanin [bounty] (#3425)
## About The Pull Request
Changes vulpkanin in several ways:
- Peanutbutter gives a mood buff
- Chocolate deals toxin damage while inside you
- innate hardened soles
- innate night vision
- hunger will drain twice as fast
- higher sensitivity to flashes
## Why It's Good For The Game
vulpkanin are literally human but fluffy, they don't even have lore in
the species selector (lol) also I'm being paid
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
add: several vulpkanin species buffs/debuffs
/🆑
---------
Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
commit 4da0397b16
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 08:54:22 2025 +0200
Automatic changelog for PR #3396 [ci skip]
commit 1ed1187fca
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Fri Apr 4 23:53:57 2025 -0700
Slug Scream! (#3396)
## About The Pull Request
Adds a new scream, "Slug". Sound file ripped from Splurt
## Why It's Good For The Game
Expression is the best thing that this video game medium can offer.
## Proof Of Testing
https://github.com/user-attachments/assets/147be9dc-98c2-4ee4-bc76-762331710143
## Changelog
🆑
sound: Slug Scream sound added to *scream choices
/🆑
commit 66e28121d4
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 08:53:15 2025 +0200
Automatic changelog for PR #3431 [ci skip]
commit 88a238b93c
Author: Bombermansam <Bombermansam@yahoo.com>
Date: Sat Apr 5 02:52:48 2025 -0400
Allows players to be sad like raptors (#3431)
## About The Pull Request
Adds a Sad Kweh emote from the two unused raptor sound files.
## Why It's Good For The Game
You can now sad birdly.
## Proof Of Testing
It compiles and was tested locally.
https://github.com/user-attachments/assets/bc5f31fb-ad12-4026-be94-d28d2db542df
## Changelog
🆑
add: *skweh emote to be sad
/🆑
commit 4a93b42977
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 08:51:43 2025 +0200
Automatic changelog for PR #3432 [ci skip]
commit f51c4d7942
Author: Bombermansam <Bombermansam@yahoo.com>
Date: Sat Apr 5 02:51:18 2025 -0400
Silicons can now Yip (#3432)
## About The Pull Request
Silicons can now emit a singular yip so they can express their inner
kobold but not too much.
## Why It's Good For The Game
Silicons can yipyip but not yip. This fixes it.
## Proof Of Testing
It compiles and was tested locally.
</details>
## Changelog
🆑
fix: Silicons can now yip.
/🆑
commit 14ec8a0440
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 08:43:03 2025 +0200
Automatic changelog for PR #3437 [ci skip]
commit e05fe31faa
Author: Odairu <39929315+Odairu@users.noreply.github.com>
Date: Sat Apr 5 02:42:41 2025 -0400
Adds more flavor to shadekin empathy (#3437)
## About The Pull Request
BASED ON SANITY SHADEKIN EMPATHY WILL:
-Take more or less time to send
-At lowest levels of sanity the message starts to break down some
-Be a different color in chat
## Why It's Good For The Game
Shadekin empathy is communication through FEELINGS so it being
better/worse based on how you're FEELING makes sense (to me)
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
balance: shadekin empathy is better/worse based on mood
/🆑
---------
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
commit 457754c461
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Sat Apr 5 06:38:05 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c3fe3d31ba
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Fri Apr 4 23:16:53 2025 -0700
You can cuff people to the tram rails #90293 (#3445)
## About The Pull Request
https://github.com/tgstation/tgstation/pull/90293
Handcuffed people can be buckled to the tram rails.
If the tram hits them then they will die badly.
If they're not shockproof and are buckled to a powered rail, it will zap
them repeatedly for a little bit of damage (but not a lot because you
probably want them to die from something else).
Unbuckling someone from a powered rail is also pretty dangerous.
While doing this I fucked around a bit with how the "is the tram deadly"
calculation worked because I didn't like how a deadly tram cuts your
head off but does literally no other damage. Now it pulverises and
beheads you.
## Why It's Good For The Game
---------
Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com>
commit 3c1c05052f
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 4 23:23:13 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 0287fe4d0b
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Fri Apr 4 21:54:53 2025 +0200
Automatic changelog for PR #3440 [ci skip]
commit 6d081fe0da
Author: Bombermansam <Bombermansam@yahoo.com>
Date: Fri Apr 4 15:54:30 2025 -0400
[Modularized] Nugget Boxes and Foodpacks can now be placed into paper sacks. (#3440)
## About The Pull Request
Nugget Boxes and Foodpacks can now be placed into paper sacks.
## Why It's Good For The Game
You can now live out your minimum wage dreams as a fast food worker a
Chick'fil'a. To quote someone that wanted this "I can now fastfoodmax as
a chef".
Food packs can also be placed into paper sacks because it makes sense.
## Proof Of Testing
It compiles and was tested locally.
I would like to praise [lessthnthree](https://github.com/lessthnthree)
for their remarkable patience in teaching me how to properly modularize
code. Really, thank you so much!
</details>
## Changelog
🆑
add: Makes Nugget Boxes and Food packs small
/🆑
---------
Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
commit 0824cb07ba
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 20:19:08 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 9d8a54be49
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 22:14:42 2025 +0200
Automatic changelog for PR #3433 [ci skip]
commit 45477353d2
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 22:14:33 2025 +0200
Automatic changelog for PR #3403 [ci skip]
commit b6b6fbfba4
Author: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
Date: Thu Apr 3 14:14:17 2025 -0600
Job Spawn borgs prioritize linking to the malf AI (#3433)
## About The Pull Request
So there's this little quirk where late join cyborgs will auto link to
whatever AI has the least cyborgs. This changes that.
This adds a priority: Malf AI > AI cores
Also this deletes an unused file I noticed.
## Why It's Good For The Game
Every cyborg that spawns in the game during an active malf round should
always connect to the malf AI if it's available.
## Proof Of Testing
It works
## Changelog
🆑
balance: Cyborgs now auto link in a priority system. Malf > AI cores >
Suit AIs / Cards
/🆑
commit 1f3aedc6c1
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Thu Apr 3 13:14:07 2025 -0700
Fix brain trauma surgery (#3403)
## About The Pull Request
Fixes the highest level of trauma surgery leaving leftover traumas.
Applies a status effect instead of the random roll of a new trauma.
## Why It's Good For The Game
Having to do lobotomy surgery over and over until you hit the 25% RNG to
make it successfully go away isn't a good gameplay experience. Better to
just apply a status effect for a while instead.
## Changelog
🆑 LT3
fix: Lobotomy/blessed lobotomy should correctly remove all surgery based
traumas
balance: Lobotomy/blessed lobotomy now provides a predictable status
effect instead of a trauma RNG roll
/🆑
commit 95d97cf4a2
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 18:50:51 2025 +0200
Automatic changelog for PR #3429 [ci skip]
commit 3c30dfbaff
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Thu Apr 3 09:50:24 2025 -0700
Shadekin Ear Gradient (#3429)
## About The Pull Request
Adds a new ear type: Shadekin Gradient
## Why It's Good For The Game
Makes Healer happy
## Proof Of Testing
## Changelog
🆑
add: Added new ear type: Shadekin Gradient
/🆑
---------
Co-authored-by: Jinshee <manastra2536@gmail.com>
commit 3dd8af584e
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 06:33:08 2025 +0200
Automatic changelog for PR #3415 [ci skip]
commit c83b14b15d
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Wed Apr 2 21:32:45 2025 -0700
Porting New Bug Customization + IPC Screens (#3415)
commit d9d40def4c
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Thu Apr 3 02:35:34 2025 +0200
Automatic changelog for PR #3387 [ci skip]
commit a154dd9d97
Author: Jinshee <96621959+Jinshee@users.noreply.github.com>
Date: Wed Apr 2 17:35:10 2025 -0700
Fixes Waggingtail Sprite for Shadekin tails + Ringtail (#3387)
## About The Pull Request
All of the shadekin tails, ringtail included, had incorrectly assigned
dmi files for their wagging state, causing them to go invisible. This,
simply, fixes that.
## Why It's Good For The Game
I love fixing sprites!
## Proof Of Testing
https://github.com/user-attachments/assets/186f7dc6-4b78-4e9e-968e-fcbdae40bf2f
## Changelog
🆑
fix: fixed wagging state for all shadekin tails and ring tail (long)
/🆑
commit ba3fa0684c
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 21:56:26 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit 70143cdadb
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 23:52:41 2025 +0200
Automatic changelog for PR #3419 [ci skip]
commit ad62db6f9b
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Wed Apr 2 14:52:18 2025 -0700
Adds pipe carp (#3419)
## About The Pull Request
A Ferocious, highly aggressive fish that thrives in the depths of shoddy
engineering work. Drawn to poorly sealed pipes, mismatched connectors,
and hastily patched atmospherics, these creatures feast on structural
incompetence with alarming efficiency.
## Changelog
🆑 LT3
add: Added new carp variant: carpmospheric technician
/🆑
commit dab0ff6a09
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 11:40:26 2025 +0200
Automatic changelog for PR #3423 [ci skip]
commit 27027d5ceb
Author: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
Date: Wed Apr 2 03:40:00 2025 -0600
take two: Reverts the disaboot apirl fools (#3423)
## About The Pull Request
Apirl fools code cleanup. Was a funny meme, but I don't think they
should happen next year.
## Changelog
🆑
del: Disaboots have been removed from apirl fools.
/🆑
commit 1c08269f2a
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 03:08:41 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit c43c9d01ed
Author: LT3 <83487515+lessthnthree@users.noreply.github.com>
Date: Tue Apr 1 19:38:12 2025 -0700
[TM ONLY] let me send long ass subtler messages to my heart's content (TGUI payload chunking) (#3406)
## About The Pull Request
(https://github.com/tgstation/tgstation/pull/90295)
## Changelog
🆑 Y0SH1M4S73R
code: Any tgui message that would be too big to send to the server is
now split into chunks and sent in sequence. This fixes several issues,
such as...
fix: It is once again possible to save large amounts of text on paper at
once.
/🆑
---------
Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net>
Co-authored-by: Y0SH1M4S73R <y0sh1m4s73r@gmail.com>
Co-authored-by: Lucy <lucy@absolucy.moe>
commit c96d028562
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 04:35:29 2025 +0200
Automatic changelog for PR #3420 [ci skip]
commit e22c174b35
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Wed Apr 2 04:35:09 2025 +0200
Automatic changelog for PR #3407 [ci skip]
commit 43a4b964b1
Author: plsleavemealon <106043510+plsleavemealon@users.noreply.github.com>
Date: Tue Apr 1 21:35:04 2025 -0500
Ethereal Powercell Bugfix (#3420)
## About The Pull Request
Fixes ethereal powercells from 20kj back to 220kj which is what they
used to be.
## Why It's Good For The Game
It is what it used to be, and with the present vanilla values you have
to recharge yourself once every ~5 minutes or so or suffer a huge mood
debuff. And if you are entombed, you will suffer death after ~10 minutes
if you do not recharge.
## Proof Of Testing
## Changelog
🆑
fix: fixed ethereals powercell back to bubbers values
/🆑
commit 3068303ae3
Author: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
Date: Tue Apr 1 20:34:46 2025 -0600
Reverts "Adds crew monitors to Advanced biotech and lathes" (#3407)
## About The Pull Request
This removes the handheld crew monitor from the medical lathe.
## Why It's Good For The Game
Alright, I just want to start out with all sources of the handheld crew
monitor after this PR
- Paramedics spawn with them
- Blueshield (command only)
- The medical vendor premium section.
- Borg upgrades
Overall while there's been a lot of QOL to the crew monitor which I
enjoy, it's all gradually made it so deaths are very noticable and often
times with someone in medical 1 second later running towards an active
fight to drag corpses away.
- I think overall we have a sort of medical omnipresence issue,
especially with an easy research destroying a level of scarcity with the
hand held crew monitor.
Anyone can print it if they have the materials and access to the lathe
versus only a few existing outside of the paramedic starting with them.
This PR of course is not going to fully tackle it. It's not going to
stop a paramedic constantly staring at sensors or the medical console
beeping when someone's in crit. But this aims to get less eyes on
sensors, mostly the ability for everyone in medical to have a little
screen to pull out and see the live feed without actively moving to a
console.
Overall I think we have this issue (a lot of it being administrative)
where every single death must be immedietly found and the person revived
in 10 minutes. This won't fully tackle that, but if the solution is we
must bloat a ton of antag abilities and items to combat sensors then I
think we have too many eyes on sensors.
## Proof Of Testing
## Changelog
🆑
del: Removes the handheld crew monitor from the medical lathes.
/🆑
commit c9cca3fbef
Author: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Date: Tue Apr 1 23:24:18 2025 +0000
Bubberstation automatic changelog compile [ci skip]
commit de81adcb6d
Author: Waterpig <49160555+Majkl-J@users.noreply.github.com>
Date: Wed Apr 2 00:55:25 2025 +0200
Makes the roundend mapvote not rerun after it gets called the first time (#3418)
## About The Pull Request
See name
## Why It's Good For The Game
Fixes#3395
## Proof Of Testing
It worked I did test it
## Changelog
Nothing player facing, basically allows us to cancel the vote once it
initializes
commit b36c477460
Author: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Tue Apr 1 18:35:54 2025 -0400
Fix every fucking piece of maint loot being skub (#3412)
## About The Pull Request
the override should append to the global maint loot list not replace it
## Why It's Good For The Game
I'm anti-skub
## Proof Of Testing
I did this PR from my phone in bed because there's no power
## About The Pull Request
Handcuffed people can be buckled to the tram rails.
If the tram hits them then they will die badly.
If they're not shockproof and are buckled to a powered rail, it will zap
them repeatedly for a little bit of damage (but not a lot because you
probably want them to die from something else).
Unbuckling someone from a powered rail is also pretty dangerous.
While doing this I fucked around a bit with how the "is the tram deadly"
calculation worked because I didn't like how a deadly tram cuts your
head off but does literally no other damage. Now it pulverises _and_
beheads you.
## Why It's Good For The Game
Multiple people I spoke to believed this was already possible
## Changelog
🆑
add: Handcuffed people can now be tied to the tram rails
balance: tram rails will no longer electrocute you if they're not
powered
/🆑
---------
Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
## About The Pull Request
This won't actually do anything on live, since those are all set to
UTC±0 currently
Pins logging and IC uses of time2text to UTC±0 instead of using the
system timezone (byond default)
Timezones not being set to utc0 caused issues before (and is again)
All timezones are now passed explicitly to make it more likely it's
cargo culted properly at least
Deletes worldtime2text cus it was gameTimestamp default args
## Why It's Good For The Game
Server timezone changes probably shouldn't affect logging, round times,
file hashes, IC time, when you caught fish, etc
## Changelog
🆑
refactor: Logging and IC timestamps will now always use UTC±0 and not be
affected by server system timezone changes
fix: Station and round times will not longer be incorrect if the system
timezone is not UTC±0
/🆑
---------
Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
[Removes all remaining users of SMOOTH_CORNER + dirt
automation](https://github.com/tgstation/tgstation/commit/71d120511a372501ac546b2571ef570eb4426a56)
Removes all remaining instances of overlay smoothing (the deprecated
system that stitches corners together IN ENGINE) from the game.
This amounts to:
The test smoothing wall, which I converted to just bitmask + diagonals
Stationary canisters, which I've done the same to (alongside adding all
the states to gags, which around doubled their gags count). These
autocut now.
I've also given dirt icons autocutting, for spriter convieneince (I
would have done this before but I didn't know they smoothed)
[Removes corner smoothing from the
codebase](https://github.com/tgstation/tgstation/commit/98ebe5815223a3078c2e591fd277b9418ed03278)
This code is OLD, and has been functionally deprecated for as long as
I've been here. It basically does what bitmask smoothing does, but
instead of prebaking connections they're formed in engine with overlays.
This is... fine, and does TECHNICALLY allow for unique effects, but
none's gonna use it because the details are so niche, so it just becomes
a risk factor for someone fucking up and using overlays for some reason.
What it does do then is clutter up our smoothing code with 2 different
async systems, one of which functions SLIGHTLY differently from its
brother. IMO it just works to confuse people trying to read smoothing
code (already quite confusing).
I've removed it, alongside its bespoke code/variables, excluding
area_limited_icon_smoothing, a var on areas that prevents smoothing out
of network, which I have instead integrated into bitmask smoothing.
I've updated snowflake's documentation to be more up to date with modern
systems, and earmarked where explanations/automation for the more...
underdeveloped bits of smoothing should go in the future.
## Why It's Good For The Game
I relapsed and needed something to put that energy towards.
We don't really want people to use this, and none knows enough about it
to take advantage of its theoretical uses.
Really its only purpose right now is making understanding diagonal
smoothing easier, and that's not all that hard of a task.
Better to remove and integrate then to let rot and confuse.
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Smoothed objects on shuttles now will only smooth with other
shuttles (added support for extensions of this system)
refactor: I've funked around with our smoothing system, cutting out some
older code. Lemme know if anything is weird PLEASE
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
## About The Pull Request
In #89619, I removed the mech PKA's mining AOE and reduced the damaging
AOE to a fraction of the damage.
I have restored both of these aspects, but I have also applied this
change to the standard PKA's mining and damage AOE. I have also included
the mob biotype limitations as well.
AOE modkits take 10% capacity, now allowing miners to use them in more
setups. However, they conflict with one another. You can only have one
AOE mod until you can get the dual AOE mod from tendrils.
The AOE damage/mining effect is now a 2 tile effect rather than 1 tile
effect.
## Why It's Good For The Game
My intent in the previous PR was to bring mech PKA's down to standard
mining limitations. So, why not improve those standards for everyone
instead? The new state of mining expects you to be dealing with a lot of
mobs at once. Even small vents can, on occasion, decide to spit out
several goliaths back to back. That's a lot of mobs with a lot of
health.
Miners need AOE options more than ever. They have very little that are
actually meaningful, sadly. So my intent here is that this should be an
expectation for our miners to be seeking out and can fit into their
current, standard gameplay.
Certainly I've only felt like shit having to sacrifice a damage or
cooldown mod for an AOE mod, only to get a very minor amount of damage
splash for my efforts. That, and the radius doesn't usually impact most
mobs as they spawn and attack from awkward angles or distances from one
another where they are JUST out of reach of one another. Trying to use
the splash to hit multiple enemies is often not worth it compared to
just hitting one enemy at a time with a lot of damage.
So, let's just go with the standard of 'Good AOE is fundamentally needed
now' and worth from that premise.
## Changelog
🆑
balance: Mech PKA now once again mines turfs and does full damage on its
AOE explosion (still only hitting mining mobs).
balance: The standard PKA AOE mods are now by default 10% capacity. But
they cannot be used with one another.
balance: The standard PKA offensive AOE mod now does the PKA's full
damage in its AOE.
balance: Mining AOEs will affect everything within a 2 tile radius
around the point of impact, up from a 1 tile radius.
/🆑
---------
Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
Replaces the asset subsystem's spritesheet generator with a rust-based
implementation (https://github.com/tgstation/rust-g/pull/160).
This is a rough port of
https://github.com/BeeStation/BeeStation-Hornet/pull/10404, but it
includes fixes for some cases I didn't catch that apply on TG.
(FWIW we've been using this system on prod for over a year and
encountered no major issues.)
`/datum/asset/spritesheet_batched`: A version of the spritesheet system
that collects a list of `/datum/universal_icon`s and sends them off to
rustg asynchronously, and the generation also runs on another thread, so
the game doesn't block during realize_spritesheet. The rust generation
is about 10x faster when it comes to actual icon generation, but the
biggest perk of the batched spritesheets is the caching system.
This PR notably does not convert a few things to the new spritesheet
generator.
- Species and antagonist icons in the preferences view because they use
getFlatIcon ~~which can't be converted to universal icons~~.
- Yes, this is still a *massive* cost to init, unfortunately. On Bee, I
actually enabled the 'legacy' cache on prod and development, which you
can see in my PR. That's why I added the 'clear cache' verb and the
`unregister()` procs, because it can force a regeneration at runtime. I
decided not to port this, since I think it would be detrimental to the
large amount of contributors here.
- It is *technically* possible to port parts of this to the uni_icon
system by making a uni_icon version of getFlatIcon. However, some
overlays use runtime-generated icons which are ~~completely unparseable
to IconForge, since they're stored in the RSC and don't exist as files
anywhere~~. This is most noticeable with things like hair (which blend
additively with the hair mask on the server, thus making them invisible
to `get_flat_uni_icon`). It also doesn't help that species and antag
icons will still need to generate a bunch of dummies and delete them to
even verify cache validity.
- It is actually possible to write the RSC icons to the filesystem
(using fcopy) and reference them in IconForge. However, I'm going to
wait on doing this until I port my GAGS implementation because it
requires GAGS to exist on the filesystem as well.
IconForge generates a cache based on the set of icons used, all
transform operations applied, and the source DMIs of each icon used
within the spritesheet. It can compare the hashes and invalidate the
cache automatically if any of these change. This means we can enable
caching on development, and have absolutely no downsides, because if
anything changes, the cache invalidates itself.
The caching has a mean cost of ~5ms and saves a lot of time compared to
generating the spritesheet, even with rust's faster generation. The main
downside is that the cache still requires building the list of icons and
their transforms, then json encoding it to send to rustg.
Here's an abbreviated example of a cache JSON. All of these need to
match for the cache to be valid. `input_hash` contains the transform
definitions for all the sprites in the spritesheet, so if the input to
iconforge changes, that hash catches it. The `sizes` and `sprites` are
loaded into DM.
```json
{
"input_hash": "99f1bc67d590e000",
"dmi_hashes": {
"icons/ui/achievements/achievements.dmi": "771200c75da11c62"
},
"sizes": [
"76x76"
],
"sprites": {
"achievement-rustascend": {
"size_id": "76x76",
"position": 1
}
},
"rustg_version": "3.6.0",
"dm_version": 1
}
```
Universal icons are just a collection of DMI, Icon State, and any icon
transformation procs you apply (blends, crops, scales). They can be
convered to DM icons via `to_icon()`. I've included an implementation of
GAGS that produces universal icons, allowing GAGS items to be converted
into them. IconForge can read universal icons and add them to
spritesheets. It's basically just a wrapper that reimplements BYOND icon
procs.
Converts some uses of md5asfile within legacy spritesheets to use
rustg_hash_file instead, improving the performance of their generation.
Fixes lizard body markings not showing in previews, and re-adds eyes to
the ethereal color preview. This is a side effect of IconForge having
*much* better error handling than DM icon procs. Invalid stuff that gets
passed around will error instead of silently doing nothing.
Changes the CSS used in legacy spritesheet generation to split
`background: url(...) no-repeat` into separate props. This is necessary
for WebView2, as IE treats these properties differently - adding
`background-color` to an icon object (as seen in the R&D console) won't
work if you don't split these out.
Deletes unused spritesheets and their associated icons (condiments
spritesheet, old PDA spritesheet)
If you press "Character Setup", the 10-13sec of lag is now approximately
0.5-2 seconds.
Tracy profile showing the time spent on get_asset_datum. I pressed the
preferences button during init on both branches. Do note that this was
ran with a smart cache HIT, so no generation occurred.
Much lower worst-case for /datum/asset/New (which includes
`create_spritesheets()` and `register()`)
Here's a look at the internal costs from rustg - as you can see
`generate_spritesheet()` is very fast:
**Before**
**After**
🆑
fix: Fixed lizard body markings and ethereal feature previews in the
preference menu missing some overlays.
refactor: Optimized spritesheet asset generation greatly using rustg
IconForge, greatly reducing post-initialization lag as well as reducing
init times and saving server computation.
config: Added 'smart' asset caching, for batched rustg IconForge
spritesheets. It is persistent and suitable for use on local, with
automatic invalidation.
add: Added admin verbs - Debug -> Clear Smart/Legacy Asset Cache for
spritesheets.
fix: Fixed R&D console icons breaking on WebView2/516
/🆑
Part 1 by grungussuss: https://github.com/tgstation/tgstation/pull/87529
gives players more control over how loud they want certain sounds to be
🆑 Rengan
sound: the volume that vox, admin sound, insturments play at can now be
tweaked in preferences, check your preferences!
sound: Elevator now uses ambience volume preference, jukeboxes uses
instrument volume preference and end of round musics uses admin music
volume preference.
/🆑
## About The Pull Request
del() log, radio log, check antagonists, law/dna/fingerprint logs all
use browser instead, which means darkmode, wahoo
The only difference now is that they are in darkmode, really.
Also removed browse calls to pipe dispensers (the machine) and windoor
assembly, as they both use TGUI now so these don't do anything.
Lastly, adds an early return to the tram admin tool if you don't select
a tram, cause I found it annoying.
## Why It's Good For The Game
Try to use old admin tools, get flashbanged
## Changelog
🆑
admin: Check antagonists & del/law/dna/fingerprint/radio log panels use
browsers which means they have darkmode. Also the tram panel will cancel
out if you click cancel.
/🆑
nevimer
