Commit Graph
24143 Commits
Author SHA1 Message Date
warriorstar-orionandGitHub 2559287298 Create a map template for tests and use an empty space level for placing it. (#27728)
* Create a dedicated area on Z-1 for tests.

* Place landmarks in testing area, with a 1-tile margin against walls.

* Consolidate map testing behavior and use a clean z-level.

* lint map

* undo SDMM var sanitization on centcomm
2024-12-30 18:25:10 +00:00
QwertytofortyandGitHub a3508e066e fix magic touch spells false deleting, fix spelling, allow escape (#27736)
* fix magic touch spells false deleting, fix spelling, allow escape

* leaps out of
2024-12-30 18:23:51 +00:00
PollardTheDragonandGitHub 3888b35b40 Removed Wedding Clothes from Chaplain Garments (#27544) 2024-12-30 18:22:34 +00:00
c6ec62f73a Remove ancient random spawners. (#27682)
* Remove ancient random spawners.

* set script PR number

* rest of updatepaths

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

---------

Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-12-30 18:20:41 +00:00
ExusAandGitHub 45f6c68d63 Adds some new Paradise-themed band posters (#27741)
* Added a few new posters.

Adds 9 new posters to the standard poster pool.

* Add band poster descriptions

Adds more detail to the band poster descriptions

* Spot edit

* Two more posters

Adds vox and skulk themed posters.

* Typo fix

Fixed a typo and reworded a part
2024-12-30 18:20:02 +00:00
warriorstar-orionandGitHub 6bf673dbb4 fix borg gripper held item self-activation (#27740) 2024-12-30 14:43:18 +00:00
warriorstar-orionandGitHub c68637011a /New -> /Initialize Migration §2: Stacks. (#27446)
* refactor: /New -> /Initialize §2: stacks

* remove named arg from phazon BS crystal removal

* whoops
2024-12-30 14:36:32 +00:00
DGamerLandGitHub 190d508ddd Nerfs the pulse demon (#27536)
* Why is this not working

* Oh that's why

* Komrad request
2024-12-27 22:05:20 +00:00
DGamerLandGitHub 61d2a0e845 Removes spell schools (#27703)
* Removes schools

* QWERTYYYY :(
2024-12-25 03:25:38 +00:00
ExusAandGitHub 2c66db9670 Resprites Quantum Pads and Cargo Pads (#27595)
* Resprites Quantum Pads and Cargo Pads

Adds a new sprite and animation for teleporter pads

* Fix rendering layers

Makes quantum pads move to a higher layer while active
2024-12-25 03:15:55 +00:00
warriorstar-orionandGitHub e520abf030 Do not break pulls on Z-level transitions. (#27702) 2024-12-24 02:24:14 +00:00
warriorstar-orionandGitHub c6fc2fbe00 Remove hopefully unused 'unpowered' airlock subtype. (#27732) 2024-12-24 02:14:21 +00:00
QwertytofortyandGitHub 2e38c61dfa it's nothing, it's for free (#27730) 2024-12-23 17:28:52 +00:00
a5726efe0c Extra Plushies + Plushify Spell (#27384)
* Plushie PR

TODO-
Fix borgs becoming mind
Add to smite list
Add diona plush effect

* Fixed Issues

Added alien plush
Added loadout
Yeah

* Apply suggestions from code review

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Drakeven <50409888+Drakeven@users.noreply.github.com>

* WIP

Will finish later

* Fixed the various issues

Should be working now! Changed the bread smite to a 'generic item' smite and then made it a specifcally breaded smite.

* Minor typo fixing

And stuff

* WIP Conversion

Converting all the attacks into more sleek attacks, will need to finish.

* Fixes galore

Yippie!

* Russian revolver wasn't working

now you can self-shoot again! Horay!

* You can no longer eat spraycans

IPC clowns everywhere devistated

* Apply suggestions from code review

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Drakeven <50409888+Drakeven@users.noreply.github.com>

* A tinsy bit of touching up

:)

---------

Signed-off-by: Drakeven <50409888+Drakeven@users.noreply.github.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-23 16:09:24 +00:00
kyunkyunkyunandGitHub 5c549adeb6 Tweak for meatpackers ruin turrets (#27422)
* fix turrets

* (not)new type of a turret
2024-12-22 16:55:04 +00:00
Truls20andGitHub 7511539544 Allows wallets to hold candy cash and chocolate coins (#27574) 2024-12-22 16:53:43 +00:00
warriorstar-orionandGitHub 718b5787cb Revert "Fixes for inserting/removing storage items/swapping items between han…" (#27706)
This reverts commit 012e1f1010.
2024-12-22 00:10:33 +00:00
012e1f1010 Fixes for inserting/removing storage items/swapping items between hands. (#27694)
* Fixes for inserting/removing storage items/swapping items between hands.

* Apply suggestions from code review

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

* Fix doc comments

* kill old comment

---------

Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-12-21 21:36:04 +00:00
warriorstar-orionandGitHub bb60a027bf unit->game tests, /tg/ assertions and allocations (#27646)
* unit->game tests, /tg/ assertions and allocations

* whoopsies

* fix lint
2024-12-21 21:19:33 +00:00
79bad427c8 Movement cross/uncross implementation. (#26762)
* refactor: Movement cross/uncross implementation.

* wrong var name

* fix unit tests dropping PDAs into nowhere

* Add documentation.

* remove unused constants

* say which procs are off limits

* fix simpleanimal z change runtime

* helps not to leave merge conflicts

* kill me

* fix typecast

* fix projectile/table collision

* treadmills don't cause MC to crash anymore

* connect_loc is appropriate here

* fix windoors and teleporters

* fix bonfires and clarify docs

* fix proximity sensors

Tested with sensors in crates, sensors in modsuits
Tested new proximity component with firing projectiles at singularity
Tested new proximity component with portable flashes
Tested new proximity component with facehuggers

* lint

* fix: polarized access helper false positives

* Revert "fix: polarized access helper false positives"

This reverts commit 9814f98cf6.

* hopefully the right change for mindflayer steam

* Changes following cameras

* fix glass table collision

* appears to fix doorspam

* fix ore bags not picking up ore

* fix signatures of /Exited

* remove debug log

* remove duplicate signal registrar

* fix emptying bags into locations

* I don't trust these nested Move calls

* use connect_loc for upgraded resonator fields

* use moveToNullspace

* fix spiderweb crossing

* fix pass checking for windows from a tile off

* fix bluespace closet/transparency issues

* fix mechs not interacting with doors and probably other things

* fix debug

* fix telepete

* add some docs

* stop trying to shoehorn prox monitor into cards

* I should make sure things build

* kill override signal warning

* undef signal

* not many prox monitors survive going off like this

* small fixes to storage

* make moving wormholes respect signals

* use correct signals for pulse demon

* fix pulse heart too

* fix smoke signals

* may have fucked singulo projectile swerve

* fix singulo projectile arcing

* remove duplicate define

* just look at it

* hopefully last cleanups of incorrect signal usage

* fix squeaking

* may god have mercy on my soul

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

* lewc review

* Apply suggestions from code review

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

* burza review

* fix bad args for grenade assemblies

* Update code/__DEFINES/is_helpers.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>

---------

Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <daan.lyklema@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-21 08:07:44 +00:00
QwertytofortyandGitHub 3a3bdc8ff1 TRAIT_UNKNOWN (#27471) 2024-12-20 21:08:15 +00:00
QwertytofortyandGitHub 2fa2576571 converts traitordevices.dm to activate_self (#27529) 2024-12-19 19:10:11 +00:00
ed626bfadb Ports Different Variants of Nian Plushies and Introduces a Plush Spawner (#27450)
* ports over more nian plushies from shiptest/beestation and introduces plushies into maint loot

* remove a value

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* removed a value

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* removed a value

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* remove a value

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* Update code/game/objects/effects/spawners/random/plushie_spawners.dm

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* Update code/game/objects/effects/spawners/random/plushie_spawners.dm

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* this should fix the conflict

* please let this upload fix the conflict

Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* i need to stop pressing commit as a form of saving, my apologies.

* added the dmi back

* fixing indentation

* removes a comment.

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>

* bumps the weight of tools and materials up to 4

---------

Signed-off-by: Hayden Redacted <91229275+haydenredacted@users.noreply.github.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-12-18 15:32:27 +00:00
warriorstar-orionandGitHub bd6450d884 Cleanup ITEM_INTERACT_ flags. (#27640)
* Cleanup `ITEM_INTERACT_` flags.

* replace new uses of old flags
2024-12-17 21:54:28 +00:00
kyunkyunkyunandGitHub f7199ccf80 depottt (#27399) 2024-12-17 16:17:37 +00:00
8ff638b519 Chasms fix pixel Y when spitting things out, and spit out indestructable things again (#27515)
* Chasms fix pixel Y when spitting things out, and spit out indestructable things again

* Apply suggestions from code review

Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com>

---------

Signed-off-by: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
2024-12-17 15:56:38 +00:00
warriorstar-orionandGitHub 02a37c8303 Fix wallets not ingesting cards on click. (#27655) 2024-12-16 03:19:46 +00:00
QwertytofortyandGitHub 0caf77d272 Attack Chain Migration: /obj/item/card (#27556)
* the work so far

* She returns on my TRUE till I ITEM_INTERACT_SUCCESS

* do this too (rip good commit name)

* Did you know? You can stamp ID cards!
2024-12-15 21:06:48 +00:00
0e765746b6 Adds a new TGUI Admin Antag Menu (#27545)
* Adds a new TGUI Admin Antag Menu

* Prettier

* fuck

* oops

* swap this shiiit

* Rebuild

* changes

* hate contractors, simple as

* welp forgot this

* fix

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-15 01:39:12 +00:00
ContrabangandGitHub d18f41c0f4 Fixes snow being on the wrong plane (#27615) 2024-12-14 19:10:20 +00:00
warriorstar-orionandGitHub f0d377c9f1 Remove unused 'broken light' light floor state (#27548) 2024-12-14 19:10:07 +00:00
e03352ddb9 Singulo Buffs - Again (#27361)
* iteration 1

* oops

* Okay now it actually works

* remove rad cap

* Adds a singulo monitor

* comments and other fixes

* rebuild tgui

* updates last size now. breach alerts now go before warnings

* oops

* fix console lables for the field gens

* New generator lookup algorithm

* comment added

* sort out the return and checks on temp_gens

* Adds sprites to the singulo monitor

* fix sprite stuff and singulo alert

* rebuild tgui

* Adds a singulo monitor board to RnD.  Uses the correct icon when no singulo is being monitored.

* give commas some space

* Adds a singulo console board to the singulo engine crate

* style fixes and fixes the check for singularity location and type

* Rebuild Tgui

* style fixes and a comment

* Removes redundant brackets

* Correct the check for there being containing generators

* Changes the generator_field variable to a more generic name

* adds a period to a comment

* Restore accidentally modified icons to their original state

* Rebuild TGUI

* Rebuild tgui

* rebuild tgui

* Rebuild TGUI

* rebuild tgui

* TGUI rebuild

* Style fixes

* TGUI rebuild

* rebuild tgui

* rebuild tgui

* Let's see if this works

* I didn't see that merge conflict. Rebuilding again

* rebuild tgui

* Rebuild TGUI

* Review changes

* Changes to the new variable name in the singulo monitor

* Adjusts bar values for each colour according to the reduced energy capacity of the new generators

* Rebuild TGUI

* Review changes

* missed a line

* improves a couple comments

* removes the pre loose warning from the singulo. It will now only alert the station once the singulo is loose. Fixes loose alerts being given repeatedly

* Update tgui.bundle.js

* TGUI rebuild

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Update tgui.bundle.js

* Fixes a bug causing the console to announce a singuloose when selecting a singularity at level 2 or above

* Removes alerts from the singulo console

* Rebuild and Merge Master

* Change the name of the singulo gen crate to include the console board

* fixes a runtime that terminated the destructor prematurely when deconstructing a console that hasn't selected a singularity

* Removes generators from the interface when they become inactive

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-14 06:07:11 +00:00
ContrabangandGitHub 0588b35af7 Prevent re-selection of targets on cryo (#27635)
* Prevent re-selection of targets on cryo

* goodbye documentation
2024-12-14 02:18:58 +00:00
1080pCatandGitHub 3c8b9492f8 his grace attack chain migration (#27580) 2024-12-11 16:19:04 +00:00
55ff05d57b Replaces The SM Crush Bonus With a New Mechanic: Gas Coefficient (#27168)
* Changes crush to per gas bonuses depending on amount in the chamber

* Undef the defines

* oops

* Make anomaly spawn threshold depend on power + bonus rather than power or crunch threshold.

* moves the crunch bonus outside the if scope

* Makes mole_crunch_bonus a variable of the SM

* adds mole_crunch_bonus to power on the top if of the arcs and anomaly section

* Adds mole count and the gas coefficient of the mix to the SM monitoring console

* Removes a redundant rounding

* Rebuild TGUI

* rebuild tgui

* Update tgui.bundle.js

* Update tgui.bundle.js

* Changes the variable name to gas coefficient

* oops

* Makes the uses of gas_coefficient a bit tidier

* Update tgui.bundle.js

* Update tgui.bundle.js

* Tgui rebuild

* Makes scaling below the old crush threshold quadratic, and makes GC scale with the square root of total moles above it.

* Uses linear scaling for the moles progress bar

* Corrects using the log scaled value of the moles for the bar

---------

Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
2024-12-11 15:40:22 +00:00
c6fcd16078 Buffs Brass - Adds a Selection of New Brass Furnishings (#27465)
* creation

* Update clockwork-overlays.dmi

* Update computer.dmi

* Update computer.dmi

* Update Operating.dm

* airlock

* Update airlock_types.dm

* Update code/game/machinery/Sleeper.dm

Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

---------

Signed-off-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-12-10 16:04:47 +00:00
TaurturaandGitHub 98aec4ed8c Added CMO's figurine (#27506) 2024-12-09 17:56:35 +00:00
aa140c1184 Tweak: Magma-ale and space beer are now a bottle subtype (#27407)
* makes magma-ale and space beer bottles instead of cans
replaced all occurences of the cans to the new type

* forgot to rever test_tiny

* path script + repathing

* space bar sleepy beer repath

* Update tools/UpdatePaths/Scripts/27407_ale_beer_repath.txt

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Toastical <vnndvp@gmail.com>

* Update code/game/objects/structures/crates_lockers/closets/secure/bar.dm

Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Signed-off-by: Toastical <vnndvp@gmail.com>

---------

Signed-off-by: Toastical <vnndvp@gmail.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
2024-12-07 22:18:55 +00:00
warriorstar-orionandGitHub ffe23af1aa make computer glow brighter and match screen color (#27484) 2024-12-07 22:12:58 +00:00
BurzahandGitHub ae7f74a5b6 Missing Attribute (#27569) 2024-12-07 02:04:46 +00:00
warriorstar-orionandGitHub d23c808e47 Fixes several attack chain call sites (#27553) 2024-12-06 22:20:12 +00:00
warriorstar-orionandGitHub af2a3daf22 Migrate /obj/effect/spawner/lootdrop to /obj/effect/spawner/random. (#27445)
* refactor: Migrate /obj/effect/spawner/lootdrop to /obj/effect/spawner/random.

* set script PR number

* fix broken updatepaths for three course meal

* make filenames unique

* goddamnit

* redirect incorrect icon states

* ugh

* fix typepath fixes
2024-12-06 15:05:38 +00:00
584e6b26d5 Adds the RSF Executive Service Upgrade for cyborgs (#27371)
* Adds the Executive RSF cyborg upgrade.

First commit for the Executive RSF with basic functionality.

* Add cheese knife

Adds a cheese knife along with the RSF upgrade to cut the cheese.

* Executive RSF Upgrade functionality.

Adds cheeses, caviar, cheese knife, and reorders RSF code to be neater.

* Nerf cyborg cheeses

Nerfs cyborg cheeses to be worse than chef food.

* Resprites Smoked Cheese

* Fixes power cost calculation

* Cleanup

* Standardize tech and Materials cost

* Adds caviar trash

Adds an empty caviar can.

* Edam and flavor

Add Edam

Adjusts flavors to compete with cheese reagent

* Undo sprinkled donut

Undid changes to RSF donut

* Fix RSF icon missed pixel

* Boolean fix

Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
Signed-off-by: ExusA <67055922+ExusA@users.noreply.github.com>

* Resprites basic cheese

Resprites basic cheese at the request of @DGamerL

* Update new cheese sprite

Adds wax to the new cheese.

* Delete unused cheese icon

Deletes a prototype cheese icon.

* Readds normal cigarettes to the executive RSF

Adds normal cigarettes back to the RSF at Fordoxia's request.

* Turns caviar from red to black

Rebrands caviar into the fancier, black variety

* Deconflict

---------

Signed-off-by: ExusA <67055922+ExusA@users.noreply.github.com>
Co-authored-by: 1080pCat <96908085+1080pCat@users.noreply.github.com>
2024-12-06 14:03:58 +00:00
warriorstar-orionandGitHub 0527e59a7c Fix some autolathe signal issues. (#27557) 2024-12-06 08:16:30 +00:00
warriorstar-orionandGitHub 4146b973f0 Attack Chain Migration: /obj/item/airlock_electronics/destroyed (#27538)
* Attack Chain Migration: /obj/item/airlock_electronics/destroyed

* don't register signals on global procs
2024-12-05 05:27:36 +00:00
d663dfc3fb [READY FOR TM] R&D Rework Part 2 - Death to the experimentor (#27472)
* PT1 - Death to experimentor

* I cant fail CI this fast come on

* PT2 - DA -> SA

* CRLF to LF

* Strange icons in the SA now

* Lets give this a go

* AGH

* Dirt

* WORK

* Oops - cere was missing the RD locker

* Map fixes

* Adds delivery chute back

* Warrior review

* Also removes magnetics

---------

Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
2024-12-04 17:55:39 +00:00
ChapGitHubadrermail@gmail.com <adrermail@gmail.com>
a0c326c939 [FIX] Slimepeople can pick a bloodtype on agent IDs again (#27509)
* Fixes bloodtype picking for agent ID

* Oops

---------

Co-authored-by: adrermail@gmail.com <adrermail@gmail.com>
2024-12-03 10:59:04 +00:00
1080pCatandGitHub 04f773a62a People activating a powersink now pokes ghosts with a follow prompt (#27349)
* People activating a powersink now pokes ghosts with a follow prompt

* fixes 'a the powersink`

* slight title change

* changed title again, added another prompt when its about to blos

* Update powersink.dm
2024-12-03 10:50:40 +00:00
warriorstar-orionandGitHub 525c68d617 Attack chain, initial setup. (pull *immediately* for *any* TM issues) (#26834)
* refactor: Attack chain, initial setup.

* migrate curtain to make dreamchecker happy

* update thurible

* don't call attacked_by separately for legacy attack chain

* remove duplicate proc

* condense similar code, put allowances for legacy code in new procs

* update docs, include diagram source

* add comment on how to update diagram

* fix admonition

* mindflayer updates

* remove commented out code

* clarify all steps

* after_attack should be overridable

* whoops

* retrofit recent changes

* duh, can't restrict this yet because of tool_acts

* i hate ore bags with the fire of a thousand suns

* return correct value for object attack logic

* Various cleanups.

We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.

I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.

* simplify some argument names

* fuck it

* make it do the thing

* Rename CI module call

* Prove that CI works

* improve test output

* aaand fix it again

* fix curtain tool interactions

* fix compile error

* fix compile error

* Better docs, introduce migration plan tool.
2024-12-02 23:36:36 +00:00
TaurturaandGitHub 3b4a78585a fixes vendor's descriptions. (#27507) 2024-12-02 18:32:19 +00:00