* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* IT WORKS UP UNTIL THIS POINT
* Consolidates SLOT_FLAG and SLOT_HUD into one
* Remove cover_both_ears
* SLOT_HUD to ITEM_SLOT
* Remove clothing_trait changes for the time being
* Remove accidental copy-paste
* Re-add no-slip var
* More failure to copy-paste correctly
* Leftover flag
* Combine left and right slot flags where possible
* UNGOOF MY DEFINES, PHAND IS NOT A THING
* Minor spacing changes
* Some more fixes from merge
* Seperates ITEM SLOT AMOUNT into two defines
* ON SECOND THOUGHT LETS NOT DO THAT.
* Addresses Contra's review
* Thank you GREP
* Rename ITEM_SLOT_FEET to ITEM_SLOT_SHOES
* Added a comment to the bitmasks in clothing defines
* Rename ITEM_SLOT_TIE to ITEM_SLOT_ACCESSORY
* These are for a seperate PR.
* Magboot fixes
* Requested changes
* Re-add accidental removal
* Wrong flags
* Update code/__DEFINES/clothing_defines.dm
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Signed-off-by: Chap <erwin@lombok.demon.nl>
* Requested changes
* Merge fixes
* Fix double headset
* Fixes multiple accessories
---------
Signed-off-by: Chap <erwin@lombok.demon.nl>
Co-authored-by: Adrer <adrermail@gmail.com>
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
* Gravity generator, Atmos Control Computers, and Station Alert Computers now work by area rather than Z_level
* Cameras get added to network depending on ancestor area
* Station Alert console work by area
* Adds a check so we don't get_area on a null variable
* Gravgen also checks for z level. Area check now includes some types of ruins that weren't checked
* Keeps everything on the Z level. Atmos alert computer now iterates over alarm, but still presesents area names
* Engineering monitor gets networks from the area it is placed in
* Adds missing area prototype to the prototype list
* moves the area check to a function
* reject legs, return to snek.
* Revert "reject legs, return to snek."
This reverts commit 1dfc2c4454.
* I don't know what happened with paradise.dme, but it seems ok now
* Requested style changes and remove redundant nulls
* oops
* Another empty line removed
* Globals work
* Double access works
* All other things
* Revert "All other things"
This reverts commit 6574442eb6.
* More changes that compile and work
* IT WORKS AAAAAA
* Changes even more .len to length()
* Apply suggestions from code review
* Update code/datums/mind.dm
* Update code/__HELPERS/sorts/InsertSort.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Update code/__HELPERS/sanitize_values.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
---------
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* CI
* undef
* hooooly crap
* yeah
* false by default
* fixes
* alright, there we go
* oops lmao
* lol, lmao even
* proper programming
* fix
* losin my mind
* oops
* yeah coloring
* WE LOVE MULTIPLE DEFINES (ive lost my sanity)
* Ghost bar character select no longer break for shared names
Ghost bar character selector now use an unique ID and not a name as an identifier. Having two characters with the same name no longer break ghost bar selector.
Hence Fixes#23608
* small fixs
* Update code/modules/ruins/ghost_bar.dm
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
* variable name fix
---------
Co-authored-by: Pierre-Louis <hernandezpierrelouis@protonmail.com>
Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
* Part 1
* Testing 1
* Revert "Testing 1"
This reverts commit fc06554b28.
* Part 1.1
* Part 2 - UI Style List
* Preferences lists
* Preferences lists - DONE
* More inputs
* MOOOOOORE
* UI style else
* Last ones
* Double name fix
* Pre-selected Search
* Return Pick Darkness
* Return Pick Darkness
* Missing users
* Some review changes
* Revert MULE lists
* I just hate MERGE CONFLICT label
* List window tweaks
* I think there it is
* why i am stopid
* Update tgui.bundle.js
* fixes a bunch of turfs being active roundstart
* some ruins
* qwerty dun broke it
* main stations
* that should do it
* i'm blowing up qwerty
* should be it
* empty commit to check ci
* merge fix
* yippie
* joyous
* lavaland tax
* regex w
* I'm gonna fax mapmerge a low teir god gif
* SOMEONE ELSE GOTTA GET FAXED
* Update code/controllers/subsystem/SSair.dm
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
---------
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
* NanoMap Auto-Update (Sun Jul 2 02:02:08 UTC 2023)
* Sorting mob_spawn file to have 2 categories.
* Holy jesus
So many files using alive and corpses... send help.
* Delete wizardcrash.dmm
* Trying..
* fixing mime/clown .dmm stuff
* Test
* Fix UpdatePaths file
now it should contain all corpses/alive path swapping.
---------
Co-authored-by: NanoMap Generation <action@github.com>
* Add voyager
* Add Golden Record
- Add Golden Record icon
- Add Golden Record basic code (i am not coder)
* oops
- Move voyager code to specific folder
* delete file
put in wrong place
* Fixes path
* Upgrades Golden Record code
- Now it have weight, resistance and Technology origin (biotech:6 Data:6)
* Updates
- Add name for item, so now its called "Golden Record".
- Add "Golden Record" inside safe.
* Modificate file for voyager to spawn
- It will never make duplicate and it have chance to spawn
* Make "cost" for ruin to spawn
- Now ruin spawn require "cost" of 1
* Trying fix space structure spawning
* REEE why it dont want to work
* returning missing solar panel
* Batch of update:
- New sprite for "Golden Record" made by @mcramon
- Changed Code to be more appealing, and added description.
- For information, paradise.dme automatically corrected my placement in code, so i say it did it for me.
* Add description
- Add description for "satellite component storage":
"Plate covering inside storage is wide, it have engraved "Voyager" on it."
* Change "description = " to "desc = "
* Trying to fix conflict with "desc = "
* Fixing to moment when error is gone.
* New stuff:
- Added new titanium wall named "satellite components storage"
desc: "There is plate covering inside storage, its wide and it have engraved 'Voyager' on it."
* Removing sheets from wall.. (?)
* Small changes
- Made "Golden Record" force you to use your both hands to pick it up and hold it.
- Now "Golden Record" have "bulky" weight.
* Always forget something
- change "Golden Record" in map to correct, new one.
* Addind Noop on satellite.
- Now its fully covered in noop (Passtrough)
* Fixes Light issues
- Used Area Passtrough instead of "Near Station" it don't create Light issues.
