* Improves dog AI resilience (#65384)
About The Pull Request
AI dogs currently have a nasty habit of getting stuck when trying to fetch items sometimes, rendering their AI behavior basically dead as they're stuck in a state where they're unable to accept any commands/inputs from their environment. This PR fixes that by adding some more robust checks to make sure a failed fetch attempt doesn't softlock the pups.
This PR also adds some growling sounds for dogs in harass mode who are guarding against someone not within biting distance.
Why It's Good For The Game
Fixes some edge cases where dog AI would stop working entirely. Makes dog AI's in attack mode more conspicuous, and less reliant on text spam to show that.
Changelog
cl Ryll/Shaps
fix: Dog AI's should no longer lock up and become unresponsive after failed fetch attempts
soundadd: Dogs in harass mode that are guarding against someone will now make growling sounds
/cl
* Fixes dog AI lockups when fetching things, adds growling noises for dog attack mode
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
* Removes some boilerplate code from basic AI (#64826)
* Squashed commit of the following:
commit 71fb208502
Author: Changelogs <action@ github.com>
Date: Tue Jul 6 00:09:32 2021 +0000
Automatic changelog compile [ci skip]
commit d07bfa44a4
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Mon Jul 5 13:03:46 2021 -0700
Automatic changelog generation for PR #60014 [ci skip]
commit cd147702cb
Author: Fikou <piotrbryla@ onet.pl>
Date: Mon Jul 5 22:03:42 2021 +0200
fixes voice of god not giving you large text (#60014)
commit bef10b996b
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Mon Jul 5 11:46:16 2021 -0700
Automatic changelog generation for PR #59988 [ci skip]
commit 7b0385468b
Author: Fikou <piotrbryla@ onet.pl>
Date: Mon Jul 5 20:46:13 2021 +0200
Concussive Gauntlets Resprite by MeyHaZah (#59988)
commit 56a58fc3bc
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Mon Jul 5 00:51:28 2021 -0700
Automatic changelog generation for PR #59990 [ci skip]
commit 181d64d929
Author: Fikou <piotrbryla@ onet.pl>
Date: Mon Jul 5 09:51:25 2021 +0200
switchblade can now be used to butcher and slice necks, icon updates when you toggle it on (#59990)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
commit 2b315303d9
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 20:56:32 2021 -0700
Automatic changelog generation for PR #59944 [ci skip]
commit 2a3330c132
Author: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
Date: Sun Jul 4 22:56:28 2021 -0500
Non-changeling spawned headslugs now burst non-antag changeling variant again (#59944)
commit 3b041f8d54
Author: Fikou <piotrbryla@ onet.pl>
Date: Mon Jul 5 05:54:14 2021 +0200
knight helmets no longer delete a nonexisting component (#60003)
commit 826e7b01a0
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 20:53:56 2021 -0700
Automatic changelog generation for PR #59994 [ci skip]
commit 31478ebcda
Author: Wayland-Smithy <64715958+Wayland-Smithy@ users.noreply.github.com>
Date: Sun Jul 4 20:53:53 2021 -0700
Fix cursed spring ruin acting as a polymorph teleport forwarder (#59994)
commit a5827ab8b1
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 20:53:29 2021 -0700
Automatic changelog generation for PR #59999 [ci skip]
commit 4fcf927bf4
Author: Bobbahbrown <bobbahbrown@ gmail.com>
Date: Mon Jul 5 00:53:26 2021 -0300
fix buckling to a vehicle not setting your initial sprite position correctly (#59999)
commit 35673b7aeb
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 20:52:31 2021 -0700
Automatic changelog generation for PR #60004 [ci skip]
commit adb9b76e1c
Author: Fikou <piotrbryla@ onet.pl>
Date: Mon Jul 5 05:52:28 2021 +0200
wisps no longer fall in chasms (#60004)
Co-authored-by: coiax <yellowbounder@ gmail.com>
commit 69a5c827c8
Author: Changelogs <action@ github.com>
Date: Mon Jul 5 00:08:58 2021 +0000
Automatic changelog compile [ci skip]
commit 7ded98f76d
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 16:47:35 2021 -0700
Automatic changelog generation for PR #59993 [ci skip]
commit 9c46c01439
Author: obsol <33932119+read-0nly@ users.noreply.github.com>
Date: Sun Jul 4 19:47:32 2021 -0400
Adds temperature and pressure sensors to circuits (#59993)
Co-authored-by: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
commit 6948ca330f
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 16:42:32 2021 -0700
Automatic changelog generation for PR #59963 [ci skip]
commit f9a2fcfdb0
Author: RandomGamer123 <31096837+RandomGamer123@ users.noreply.github.com>
Date: Sun Jul 4 19:42:29 2021 -0400
Removes plasteel as a custom material for tanks to prevent bugs (#59963)
commit 13776b7c13
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 16:41:55 2021 -0700
Automatic changelog generation for PR #59927 [ci skip]
commit 4e891fb72e
Author: spessbro <51048066+spessbro@ users.noreply.github.com>
Date: Sun Jul 4 19:41:52 2021 -0400
carnivory is visible (#59927)
commit 31942bda5b
Author: interestingusernam3 <51925758+interestingusernam3@ users.noreply.github.com>
Date: Mon Jul 5 01:40:04 2021 +0200
Cleans up and DMdoc's lazarus_injector.dm. (#59937)
commit f0203b9261
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 16:39:06 2021 -0700
Automatic changelog generation for PR #59950 [ci skip]
commit 63da37d8ef
Author: TheSmallBlue <ilanmori@ hotmail.com>
Date: Sun Jul 4 20:39:03 2021 -0300
Adds the "Split" circuit component (#59950)
commit 6ec208438f
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 16:37:54 2021 -0700
Automatic changelog generation for PR #59983 [ci skip]
commit b7c2c9134e
Author: Fikou <piotrbryla@ onet.pl>
Date: Mon Jul 5 01:37:51 2021 +0200
hiero dash now doesnt work on blocked turfs (#59983)
commit fba41ea78a
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 16:37:07 2021 -0700
Automatic changelog generation for PR #59982 [ci skip]
commit f124ed1cff
Author: Fikou <piotrbryla@ onet.pl>
Date: Mon Jul 5 01:37:04 2021 +0200
removes the weird light from the upgraded mining hardsuit (#59982)
commit 27e1c4d3c1
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 15:28:41 2021 -0700
Automatic changelog generation for PR #59986 [ci skip]
commit 189a7160da
Author: Wayland-Smithy <64715958+Wayland-Smithy@ users.noreply.github.com>
Date: Sun Jul 4 15:28:38 2021 -0700
sillycone touch (#59986)
commit 3d43e96634
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 15:27:17 2021 -0700
Automatic changelog generation for PR #59995 [ci skip]
commit fec650f7fe
Author: 小月猫 <alina.r.starkova@ gmail.com>
Date: Sun Jul 4 18:27:15 2021 -0400
fixed the define for the shock wire (#59995)
no wonder autolathes never shocked the cargo techs whenever they hacked it
commit b647efd8fb
Author: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com>
Date: Sun Jul 4 12:54:59 2021 -0700
Migrates the hellspawn stuff over from hackmd (#59928)
* Migrates some content over from hackmd, this should make it more visible, which I think is a good thing.
In other news, we really should reorg this document, should make subdocs like oranges wanted
* Parently we lint for this, nice
commit a6635f7efe
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 09:48:21 2021 -0700
Automatic changelog generation for PR #59985 [ci skip]
commit 35af64526a
Author: Fikou <piotrbryla@ onet.pl>
Date: Sun Jul 4 18:48:18 2021 +0200
Make the light eater a mining tool (#59985)
what the title says, light eater can now pick rocks
ive had a lot of rounds as admin on kilo/tram where i have to give them this so they arent stuck in gay baby jail forever
commit e6d4748d87
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 09:47:54 2021 -0700
Automatic changelog generation for PR #59984 [ci skip]
commit cd5c44d4ed
Author: Fikou <piotrbryla@ onet.pl>
Date: Sun Jul 4 18:47:51 2021 +0200
Set commission plaques to below open door layer (#59984)
it looks bad when you drop an item
commit 092c73c24e
Author: InsaneRed <47158596+InsaneRed@ users.noreply.github.com>
Date: Sun Jul 4 17:29:09 2021 +0300
Update Delta Camera Dir (#59960)
commit 084d325e10
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 07:28:27 2021 -0700
Automatic changelog generation for PR #59972 [ci skip]
commit 437383413a
Author: Paxilmaniac <82386923+Paxilmaniac@ users.noreply.github.com>
Date: Sun Jul 4 10:28:23 2021 -0400
Meta Atmos Piping fix (#59972)
commit bb17e725da
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 03:21:19 2021 -0700
Automatic changelog generation for PR #59968 [ci skip]
commit 5347af6dfd
Author: KIBORG04 <bossmira4@ gmail.com>
Date: Sun Jul 4 13:21:16 2021 +0300
Fix reveal role from a mafia psychologist (#59968)
commit 4249a1ba6b
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 02:37:32 2021 -0700
Automatic changelog generation for PR #59976 [ci skip]
commit 92c6b5f4f2
Author: Paxilmaniac <82386923+Paxilmaniac@ users.noreply.github.com>
Date: Sun Jul 4 05:37:30 2021 -0400
Allows the detective's and nuke op's holsters to be placed in the suit storage slot of armor vests (#59976)
* single line change that will break everything
* now they work even better
* Trailing comma
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
commit 3157e7ae3d
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 02:20:45 2021 -0700
Automatic changelog generation for PR #59877 [ci skip]
commit e4d8795e9c
Author: coiax <yellowbounder@ gmail.com>
Date: Sun Jul 4 10:20:42 2021 +0100
Add new Wallets! station trait (#59877)
Add a new simple station trait, that replaces everyone's ID with a
wallet containing said ID, as well as their starting money, and if
they're lucky, a little bonus surprise.
In addition, adds a force variable to station traits, which will
always enable them, rather than having to edit weight and probability
of rolling a trait of that sign (postive, negative).
Co-authored-by: Rohesie <rohesie@ gmail.com>
commit 8a2d5307e6
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jul 4 01:50:21 2021 -0700
Automatic changelog generation for PR #59772 [ci skip]
commit a8d7b45d2a
Author: tralezab <40974010+tralezab@ users.noreply.github.com>
Date: Sun Jul 4 01:50:18 2021 -0700
Ban posibrains and mmis from savannah ivanov (#59772)
Savannah Ivanov cannot have mmis or posibrains in them.
Now I know that sounds BAD... but I originally intended to do this as it removes a huge trust element and bypasses recruiting people for cooperation. I simply uuuh genuinely forgot to include this, so sorry for the DRAMA.
I was considering blocking the AI too, but AIs are actually more likely to be turned against you than fellow crewmembers
Co-authored-by: coiax <yellowbounder@ gmail.com>
commit 7ef4c4c027
Author: Rohesie <rohesie@ gmail.com>
Date: Sun Jul 4 02:14:44 2021 -0300
Fixes a runtime and refactors suit jetpacks a bit (#59922)
commit 7c22e67bfb
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 22:06:02 2021 -0700
Automatic changelog generation for PR #59752 [ci skip]
commit b2ecb787e1
Author: Greniza <61635418+Greniza@ users.noreply.github.com>
Date: Sat Jul 3 22:05:58 2021 -0700
Environment Protection Bags + Minor Weather Changes (#59752)
Co-authored-by: Matthew J. <12817816+ZephyrTFA@ users.noreply.github.com>
commit ea59898bc1
Author: ArcaneMusic <41715314+ArcaneMusic@ users.noreply.github.com>
Date: Sun Jul 4 00:48:27 2021 -0400
Documents antag_datum.dm (#59967)
Co-authored-by: AnturK <AnturK@ users.noreply.github.com>
commit a8839f233e
Author: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com>
Date: Sat Jul 3 21:47:10 2021 -0700
Changes a line of the master controller to make it easier to read (#59974)
commit 12645cefc4
Author: Changelogs <action@ github.com>
Date: Sun Jul 4 00:09:34 2021 +0000
Automatic changelog compile [ci skip]
commit 1e063242d0
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 15:29:50 2021 -0700
Automatic changelog generation for PR #59925 [ci skip]
commit 972cd3de61
Author: Bobbahbrown <bobbahbrown@ gmail.com>
Date: Sat Jul 3 19:29:46 2021 -0300
introduce advanced sucking functionality to custodians (+ bonus GAGging) (#59925)
* base sucking functionality
* functional upgrade and upgrade refactor
* minor tweak here
* finish overhaul of upgrades, add gags-ified upgrades
* add documentation (you love to see it)
* update sucking sound
* do some of the requested cleanup, fix key going into trash bag, add right click func
commit d7c855b00e
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 13:59:39 2021 -0700
Automatic changelog generation for PR #59966 [ci skip]
commit 7215711974
Author: Ghom <42542238+Ghommie@ users.noreply.github.com>
Date: Sat Jul 3 22:59:36 2021 +0200
Fix "Is This Thing On?" sci experiment to accept any explosion(#59966)
...Even those with negative devastation and/or heavy values (like IEDs, welders, fuel tanks).
commit 24cb23fa74
Author: Rohesie <rohesie@ gmail.com>
Date: Sat Jul 3 15:49:32 2021 -0300
Inexistent prefs runtime fix and a little cleanup (#59915)
commit fbfefee3cd
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 11:39:59 2021 -0700
Automatic changelog generation for PR #59938 [ci skip]
commit be92d05a4b
Author: Arkatos1 <43862960+Arkatos1@ users.noreply.github.com>
Date: Sat Jul 3 20:39:56 2021 +0200
Large cardboard box icon fix (#59938)
* cardboard box fix
commit 4d62d199d2
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 11:37:39 2021 -0700
Automatic changelog generation for PR #59935 [ci skip]
commit 578588e8e9
Author: MMMiracles <lolaccount1@ hotmail.com>
Date: Sat Jul 3 14:37:35 2021 -0400
removed extra yellow pipe and made orange/red pipe overlap in atmos better looking (#59935)
commit a2eb5c5382
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 11:36:00 2021 -0700
Automatic changelog generation for PR #59934 [ci skip]
commit 1e5e3803ae
Author: Urumasi <Urumasi@ email.cz>
Date: Sat Jul 3 20:35:57 2021 +0200
Fix turbine exploit (#59934)
commit fce141a97e
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 11:33:16 2021 -0700
Automatic changelog generation for PR #59931 [ci skip]
commit 7d82dc2644
Author: Sheits <81964183+Sheits@ users.noreply.github.com>
Date: Sun Jul 4 04:33:13 2021 +1000
Sprites (#59931)
commit cc791ed2be
Author: Emmett Gaines <ninjanomnom@ protonmail.com>
Date: Sat Jul 3 14:31:34 2021 -0400
Makes GAGS layer limit per icon state, not per config file (#59923)
commit c9314a321e
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:59:41 2021 -0700
Automatic changelog generation for PR #59962 [ci skip]
commit ebac974568
Author: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
Date: Sat Jul 3 18:59:38 2021 +0100
Fixed being able to insert infinitely many components into a shell. Fixes being able to view the shell's circuit in a locked shell. (#59962)
commit b54bffe24a
Author: coiax <yellowbounder@ gmail.com>
Date: Sat Jul 3 18:53:36 2021 +0100
Remove unused hivemind powers and supression (#59911)
- BZ metabolites no longer mute changeling hiveminds, because changeling
hiveminds no longer exist.
- Removed code for two unused changeling powers, Hive Channel DNA and
Hive Absorb DNA.
commit 1ee1b03df3
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:53:03 2021 -0700
Automatic changelog generation for PR #59917 [ci skip]
commit 5adf4f17d2
Author: death and coding <58394696+thestubborn@ users.noreply.github.com>
Date: Sat Jul 3 18:53:01 2021 +0100
Allows Bananas to be holstered (#59917)
Clowntectives can now comically whip out their trusty potassium pistol to brutally feed mimes to death. Or sneak into the detective's office and replace their actual gun with a banana.
Get it, because I call you guys the banana bros all the time?
commit f279f19e08
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:52:13 2021 -0700
Automatic changelog generation for PR #59919 [ci skip]
commit e361040c74
Author: Wayland-Smithy <64715958+Wayland-Smithy@ users.noreply.github.com>
Date: Sat Jul 3 10:52:10 2021 -0700
Fix incorporeal movers procing containment field effects (#59919)
commit 22340a88c7
Author: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>
Date: Sat Jul 3 13:49:04 2021 -0400
Makes bots order from what kind of venue you are, rather than being hardcoded (#59954)
Instead of checking the type of venue to order from, they will now instead check from venue_type (Which there's currently only 2 of)
commit 7d8346eb04
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:46:46 2021 -0700
Automatic changelog generation for PR #59946 [ci skip]
commit 066e34148c
Author: RandomGamer123 <31096837+RandomGamer123@ users.noreply.github.com>
Date: Sat Jul 3 13:46:43 2021 -0400
Makes tanks display their max pressure and only return their analysed contents once (#59946)
commit cd5660a87d
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:46:17 2021 -0700
Automatic changelog generation for PR #59953 [ci skip]
commit 16d89a146e
Author: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
Date: Sat Jul 3 18:46:13 2021 +0100
RAM now has an option to select between types. Refactored the any type to be more friendly with circuit code. (#59953)
RAM now has an option to select between types and an output signal. Refactored the any type to be more friendly with user displays.
Code that includes changing type is no longer hard to read because of snowflake code for the "any" type.
RAM can now more easily act as a constant value component.
RAM also has an output signal because it should and the fact that it doesn't was an oversight when converting everything to use input and output signals.
commit c7d4606b68
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:44:49 2021 -0700
Automatic changelog generation for PR #59952 [ci skip]
commit d35ec05181
Author: Wayland-Smithy <64715958+Wayland-Smithy@ users.noreply.github.com>
Date: Sat Jul 3 10:44:46 2021 -0700
Fix Cross Server Messages Containing HTML Garbage (#59952)
Gets rid of a minor annoyance that has been around since like when the feature was first added?
commit ad39071239
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:44:13 2021 -0700
Automatic changelog generation for PR #59955 [ci skip]
commit a57a04b320
Author: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
Date: Sat Jul 3 18:44:09 2021 +0100
Fixed carps being untameable and fixes tameable code not properly removing itself from something (#59955)
Fixes#59897
commit 452952851d
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:43:38 2021 -0700
Automatic changelog generation for PR #59942 [ci skip]
commit 11dd7a852b
Author: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
Date: Sat Jul 3 18:43:35 2021 +0100
Adds crew monitor usb connections and fixes the soundemitter's frequency port (#59942)
Adds crew monitor usb connections and fixes the soundemitter's frequency port
Allows you to view health and stuff.
commit ed6d5465b5
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:42:45 2021 -0700
Automatic changelog generation for PR #59958 [ci skip]
commit 3356f5d2ab
Author: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
Date: Sat Jul 3 18:42:42 2021 +0100
Fixed cooldowns for speech and soundemitter circuit components. Brought speech component more in line with other components. (#59958)
Fixes to the cooldowns. Also circuits now use an input trigger/output trigger system which the speech component hadn't yet adopted because it was made before that system was introduced and left out when changing most components to use this system.
Also temporarily disables input/output signal ports for the prebuilt speech relay circuit until I can properly code in a way to load circuits.
commit 78f9f71ceb
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:41:36 2021 -0700
Automatic changelog generation for PR #59959 [ci skip]
commit 5e6a90a0d5
Author: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
Date: Sat Jul 3 18:41:32 2021 +0100
Limits the maximum string length of a circuit component port to 5K characters (#59959)
People could duplicate string lengths to the point where UIs break (and maybe OOMs though it'd take a while).
commit 6c502cecd5
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:35:37 2021 -0700
Automatic changelog generation for PR #59941 [ci skip]
commit e29c6c7a89
Author: Wayland-Smithy <64715958+Wayland-Smithy@ users.noreply.github.com>
Date: Sat Jul 3 10:35:33 2021 -0700
Hookup Change Command Name to Create Command Report (#59941)
Adds and defaults the contents of command_name() to the list of names in the Create Command Report tgui presets if changed from Central Command.
commit 101da02669
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:34:35 2021 -0700
Automatic changelog generation for PR #59943 [ci skip]
commit cc40cc4677
Author: Wayland-Smithy <64715958+Wayland-Smithy@ users.noreply.github.com>
Date: Sat Jul 3 10:34:32 2021 -0700
Fix blanket cure_blind calls removing quirk and blindfold traits (#59943)
Makes it so when proc/cure_blind(source) is called with no source is does not cure blindness from the quirk, blindfolds, or other eye coverings.
commit 87f0e0d4a0
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jul 3 10:31:40 2021 -0700
Automatic changelog generation for PR #59957 [ci skip]
commit 3c7c5f0dbe
Author: tralezab <40974010+tralezab@ users.noreply.github.com>
Date: Sat Jul 3 10:31:37 2021 -0700
PDAs now include round time (#59957)
Part of my document on duplicating verb panel functionality so at some point in the far, far future we may be rid of it. you can read more here.
hackmd.io/tJ5H3opRQiG1GCN1sP142w
The other thing the status panel needs to do is send time dilation to the tgui chat. Having messed around with tgui chat, I am very confident i'm going to need stylemistake or mothblocks help me out with that one, it's so beyond my level it isn't even funny.
I know this is a VERY long description for a very small change but expect more of this in the future
commit 911d762562
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Fri Jul 2 21:23:19 2021 -0700
Automatic changelog generation for PR #59638 [ci skip]
commit 4a62b6ba9c
Author: YakumoChen <king_yoshi42@ yahoo.com>
Date: Sat Jul 3 04:23:16 2021 +0000
New contraband peanuts (#59638)
Adds a new variety of peanuts to Getmore
Tweaks peanuts to have a higher price, since they're currently the best thing to buy in the vendor.
commit d20a701b7c
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Fri Jul 2 21:01:17 2021 -0700
Automatic changelog generation for PR #59947 [ci skip]
commit 97e15965a1
Author: RandomGamer123 <31096837+RandomGamer123@ users.noreply.github.com>
Date: Sat Jul 3 00:01:14 2021 -0400
Fix ion carbine parts kit's name and other similar grammar issues (#59947)
commit 4b84de5573
Author: Changelogs <action@ github.com>
Date: Sat Jul 3 00:09:45 2021 +0000
Automatic changelog compile [ci skip]
commit 72c047c72e
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Fri Jul 2 16:23:20 2021 -0700
Automatic changelog generation for PR #59574 [ci skip]
commit 629c06dee7
Author: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
Date: Sat Jul 3 00:23:17 2021 +0100
Adds blob as a midround antag like midround traitors, where it does not require a ghost role (#59574)
Co-authored-by: Jonathan Rubenstein <jrubcop@ gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
commit d4ed79af38
Author: Timberpoes <silent_insomnia_pp@ hotmail.co.uk>
Date: Sat Jul 3 00:17:33 2021 +0100
Fix error on secondary attacking certain secure closets. (#59867)
* Feex
* Reviewify
commit dd8e5e559a
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Fri Jul 2 13:21:36 2021 -0700
Automatic changelog generation for PR #59939 [ci skip]
commit 3c202820ef
Author: interestingusernam3 <51925758+interestingusernam3@ users.noreply.github.com>
Date: Fri Jul 2 22:21:33 2021 +0200
Makes polar bears not become easier to move after you kill and revive them (#59939)
commit 5b35c83f3e
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Fri Jul 2 08:59:41 2021 -0700
Automatic changelog generation for PR #59921 [ci skip]
commit f5be9c5cee
Author: dragomagol <66640614+dragomagol@ users.noreply.github.com>
Date: Fri Jul 2 08:59:38 2021 -0700
Removes reference to intents from Martial Arts instructions (#59921)
In CQC, Plasma Fist, Sleeping Carp and Wrestling instructions verb:
Harm -> Punch
Disarm -> Shove
Also removed reference to intents from the changeling's tentacle grab, changing it to neutral/combat stance.
commit c5914c4784
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 21:32:22 2021 -0700
Automatic changelog generation for PR #59887 [ci skip]
commit 4ae906446f
Author: aaaa1023 <74441292+aaaa1023@ users.noreply.github.com>
Date: Thu Jul 1 22:32:19 2021 -0600
Sink frames are now deconstructable (#59887)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
commit 6e7a2372a2
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 17:18:09 2021 -0700
Automatic changelog generation for PR #59773 [ci skip]
commit 444ae340d0
Author: tralezab <40974010+tralezab@ users.noreply.github.com>
Date: Thu Jul 1 17:18:06 2021 -0700
Catwalk Flooring (#59773)
commit 8841fb0006
Author: Changelogs <action@ github.com>
Date: Fri Jul 2 00:11:47 2021 +0000
Automatic changelog compile [ci skip]
commit 2c5a357035
Author: Rohesie <rohesie@ gmail.com>
Date: Thu Jul 1 21:06:42 2021 -0300
Reverts Entered() passing dir instead of old loc (#59910)
commit 512fe152ab
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 16:37:38 2021 -0700
Automatic changelog generation for PR #59918 [ci skip]
commit 1faae1350b
Author: Cheshify <73589390+Cheshify@ users.noreply.github.com>
Date: Thu Jul 1 19:37:35 2021 -0400
Fixes Pocket Protector/Flashlight Pen Oversight (#59918)
commit ab8ba5ce2f
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 16:35:30 2021 -0700
Automatic changelog generation for PR #59920 [ci skip]
commit 0ce099fd77
Author: Wayland-Smithy <64715958+Wayland-Smithy@ users.noreply.github.com>
Date: Thu Jul 1 16:35:26 2021 -0700
Fix rogue vending machines targeting incorporeal (#59920)
commit db71bc8455
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 13:56:53 2021 -0700
Automatic changelog generation for PR #59909 [ci skip]
commit e1d3c12dba
Author: Sparkezel <53384660+Sparkezel@ users.noreply.github.com>
Date: Thu Jul 1 22:56:50 2021 +0200
Make bat hits no longer stunlock (#59909)
Wooden bats are 2nd best melee weapon in game, just next to stun batons. They cost 5 wooden planks which makes them ridiculously cheap and available to everyone, and the worst thing about them is how easily they can just stunlock people out of nowhere. I did what I believe was the best way to balance them out
commit 5600467371
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 13:31:14 2021 -0700
Automatic changelog generation for PR #59884 [ci skip]
commit 05a4afd2fd
Author: Emmett Gaines <ninjanomnom@ protonmail.com>
Date: Thu Jul 1 16:31:10 2021 -0400
Adds verification for reference layers to check if target config has the desired icon_state (#59884)
commit 65de6ac785
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 13:31:01 2021 -0700
Automatic changelog generation for PR #59832 [ci skip]
commit bc09b1d15a
Author: Seris02 <49109742+Seris02@ users.noreply.github.com>
Date: Fri Jul 2 04:30:58 2021 +0800
Makes it so changeling legs copy digitigrade/normal, try number 2 (#59832)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
commit c7c84cc47d
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 11:58:36 2021 -0700
Automatic changelog generation for PR #59735 [ci skip]
commit 38278f2e17
Author: RandomGamer123 <31096837+RandomGamer123@ users.noreply.github.com>
Date: Thu Jul 1 14:58:33 2021 -0400
Change uplink implants to inherit the uplink flags of the uplink they were bought from (#59735)
Uplinks implants bought from uplinks inherit the uplink flags of the uplink they were bought from.
This fixes an undocumented bug where by purchasing an uplink implant, nuke ops would be able to get things they normally can't.
Co-authored-by: tralezab <40974010+tralezab@ users.noreply.github.com>
Co-authored-by: Jordan Brown <Cyberboss@ users.noreply.github.com>
commit fee8d505f1
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 01:23:09 2021 -0700
Automatic changelog generation for PR #59875 [ci skip]
commit b949810112
Author: Bobbahbrown <bobbahbrown@ gmail.com>
Date: Thu Jul 1 05:23:03 2021 -0300
Remove ability to circumvent config VAS protection (#59875)
commit 77766aa79f
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 01:13:46 2021 -0700
Automatic changelog generation for PR #59904 [ci skip]
commit 1524f80565
Author: Ryll Ryll <3589655+Ryll-Ryll@ users.noreply.github.com>
Date: Thu Jul 1 04:13:42 2021 -0400
Fixes OOC heart commendations not saving between rounds (#59904)
commit 8c2c0670c8
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 01:13:24 2021 -0700
Automatic changelog generation for PR #59902 [ci skip]
commit e42f7f867d
Author: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
Date: Thu Jul 1 03:13:20 2021 -0500
Fixes spread glowshrooms runtiming on initialize (#59902)
commit e381dbd79e
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Thu Jul 1 00:50:04 2021 -0700
Automatic changelog generation for PR #59905 [ci skip]
commit 8168f8d84c
Author: Ryll Ryll <3589655+Ryll-Ryll@ users.noreply.github.com>
Date: Thu Jul 1 03:50:01 2021 -0400
Fixes being able to sacrifice pAI's (#59905)
commit c5c941766b
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 19:41:07 2021 -0700
Automatic changelog generation for PR #59873 [ci skip]
commit 90a611a344
Author: Timberpoes <silent_insomnia_pp@ hotmail.co.uk>
Date: Thu Jul 1 03:41:04 2021 +0100
Fix forensic component inheritance inserting null entries into lists and causing to_chat errors. (#59873)
Fixing the following runtime:
[17:13:04] Runtime in to_chat.dm,88: Empty or null string in to_chat proc call.
proc name: to chat (/proc/to_chat)
usr: Cowboy_penis_monster/(Zackary Mason)
usr.loc: (Telecomms Control Room (105,89,2))
src: null
call stack:
to chat(Zackary Mason (/mob/living/carbon/human), "", null, "", 0, 1, 1, 0)
the forensic scanner (/obj/item/detective_scanner): add log("", 1)
the forensic scanner (/obj/item/detective_scanner): scan(Control Room (/obj/machinery/door/airlock/command/glass), Zackary Mason (/mob/living/carbon/human))
Forensic scanner attempting to add "" to the logs, which eventually gets output to_chat.
Tracked error down to forensic component lazylists and the fun of trying to OR two lazylists together.
commit 86f12caeef
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 18:46:27 2021 -0700
Automatic changelog generation for PR #59871 [ci skip]
commit 63f84711ed
Author: 小月猫 <alina.r.starkova@ gmail.com>
Date: Wed Jun 30 21:46:24 2021 -0400
Fixes some minor tramstation mapping issues (#59871)
* Added heavy firedoors on the windows between toxins and the sci hallways
* Fixed air alarm placement in science
* added missing air alarms in engineering
* kitchen freezer now has the proper area
* sec point near arrivals had no air alarm
* added missing air alarms in security
* added missing air alarms in science
* added missing air alarm in escape hallway
* removed redundant air alarm
* added APC in kitchen
commit d368e4d49d
Author: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com>
Date: Wed Jun 30 17:51:35 2021 -0700
Changes how weather sends sound to players, reduces sound loop overtime (#59284)
* Converts looping sounds from a list of play locations to just the one
* Updates all uses of looping sounds to match the new arg
* Adds an area based sound manager that hooks into looping sounds to drive the actual audio. I'll be using this to redo how weather effects handle sound
* Some structrual stuff to make everything else smoother
Timers now properly return the time left for client based timers
Weather sends global signals when it starts/stops
Looping sounds now use their timerid var for all their sound related timers, not just the main loop
* This is the painful part
Adds an area sound manager component, it handles the logic of moving into new areas potentially creating new
sound loops. We do some extra work to prevent stacking sound loops.
Adds an ash storm listener element that adds a tailored area sound manager to clients on the lavaland z level.
It's removed on logout.
Adds the ash_storm_sounds assoc list, a reference to this is passed into area sound managers, and it's modified
in a manner that doesn't break the reference in ash_storm (This is what I hate)
* Hooks ash storm listener into cliented mobs and possessed objects
* Documents the odd ref stuff, adds an ignore start var to looping sounds, fixes some errors and lint issues
* Applies kyler's review
banging
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
* Cleans up some var names, reduces the amount of looping we do in some areas
* Makes the code compile, redoes the movement listener to be more general
* fuck
* We don't need to detach on del if we're just removing signals on detach
* Should? work
* if(direct) memes
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
commit 52398b255a
Author: Changelogs <action@ github.com>
Date: Thu Jul 1 00:09:35 2021 +0000
Automatic changelog compile [ci skip]
commit 7eacef421a
Author: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
Date: Wed Jun 30 16:01:26 2021 -0700
Revert "Barticles for bonfires 2021 (#59869)" (#59916)
This reverts commit 0ad74e9637.
commit c94d077ca2
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 14:32:34 2021 -0700
Automatic changelog generation for PR #59893 [ci skip]
commit 39a9331614
Author: Malgover <56408561+Malgover@ users.noreply.github.com>
Date: Wed Jun 30 23:32:31 2021 +0200
New riot gear sprites (#59893)
commit 852a839a50
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 14:31:51 2021 -0700
Automatic changelog generation for PR #59869 [ci skip]
commit 0ad74e9637
Author: tralezab <40974010+tralezab@ users.noreply.github.com>
Date: Wed Jun 30 14:31:48 2021 -0700
Barticles for bonfires 2021 (#59869)
* barticles
* better bode
commit 257b90dd62
Author: Rohesie <rohesie@ gmail.com>
Date: Wed Jun 30 18:29:03 2021 -0300
Fixes oneway effects (#59872)
commit c3f659295f
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 14:25:16 2021 -0700
Automatic changelog generation for PR #59888 [ci skip]
commit 7e2a944fc7
Author: Arkatos1 <43862960+Arkatos1@ users.noreply.github.com>
Date: Wed Jun 30 23:25:13 2021 +0200
Null rod radial menu update (#59888)
Co-authored-by: Fikou <piotrbryla@ onet.pl>
Co-authored-by: Emmanuel S. <emmanuelssr@ gmail.com>
commit be0e1c4360
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 14:16:27 2021 -0700
Automatic changelog generation for PR #59684 [ci skip]
commit 6e01f2901f
Author: bloons3 <bloons3@ users.noreply.github.com>
Date: Wed Jun 30 16:16:23 2021 -0500
Enhances AI law and borg logging (#59684)
Persistent logging for sometimes disputed actions
The "impacted cyborgs" is useful for reconstructing which borgs were synced to an AI at what time, which sometimes may not be clear from logs
commit 2d597584c8
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 11:38:34 2021 -0700
Automatic changelog generation for PR #59866 [ci skip]
commit 02f0fe75fa
Author: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
Date: Wed Jun 30 19:38:31 2021 +0100
Adds the sound emitter circuit component (#59866)
Adds the sound emitter circuit component. Allows the integrated circuit to play a sound of varying volume and frequency.
commit 6f3f14566a
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 10:21:11 2021 -0700
Automatic changelog generation for PR #59865 [ci skip]
commit b9dbda85a5
Author: Time-Green <timkoster1@ hotmail.com>
Date: Wed Jun 30 19:21:08 2021 +0200
Massively buffs debriding surgery (#59865)
Yesterday, I got lasered in the arm twice. A good three minutes later I lose all controle off my arm and have an assistant debride my arm. On a surgical table with sterilizine, this took 2 minutes and 30 seconds.
All wounds can be fixed quite easily, but the infection wound type has always been an absolute nightmare. This was the only time I recorded it, but this has happened so many times and it feels like the average lies around 4~ minutes for this surgery to complete.
It still depends on how badly infected your burn wound is, but it shouldn't take longer than 30 seconds now.
commit a0941fe7f2
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 09:47:44 2021 -0700
Automatic changelog generation for PR #59885 [ci skip]
commit fcf6bbd9ec
Author: Wayland-Smithy <64715958+Wayland-Smithy@ users.noreply.github.com>
Date: Wed Jun 30 09:47:41 2021 -0700
Fix cyborg locker right click (#59885)
I guess silicon shared the old AltClick proc with other living, but that is not the case for secondary click.
commit a2a40e2b08
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 09:46:51 2021 -0700
Automatic changelog generation for PR #59883 [ci skip]
commit 9d80156890
Author: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com>
Date: Wed Jun 30 09:46:46 2021 -0700
Fixes an issue with performance logging (#59883)
Redoes how logs are generated, calling profile() does not guarentee that the output logs will contain one of each entry, if the value is 0 it just doesn't return data for that entry. So we need to do some memes to make sure things are working properly
Removes a debug proc that I forgot about
commit 7ad39850ed
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 09:40:26 2021 -0700
Automatic changelog generation for PR #59882 [ci skip]
commit 71e2191f5f
Author: Bobbahbrown <bobbahbrown@ gmail.com>
Date: Wed Jun 30 13:40:22 2021 -0300
Add 'other tickets by user' to adminhelp ticket panel (#59882)
added a list of other tickets that have been opened by a user, when relevant, to the adminhelp ticket panel.
commit ce7a658c10
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 09:39:04 2021 -0700
Automatic changelog generation for PR #59852 [ci skip]
commit 31e9f7444a
Author: KubeRoot <kubinator4321@ gmail.com>
Date: Wed Jun 30 18:39:01 2021 +0200
Make transit tube dispenser stations buildable (#59852)
Dispenser stations had some sprite issues due to using wrong icon states and having wrong orientation for flipped versions.
This PR fixes the issues and adds them to the RPD.
I can remove them from RPD construction if you don't want them to be constructible - this was the main motivation for implementing the changes in a downstream.
commit 3a0815f191
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Wed Jun 30 01:30:55 2021 -0700
Automatic changelog generation for PR #59879 [ci skip]
commit 0f0714691e
Author: tralezab <40974010+tralezab@ users.noreply.github.com>
Date: Wed Jun 30 01:30:51 2021 -0700
fixes buying shuttle insurance while the shuttle is docked (#59879)
* ok
* ??
commit bc79093c63
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Tue Jun 29 21:21:00 2021 -0700
Automatic changelog generation for PR #59874 [ci skip]
commit 634049e1e9
Author: Bobbahbrown <bobbahbrown@ gmail.com>
Date: Wed Jun 30 01:20:57 2021 -0300
Add $reset directive to config processor for setting a config entry to default value (#59874)
added this so that the value of INTERVIEW_QUESTIONS (and subsequently any other string list) can be overridden without much issue by additional config files.
i also changed the functionality of default on config_entry as it seemed to be counterintuitive to have it be set to the initial value of the config_entry. in my opinion this should be a compile-time default, and so i've refactored the code such that default now contains the actual default, and the config_entry_value is set at intialization.
commit 3542c43c5a
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Tue Jun 29 18:05:36 2021 -0700
Automatic changelog generation for PR #59880 [ci skip]
commit 50954715d8
Author: Arkatos1 <43862960+Arkatos1@ users.noreply.github.com>
Date: Wed Jun 30 03:05:33 2021 +0200
Fixes relic war hammer typepath (#59880)
This PR fixes a typepath mismatch - /obj/item/nullrod/hammmer and /obj/item/nullrod/hammer, which are supposed to be one item. This mismatch caused relic war hammer not to be able to do kneejerk action, and it also meant that one duplicate nullrod item was showing in the radial menu for the null rod reskin variant selection.
commit 4549b0be9d
Author: Timberpoes <silent_insomnia_pp@ hotmail.co.uk>
Date: Wed Jun 30 02:03:58 2021 +0100
Fix to_chat error with empty surgery step strings (#59876)
/datum/surgery_step/incise/success() has no vague_message arg in a certain edge case when calling display_results. This eventually leads to an empty string being sent to /mob/proc/show_message() - Unsure if this is intended or not, but I've added an equivalent string based on the other usages of display_results instead of sending an empty string.
commit c0e41885b8
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Tue Jun 29 17:53:40 2021 -0700
Automatic changelog generation for PR #59894 [ci skip]
commit 03c1ce3932
Author: Wayland-Smithy <64715958+Wayland-Smithy@ users.noreply.github.com>
Date: Tue Jun 29 17:53:37 2021 -0700
Fix hand teleporter and other portals looping forever (#59894)
Makes portals use Bumped() instead of COMSIG_ATOM_ENTERED for detecting atoms crossing the event horizon.
Removes unused and potential loop causing forceMove argument from do_teleport()
commit 2c7c09867f
Author: Changelogs <action@ github.com>
Date: Wed Jun 30 00:09:55 2021 +0000
Automatic changelog compile [ci skip]
commit 7771a76dca
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Tue Jun 29 13:23:17 2021 -0700
Automatic changelog generation for PR #59850 [ci skip]
commit 7e9e2df721
Author: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
Date: Tue Jun 29 21:23:14 2021 +0100
Adds USB to arrest consoles. Adds list circuit components. (#59850)
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
commit b2285bf29b
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Tue Jun 29 12:50:32 2021 -0700
Automatic changelog generation for PR #59868 [ci skip]
commit d0181eacad
Author: Fikou <piotrbryla@ onet.pl>
Date: Tue Jun 29 21:50:29 2021 +0200
Fix singularity beacon (#59868)
Stops singularity objects from being added to the global singularity list,
this list is only for singularity components.
This fixes singularity beacons breaking because they expect that only
singularity components are in the global singularity list.
commit 11b8701215
Author: AnturK <AnturK@ users.noreply.github.com>
Date: Tue Jun 29 21:13:12 2021 +0200
Fixes minor quirk runtime. (#59870)
commit 2a1569a7a7
Author: Time-Green <timkoster1@ hotmail.com>
Date: Tue Jun 29 18:21:47 2021 +0200
Remove unnecessary species breath code (#59864)
Human code override breathe(), called the species datum which checked if the human had NO_BREATH. I just made it check for NOBREATH directly, since it is apparently a human only trait.
If someone wants to implement special breathing checks/behaviour, make custom lungs
commit ae078ffbfa
Author: spessbro <51048066+spessbro@ users.noreply.github.com>
Date: Tue Jun 29 04:45:18 2021 -0400
puts the drag_pickup component on card decks (#59857)
commit 3801c24229
Author: oranges <email@ oranges.net.nz>
Date: Tue Jun 29 20:44:43 2021 +1200
Update rust-g version to latest release (#59863)
* Update rust version to latest release
This should fix the fact our docker build has been failing for the past
10 days
* Make wget not be quite so noisy
commit 79680e46aa
Author: Changelogs <action@ github.com>
Date: Tue Jun 29 00:11:50 2021 +0000
Automatic changelog compile [ci skip]
commit 3c91a86cc5
Author: Rohesie <rohesie@ gmail.com>
Date: Mon Jun 28 19:44:53 2021 -0300
Fixes a runtime: Entered() passing the wrong args (#59854)
commit c183ddf839
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Mon Jun 28 15:39:26 2021 -0700
Automatic changelog generation for PR #59855 [ci skip]
commit c3917b8225
Author: Timberpoes <silent_insomnia_pp@ hotmail.co.uk>
Date: Mon Jun 28 23:39:23 2021 +0100
Cooked steaks are once again edible. (#59855)
commit baa1b96449
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Mon Jun 28 07:03:25 2021 -0700
Automatic changelog generation for PR #59520 [ci skip]
commit 24be009e96
Author: zxaber <37497534+zxaber@ users.noreply.github.com>
Date: Mon Jun 28 07:03:22 2021 -0700
Jaunting no longer allows you to end up inside a wall (#59520)
Jaunting now keeps track of the last five non-blocked tiles you moved across while in the jaunt. Upon exit, it will attempt to deposit you into the last unblocked tile. Should it run out of tiles to try, you will be returned to your starting location. As such, jaunting mobs can no longer end up inside walls or dense objects. Tables, and anything else with the climbable element, are still allowed.
Added support to /turf/proc/is_blocked_turf() to allow ignoring climbable atoms.
Added the TRAIT_CLIMBABLE trait, applied by the climbable element, to accomplish the above.
commit f7ac03beb0
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Mon Jun 28 07:02:01 2021 -0700
Automatic changelog generation for PR #59848 [ci skip]
commit baf7efb692
Author: Ryll Ryll <3589655+Ryll-Ryll@ users.noreply.github.com>
Date: Mon Jun 28 10:01:58 2021 -0400
Slightly buffs knife wounds, slightly nerfs scalpel wounds (#59848)
Recently it came to my attention that knives are actually really bad at causing slashing wounds, while the scalpel is probably a little too good at causing them, even through armor. So, here's what this PR does:
Knives in general are more effective at causing slash wounds, especially if the target has no armor/clothing on that limb. The butcher's cleaver in particular is now equally as effective as a circular saw.
Scalpels are a bit less effective at causing slash wounds against armor/clothing, though they're still extremely good at cutting, especially against exposed flesh.
With these stats, knives will be more effective against unarmored targets, and can actually be counted on to draw blood when needed.
commit ff0031b244
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Mon Jun 28 06:56:36 2021 -0700
Automatic changelog generation for PR #59779 [ci skip]
commit 52283197a6
Author: Sheits <81964183+Sheits@ users.noreply.github.com>
Date: Mon Jun 28 23:56:33 2021 +1000
Paradox bag resprite and rework (#59779)
Paradox bags can now be worn on the belt slot instead of the back, while being able to carry less (it can still fit inside bags).
Adds new sprites for the icon and belt.
commit fbdfde900c
Author: Timberpoes <silent_insomnia_pp@ hotmail.co.uk>
Date: Mon Jun 28 14:11:33 2021 +0100
The to_chat proc no longer accepts null or empty strings and runtimes instead. (#59843)
* Catch null text sent to to_chat
* Brain traumas no longer send empty to_chat gain strings
* Make to_chat_immediate changes and clean up args list formatting
* Fix empty to_chat message where there is no memo for admins
* Fix additional edge case where there are no messages for the ckey.
commit 5f4c0baeea
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jun 27 19:02:23 2021 -0700
Automatic changelog generation for PR #59675 [ci skip]
commit 901d6c0651
Author: RandomGamer123 <31096837+RandomGamer123@ users.noreply.github.com>
Date: Sun Jun 27 22:02:20 2021 -0400
Cyborg Cult Sacrifice Fix (#59675)
This PR fixes cyborgs' interactions with Cult's offer rune. Before this PR, the game would attempt to sacrifice the cyborg and put its mind into a soulstone by handing it over to a method that was incapable of doing so, thus creating an empty soulstone and permanently removing the cyborg from the round as a result. Now, attempting to offer a cyborg on an offer rune provides the first activator with an option of any construct to turn the cyborg into, and turns them into that when chosen, similar to how twisted construct operates but without the wait time.
Also moves cult construct list into global vars, renames THEME_CULT into THEME_FAKE_CULT and adds a real THEME_CULT for actual cult constructs, and added another proc to handle the class switching.
commit f7d2ce1510
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jun 27 18:11:55 2021 -0700
Automatic changelog generation for PR #59839 [ci skip]
commit cb3835db08
Author: Timberpoes <silent_insomnia_pp@ hotmail.co.uk>
Date: Mon Jun 28 02:11:52 2021 +0100
Fix obsessed antags not getting policy string output to chat (#59839)
commit ac8a7cdf5d
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jun 27 18:11:35 2021 -0700
Automatic changelog generation for PR #59822 [ci skip]
commit f0da569a02
Author: Aronai Sieyes <arokha@ arokha.com>
Date: Sun Jun 27 21:11:32 2021 -0400
Fix tgui async modals (#59822)
* Fix tgui async modal constructor order
* Fix another bug with the async modals
commit 80875b03a6
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jun 27 18:10:38 2021 -0700
Automatic changelog generation for PR #59830 [ci skip]
commit 891d7bb363
Author: zxaber <37497534+zxaber@ users.noreply.github.com>
Date: Sun Jun 27 18:10:35 2021 -0700
Sets RD consoles to have two ID card slots (#59830)
commit dffa8af41e
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jun 27 17:14:50 2021 -0700
Automatic changelog generation for PR #59360 [ci skip]
commit d3dd525e08
Author: cacogen <25089914+cacogen@ users.noreply.github.com>
Date: Mon Jun 28 12:14:48 2021 +1200
Cannabis has more believable effects (#59360)
Adds cannabis reagent and replaces space drugs with it in cannabis products
Adds space drugs to rainbow weed, which fits its theme and might satisfy the people who miss the effect
Removes lipolicide from cannabis products in favour of the reagent consuming nutrition directly
Cannabis reagent gives you messages describing symptoms of cannabis intoxication, makes you laugh, makes you hungry, has a chance to couchlock you buckled to a chair and put you to sleep lying down
Cannabis no longer references hallucinating, can't be overdosed and has no addiction
Adds Stoned status effect, which is applied by cannabis reagent
Stoned status effect slows you down, gives you bloodshot eyes, makes you clumsy, boosts your mood and gives you the drugged sound environment
Adds "stoned" icon state for Stoned status effect screen alert (sprite shamelessly stolen from the Smoke spell)
Adds BLOODSHOT_EYES trait, which is applied by Stoned status effect
Adds examine eye descriptions for bloodshot eyes and player-chosen red eyes
Adds cannabis movespeed modifier, which is applied by the Stoned status effect
Adds Stoned mood event, which is applied by Stoned status effect and gives the same mood boost as High but doesn't reference tripping
commit d986f791ed
Author: Changelogs <action@ github.com>
Date: Mon Jun 28 00:09:47 2021 +0000
Automatic changelog compile [ci skip]
commit 1cdbec7a37
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jun 27 15:31:07 2021 -0700
Automatic changelog generation for PR #59750 [ci skip]
commit 7ace8da9e0
Author: Kyle Spier-Swenson <kyleshome@ gmail.com>
Date: Sun Jun 27 15:31:03 2021 -0700
Adds configs to disable laggy hard deletes (#59750)
cl
server: Added configs to disable laggy hard deletes once they lag the server too much.
admin: laggy hard deletes only output once per type path.
/cl
closes#58379
commit 56ec8af075
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jun 27 11:12:53 2021 -0700
Automatic changelog generation for PR #59820 [ci skip]
commit 2303f6a892
Author: dragomagol <66640614+dragomagol@ users.noreply.github.com>
Date: Sun Jun 27 11:12:50 2021 -0700
Remove yellow siding tiles (#59820)
They're only used at Centcom, and we have decals now to do what these tiles do.
commit 134f266f78
Author: Rohesie <rohesie@ gmail.com>
Date: Sun Jun 27 13:45:24 2021 -0300
Document Moved() and forwards old_locs (#59819)
- Passes the proper arguments on Moved(), forgot to do this on another PR.
- Documents the proc better.
- Cleans up code a little.
commit 3316e2223f
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jun 27 08:35:57 2021 -0700
Automatic changelog generation for PR #59801 [ci skip]
commit a915c7167e
Author: Time-Green <timkoster1@ hotmail.com>
Date: Sun Jun 27 17:35:53 2021 +0200
Refactors species stomach code, makes ethereal charge inherent to their stomach (#59801)
A stomach would literally just ask the species datum how to be hungry and made a bunch of exceptions for ethereals. I mostly just moved code around so that hunger is handled by a persons stomach, thus shrinking the species.dm bloat.
This also makes it so ethereal's charge mechanic is unique to their stomache, instead of this really weird inbetween where just nothing happens and you kinda starve to death. You can stick an ethereal stomach in a human and this will replace their hunger mechanic with the charge mechanic and lets them absorb power from APCs and everything. You can also give ethereals a normal stomach and they'll use the normal hunger mechanics
commit 04e845fa77
Author: AnturK <AnturK@ users.noreply.github.com>
Date: Sun Jun 27 17:33:23 2021 +0200
Fixes projectile runtime (#59824)
For example projectile moving into a chasm on last step.
commit 23790c6c5e
Author: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
Date: Sun Jun 27 07:43:49 2021 -0700
Fix missing SIGNAL_HANDLER (#59826)
Adds SIGNAL_HANDLER to everywhere that didn't have it that was picked up by dm-lua, which is now ready enough to catch these.
commit 8b2c21cfa1
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sun Jun 27 07:18:45 2021 -0700
Automatic changelog generation for PR #59831 [ci skip]
commit c13a7a83a9
Author: Coconutwarrior97 <40315842+Coconutwarrior97@ users.noreply.github.com>
Date: Sun Jun 27 09:18:42 2021 -0500
Free golem policy (#59831)
Adds policy.json functionality for Free Golems, will make it easier for future headmins to alter the policy.json rather than PR a change.
commit 2f7c7d0bad
Author: tgstation-server <tgstation-server@ tgstation13.org>
Date: Sat Jun 26 19:26:36 2021 -0700
Automatic changelog generation for PR #59556 [ci skip]
commit 67c89fa1ab
Author: Emmett Gaines <ninjanomnom@ protonmail.com>
Date: Sat Jun 26 22:26:33 2021 -0400
Greyscale Mat Datum Stationary Smooth Tanks (#59556)
Stationary gas tanks have been in a terrible place for a long time, this addresses some of the issues with a more balance focused change coming in a second mapping pr after this one.
Stationary gas tanks have been made constructable and act similarly to canisters in that they can be damaged, repaired, and over-pressurized to explode. Additionally, they can be made with any rigid material and their stats depend on that material. A glass tank is going to have far less pressure capability than one made of plasteel.
In terms of gameplay there are two main differences now: Adjacent stationary tanks will merge together both graphically and with their internal storage. Any port on any of the tanks can access this shared storage. Also stationary tanks no longer magically have many times the volume for gas as the tile it's…
* Removes some boilerplate code from basic AI
Co-authored-by: ma44 <guyonleagueoflegends@gmail.com>
* Restores old monkey knockdowns (monkey nerf) (#65080)
Monkey knockdown used to be on Crossed until it was made an AI here: 55238
Now it instead uses COMSIG_ATOM_ENTERED, which only takes into account walking over the monkey. Something that you can't do unless you are non-dense or they are lying on the floor, in which case you aren't even knocking them down?
Now it uses COMSIG_MOVABLE_CROSS instead so it's how it used to be, actually functional and useful.
* Restores old monkey knockdowns (monkey nerf)
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Makes non-dense mobs not knock monkeys over (#65040)
Monkeys only get knocked over when you walk over them (not even when you swap places with them, which I thought was supposed to be the case), this makes non-dense mobs not knock them over. Which means Revenants, bots, small animals (lizards/butterflies), larvas, ect. will not knock monkeys over.
* Makes non-dense mobs not knock monkeys over
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Fixes Hauntium runtiming to hell (get it) due to real fake weakrefs (#64779)
Hauntium AI was recently changed to use weakrefs to cut back on hard deletes
Unfortunately, not all cases of hauntium AI assigning references were swapped to weakrefs.
Meaning the haunting list ended up being some weird combination of hard references to mobs and weak references.
These hard references in the list caused a million runtimes a second because the ai was, of course, trying to resolve() hard references which doesn't work and it was doing it every second
Hauntium should now properly use weakrefs in the cases it's used in.
Spooky things actually haunt again
* Fixes Hauntium runtiming to hell (get it) due to real fake weakrefs
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Actually fixes strange mob delays: BEEPSKY IS TOO FAST edition (#64351)
* Revert " Properly speeds up a lot of things, mostly mobs (#64270)"
This reverts commit a836574388.
THE BYOND REF WAS A LIE, THE PLAYERS ARE FOOLS, HELP, HELPPPPPPP
It turns out that despite what the byond ref says, the walk proc's delays were not in fact in ticks, but in deciseconds.
This means when I "fixed" mob movement by doubling all walk delays, what I actually did was double the speed of anything that used walk()
I have a feeling that the actual issue players were seeing was just move_to having fucked up distance logic, and the movement of slow mobs being smoothed out. I've changed that, so hopefully this puts a seal on the whole problem
I've had a request put in to make beepsky faster, but I think that's best done in a seperate pr
* Adds a flag to disable smooth moveloop movement
Applies it to hostile mob's Goto()
Backports the fixes to move_to and move_away from the previous pr
* Actually fixes strange mob delays: BEEPSKY IS TOO FAST edition
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* Properly speeds up a lot of things, mostly mobs (#64270)
When I made my move loop changes (815bb8a) 62567, I converted a few walk() procs to
the new system
What I didn't know when I did that conversion is that walk() operates on ticks, when move loops operate on
deciseconds
So when I converted say, mob movement over, I accidentially halved the attack movespeed of all of our mobs
This resolves that, alongside a few other misteps
Of note: There are old comments implying that walk()'s delay is not actually linear, or simply as the reference says "in ticks"
I don't have a good idea of how fast things actually should be though, which makes this tricky
In light of this, I've decreased the move speed of legion slightly, in hopes that it will feel more "normal"
I've also fixed a bug with move_to and move_away, they were treating their distance parameters as move to this and one more, rather then move to this. This lead to mobs attempting to overlap with your sprite. s cringe, and also fixed
* Properly speeds up a lot of things, mostly mobs
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* Adds a movement looping system, replaces inbuild procs and spacedrift with it (#62567)
* Adds a subsystem to handle automated directional movement, replaces all instances of walk_towards with it. Makes meteors and immovable rods not drift in space, and makes immovable rods more destructive. Note, I've opted not to use byond's method of moving towards something, which is effectively Move(src, get_step(src, get_dir(src, target))) as it's cringe and doesn't make a smooth line. I've replaced it with a autoupdating rise over run setup, read the code for more details
* woop forgot the subsystem
* Documentation, contributing.md entry, and some cleanup
* Makes the moveloop datum more oop friendly, sets us up for a lot of conversions
* Converts the curseblob and walk_away() to the subsystem
* Changes the default for override from FALSE to TRUE
* converts walk() over, still need to add a replacement proc for it, but we didn't actually have anything that used the raw proc
* converts the rest of walk_to() over, nearing the end now
* cleans up some errors
* Fully documents everything, fills in some missing movement types, uses the power of oop to make things cleaner, and typepaths longer
* Finishes the contributing.md stuff
* Done
* Fefaults -> Defaults, can you tell I wrote this at 1AM?
* resolves bubblegum issues
* Roh's suggestions
Co-authored-by: Rohesie <rohesie@ gmail.com>
* Cleanup
* Hey lemon, did you know that Destroy() lives on datums? ahhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh
* Converts over the discrepencies created in my absense
* HAHA FUCK YOU I PAY MY DUES
* Whoops lost some stuff in the merge
* Converts the system from seconds to deciseconds to make dealing with the api more sane
* Some stuff I missed
* Makes movement an inheritable subsystem type, splits the moveloop file into two, one for the subsystem, and one for the datums
* Makes a subsystem that handles directing movers out to other subsystems. It's a bit bad right now, but it's a
good first step. I think I'll move the move loop datum to a lazy var on mobs instead of an assoc list, don't
like lists.
Also makes the movement procs global, I'll move em to the /movement subsystem at some point or something like
that
* Converts the existing uses of the procs over to the new format
* Adds support for subsystem precedence, so a type of A can override type B.
General cleanup, still kinda in debug mode but it's getting better
* I'll admit I'm not too familiar with this, but I think it will work
* Adds starting logic so movement types "pausing" makes any sense
Redoes how waiting is handled to make it based on world.time directly. I don't remember why. I think it's better
this way.
Adds a drifting movement type, moves space drift over to it.
Needs severe work before it's ready, too much info stored and modified on the moving object, see comment
Starts work on making drifting smooth
* Moves almost all space drifting vars over to signals on the movement datum
Properly implements glide size stuff for both the subsystem and the loops. Space drift will be smoother now.
It's not perfect, but it'll work just fine for now
Adds a way to override a client'd mob's glide size mid move, uses it to make entering a spacedrift look right
Adds a way to delay a client move outside of just move_delay, meant to be used for long periods, and setup such
that it doesn't make inputs persist
Adds flags to movement loops, alongside MOVELOOP_OVERRIDE_CLIENT_CONTROL, which blocks client movements while
the loop is firing, and for it's visual delay after
This means you can't exit a space drift until you hit the actual wall. This feels a lot better
Some general logic stuff, move() will return true/false if it succeeded or failed
Adds a stop_loop() proc that's called when a move loop is no longer active
Suck my nuts
* Moves precedence to the loop instead of the subsystem
* Moves drifting into a component, this lets me explictly block input after the move loop ends, so people can't
move the moment they functionally move onto a new tile
This is a bit underdeveloped currently, but that's a problem for another day
Cleans up some uses of move procs, fixes runtimes in metoer and curseblob code
Adds signals for stopping/starting a move loop, sending one for destroy is redundant.
Moves existing event signals from the movable being acted on to the loop itself, makes more sense this way
Makes the move handler return the created loop up the chain so we can register to it
Fixes a logic error in loop contesting code that lead to loops never actually being removed from subsystems
because they didn't know they should be.
Properly changes lifetime from a time to stop, to functionally an amount of moves to complete before stopping
Adds some new signals for pre/post loop process. This is to better tie into components.
I decided I didn't like the idea of tying all functionality to the loops themselves
The loop decides functionally how to move, components or just tied in signals can decide when/when not to move
and can modify properties of the loop
Making a new loop for things like atmos drift, something I'm interested in tackling in the future, seemed silly
* Moves movement procs directly to the subsystem for better namespacing or whatever
* Moves movement packets onto /atom/movable, no longer need the debugging
I've decided to not just put their contents fully onto atom movable, since it makes debugging on live much
harder, can't sdql for them anymore.
Fixes a runtime in meteor code, properly this time
Fixes a logic error in stop_looping
Makes move manager NO_INIT, because well, it doesn't init
* Commits human sin, makes Recover() work properly for movement subsystems
* Fixes immovable rod orbits not always working, they were returning too early in moved and fucking up the var we use to track move count, and thus not sending a signal properly
* Reworks the curseblob to use signals more, and to not use override
* Missed this in the movement ss commit
* Removes override, makes having a higher or equal precedence take its place
* Updates documentation
* Cleans up some unused defines
* Nukes the unused flags option
* Whoops forgot to qdel check
* Removes an unused var I had for client move prevention before I started using a component
* Let's do this properly
* Modernizes meteor code to better match how explosions actually work currently
* Some more cleanup
* Cleans up effect code a little bit
Nukes the effect system's sleep loop, we use movement loops instead
As a part of that, instead of 1 timer per effect spawned, we react to loop failure and make it 1 timer per
effect system
This should reduce the amoumt of slowdown we see after mass lighting break
It's not everything, we're still making a timer per spark effect, but it cuts things down significantly
* Updates explosions to not sleep
* Adds support for modifying a loops delay post process, makes extinguisher code suck less then it does currently, nukes some more sleeps and timer loops
* Converts water tank resin over to move loops rather then sleeps, minor behavior change mind, the cooldown starts on fire rather then on land, but I think that makes more sense anyway
* compile and runtime fix
* Fixes some runtimes, cleans up some code, ensures feature parity when it comes to logging
* Prevents resin foam from space drifting
* Adds support for flags back into the system, I need it for reasons
* Updates move_towards to fix some bugs and resolve some inconsistent behavior, implements a flag that makes a loop's first move start instantly
* Fixes extinguishers not actually transfering any reagents
* Converts sprays to the new system. This does actually minorly change behavior, in that I've changed the order of spray actions from step -> sleep -> wash to step -> wash -> sleep, but I'm not terribly torn up about it because frankly I think it feels better
* Converts grav catapults over to the new system
* Converts trays over to moveloops
* Converts robot streaking to move loops, the other two coming soon
* Compile you won't. Also fixes a behavior issue with oil streaks
* Does directional step_to properly, cleans up the other two streaking types
* Converts step_trigger over, not that it's actually used anywhere. Changes how stoping a move works, you need to explicitly qdel, other the step is just considered to be ignored. This will make life easier later
* Adds a jps movement loop. It's a bit bloaty, id is stupid, but it'll work just fine
* Makes the system support passing in a datum that's just used as extra context for the move. The hope is this makes signalizing things less of an absolute headache
* Begins the conversion of ai movement datums to movement loops
* These two are reasonably simple, only weird thing I'm doing is A: Not allowing target hotswapping, which I hope none is doing, and B: passing the controller into the move loop as extra context so things work properly
* JPS is a bit more complex, partially because the old implementation was a bit weird. 2 major things. 1: I'm dropping what I think was a redundant behavior minimum distance check from the premove bit of logic, since I'm pretty sure it didn't do anything. 2, instead of just stoping the step in an error state like being pulled, we count it against our max move total
* Audit
* Moves most forced movement to the framework, adds some components to make things nicer
* Implements a flag that makes the loop always operate, regardless of precedence and without impacting any other loops
* Moves movement subsystems into the right folder
* Hey potato what if you had two procs that did the same thing and one called the other? Wow it's useless
* Merges slipping and force movement
* Converys conveyors over to the system. It's a bit fragile, but I think it's totally worth it to save the sleep loop
* Precedence -> Priority, cleans up some logic errors, makes priority highest to lowest instead of lowest to highest, straight cleans some code up
* Makes poly and bubbles ignore spacedrift, now that precedence actually functions properly. I'm likely missing cases of this, will deal with it later
* Depression, thy name is linter
* Fixes linter, and hopefully fixes the runtimes in ci too
* Wew
* Sets sprays and extinguishers back to legacy, since people do actually seem to have noticed
* Spelling errors my beloved
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
* More detail, moves return descriptions
* Converts transit tubes to the system?
* Adds the glide size modifier. Not honestly sure that this should be default, considering how crummy it makes things look for normal walking, but it's useful as hell here
* Adds a force move in dir template, actual support for fast initial steps (wtf old me) and a helper proc for setting delay
* Cleans up displosal code a bit, I thought about adding it to the system but it would functionally be just 'disposal loops'. Maybe I'll make a template subtype? not sure how I want to handle stuff like this
* Cleans up mob movement a bit
* Let's use the controller's visual delay
* Makes the resin thrower nicer, cries
* Cleans up some comments, replaces an implicit world.icon_size with an explicit one, fixes up a typecheck
* typecache instead of double istype. Can't do much about the !atom/movable, list would be too big I feel
* hhh
* bro wtf
* Documents the why of SS_TICKER
* Puts SSmovement on SS_TICKER. Lets us support tick steps
* Cleans up the charge action. Makes it use moveloops
* Fixes CI? kinda worried that this just got dropped
* Converts disposal pipes to move loops. They stutter a bit more then usual as of now, hoping that's a me thing, if it's not I'ma look at uping the priority of the base subsystem
* Moves the move subsystems off background, puts some on ssticker
* Prevents some things that shouldn't move in space from moving in space
* Documents the general form and usage of the system
* Virgin one vs chad once
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
* Removes unneeded check
* Moves appropriate movement subsystems into SS_BACKGROUND. Removes redundant SS_KEEP_TIMINGs
I do want the behavior of SS_TICKER, which at this point is tick based waits, and ignoring overtime when
calculating next fire.
Since honestly, these subsystems should ignore overtime in regards to next fire, the cost of moving A may be
nothing compared to the cost of moving B.
* Makes the MODULUS macro use floor. I knew our coders would never let me down, glad this exists, thanks ninja
Fixes teleporting caused by shitty round() behavior, adds a "you hit your target" case to homing loops
* Converts blood splatters to move loops, that'll do it
Co-authored-by: Rohesie <rohesie@ gmail.com>
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
* Adds a movement looping system, replaces inbuild procs and spacedrift with it
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@ gmail.com>
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
* More Basic AI behavior flags for manipulating movement (#63974)
* More Basic AI behavior flags for manipulating movement
Co-authored-by: ma44 <guyonleagueoflegends@gmail.com>
* prevents ai from moving after being killed (#63455)
I don't like that they move, when you kill them
* prevents ai from moving after being killed
Co-authored-by: AndrewL97 <andrewjlove97@gmail.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* [Ready] MODsuits
* we dont need to add these people as codeowners, goodness gracious
* have to remove this because upstream
* part 1 of these fixes
* EEEE
* Update peacekeeper_clothing.dm
* E
* E
* Auto stash before merge of "upstream-merge-59109" and "origin/upstream-merge-59109"
* E
* Update expeditionary_trooper.dm
* more removal
* nice
* modsuti modstui modusuti
* fixes
* E
* ITS MODsuit not HARDSUIT
* more hardsuit references
* MODSUIT NOT HARSUITEDSA
* Maps
* More ,map
* oop
* e
* oo aa
* 0
* ting tang
* Update modsuit_tailsprites.dm
* hi fikou
* bs tech update
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
* Fixes typos in span, other html elements (#63510)
Atomizes a much larger PR for another time...
There are typos in span and other html messages that causes them to not render correctly or at all.
Bug fixes
Converts those instances of span to use the macro
* Fixes typos in span, other html elements
Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
* Chimps no longer get grumpy when you hug them or throw things with no throw force at them. (#62685)
* Chimps no longer get pissed when you hug them.
* Pun Pun no longer hates hat throwing.
* Chimps no longer get grumpy when you hug them or throw things with no throw force at them.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Adds a (hopefully) comprehensive guide to writing an AI Datum in our repo (#61811)
AI Controllers are pretty difficult to learn if you don't have someone to explain the concepts, I thought I could cut that out by having a handy dandy guide to show people. If we're ever to eventually move all simplemobs onto basic mobs, we need to have a weapon like this to combat the questions.
The more people who understand Datum AI, the better. I remember a few maintainers mentioning that it would be nicer to have more guides in the repo, since it is essentially 9,970 bytes of future review prevention.
* Adds a (hopefully) comprehensive guide to writing an AI Datum in our repo
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* stops the monkey ai from committing 53k runtimes and makes it so they can disposal people again (#62121)
* stops the monkey ai from committing 53k runtimes and makes it so they can disposal people again
Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com>
* Monkey subtree breakup refactor! (#61741)
Splitting up monkey ai into subtrees allows me to make a punpun ai after this pr is merged, makes stopping planning matter for the AI subtrees, and more generic subtrees that can be used by most ais
It also gets rid of bad practices like setting blackboards in the ai controller.
* Monkey subtree breakup refactor!
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* if you give a monkey an instrument, it will begin playing the donkey kong theme (#61726)
* if you give a monkey an instrument, it will begin playing the donkey kong theme
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* Hauntium is chill with the undead, buffs hauntium stats (#61584)
* Hauntium is chill with the undead, buffs hauntium stats
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* Refactors datum AI idle behaviors into datums (#61455)
Co-authored-by: MonkeyThatCodes <monkey>
* Refactors datum AI idle behaviors into datums
Co-authored-by: AMonkeyThatCodes <20987591+AMonkeyThatCodes@users.noreply.github.com>
* fixes bad arguments to /datum/footstep/Attach() (vary to sound_vary) (#61231)
#60479 changed the attach argument "vary" into "sound_vary" but didnt change the two associative arguments for vary to sound_vary. this does that. now Attach() wont runtime for the footstep element
* fixes bad arguments to /datum/footstep/Attach() (vary to sound_vary)
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
* Refactors connect_loc_behalf into a component (#60678)
See title. Also refactors caltrops into a component because they use connect_loc_behalf which requires them to hold the state.
This also fixes COMPONENT_DUPE_SELECTIVE from just outright not working.
connect_loc_behalf doesn't make sense as an element because it tries to hold states. There is also no way to maintain current behaviour and not have the states that it needs.
Due to the fact that it tries to hold states, it means the code itself is a lot more buggy because it's a lot harder to successfully manage these states without runtimes or bugs.
On metastation, there is only 2519 connect_loc_behalf components at roundstart. MrStonedOne has told me that datums take up this much space:
image
If we do the (oversimplified) math, there are only ever 5 variables that'll likely be changed on most connect_loc_behalf components at runtime:
connections,
tracked,
signal_atom,
parent,
signal_procs
This means that on metastation at roundstart, we take up this amount: (24 + 16 * 5) * 2519 = 261.97600 kilobytes
This is not really significant and the benefits of moving this to a component greatly outweighs the memory cost.
(Basically the memory cost is outweighed by the maint cost of tracking down issues with the thing. It's too buggy to be viable longterm basically)
* Update glass.dm
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* Monkeys can now retaliate against xenomorph and animal attacks. (#60157)
Co-authored-by: Rohesie <rohesie@ gmail.com>
* Monkeys can now retaliate against xenomorph and animal attacks.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@ gmail.com>
* Fixes carps being given orders without a friend. Fixes sentient carps being unridable (#60441)
* Fixes carps being given orders without a friend. Fixes sentient carps being unridable
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
* Sentient monkeys are no longer knocked over by mobs in the way. (#60139)
Title. They used to be immune to this in the past, but then they were refactored into a species and things have changed.
* Sentient monkeys are no longer knocked over by mobs in the way.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Makes carps not lose track of who they're following if vision gets obstructed (#60274)
* Makes carps not lose track of who they're following if vision gets obstructed
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
* Monkeys and dogs no longer yoink items they can't reach. (#60150)
* Monkeys and dogs no longer yoink items they can't reach.
Title. More ai behavior botherations.
* Monkeys and dogs no longer yoink items they can't reach.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Reverts Entered() passing dir instead of old loc (#59910)
* Reverts Entered() passing dir instead of old loc
Co-authored-by: Rohesie <rohesie@gmail.com>
* Makes turfs persist their signals, uses this to optimize connect_loc (#59608)
* Makes turfs persist signals
* Splits connect_loc up into two elements, one for stuff that wishes to connect on behalf of something, and one for stuff that just wants to connect normally. Connecting on behalf of someone has a significant amount of overhead, so let's do this to keep things clear
* Converts all uses of connect_loc over to the new patterns
* Adds some comments, actually makes turfs persist signals
* There's no need to detach connect loc anymore, since all it does is unregister signals. Unregisters a signal from formorly decal'd turfs, and makes the changeturf signal persistance stuff actually work
* bro fuck documentation
* Changes from a var to a proc, prevents admemems and idiots
* Extra detail on why we do the copy post qdel
* Makes turfs persist their signals, uses this to optimize connect_loc
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Adds set_density()
Fixes one instance of a duplicate density assignment on an object.
Comments two hacky usages of density which will have to forgo using the setter for now.
Lets us append code to the event of density changing.
Pretty sure this is leading up to some multitile object thing -Lemon
Co-authored-by: Rohesie <rohesie@gmail.com>
SkyratBot
Gandalf
Useroth